rust/greptimedb
1
0
Fork 0
mirror of https://github.com/GreptimeTeam/greptimedb.git synced 2026-07-06 05:50:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

adjust comments

Browse Source 
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
This commit is contained in:
Ruihang Xia
2026-04-09 06:40:27 +08:00
parent 32ed9d0e11
commit a801e873cf
1 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/promql/src/functions/extrapolate_rate.rs
View File

@@ -129,7 +129,7 @@ impl<const IS_COUNTER: bool, const IS_RATE: bool> ExtrapolatedRate<IS_COUNTER, I
/// * 0: timestamp range vector
/// * 1: value range vector
/// * 2: timestamp vector
/// * 3: range length. Range duration in millisecond. Not used here
/// * 3: range length. Range duration in milliseconds
fn calc(&self, input: &[ColumnarValue]) -> DfResult<ColumnarValue> {
if input.len() != 4 {
return Err(DataFusionError::Plan(
@@ -214,6 +214,9 @@ impl<const IS_COUNTER: bool, const IS_RATE: bool> ExtrapolatedRate<IS_COUNTER, I
let last_value = all_values[end - 1];
let result_value = if IS_COUNTER {
// Adjacent normalized windows usually slide forward by one sample. Reuse the
// previous window's accumulated reset correction and adjust only the dropped and
// newly added edges, falling back to a full scan when the layout changes.
if prev_offset != usize::MAX && offset == prev_offset + 1 && length == prev_length {
if all_values[prev_offset + 1] < all_values[prev_offset] {
counter_correction -= all_values[prev_offset];
@@ -246,6 +249,8 @@ impl<const IS_COUNTER: bool, const IS_RATE: bool> ExtrapolatedRate<IS_COUNTER, I
let mut duration_to_start_ms = (first_ts - range_start) as f64;
let duration_to_end_ms = (range_end - last_ts) as f64;
// Counters cannot be negative, so Prometheus allows the extrapolation window to snap
// back to the inferred zero point instead of extending into negative values.
if IS_COUNTER && result_value > 0.0 && first_value >= 0.0 {
let duration_to_zero = sampled_interval_ms * (first_value / result_value);
if duration_to_zero < duration_to_start_ms {
@@ -256,6 +261,8 @@ impl<const IS_COUNTER: bool, const IS_RATE: bool> ExtrapolatedRate<IS_COUNTER, I
let extrapolation_threshold = average_interval_ms * 1.1;
let mut extrapolated_interval_ms = sampled_interval_ms;
// Mirror Prometheus extrapolation: extend to the real range boundary when a sample is
// close enough, otherwise add half an average sampling interval on that side.
if duration_to_start_ms < extrapolation_threshold {
extrapolated_interval_ms += duration_to_start_ms;
} else {