rust/greptimedb
1
0
Fork 0
mirror of https://github.com/GreptimeTeam/greptimedb.git synced 2026-01-03 20:02:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

perf: use memory state to check if a logical region exists

Browse Source 
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
This commit is contained in:
Ruihang Xia
2024-05-31 18:16:08 +08:00
parent fcfcf86385
commit b02c256157
4 changed files with 6 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/metric-engine/src/engine/create.rs
View File

@@ -171,9 +171,10 @@ impl MetricEngineInner {
// check if the logical region already exist
if self
.metadata_region
.is_logical_region_exists(metadata_region_id, logical_region_id)
.await?
.state
.read()
.unwrap()
.is_logical_region_exists(logical_region_id)
{
info!("Create a existing logical region {logical_region_id}. Skipped");
return Ok(data_region_id);

2
src/metric-engine/src/engine/put.rs
View File

@@ -104,7 +104,7 @@ impl MetricEngineInner {
// check if the region exists
let data_region_id = to_data_region_id(physical_region_id);
let state = self.state.read().unwrap();
if !state.is_logical_region_exist(logical_region_id) {
if !state.is_logical_region_exists(logical_region_id) {
error!("Trying to write to an nonexistent region {logical_region_id}");
return LogicalRegionNotFoundSnafu {
region_id: logical_region_id,

2
src/metric-engine/src/engine/state.rs
View File

@@ -149,7 +149,7 @@ impl MetricEngineState {
Ok(exist)
}
pub fn is_logical_region_exist(&self, logical_region_id: RegionId) -> bool {
pub fn is_logical_region_exists(&self, logical_region_id: RegionId) -> bool {
self.logical_regions().contains_key(&logical_region_id)
}
}

15
src/metric-engine/src/metadata_region.rs
View File

@@ -139,17 +139,6 @@ impl MetadataRegion {
Ok(())
}
/// Check if the given logical region exists.
pub async fn is_logical_region_exists(
&self,
physical_region_id: RegionId,
logical_region_id: RegionId,
) -> Result<bool> {
let region_id = utils::to_metadata_region_id(physical_region_id);
let region_key = Self::concat_region_key(logical_region_id);
self.exists(region_id, &region_key).await
}
/// Check if the given column exists. Return the semantic type if exists.
pub async fn column_semantic_type(
&self,
@@ -669,10 +658,6 @@ mod test {
.add_logical_region(physical_region_id, logical_region_id)
.await
.unwrap();
assert!(metadata_region
.is_logical_region_exists(physical_region_id, logical_region_id)
.await
.unwrap());
// add it again
assert!(metadata_region