rust/greptimedb
1
0
Fork 0
mirror of https://github.com/GreptimeTeam/greptimedb.git synced 2026-01-06 05:12:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: avoid total size overflow (#4487)

Browse Source 
feat: avoid total size overflow
This commit is contained in:
Yingwen
2024-08-02 14:16:37 +08:00
committed by GitHub
parent 8e7c027bf5
commit b388829a96
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/mito2/src/cache/file_cache.rs vendored
View File

@@ -199,7 +199,9 @@ impl FileCache {
.metakey(Metakey::ContentLength)
.await
.context(OpenDalSnafu)?;
let (mut total_size, mut total_keys) = (0, 0);
// Use i64 for total_size to reduce the risk of overflow.
// It is possible that the total size of the cache is larger than i32::MAX.
let (mut total_size, mut total_keys) = (0i64, 0);
while let Some(entry) = lister.try_next().await.context(OpenDalSnafu)? {
let meta = entry.metadata();
if !meta.is_file() {
@@ -212,13 +214,11 @@ impl FileCache {
self.memory_index
.insert(key, IndexValue { file_size })
.await;
total_size += file_size;
total_size += i64::from(file_size);
total_keys += 1;
}
// The metrics is a signed int gauge so we can updates it finally.
CACHE_BYTES
.with_label_values(&[FILE_TYPE])
.add(total_size.into());
CACHE_BYTES.with_label_values(&[FILE_TYPE]).add(total_size);
info!(
"Recovered file cache, num_keys: {}, num_bytes: {}, cost: {:?}",