rust/greptimedb
1
0
Fork 0
mirror of https://github.com/GreptimeTeam/greptimedb.git synced 2026-01-03 20:02:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: support datetime type parsing (#1071)

Browse Source 
* fix: support datetime type parsing

* fix: unit test
This commit is contained in:
Lei, HUANG
2023-02-23 20:26:47 +08:00
committed by GitHub
parent fdd17c6eeb
commit b48c851b96
1 changed files with 6 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
src/sql/src/statements.rs
View File

@@ -30,10 +30,8 @@ use std::str::FromStr;
use api::helper::ColumnDataTypeWrapper;
use common_base::bytes::Bytes;
use common_time::Timestamp;
use datatypes::data_type::DataType;
use datatypes::prelude::ConcreteDataType;
use datatypes::schema::{ColumnDefaultConstraint, ColumnSchema};
use datatypes::types::DateTimeType;
use datatypes::value::Value;
use snafu::{ensure, OptionExt, ResultExt};
@@ -305,25 +303,7 @@ pub fn sql_data_type_to_concrete_data_type(data_type: &SqlDataType) -> Result<Co
SqlDataType::Boolean => Ok(ConcreteDataType::boolean_datatype()),
SqlDataType::Date => Ok(ConcreteDataType::date_datatype()),
SqlDataType::Varbinary(_) => Ok(ConcreteDataType::binary_datatype()),
SqlDataType::Custom(obj_name, _) => match &obj_name.0[..] {
[type_name] => {
if type_name
.value
.eq_ignore_ascii_case(DateTimeType::default().name())
{
Ok(ConcreteDataType::datetime_datatype())
} else {
error::SqlTypeNotSupportedSnafu {
t: data_type.clone(),
}
.fail()
}
}
_ => error::SqlTypeNotSupportedSnafu {
t: data_type.clone(),
}
.fail(),
},
SqlDataType::Datetime(_) => Ok(ConcreteDataType::datetime_datatype()),
SqlDataType::Timestamp(_, _) => Ok(ConcreteDataType::timestamp_millisecond_datatype()),
_ => error::SqlTypeNotSupportedSnafu {
t: data_type.clone(),
@@ -340,10 +320,9 @@ mod tests {
use common_time::timestamp::TimeUnit;
use datatypes::types::BooleanType;
use datatypes::value::OrderedFloat;
use sqlparser::ast::ObjectName;
use super::*;
use crate::ast::{Ident, TimezoneInfo};
use crate::ast::TimezoneInfo;
use crate::statements::ColumnOption;
fn check_type(sql_type: SqlDataType, data_type: ConcreteDataType) {
@@ -382,10 +361,6 @@ mod tests {
check_type(SqlDataType::Double, ConcreteDataType::float64_datatype());
check_type(SqlDataType::Boolean, ConcreteDataType::boolean_datatype());
check_type(SqlDataType::Date, ConcreteDataType::date_datatype());
check_type(
SqlDataType::Custom(ObjectName(vec![Ident::new("datetime")]), vec![]),
ConcreteDataType::datetime_datatype(),
);
check_type(
SqlDataType::Timestamp(None, TimezoneInfo::None),
ConcreteDataType::timestamp_millisecond_datatype(),
@@ -410,6 +385,10 @@ mod tests {
SqlDataType::UnsignedTinyInt(None),
ConcreteDataType::uint8_datatype(),
);
check_type(
SqlDataType::Datetime(None),
ConcreteDataType::datetime_datatype(),
)
}
#[test]