fix: improve error message in validate_proto_value (#2328)

* fix: correct error message in validate_proto_value()

* fix: print location in InvalidRequest error

* style: format
This commit is contained in:
Yingwen
2023-09-06 10:46:44 +08:00
committed by Ruihang Xia
parent eb7116ab56
commit c3f6529178
2 changed files with 10 additions and 4 deletions

View File

@@ -186,7 +186,12 @@ pub enum Error {
location: Location,
},
#[snafu(display("Invalid request to region {}, reason: {}", region_id, reason))]
#[snafu(display(
"Invalid request to region {}, location: {}, reason: {}",
region_id,
location,
reason
))]
InvalidRequest {
region_id: RegionId,
reason: String,

View File

@@ -360,10 +360,11 @@ pub(crate) fn validate_proto_value(
InvalidRequestSnafu {
region_id,
reason: format!(
"column {} has type {:?}, but schema has type {:?}",
column_schema.column_name,
"value has type {:?}, but column {} has type {:?}({})",
value_type,
ColumnDataType::from_i32(column_schema.datatype)
column_schema.column_name,
ColumnDataType::from_i32(column_schema.datatype),
column_schema.datatype,
),
}
);