rust/greptimedb
1
0
Fork 0
mirror of https://github.com/GreptimeTeam/greptimedb.git synced 2026-08-18 12:08:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: preserve nulls in timestamp arrays (#8508)

Browse Source 
Signed-off-by: discord9 <discord9@163.com>
This commit is contained in:
discord9
2026-07-16 14:40:42 +08:00
committed by GitHub
parent a3816c889e
commit c7bcddacc5
1 changed files with 57 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/servers/src/postgres/types.rs
+57 -5
View File
@@ -1055,17 +1055,22 @@ pub(super) fn parameters_to_scalar_values(
TimestampType::Nanosecond(_) => {
let values = data
.into_iter()
.filter_map(|ts| {
ts.and_then(|ts| {
ts.and_utc().timestamp_nanos_opt().map(|nanos| {
.map(|ts| match ts {
None => {
Ok(ScalarValue::TimestampNanosecond(None, None))
}
Some(ts) => ts
.and_utc()
.timestamp_nanos_opt()
.map(|nanos| {
ScalarValue::TimestampNanosecond(
Some(nanos),
None,
)
})
})
.ok_or_else(|| numeric_out_of_range_error(ts)),
})
.collect::<Vec<_>>();
.collect::<PgWireResult<Vec<_>>>()?;
ScalarValue::List(ScalarValue::new_list(
&values,
&ArrowDataType::Timestamp(TimeUnit::Nanosecond, None),
@@ -2051,6 +2056,53 @@ mod test {
}
}
fn qbs_timestamp_nanosecond_array_plan() -> LogicalPlan {
build_plan_with_params(vec![(
"$1",
DataType::List(Arc::new(Field::new(
"item",
DataType::Timestamp(TimeUnit::Nanosecond, None),
true,
))),
)])
}
#[test]
fn test_qbs_pg_timestamp_nanosecond_array_preserves_null_slot() {
let portal = make_portal(
vec![Some(Type::TIMESTAMP_ARRAY)],
vec![s(
r#"{"2024-01-01 00:00:00.000001",NULL,"2024-01-01 00:00:00.000003"}"#,
)],
);
let values =
parameters_to_scalar_values(&qbs_timestamp_nanosecond_array_plan(), &portal).unwrap();
let expected = ScalarValue::List(ScalarValue::new_list(
&[
ScalarValue::TimestampNanosecond(Some(1_704_067_200_000_001_000), None),
ScalarValue::TimestampNanosecond(None, None),
ScalarValue::TimestampNanosecond(Some(1_704_067_200_000_003_000), None),
],
&ArrowDataType::Timestamp(TimeUnit::Nanosecond, None),
true,
));
assert_eq!(expected, values[0]);
}
#[test]
fn test_qbs_pg_timestamp_nanosecond_array_out_of_range_rejected() {
let portal = make_portal(
vec![Some(Type::TIMESTAMP_ARRAY)],
vec![s(r#"{"3000-01-01 00:00:00"}"#)],
);
assert_numeric_out_of_range(parameters_to_scalar_values(
&qbs_timestamp_nanosecond_array_plan(),
&portal,
));
}
#[test]
fn test_numeric_uint64_scalar_negative_rejected() {
let plan = build_plan_with_params(vec![("$1", DataType::UInt64)]);