refactor: move code out of loop (#1657)

This commit is contained in:
Weny Xu
2023-05-27 14:31:13 +09:00
committed by GitHub
parent 4094907c09
commit d072947ef2

View File

@@ -183,19 +183,19 @@ impl HeartbeatHandlerGroup {
) -> Result<HeartbeatResponse> {
let mut acc = HeartbeatAccumulator::default();
let handlers = self.handlers.read().await;
let role = req
.header
.as_ref()
.and_then(|h| Role::from_i32(h.role))
.context(error::InvalidArgumentsSnafu {
err_msg: format!("invalid role: {:?}", req.header),
})?;
for h in handlers.iter() {
if ctx.is_skip_all() {
break;
}
let role = req
.header
.as_ref()
.and_then(|h| Role::from_i32(h.role))
.context(error::InvalidArgumentsSnafu {
err_msg: format!("invalid role: {:?}", req.header),
})?;
if h.is_acceptable(role) {
h.handle(&req, &mut ctx, &mut acc).await?;
}