rust/greptimedb
1
0
Fork 0
mirror of https://github.com/GreptimeTeam/greptimedb.git synced 2026-05-27 18:30:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: iterator bad implement (#2760)

Browse Source 
* fix: iter_data() doesn't stop

* chore: Update src/datatypes/src/vectors/decimal.rs

---------

Co-authored-by: Yingwen <realevenyag@gmail.com>
This commit is contained in:
Wei
2023-11-16 20:26:05 +08:00
committed by GitHub
parent ae27fbc7f2
commit d2cf72e0f1
1 changed files with 22 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
src/datatypes/src/vectors/decimal.rs
View File

@@ -252,11 +252,9 @@ impl<'a> Iterator for Decimal128Iter<'a> {
type Item = Option<Decimal128>;
fn next(&mut self) -> Option<Self::Item> {
Some(
self.iter
.next()
.and_then(|v| v.map(|v| Decimal128::new(v, self.precision, self.scale))),
)
self.iter
.next()
.map(|item| item.map(|v| Decimal128::new(v, self.precision, self.scale)))
}
fn size_hint(&self) -> (usize, Option<usize>) {
@@ -519,3 +517,22 @@ pub mod tests {
assert!(array.is_null(4));
}
}
#[test]
fn test_decimal28_vector_iter_data() {
let vector = Decimal128Vector::from_values(vec![1, 2, 3, 4])
.with_precision_and_scale(3, 1)
.unwrap();
let mut iter = vector.iter_data();
assert_eq!(iter.next(), Some(Some(Decimal128::new(1, 3, 1))));
assert_eq!(iter.next(), Some(Some(Decimal128::new(2, 3, 1))));
assert_eq!(iter.next(), Some(Some(Decimal128::new(3, 3, 1))));
assert_eq!(iter.next(), Some(Some(Decimal128::new(4, 3, 1))));
assert_eq!(iter.next(), None);
let values = vector
.iter_data()
.filter_map(|v| v.map(|x| x.val() * 2))
.collect::<Vec<_>>();
assert_eq!(values, vec![2, 4, 6, 8]);
}