rust/greptimedb
1
0
Fork 0
mirror of https://github.com/GreptimeTeam/greptimedb.git synced 2026-11-04 09:57:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: revert unnecessary change

Browse Source
This commit is contained in:
Ning Sun
2026-09-18 17:47:50 +08:00
parent 6517feb91a
commit dcbe34d481
1 changed files with 2 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/metric-engine/src/engine/create.rs
+2 -34
View File
@@ -234,9 +234,8 @@ impl MetricEngineInner {
request_unit == unit,
UnexpectedRequestSnafu {
reason: format!(
"Metric has different time unit ({request_unit:?}) than the physical \
table ({unit:?}); the time index unit of a logical table must match \
the physical table's",
"Metric has differenttime unit ({:?}) than the physical region ({:?})",
request_unit, unit
),
}
);
@@ -1110,37 +1109,6 @@ mod test {
assert!(is_tsid_col(tsid_metadata));
}
#[tokio::test]
async fn test_create_logical_regions_time_index_unit_mismatch() {
let env = TestEnv::new().await;
let engine = env.metric();
let physical_region_id = env.default_physical_region_id();
let logical_region_id = env.default_logical_region_id();
env.create_physical_region_with_ts_type(
physical_region_id,
&TestEnv::default_table_dir(),
vec![],
ConcreteDataType::timestamp_microsecond_datatype(),
)
.await;
// A logical region request with a millisecond time index is rejected
// with the mismatch error naming both units.
let request = create_logical_region_request(
&["job"],
physical_region_id,
&store_api::path_utils::table_dir("test", logical_region_id.table_id()),
);
let err = engine
.handle_request(logical_region_id, RegionRequest::Create(request))
.await
.unwrap_err();
let message = err.to_string();
assert!(message.contains("Millisecond"), "{message}");
assert!(message.contains("Microsecond"), "{message}");
assert!(message.contains("different time unit"), "{message}");
}
#[tokio::test]
async fn test_create_logical_regions() {
let env = TestEnv::new().await;