fix: allow ipv4_num_to_string to accept valid integers (#7994)

* fix: allow ipv4_num_to_string to accept valid integers

Signed-off-by: Johannes Sluis <joesluis51@gmail.com>

* test: update sqlness result file

Signed-off-by: Johannes Sluis <joesluis51@gmail.com>

* fix: use coercible integer signature for ipv4_num_to_string

Signed-off-by: Johannes Sluis <joesluis51@gmail.com>

---------

Signed-off-by: Johannes Sluis <joesluis51@gmail.com>

src/common/function/src/scalars/ip/ipv4.rs

@@ -20,7 +20,10 @@ use common_query::error::InvalidFuncArgsSnafu;
 use datafusion_common::arrow::array::{Array, AsArray, StringViewBuilder, UInt32Builder};
 use datafusion_common::arrow::compute;
 use datafusion_common::arrow::datatypes::{DataType, UInt32Type};
-use datafusion_expr::{ColumnarValue, ScalarFunctionArgs, Signature, TypeSignature, Volatility};
+use datafusion_expr::{
+    Coercion, ColumnarValue, ScalarFunctionArgs, Signature, TypeSignature, TypeSignatureClass,
+    Volatility,
+};
 use derive_more::Display;
 
 use crate::function::{Function, extract_args};
@@ -44,7 +47,7 @@ impl Default for Ipv4NumToString {
     fn default() -> Self {
         Self {
             signature: Signature::new(
-                TypeSignature::Exact(vec![DataType::UInt32]),
+                TypeSignature::Coercible(vec![Coercion::new_exact(TypeSignatureClass::Integer)]),
                 Volatility::Immutable,
             ),
             aliases: ["inet_ntoa".to_string()],
@@ -70,6 +73,14 @@ impl Function for Ipv4NumToString {
         args: ScalarFunctionArgs,
     ) -> datafusion_common::Result<ColumnarValue> {
         let [arg0] = extract_args(self.name(), &args)?;
+        let arg0 = compute::cast_with_options(
+            &arg0,
+            &DataType::UInt32,
+            &compute::CastOptions {
+                safe: false,
+                ..Default::default()
+            },
+        )?;
         let uint_vec = arg0.as_primitive::<UInt32Type>();
 
         let size = uint_vec.len();
@@ -171,7 +182,7 @@ mod tests {
     use std::sync::Arc;
 
     use arrow_schema::Field;
-    use datafusion_common::arrow::array::{StringViewArray, UInt32Array};
+    use datafusion_common::arrow::array::{Int64Array, StringViewArray, UInt32Array};
 
     use super::*;
 
@@ -200,6 +211,51 @@ mod tests {
         assert_eq!(result.value(3), "255.255.255.255");
     }
 
+    #[test]
+    fn test_ipv4_num_to_string_accepts_int64() {
+        let func = Ipv4NumToString::default();
+
+        // Test data
+        let values = vec![167772161i64, 3232235521i64, 0i64, 4294967295i64];
+        let input = ColumnarValue::Array(Arc::new(Int64Array::from(values)));
+
+        let args = ScalarFunctionArgs {
+            args: vec![input],
+            arg_fields: vec![],
+            number_rows: 4,
+            return_field: Arc::new(Field::new("x", DataType::Utf8View, false)),
+            config_options: Arc::new(Default::default()),
+        };
+        let result = func.invoke_with_args(args).unwrap();
+        let result = result.to_array(4).unwrap();
+        let result = result.as_string_view();
+
+        assert_eq!(result.value(0), "10.0.0.1");
+        assert_eq!(result.value(1), "192.168.0.1");
+        assert_eq!(result.value(2), "0.0.0.0");
+        assert_eq!(result.value(3), "255.255.255.255");
+    }
+
+    #[test]
+    fn test_ipv4_num_to_string_rejects_negative_int64() {
+        let func = Ipv4NumToString::default();
+
+        // Test data
+        let values = vec![-1i64];
+        let input = ColumnarValue::Array(Arc::new(Int64Array::from(values)));
+
+        let args = ScalarFunctionArgs {
+            args: vec![input],
+            arg_fields: vec![],
+            number_rows: 1,
+            return_field: Arc::new(Field::new("x", DataType::Utf8View, false)),
+            config_options: Arc::new(Default::default()),
+        };
+        let result = func.invoke_with_args(args);
+
+        assert!(result.is_err());
+    }
+
     #[test]
     fn test_ipv4_string_to_num() {
         let func = Ipv4StringToNum::default();

tests/cases/standalone/common/function/ip.result

@@ -122,6 +122,15 @@ FROM ip_v4_data;
 | 8  | 0.0.0.0         | 0          | 0                | 0.0.0.0         |
 +----+-----------------+------------+------------------+-----------------+
 
+-- Test IPv4 number to string conversion function without explicit cast
+SELECT ipv4_num_to_string(3232235521);
+
++---------------------------------------+
+| ipv4_num_to_string(Int64(3232235521)) |
++---------------------------------------+
+| 192.168.0.1                           |
++---------------------------------------+
+
 -- Test IPv4 CIDR functions
 -- SQLNESS SORT_RESULT 3 1
 SELECT

tests/cases/standalone/common/function/ip.sql

@@ -84,6 +84,9 @@ SELECT
     inet_ntoa(ip_numeric) AS computed_addr
 FROM ip_v4_data;
 
+-- Test IPv4 number to string conversion function without explicit cast
+SELECT ipv4_num_to_string(3232235521);
+
 -- Test IPv4 CIDR functions
 -- SQLNESS SORT_RESULT 3 1
 SELECT