rust/greptimedb
1
0
Fork 0
mirror of https://github.com/GreptimeTeam/greptimedb.git synced 2026-05-22 07:50:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: relax memory ordering of accessing VersionControl::submmitted_sequence (#305)

Browse Source 
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>

Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
This commit is contained in:
Ruihang Xia
2022-10-12 11:52:43 +08:00
committed by GitHub
parent 0c829a9712
commit e99668092c
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/storage/src/version.rs
View File

@@ -64,7 +64,7 @@ impl VersionControl {
#[inline]
pub fn committed_sequence(&self) -> SequenceNumber {
self.committed_sequence.load(Ordering::Acquire)
self.committed_sequence.load(Ordering::Relaxed)
}
/// Set committed sequence to `value`.
@@ -73,8 +73,8 @@ impl VersionControl {
/// last sequence.
#[inline]
pub fn set_committed_sequence(&self, value: SequenceNumber) {
// Release ordering should be enough to guarantee sequence is updated at last.
self.committed_sequence.store(value, Ordering::Release);
// Relaxed ordering is enough for this update as this method requires external synchoronization.
self.committed_sequence.store(value, Ordering::Relaxed);
}
/// Add mutable memtables and commit.