rust/greptimedb
1
0
Fork 0
mirror of https://github.com/GreptimeTeam/greptimedb.git synced 2026-01-15 01:32:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: avoid clone column names (#161)

Browse Source
This commit is contained in:
Jiachun Feng
2022-08-12 10:09:23 +08:00
committed by GitHub
parent 1dd780d857
commit ea40616cfe
1 changed files with 24 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

43
src/storage/src/write_batch.rs
View File

@@ -627,28 +627,33 @@ pub mod codec {
.map(
|(ext, mtn)| match MutationType::from_i32(ext.mutation_type) {
Some(MutationType::Put) => {
let valid_column_names = if ext.column_null_mask.is_empty() {
column_names.clone()
} else {
bit_vec::BitVec::from_slice(&ext.column_null_mask)
.into_iter()
.zip(column_names.iter())
.filter(|(is_null, _)| !*is_null)
.map(|(_, column_name)| column_name.clone())
.collect::<Vec<_>>()
let gen_mutation_put = |valid_columns: &[String]| {
let mut put_data = PutData::with_num_columns(valid_columns.len());
let res = valid_columns
.iter()
.zip(mtn)
.map(|(name, vector)| {
put_data.add_column_by_name(name, vector.clone())
})
.collect::<Result<Vec<_>>>();
res.map(|_| Mutation::Put(put_data))
};
let mut put_data = PutData::with_num_columns(valid_column_names.len());
if ext.column_null_mask.is_empty() {
gen_mutation_put(&column_names)
} else {
let valid_columns =
bit_vec::BitVec::from_slice(&ext.column_null_mask)
.into_iter()
.zip(column_names.iter())
.filter(|(is_null, _)| !*is_null)
.map(|(_, column_name)| column_name.clone())
.collect::<Vec<_>>();
let res = valid_column_names
.iter()
.zip(mtn)
.map(|(name, vector)| {
put_data.add_column_by_name(name, vector.clone())
})
.collect::<Result<Vec<_>>>();
res.map(|_| Mutation::Put(put_data))
gen_mutation_put(&valid_columns)
}
}
Some(MutationType::Delete) => {
todo!("delete mutation")