rust/greptimedb
1
0
Fork 0
mirror of https://github.com/GreptimeTeam/greptimedb.git synced 2026-08-18 12:08:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(json2): treat empty object as null when insert (#8602)

Browse Source 
* fix(json2): treat empty object as null when insert

Signed-off-by: luofucong <luofc@foxmail.com>

* fix ci

Signed-off-by: luofucong <luofc@foxmail.com>

---------

Signed-off-by: luofucong <luofc@foxmail.com>
This commit is contained in:
LFC
2026-07-22 13:09:02 +00:00
committed by GitHub
parent 25217100b0
commit eddedff769
2 changed files with 11 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/datatypes/src/vectors/json/builder.rs
+10 -1
View File
@@ -114,6 +114,7 @@ fn json_variant_into_struct_value(
fn json_variant_into_value(value: JsonVariant, expected_type: &ConcreteDataType) -> Result<Value> {
let value = match (value, expected_type) {
(JsonVariant::Null, _) | (_, ConcreteDataType::Null(_)) => Value::Null,
(JsonVariant::Object(object), _) if object.is_empty() => Value::Null,
(JsonVariant::Bool(x), ConcreteDataType::Boolean(_)) => Value::Boolean(x),
(JsonVariant::Number(x), ConcreteDataType::UInt64(_)) => {
let Some(x) = x.as_u64() else {
@@ -247,7 +248,7 @@ impl MutableVector for JsonVectorBuilder {
}
fn to_vector(&mut self) -> VectorRef {
self.try_build().unwrap_or_else(|e| panic!("{}", e))
self.try_build().unwrap_or_else(|e| panic!("{:?}", e))
}
fn to_vector_cloned(&self) -> VectorRef {
@@ -420,6 +421,14 @@ mod tests {
#[test]
fn test_json_variant_into_struct_value() -> Result<()> {
assert_eq!(
json_variant_into_value(
JsonVariant::Object(Default::default()),
&ConcreteDataType::string_datatype(),
)?,
Value::Null
);
let item_type =
ConcreteDataType::struct_datatype(StructType::new(Arc::new(vec![StructField::new(
"id".to_string(),
tests/cases/standalone/common/types/json/json2.result
+1 -1
View File
@@ -150,7 +150,7 @@ select j.a, j.a.x from json2_table order by ts;
| {"b":-2} | |
| {"b":3} | |
| {"b":-4} | |
| {"b":null} | |
| | |
| | |
| {"b":"s7"} | |
| {"b":8} | |