refactor: merge servers::context into session (#811)

* refactor: move context to session

* chore: add unit test

* chore: add pg, opentsdb, influxdb and prometheus to channel enum

.github/workflows/coverage.yml

@@ -24,7 +24,7 @@ on:
 name: Code coverage
 
 env:
-  RUST_TOOLCHAIN: nightly-2022-07-14
+  RUST_TOOLCHAIN: nightly-2022-12-20
 
 jobs:
   coverage:
@@ -34,6 +34,11 @@ jobs:
     steps:
       - uses: actions/checkout@v3
       - uses: arduino/setup-protoc@v1
+        with:
+          repo-token: ${{ secrets.GITHUB_TOKEN }}
+      - uses: KyleMayes/install-llvm-action@v1
+        with:
+          version: "14.0"
       - name: Install toolchain
         uses: dtolnay/rust-toolchain@master
         with:
@@ -48,6 +53,7 @@ jobs:
       - name: Collect coverage data
         run: cargo llvm-cov nextest --workspace --lcov --output-path lcov.info
         env:
+          CARGO_BUILD_RUSTFLAGS: "-C link-arg=-fuse-ld=lld"
           RUST_BACKTRACE: 1
           CARGO_INCREMENTAL: 0
           GT_S3_BUCKET: ${{ secrets.S3_BUCKET }}

.github/workflows/develop.yml

@@ -23,7 +23,7 @@ on:
 name: CI
 
 env:
-  RUST_TOOLCHAIN: nightly-2022-07-14
+  RUST_TOOLCHAIN: nightly-2022-12-20
 
 jobs:
   typos:
@@ -41,6 +41,8 @@ jobs:
     steps:
       - uses: actions/checkout@v3
       - uses: arduino/setup-protoc@v1
+        with:
+          repo-token: ${{ secrets.GITHUB_TOKEN }}
       - uses: dtolnay/rust-toolchain@master
         with:
           toolchain: ${{ env.RUST_TOOLCHAIN }}
@@ -81,6 +83,8 @@ jobs:
   #         path: ./llvm
   #         key: llvm
   #     - uses: arduino/setup-protoc@v1
+  #       with:
+  #         repo-token: ${{ secrets.GITHUB_TOKEN }}
   #     - uses: KyleMayes/install-llvm-action@v1
   #       with:
   #         version: "14.0"
@@ -114,6 +118,8 @@ jobs:
     steps:
       - uses: actions/checkout@v3
       - uses: arduino/setup-protoc@v1
+        with:
+          repo-token: ${{ secrets.GITHUB_TOKEN }}
       - uses: dtolnay/rust-toolchain@master
         with:
           toolchain: ${{ env.RUST_TOOLCHAIN }}
@@ -131,6 +137,8 @@ jobs:
     steps:
       - uses: actions/checkout@v3
       - uses: arduino/setup-protoc@v1
+        with:
+          repo-token: ${{ secrets.GITHUB_TOKEN }}
       - uses: dtolnay/rust-toolchain@master
         with:
           toolchain: ${{ env.RUST_TOOLCHAIN }}

.github/workflows/release.yml

@@ -10,7 +10,7 @@ on:
 name: Release
 
 env:
-  RUST_TOOLCHAIN: nightly-2022-07-14
+  RUST_TOOLCHAIN: nightly-2022-12-20
 
   # FIXME(zyy17): Would be better to use `gh release list -L 1 | cut -f 3` to get the latest release version tag, but for a long time, we will stay at 'v0.1.0-alpha-*'.
   SCHEDULED_BUILD_VERSION_PREFIX: v0.1.0-alpha

Cargo.toml

@@ -39,5 +39,31 @@ members = [
     "tests/runner",
 ]
 
+[workspace.package]
+version = "0.1.0"
+edition = "2021"
+license = "Apache-2.0"
+
+[workspace.dependencies]
+arrow = "29.0"
+arrow-flight = "29.0"
+arrow-schema = { version = "29.0", features = ["serde"] }
+async-stream = "0.3"
+async-trait = "0.1"
+# TODO(LFC): Use released Datafusion when it officially dpendent on Arrow 29.0
+datafusion = { git = "https://github.com/apache/arrow-datafusion.git", rev = "4917235a398ae20145c87d20984e6367dc1a0c1e" }
+datafusion-common = { git = "https://github.com/apache/arrow-datafusion.git", rev = "4917235a398ae20145c87d20984e6367dc1a0c1e" }
+datafusion-expr = { git = "https://github.com/apache/arrow-datafusion.git", rev = "4917235a398ae20145c87d20984e6367dc1a0c1e" }
+datafusion-optimizer = { git = "https://github.com/apache/arrow-datafusion.git", rev = "4917235a398ae20145c87d20984e6367dc1a0c1e" }
+datafusion-physical-expr = { git = "https://github.com/apache/arrow-datafusion.git", rev = "4917235a398ae20145c87d20984e6367dc1a0c1e" }
+datafusion-sql = { git = "https://github.com/apache/arrow-datafusion.git", rev = "4917235a398ae20145c87d20984e6367dc1a0c1e" }
+futures = "0.3"
+parquet = "29.0"
+paste = "1.0"
+serde = { version = "1.0", features = ["derive"] }
+snafu = { version = "0.7", features = ["backtraces"] }
+sqlparser = "0.28"
+tokio = { version = "1", features = ["full"] }
+
 [profile.release]
 debug = true

benchmarks/Cargo.toml

@@ -1,14 +1,14 @@
 [package]
 name = "benchmarks"
-version = "0.1.0"
-edition = "2021"
-license = "Apache-2.0"
+version.workspace = true
+edition.workspace = true
+license.workspace = true
 
 [dependencies]
-arrow = "26.0.0"
+arrow.workspace = true
 clap = { version = "4.0", features = ["derive"] }
 client = { path = "../src/client" }
 indicatif = "0.17.1"
 itertools = "0.10.5"
-parquet = "26.0.0"
-tokio = { version = "1.21", features = ["full"] }
+parquet.workspace = true
+tokio.workspace = true

benchmarks/src/bin/nyc-taxi.rs

@@ -15,7 +15,6 @@
 //! Use the taxi trip records from New York City dataset to bench. You can download the dataset from
 //! [here](https://www1.nyc.gov/site/tlc/about/tlc-trip-record-data.page).
 
-#![feature(once_cell)]
 #![allow(clippy::print_stdout)]
 
 use std::collections::HashMap;
@@ -26,10 +25,9 @@ use arrow::array::{ArrayRef, PrimitiveArray, StringArray, TimestampNanosecondArr
 use arrow::datatypes::{DataType, Float64Type, Int64Type};
 use arrow::record_batch::RecordBatch;
 use clap::Parser;
-use client::admin::Admin;
 use client::api::v1::column::Values;
-use client::api::v1::{Column, ColumnDataType, ColumnDef, CreateTableExpr, InsertExpr, TableId};
-use client::{Client, Database, Select};
+use client::api::v1::{Column, ColumnDataType, ColumnDef, CreateTableExpr, InsertRequest, TableId};
+use client::{Client, Database};
 use indicatif::{MultiProgress, ProgressBar, ProgressStyle};
 use parquet::arrow::arrow_reader::ParquetRecordBatchReaderBuilder;
 use tokio::task::JoinSet;
@@ -94,14 +92,14 @@ async fn write_data(
         .unwrap();
     let progress_bar = mpb.add(ProgressBar::new(row_num as _));
     progress_bar.set_style(pb_style);
-    progress_bar.set_message(format!("{:?}", path));
+    progress_bar.set_message(format!("{path:?}"));
 
     let mut total_rpc_elapsed_ms = 0;
 
     for record_batch in record_batch_reader {
         let record_batch = record_batch.unwrap();
         let (columns, row_count) = convert_record_batch(record_batch);
-        let insert_expr = InsertExpr {
+        let request = InsertRequest {
             schema_name: "public".to_string(),
             table_name: TABLE_NAME.to_string(),
             region_number: 0,
@@ -109,16 +107,13 @@ async fn write_data(
             row_count,
         };
         let now = Instant::now();
-        db.insert(insert_expr).await.unwrap();
+        db.insert(request).await.unwrap();
         let elapsed = now.elapsed();
         total_rpc_elapsed_ms += elapsed.as_millis();
         progress_bar.inc(row_count as _);
     }
 
-    progress_bar.finish_with_message(format!(
-        "file {:?} done in {}ms",
-        path, total_rpc_elapsed_ms
-    ));
+    progress_bar.finish_with_message(format!("file {path:?} done in {total_rpc_elapsed_ms}ms",));
     total_rpc_elapsed_ms
 }
 
@@ -355,25 +350,23 @@ fn query_set() -> HashMap<String, String> {
 
     ret.insert(
         "count_all".to_string(),
-        format!("SELECT COUNT(*) FROM {};", TABLE_NAME),
+        format!("SELECT COUNT(*) FROM {TABLE_NAME};"),
     );
 
     ret.insert(
         "fare_amt_by_passenger".to_string(),
-        format!("SELECT passenger_count, MIN(fare_amount), MAX(fare_amount), SUM(fare_amount) FROM {} GROUP BY passenger_count",TABLE_NAME)
+        format!("SELECT passenger_count, MIN(fare_amount), MAX(fare_amount), SUM(fare_amount) FROM {TABLE_NAME} GROUP BY passenger_count")
     );
 
     ret
 }
 
-async fn do_write(args: &Args, client: &Client) {
-    let admin = Admin::new("admin", client.clone());
-
+async fn do_write(args: &Args, db: &Database) {
     let mut file_list = get_file_list(args.path.clone().expect("Specify data path in argument"));
     let mut write_jobs = JoinSet::new();
 
-    let create_table_result = admin.create(create_table_expr()).await;
-    println!("Create table result: {:?}", create_table_result);
+    let create_table_result = db.create(create_table_expr()).await;
+    println!("Create table result: {create_table_result:?}");
 
     let progress_bar_style = ProgressStyle::with_template(
         "[{elapsed_precise}] {bar:60.cyan/blue} {pos:>7}/{len:7} {msg}",
@@ -387,7 +380,7 @@ async fn do_write(args: &Args, client: &Client) {
     let batch_size = args.batch_size;
     for _ in 0..args.thread_num {
         if let Some(path) = file_list.pop() {
-            let db = Database::new(DATABASE_NAME, client.clone());
+            let db = db.clone();
             let mpb = multi_progress_bar.clone();
             let pb_style = progress_bar_style.clone();
             write_jobs.spawn(async move { write_data(batch_size, &db, path, mpb, pb_style).await });
@@ -396,7 +389,7 @@ async fn do_write(args: &Args, client: &Client) {
     while write_jobs.join_next().await.is_some() {
         file_progress.inc(1);
         if let Some(path) = file_list.pop() {
-            let db = Database::new(DATABASE_NAME, client.clone());
+            let db = db.clone();
             let mpb = multi_progress_bar.clone();
             let pb_style = progress_bar_style.clone();
             write_jobs.spawn(async move { write_data(batch_size, &db, path, mpb, pb_style).await });
@@ -406,10 +399,10 @@ async fn do_write(args: &Args, client: &Client) {
 
 async fn do_query(num_iter: usize, db: &Database) {
     for (query_name, query) in query_set() {
-        println!("Running query: {}", query);
+        println!("Running query: {query}");
         for i in 0..num_iter {
             let now = Instant::now();
-            let _res = db.select(Select::Sql(query.clone())).await.unwrap();
+            let _res = db.sql(&query).await.unwrap();
             let elapsed = now.elapsed();
             println!(
                 "query {}, iteration {}: {}ms",
@@ -431,13 +424,13 @@ fn main() {
         .unwrap()
         .block_on(async {
             let client = Client::with_urls(vec![&args.endpoint]);
+            let db = Database::new(DATABASE_NAME, client);
 
             if !args.skip_write {
-                do_write(&args, &client).await;
+                do_write(&args, &db).await;
             }
 
             if !args.skip_read {
-                let db = Database::new(DATABASE_NAME, client.clone());
                 do_query(args.iter_num, &db).await;
             }
         })

docker/Dockerfile

@@ -24,6 +24,8 @@ RUN cargo build --release
 # TODO(zyy17): Maybe should use the more secure container image.
 FROM ubuntu:22.04 as base
 
+RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get -y install ca-certificates
+
 WORKDIR /greptime
 COPY --from=builder /greptimedb/target/release/greptime /greptime/bin/
 ENV PATH /greptime/bin/:$PATH

docker/ci/Dockerfile

@@ -1,5 +1,7 @@
 FROM ubuntu:22.04
 
+RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get -y install ca-certificates
+
 ARG TARGETARCH
 
 ADD $TARGETARCH/greptime /greptime/bin/

docs/rfcs/2022-12-20-promql-in-rust/rfc.md

@@ -0,0 +1,175 @@
+---
+Feature Name: "promql-in-rust"
+Tracking Issue: https://github.com/GreptimeTeam/greptimedb/issues/596
+Date: 2022-12-20
+Author: "Ruihang Xia <waynestxia@gmail.com>"
+---
+
+Rewrite PromQL in Rust
+----------------------
+
+# Summary
+A Rust native implementation of PromQL, for GreptimeDB.
+
+# Motivation
+Prometheus and its query language PromQL prevails in the cloud-native observability area, which is an important scenario for time series database like GreptimeDB. We already have support for its remote read and write protocols. Users can now integrate GreptimeDB as the storage backend to existing Prometheus deployment, but cannot run PromQL query directly on GreptimeDB like SQL.
+
+This RFC proposes to add support for PromQL. Because it was created in Go, we can't use the existing code easily. For interoperability, performance and extendability, porting its logic to Rust is a good choice.
+
+# Details
+
+## Overview
+One of the goals is to make use of our existing basic operators, execution model and runtime to reduce the work. So the entire proposal is built on top of Apache Arrow DataFusion. The rewrote PromQL logic is manifested as `Expr` or `Execution Plan` in DataFusion. And both the intermediate data structure and the result is in the format of `Arrow`'s `RecordBatch`.
+
+The following sections are organized in a top-down manner. Starts with evaluation procedure. Then introduces the building blocks of our new PromQL operation. Follows by an explanation of data model. And end with an example logic plan.
+
+*This RFC is heavily related to Prometheus and PromQL. It won't repeat some basic concepts of them.*
+
+## Evaluation
+
+The original implementation is like an interpreter of parsed PromQL AST. It has two characteristics: (1) Operations are evaluated in place after they are parsed to AST. And some key parameters are separated from the AST because they do not present in the query, but come from other places like another field in the HTTP payload. (2) calculation is performed per timestamp. You can see this pattern many times:
+```go
+for ts := ev.startTimestamp; ts <= ev.endTimestamp; ts += ev.interval {}
+```
+
+These bring out two differences in the proposed implementation. First, to make it more general and clear, the evaluation procedure is reorganized into serval phases (and is the same as DataFusion's). And second, data are evaluated by time series (corresponding to "columnar calculation", if think timestamp as row number).
+
+```
+                                      Logic
+   Query             AST              Plan
+ ─────────► Parser ───────► Logical ────────► Physical ────┐
+                            Planner           Planner      │
+                                                           │
+ ◄───────────────────────────── Executor  ◄────────────────┘
+        Evaluation Result                     Execution
+                                                Plan
+```
+
+- Parser 
+
+    Provided by [`promql-parser`](https://github.com/GreptimeTeam/promql-parser) crate. Same as the original implementation.
+
+- Logical Planner
+
+    Generates a logical plan with all the needed parameters. It should accept something like `EvalStmt` in Go's implementation, which contains query time range, evaluation interval and lookback range.
+
+    Another important thing done here is assembling the logic plan, with all the operations baked into logically. Like what's the filter and time range to read, how the data then flows through a selector into a binary operation, etc. Or what's the output schema of every single step. The generated logic plan is deterministic without variables, and can be `EXPLAIN`ed clearly.
+
+- Physical Planner
+
+    This step converts a logic plan into evaluatable execution plan. There are not many special things like the previous step. Except when a query is going to be executed distributedly. In this case, a logic plan will be divided into serval parts and sent to serval nodes. One physical planner only sees its own part.
+
+- Executor
+
+    As its name shows, this step calculates data to result. And all new calculation logic, the implementation of PromQL in rust, is placed here. And the rewrote functions are using `RecordBatch` and `Array` from `Arrow` as the intermediate data structure.
+
+    Each "batch" contains only data from single time series. This is from the underlying storage implementation. Though it's not a requirement of this RFC, having this property can simplify some functions.
+    
+    Another thing to mention is the rewrote functions don't aware of timestamp or value columns, they are defined only based on the input data types. For example, `increase()` function in PromQL calculates the unbiased delta of data, its implementation here only does this single thing. Let's compare the signature of two implementations:
+
+    - Go
+        ```go
+        func funcIncrease(vals []parser.Value, args parser.Expressions) Vector {}
+        ```
+    - Rust
+        ```rust
+        fn prom_increase(input: Array) -> Array {}
+        ```
+
+    Some unimportant parameters are omitted. The original Go version only writes the logic for `Point`'s value, either float or histogram. But the proposed rewritten one accepts a generic `Array` as input, which can be any type that suits, from `i8` to `u64` to `TimestampNanosecond`.
+
+## Plan and Expression
+
+They are structures to express logic from PromQL. The proposed implementation is built on top of DataFusion, thus our plan and expression are in form of `ExtensionPlan` and `ScalarUDF`. The only difference between them in this context is the return type: plan returns a record batch while expression returns a single column.
+
+This RFC proposes to add four new plans, they are fundamental building blocks that mainly handle data selection logic in PromQL, for the following calculation expressions. 
+
+- `SeriesNormalize`
+
+    Sort data inside one series on the timestamp column, and bias "offset" if has. This plan usually comes after `TableScan` (or `TableScan` and `Filter`) plan.
+
+- `VectorManipulator` and `MatrixManipulator`
+
+    Corresponding to `InstantSelector` and `RangeSelector`. We don't calculate timestamp by timestamp, thus use "vector" instead of "instant", this image shows the difference. And "matrix" is another name for "range vector", for not confused with our "vector". The following section will detail how they are implemented using Arrow.
+
+    ![instant_and_vector](instant-and-vector.png)
+
+    Due to "interval" parameter in PromQL, data after "selector" (or "manipulator" here) are usually shorter than input. And we have to modify the entire record batch to shorten both timestamp, value and tag columns. So they are formed as plan.
+
+- `PromAggregator`
+
+    The carrier of aggregator expressions. This should not be very different from the DataFusion built-in `Aggregate` plan, except PromQL can use "group without" to do reverse selection.
+
+PromQL has around 70 expressions and functions. But luckily we can reuse lots of them from DataFusion. Like unary expression, binary expression and aggregator. We only need to implement those PromQL-specific expressions, like `rate` or `percentile`. The following table lists some typical functions in PromQL, and their signature in the proposed implementation. Other function should be the same.
+
+| Name               	| In Param(s)                                          	| Out Param(s) 	| Explain            	|
+|--------------------	|------------------------------------------------------	|--------------	|--------------------	|
+| instant_delta      	| Matrix T                                             	| Array T      	| idelta in PromQL   	|
+| increase           	| Matrix T                                             	| Array T      	| increase in PromQL 	|
+| extrapolate_factor 	| - Matrix T<br>- Array Timestamp<br>- Array Timestamp 	| Array T      	| *                   	|
+
+*: *`extrapolate_factor` is one of the "dark sides" in PromQL. In short it's a translation of this [paragraph](https://github.com/prometheus/prometheus/blob/0372e259baf014bbade3134fd79bcdfd8cbdef2c/promql/functions.go#L134-L159)*
+
+To reuse those common calculation logic, we can break them into serval expressions, and assemble in the logic planning phase. Like `rate()` in PromQL can be represented as `increase / extrapolate_factor`.
+
+## Data Model
+
+This part explains how data is represented. Following the data model in GreptimeDB, all the data are stored as table, with tag columns, timestamp column and value column. Table to record batch is very straightforward. So an instant vector can be thought of as a row (though as said before, we don't use instant vectors) in the table. Given four basic types in PromQL: scalar, string, instant vector and range vector, only the last "range vector" need some tricks to adapt our columnar calculation.
+
+Range vector is some sort of matrix, it's consisted of small one-dimension vectors, with each being an input of range function. And, applying range function to a range vector can be thought of kind of convolution.
+
+![range-vector-with-matrix](range-vector-with-matrix.png)
+
+(Left is an illustration of range vector. Notice the Y-axis has no meaning, it's just put different pieces separately. The right side is an imagined "matrix" as range function. Multiplying the left side to it can get a one-dimension "matrix" with four elements. That's the evaluation result of a range vector.)
+
+To adapt this range vector to record batch, it should be represented by a column. This RFC proposes to use `DictionaryArray` from Arrow to represent range vector, or `Matrix`. This is "misusing" `DictionaryArray` to ship some additional information about an array. Because the range vector is sliding over one series, we only need to know the `offset` and `length` of each slides to reconstruct the matrix from an array:
+
+![matrix-from-array](matrix-from-array.png)
+
+The length is not fixed, it depends on the input's timestamp. An PoC implementation of `Matrix` and `increase()` can be found in [this repo](https://github.com/waynexia/corroding-prometheus).
+
+## Example
+
+The logic plan of PromQL query
+```promql
+# start: 2022-12-20T10:00:00
+# end: 2022-12-21T10:00:00
+# interval: 1m
+# lookback: 30s
+sum (rate(request_duration[5m])) by (idc)
+```
+looks like
+
+<!-- title: 'PromAggregator: \naggr = sum, column = idc'
+operator: prom
+inputs:
+- title: 'Matrix Manipulator: \ninterval = 1m, range = 5m, expr = div(increase(value), extrapolate_factor(timestamp))'
+  operator: prom
+  inputs:
+  - title: 'Series Normalize: \noffset = 0'
+    operator: prom
+    inputs:
+    - title: 'Filter: \ntimetamp > 2022-12-20T10:00:00 && timestamp < 2022-12-21T10:00:00'
+      operator: filter
+      inputs:
+      - title: 'Table Scan: \ntable = request_duration, timetamp > 2022-12-20T10:00:00 && timestamp < 2022-12-21T10:00:00'
+        operator: scan -->
+
+![example](example.png)
+
+# Drawbacks
+
+Human-being is always error-prone. It's harder to endeavor to rewrite from the ground and requires more attention to ensure correctness, than translate line-by-line. And, since the evaluator's architecture are different, it might be painful to catch up with PromQL's breaking update (if any) in the future.
+
+Misusing Arrow's DictionaryVector as Matrix is another point. This hack needs some `unsafe` function call to bypass Arrow's check. And though Arrow's API is stable, this is still an undocumented behavior.
+
+# Alternatives
+
+There are a few alternatives we've considered:
+- Wrap the existing PromQL's implementation via FFI, and import it to GreptimeDB.
+- Translate its evaluator engine line-by-line, rather than rewrite one.
+- Integrate the Prometheus server into GreptimeDB via RPC, making it a detached execution engine for PromQL.
+
+The first and second options are making a separate execution engine in GreptimeDB, they may alleviate the pain during rewriting, but will have negative impacts to afterward evolve like resource management. And introduce another deploy component in the last option will bring a complex deploy architecture.
+
+And all of them are more or less redundant in data transportation that affects performance and resources. The proposed built-in executing procedure is also easy to integrate and expose to the existing SQL interface GreptimeDB currently provides. Some concepts in PromQL like sliding windows (range vector in PromQL) are very convenient and ergonomic in analyzing series data. This makes it not only a PromQL evaluator, but also an enhancement to our query system.

rust-toolchain

@@ -1 +1 @@
-nightly-2022-07-14
+nightly-2022-12-20

src/api/Cargo.toml

@@ -1,11 +1,11 @@
 [package]
 name = "api"
-version = "0.1.0"
-edition = "2021"
-license = "Apache-2.0"
-# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
+version.workspace = true
+edition.workspace = true
+license.workspace = true
 
 [dependencies]
+arrow-flight.workspace = true
 common-base = { path = "../common/base" }
 common-error = { path = "../common/error" }
 common-time = { path = "../common/time" }

src/api/build.rs

@@ -20,7 +20,6 @@ fn main() {
         .file_descriptor_set_path(default_out_dir.join("greptime_fd.bin"))
         .compile(
             &[
-                "greptime/v1/select.proto",
                 "greptime/v1/greptime.proto",
                 "greptime/v1/meta/common.proto",
                 "greptime/v1/meta/heartbeat.proto",

src/api/greptime/v1/common.proto

@@ -6,17 +6,8 @@ message RequestHeader {
   string tenant = 1;
 }
 
-message ExprHeader {
-  uint32 version = 1;
-}
-
 message ResultHeader {
   uint32 version = 1;
   uint32 code = 2;
   string err_msg = 3;
 }
-
-message MutateResult {
-  uint32 success = 1;
-  uint32 failure = 2;
-}

src/api/greptime/v1/database.proto

@@ -2,6 +2,7 @@ syntax = "proto3";
 
 package greptime.v1;
 
+import "greptime/v1/ddl.proto";
 import "greptime/v1/column.proto";
 import "greptime/v1/common.proto";
 
@@ -15,24 +16,21 @@ message DatabaseResponse {
 }
 
 message ObjectExpr {
-  ExprHeader header = 1;
-  oneof expr {
-    InsertExpr insert = 2;
-    SelectExpr select = 3;
-    UpdateExpr update = 4;
-    DeleteExpr delete = 5;
+  oneof request {
+    InsertRequest insert = 1;
+    QueryRequest query = 2;
+    DdlRequest ddl = 3;
   }
 }
 
-// TODO(fys): Only support sql now, and will support promql etc in the future
-message SelectExpr {
-  oneof expr {
+message QueryRequest {
+  oneof query {
     string sql = 1;
     bytes logical_plan = 2;
   }
 }
 
-message InsertExpr {
+message InsertRequest {
   string schema_name = 1;
   string table_name = 2;
 
@@ -41,26 +39,18 @@ message InsertExpr {
 
   // The row_count of all columns, which include null and non-null values.
   //
-  // Note: the row_count of all columns in a InsertExpr must be same.
+  // Note: the row_count of all columns in a InsertRequest must be same.
   uint32 row_count = 4;
 
   // The region number of current insert request.
   uint32 region_number = 5;
 }
 
-// TODO(jiachun)
-message UpdateExpr {}
-// TODO(jiachun)
-message DeleteExpr {}
-
 message ObjectResult {
   ResultHeader header = 1;
-  oneof result {
-    SelectResult select = 2;
-    MutateResult mutate = 3;
-  }
+  repeated bytes flight_data = 2;
 }
 
-message SelectResult {
-  bytes raw_data = 1;
+message FlightDataExt {
+  uint32 affected_rows = 1;
 }

src/api/greptime/v1/ddl.proto

@@ -5,29 +5,15 @@ package greptime.v1;
 import "greptime/v1/column.proto";
 import "greptime/v1/common.proto";
 
-message AdminRequest {
-  string name = 1;
-  repeated AdminExpr exprs = 2;
-}
-
-message AdminResponse {
-  repeated AdminResult results = 1;
-}
-
-message AdminExpr {
-  ExprHeader header = 1;
+// "Data Definition Language" requests, that create, modify or delete the database structures but not the data.
+// `DdlRequest` could carry more information than plain SQL, for example, the "table_id" in `CreateTableExpr`.
+// So create a new DDL expr if you need it.
+message DdlRequest {
   oneof expr {
+    CreateDatabaseExpr create_database = 1;
     CreateTableExpr create_table = 2;
     AlterExpr alter = 3;
-    CreateDatabaseExpr create_database = 4;
-    DropTableExpr drop_table = 5;
-  }
-}
-
-message AdminResult {
-  ResultHeader header = 1;
-  oneof result {
-    MutateResult mutate = 2;
+    DropTableExpr drop_table = 4;
   }
 }
 

src/api/greptime/v1/greptime.proto

@@ -2,7 +2,6 @@ syntax = "proto3";
 
 package greptime.v1;
 
-import "greptime/v1/admin.proto";
 import "greptime/v1/common.proto";
 import "greptime/v1/database.proto";
 
@@ -12,11 +11,9 @@ service Greptime {
 
 message BatchRequest {
   RequestHeader header = 1;
-  repeated AdminRequest admins = 2;
-  repeated DatabaseRequest databases = 3;
+  repeated DatabaseRequest databases = 2;
 }
 
 message BatchResponse {
-  repeated AdminResponse admins = 1;
-  repeated DatabaseResponse databases = 2;
+  repeated DatabaseResponse databases = 1;
 }

src/api/greptime/v1/select.proto

@@ -1,10 +0,0 @@
-syntax = "proto3";
-
-package greptime.v1.codec;
-
-import "greptime/v1/column.proto";
-
-message SelectResult {
-  repeated Column columns = 1;
-  uint32 row_count = 2;
-}

src/api/src/result.rs

@@ -12,30 +12,19 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-use common_error::prelude::ErrorExt;
+use arrow_flight::FlightData;
+use prost::Message;
 
-use crate::v1::codec::SelectResult;
-use crate::v1::{
-    admin_result, object_result, AdminResult, MutateResult, ObjectResult, ResultHeader,
-    SelectResult as SelectResultRaw,
-};
+use crate::v1::{ObjectResult, ResultHeader};
 
 pub const PROTOCOL_VERSION: u32 = 1;
 
-pub type Success = u32;
-pub type Failure = u32;
-
 #[derive(Default)]
 pub struct ObjectResultBuilder {
     version: u32,
     code: u32,
     err_msg: Option<String>,
-    result: Option<Body>,
-}
-
-pub enum Body {
-    Mutate((Success, Failure)),
-    Select(SelectResult),
+    flight_data: Option<Vec<FlightData>>,
 }
 
 impl ObjectResultBuilder {
@@ -62,13 +51,8 @@ impl ObjectResultBuilder {
         self
     }
 
-    pub fn mutate_result(mut self, success: u32, failure: u32) -> Self {
-        self.result = Some(Body::Mutate((success, failure)));
-        self
-    }
-
-    pub fn select_result(mut self, select_result: SelectResult) -> Self {
-        self.result = Some(Body::Select(select_result));
+    pub fn flight_data(mut self, flight_data: Vec<FlightData>) -> Self {
+        self.flight_data = Some(flight_data);
         self
     }
 
@@ -79,92 +63,24 @@ impl ObjectResultBuilder {
             err_msg: self.err_msg.unwrap_or_default(),
         });
 
-        let result = match self.result {
-            Some(Body::Mutate((success, failure))) => {
-                Some(object_result::Result::Mutate(MutateResult {
-                    success,
-                    failure,
-                }))
-            }
-            Some(Body::Select(select)) => Some(object_result::Result::Select(SelectResultRaw {
-                raw_data: select.into(),
-            })),
-            None => None,
-        };
-
-        ObjectResult { header, result }
-    }
-}
-
-pub fn build_err_result(err: &impl ErrorExt) -> ObjectResult {
-    ObjectResultBuilder::new()
-        .status_code(err.status_code() as u32)
-        .err_msg(err.to_string())
-        .build()
-}
-
-#[derive(Debug)]
-pub struct AdminResultBuilder {
-    version: u32,
-    code: u32,
-    err_msg: Option<String>,
-    mutate: Option<(Success, Failure)>,
-}
-
-impl AdminResultBuilder {
-    pub fn status_code(mut self, code: u32) -> Self {
-        self.code = code;
-        self
-    }
-
-    pub fn err_msg(mut self, err_msg: String) -> Self {
-        self.err_msg = Some(err_msg);
-        self
-    }
-
-    pub fn mutate_result(mut self, success: u32, failure: u32) -> Self {
-        self.mutate = Some((success, failure));
-        self
-    }
-
-    pub fn build(self) -> AdminResult {
-        let header = Some(ResultHeader {
-            version: self.version,
-            code: self.code,
-            err_msg: self.err_msg.unwrap_or_default(),
-        });
-
-        let result = if let Some((success, failure)) = self.mutate {
-            Some(admin_result::Result::Mutate(MutateResult {
-                success,
-                failure,
-            }))
+        let flight_data = if let Some(flight_data) = self.flight_data {
+            flight_data
+                .into_iter()
+                .map(|x| x.encode_to_vec())
+                .collect::<Vec<Vec<u8>>>()
         } else {
-            None
+            vec![]
         };
-
-        AdminResult { header, result }
-    }
-}
-
-impl Default for AdminResultBuilder {
-    fn default() -> Self {
-        Self {
-            version: PROTOCOL_VERSION,
-            code: 0,
-            err_msg: None,
-            mutate: None,
+        ObjectResult {
+            header,
+            flight_data,
         }
     }
 }
 
 #[cfg(test)]
 mod tests {
-    use common_error::status_code::StatusCode;
-
     use super::*;
-    use crate::error::UnknownColumnDataTypeSnafu;
-    use crate::v1::{object_result, MutateResult};
 
     #[test]
     fn test_object_result_builder() {
@@ -172,32 +88,10 @@ mod tests {
             .version(101)
             .status_code(500)
             .err_msg("Failed to read this file!".to_string())
-            .mutate_result(100, 20)
             .build();
         let header = obj_result.header.unwrap();
         assert_eq!(101, header.version);
         assert_eq!(500, header.code);
         assert_eq!("Failed to read this file!", header.err_msg);
-
-        let result = obj_result.result.unwrap();
-        assert_eq!(
-            object_result::Result::Mutate(MutateResult {
-                success: 100,
-                failure: 20,
-            }),
-            result
-        );
-    }
-
-    #[test]
-    fn test_build_err_result() {
-        let err = UnknownColumnDataTypeSnafu { datatype: 1 }.build();
-        let err_result = build_err_result(&err);
-        let header = err_result.header.unwrap();
-        let result = err_result.result;
-
-        assert_eq!(PROTOCOL_VERSION, header.version);
-        assert_eq!(StatusCode::InvalidArguments as u32, header.code);
-        assert!(result.is_none());
     }
 }

src/api/src/serde.rs

@@ -15,7 +15,6 @@
 pub use prost::DecodeError;
 use prost::Message;
 
-use crate::v1::codec::SelectResult;
 use crate::v1::meta::TableRouteValue;
 
 macro_rules! impl_convert_with_bytes {
@@ -36,80 +35,4 @@ macro_rules! impl_convert_with_bytes {
     };
 }
 
-impl_convert_with_bytes!(SelectResult);
 impl_convert_with_bytes!(TableRouteValue);
-
-#[cfg(test)]
-mod tests {
-    use std::ops::Deref;
-
-    use crate::v1::codec::*;
-    use crate::v1::{column, Column};
-
-    const SEMANTIC_TAG: i32 = 0;
-
-    #[test]
-    fn test_convert_select_result() {
-        let select_result = mock_select_result();
-
-        let bytes: Vec<u8> = select_result.into();
-        let result: SelectResult = bytes.deref().try_into().unwrap();
-
-        assert_eq!(8, result.row_count);
-        assert_eq!(1, result.columns.len());
-
-        let column = &result.columns[0];
-        assert_eq!("foo", column.column_name);
-        assert_eq!(SEMANTIC_TAG, column.semantic_type);
-        assert_eq!(vec![1], column.null_mask);
-        assert_eq!(
-            vec![2, 3, 4, 5, 6, 7, 8],
-            column.values.as_ref().unwrap().i32_values
-        );
-    }
-
-    #[should_panic]
-    #[test]
-    fn test_convert_select_result_wrong() {
-        let select_result = mock_select_result();
-
-        let mut bytes: Vec<u8> = select_result.into();
-
-        // modify some bytes
-        bytes[0] = 0b1;
-        bytes[1] = 0b1;
-
-        let result: SelectResult = bytes.deref().try_into().unwrap();
-
-        assert_eq!(8, result.row_count);
-        assert_eq!(1, result.columns.len());
-
-        let column = &result.columns[0];
-        assert_eq!("foo", column.column_name);
-        assert_eq!(SEMANTIC_TAG, column.semantic_type);
-        assert_eq!(vec![1], column.null_mask);
-        assert_eq!(
-            vec![2, 3, 4, 5, 6, 7, 8],
-            column.values.as_ref().unwrap().i32_values
-        );
-    }
-
-    fn mock_select_result() -> SelectResult {
-        let values = column::Values {
-            i32_values: vec![2, 3, 4, 5, 6, 7, 8],
-            ..Default::default()
-        };
-        let null_mask = vec![1];
-        let column = Column {
-            column_name: "foo".to_string(),
-            semantic_type: SEMANTIC_TAG,
-            values: Some(values),
-            null_mask,
-            ..Default::default()
-        };
-        SelectResult {
-            columns: vec![column],
-            row_count: 8,
-        }
-    }
-}

src/api/src/v1.rs

@@ -17,9 +17,5 @@ tonic::include_proto!("greptime.v1");
 
 pub const GREPTIME_FD_SET: &[u8] = tonic::include_file_descriptor_set!("greptime_fd");
 
-pub mod codec {
-    tonic::include_proto!("greptime.v1.codec");
-}
-
 mod column_def;
 pub mod meta;

src/catalog/Cargo.toml

@@ -1,14 +1,13 @@
 [package]
 name = "catalog"
-version = "0.1.0"
-edition = "2021"
-license = "Apache-2.0"
-# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
+version.workspace = true
+edition.workspace = true
+license.workspace = true
 
 [dependencies]
 api = { path = "../api" }
 arc-swap = "1.0"
-async-stream = "0.3"
+async-stream.workspace = true
 async-trait = "0.1"
 backoff = { version = "0.4", features = ["tokio"] }
 common-catalog = { path = "../common/catalog" }
@@ -19,7 +18,7 @@ common-recordbatch = { path = "../common/recordbatch" }
 common-runtime = { path = "../common/runtime" }
 common-telemetry = { path = "../common/telemetry" }
 common-time = { path = "../common/time" }
-datafusion = "14.0.0"
+datafusion.workspace = true
 datatypes = { path = "../datatypes" }
 futures = "0.3"
 futures-util = "0.3"
@@ -31,7 +30,7 @@ serde_json = "1.0"
 snafu = { version = "0.7", features = ["backtraces"] }
 storage = { path = "../storage" }
 table = { path = "../table" }
-tokio = { version = "1.18", features = ["full"] }
+tokio.workspace = true
 
 [dev-dependencies]
 chrono = "0.4"
@@ -40,4 +39,4 @@ mito = { path = "../mito", features = ["test"] }
 object-store = { path = "../object-store" }
 storage = { path = "../storage" }
 tempdir = "0.3"
-tokio = { version = "1.0", features = ["full"] }
+tokio.workspace = true

src/catalog/src/helper.rs

@@ -33,48 +33,38 @@ const ALPHANUMERICS_NAME_PATTERN: &str = "[a-zA-Z_][a-zA-Z0-9_]*";
 
 lazy_static! {
     static ref CATALOG_KEY_PATTERN: Regex = Regex::new(&format!(
-        "^{}-({})$",
-        CATALOG_KEY_PREFIX, ALPHANUMERICS_NAME_PATTERN
+        "^{CATALOG_KEY_PREFIX}-({ALPHANUMERICS_NAME_PATTERN})$"
     ))
     .unwrap();
 }
 
 lazy_static! {
     static ref SCHEMA_KEY_PATTERN: Regex = Regex::new(&format!(
-        "^{}-({})-({})$",
-        SCHEMA_KEY_PREFIX, ALPHANUMERICS_NAME_PATTERN, ALPHANUMERICS_NAME_PATTERN
+        "^{SCHEMA_KEY_PREFIX}-({ALPHANUMERICS_NAME_PATTERN})-({ALPHANUMERICS_NAME_PATTERN})$"
     ))
     .unwrap();
 }
 
 lazy_static! {
     static ref TABLE_GLOBAL_KEY_PATTERN: Regex = Regex::new(&format!(
-        "^{}-({})-({})-({})$",
-        TABLE_GLOBAL_KEY_PREFIX,
-        ALPHANUMERICS_NAME_PATTERN,
-        ALPHANUMERICS_NAME_PATTERN,
-        ALPHANUMERICS_NAME_PATTERN
+        "^{TABLE_GLOBAL_KEY_PREFIX}-({ALPHANUMERICS_NAME_PATTERN})-({ALPHANUMERICS_NAME_PATTERN})-({ALPHANUMERICS_NAME_PATTERN})$"
     ))
     .unwrap();
 }
 
 lazy_static! {
     static ref TABLE_REGIONAL_KEY_PATTERN: Regex = Regex::new(&format!(
-        "^{}-({})-({})-({})-([0-9]+)$",
-        TABLE_REGIONAL_KEY_PREFIX,
-        ALPHANUMERICS_NAME_PATTERN,
-        ALPHANUMERICS_NAME_PATTERN,
-        ALPHANUMERICS_NAME_PATTERN
+        "^{TABLE_REGIONAL_KEY_PREFIX}-({ALPHANUMERICS_NAME_PATTERN})-({ALPHANUMERICS_NAME_PATTERN})-({ALPHANUMERICS_NAME_PATTERN})-([0-9]+)$"
     ))
     .unwrap();
 }
 
 pub fn build_catalog_prefix() -> String {
-    format!("{}-", CATALOG_KEY_PREFIX)
+    format!("{CATALOG_KEY_PREFIX}-")
 }
 
 pub fn build_schema_prefix(catalog_name: impl AsRef<str>) -> String {
-    format!("{}-{}-", SCHEMA_KEY_PREFIX, catalog_name.as_ref())
+    format!("{SCHEMA_KEY_PREFIX}-{}-", catalog_name.as_ref())
 }
 
 pub fn build_table_global_prefix(
@@ -82,8 +72,7 @@ pub fn build_table_global_prefix(
     schema_name: impl AsRef<str>,
 ) -> String {
     format!(
-        "{}-{}-{}-",
-        TABLE_GLOBAL_KEY_PREFIX,
+        "{TABLE_GLOBAL_KEY_PREFIX}-{}-{}-",
         catalog_name.as_ref(),
         schema_name.as_ref()
     )
@@ -378,7 +367,7 @@ mod tests {
             table_info,
         };
         let serialized = serde_json::to_string(&value).unwrap();
-        let deserialized = TableGlobalValue::parse(&serialized).unwrap();
+        let deserialized = TableGlobalValue::parse(serialized).unwrap();
         assert_eq!(value, deserialized);
     }
 }

src/catalog/src/lib.rs

@@ -157,7 +157,7 @@ pub struct RegisterSchemaRequest {
 
 /// Formats table fully-qualified name
 pub fn format_full_table_name(catalog: &str, schema: &str, table: &str) -> String {
-    format!("{}.{}.{}", catalog, schema, table)
+    format!("{catalog}.{schema}.{table}")
 }
 
 pub trait CatalogProviderFactory {
@@ -187,8 +187,7 @@ pub(crate) async fn handle_system_table_request<'a, M: CatalogManager>(
                 .await
                 .with_context(|_| CreateTableSnafu {
                     table_info: format!(
-                        "{}.{}.{}, id: {}",
-                        catalog_name, schema_name, table_name, table_id,
+                        "{catalog_name}.{schema_name}.{table_name}, id: {table_id}",
                     ),
                 })?;
             manager
@@ -200,7 +199,7 @@ pub(crate) async fn handle_system_table_request<'a, M: CatalogManager>(
                     table: table.clone(),
                 })
                 .await?;
-            info!("Created and registered system table: {}", table_name);
+            info!("Created and registered system table: {table_name}");
             table
         };
         if let Some(hook) = req.open_hook {

src/catalog/src/local/manager.rs

@@ -338,7 +338,7 @@ impl CatalogManager for LocalCatalogManager {
         let schema = catalog
             .schema(schema_name)?
             .with_context(|| SchemaNotFoundSnafu {
-                schema_info: format!("{}.{}", catalog_name, schema_name),
+                schema_info: format!("{catalog_name}.{schema_name}"),
             })?;
 
         {
@@ -452,7 +452,7 @@ impl CatalogManager for LocalCatalogManager {
         let schema = catalog
             .schema(schema_name)?
             .with_context(|| SchemaNotFoundSnafu {
-                schema_info: format!("{}.{}", catalog_name, schema_name),
+                schema_info: format!("{catalog_name}.{schema_name}"),
             })?;
         schema.table(table_name)
     }

src/catalog/src/remote/manager.rs

@@ -331,10 +331,7 @@ impl RemoteCatalogManager {
             .open_table(&context, request)
             .await
             .with_context(|_| OpenTableSnafu {
-                table_info: format!(
-                    "{}.{}.{}, id:{}",
-                    catalog_name, schema_name, table_name, table_id
-                ),
+                table_info: format!("{catalog_name}.{schema_name}.{table_name}, id:{table_id}"),
             })? {
             Some(table) => {
                 info!(
@@ -355,7 +352,7 @@ impl RemoteCatalogManager {
                     .clone()
                     .try_into()
                     .context(InvalidTableSchemaSnafu {
-                        table_info: format!("{}.{}.{}", catalog_name, schema_name, table_name,),
+                        table_info: format!("{catalog_name}.{schema_name}.{table_name}"),
                         schema: meta.schema.clone(),
                     })?;
                 let req = CreateTableRequest {
@@ -477,7 +474,7 @@ impl CatalogManager for RemoteCatalogManager {
         let schema = catalog
             .schema(schema_name)?
             .with_context(|| SchemaNotFoundSnafu {
-                schema_info: format!("{}.{}", catalog_name, schema_name),
+                schema_info: format!("{catalog_name}.{schema_name}"),
             })?;
         schema.table(table_name)
     }

src/catalog/src/system.rs

@@ -61,7 +61,7 @@ impl Table for SystemCatalogTable {
 
     async fn scan(
         &self,
-        _projection: &Option<Vec<usize>>,
+        _projection: Option<&Vec<usize>>,
         _filters: &[Expr],
         _limit: Option<usize>,
     ) -> table::Result<PhysicalPlanRef> {
@@ -129,7 +129,7 @@ impl SystemCatalogTable {
         let ctx = SessionContext::new();
         let scan = self
             .table
-            .scan(&full_projection, &[], None)
+            .scan(full_projection, &[], None)
             .await
             .context(error::SystemCatalogTableScanSnafu)?;
         let stream = scan
@@ -197,7 +197,7 @@ pub fn build_table_insert_request(full_table_name: String, table_id: TableId) ->
 }
 
 pub fn build_schema_insert_request(catalog_name: String, schema_name: String) -> InsertRequest {
-    let full_schema_name = format!("{}.{}", catalog_name, schema_name);
+    let full_schema_name = format!("{catalog_name}.{schema_name}");
     build_insert_request(
         EntryType::Schema,
         full_schema_name.as_bytes(),
@@ -390,7 +390,7 @@ mod tests {
         if let Entry::Catalog(e) = entry {
             assert_eq!("some_catalog", e.catalog_name);
         } else {
-            panic!("Unexpected type: {:?}", entry);
+            panic!("Unexpected type: {entry:?}");
         }
     }
 
@@ -407,7 +407,7 @@ mod tests {
             assert_eq!("some_catalog", e.catalog_name);
             assert_eq!("some_schema", e.schema_name);
         } else {
-            panic!("Unexpected type: {:?}", entry);
+            panic!("Unexpected type: {entry:?}");
         }
     }
 
@@ -426,7 +426,7 @@ mod tests {
             assert_eq!("some_table", e.table_name);
             assert_eq!(42, e.table_id);
         } else {
-            panic!("Unexpected type: {:?}", entry);
+            panic!("Unexpected type: {entry:?}");
         }
     }
 

src/catalog/src/tables.rs

@@ -77,7 +77,7 @@ impl Table for Tables {
 
     async fn scan(
         &self,
-        _projection: &Option<Vec<usize>>,
+        _projection: Option<&Vec<usize>>,
         _filters: &[Expr],
         _limit: Option<usize>,
     ) -> table::error::Result<PhysicalPlanRef> {
@@ -370,7 +370,7 @@ mod tests {
             .unwrap();
 
         let tables = Tables::new(catalog_list, "test_engine".to_string());
-        let tables_stream = tables.scan(&None, &[], None).await.unwrap();
+        let tables_stream = tables.scan(None, &[], None).await.unwrap();
         let session_ctx = SessionContext::new();
         let mut tables_stream = tables_stream.execute(0, session_ctx.task_ctx()).unwrap();
 

src/catalog/tests/local_catalog_tests.rs

@@ -69,8 +69,7 @@ mod tests {
         assert!(
             err.to_string()
                 .contains("Table `greptime.public.test_table` already exists"),
-            "Actual error message: {}",
-            err
+            "Actual error message: {err}",
         );
     }
 

src/catalog/tests/mock.rs

@@ -189,10 +189,10 @@ impl TableEngine for MockTableEngine {
         unimplemented!()
     }
 
-    fn get_table<'a>(
+    fn get_table(
         &self,
         _ctx: &EngineContext,
-        table_ref: &'a TableReference,
+        table_ref: &TableReference,
     ) -> table::Result<Option<TableRef>> {
         futures::executor::block_on(async {
             Ok(self
@@ -204,7 +204,7 @@ impl TableEngine for MockTableEngine {
         })
     }
 
-    fn table_exists<'a>(&self, _ctx: &EngineContext, table_ref: &'a TableReference) -> bool {
+    fn table_exists(&self, _ctx: &EngineContext, table_ref: &TableReference) -> bool {
         futures::executor::block_on(async {
             self.tables
                 .read()

src/client/Cargo.toml

@@ -1,13 +1,12 @@
 [package]
 name = "client"
-version = "0.1.0"
-edition = "2021"
-license = "Apache-2.0"
-# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
+version.workspace = true
+edition.workspace = true
+license.workspace = true
 
 [dependencies]
 api = { path = "../api" }
-async-stream = "0.3"
+async-stream.workspace = true
 common-base = { path = "../common/base" }
 common-error = { path = "../common/error" }
 common-grpc = { path = "../common/grpc" }
@@ -15,18 +14,18 @@ common-grpc-expr = { path = "../common/grpc-expr" }
 common-query = { path = "../common/query" }
 common-recordbatch = { path = "../common/recordbatch" }
 common-time = { path = "../common/time" }
-datafusion = "14.0.0"
+datafusion.workspace = true
 datatypes = { path = "../datatypes" }
 enum_dispatch = "0.3"
 parking_lot = "0.12"
 rand = "0.8"
-snafu = { version = "0.7", features = ["backtraces"] }
+snafu.workspace = true
 tonic = "0.8"
 
 [dev-dependencies]
 datanode = { path = "../datanode" }
 substrait = { path = "../common/substrait" }
-tokio = { version = "1.0", features = ["full"] }
+tokio.workspace = true
 tracing = "0.1"
 tracing-subscriber = { version = "0.3", features = ["env-filter"] }
 

src/client/examples/insert.rs

@@ -1,106 +0,0 @@
-// Copyright 2022 Greptime Team
-//
-// Licensed under the Apache License, Version 2.0 (the "License");
-// you may not use this file except in compliance with the License.
-// You may obtain a copy of the License at
-//
-// http://www.apache.org/licenses/LICENSE-2.0
-//
-// Unless required by applicable law or agreed to in writing, software
-// distributed under the License is distributed on an "AS IS" BASIS,
-// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-// See the License for the specific language governing permissions and
-// limitations under the License.
-
-use api::v1::*;
-use client::{Client, Database};
-
-fn main() {
-    tracing::subscriber::set_global_default(tracing_subscriber::FmtSubscriber::builder().finish())
-        .unwrap();
-
-    run();
-}
-
-#[tokio::main]
-async fn run() {
-    let client = Client::with_urls(vec!["127.0.0.1:3001"]);
-    let db = Database::new("greptime", client);
-
-    let (columns, row_count) = insert_data();
-
-    let expr = InsertExpr {
-        schema_name: "public".to_string(),
-        table_name: "demo".to_string(),
-        region_number: 0,
-        columns,
-        row_count,
-    };
-    db.insert(expr).await.unwrap();
-}
-
-fn insert_data() -> (Vec<Column>, u32) {
-    const SEMANTIC_TAG: i32 = 0;
-    const SEMANTIC_FIELD: i32 = 1;
-    const SEMANTIC_TS: i32 = 2;
-
-    let row_count = 4;
-
-    let host_vals = column::Values {
-        string_values: vec![
-            "host1".to_string(),
-            "host2".to_string(),
-            "host3".to_string(),
-            "host4".to_string(),
-        ],
-        ..Default::default()
-    };
-    let host_column = Column {
-        column_name: "host".to_string(),
-        semantic_type: SEMANTIC_TAG,
-        values: Some(host_vals),
-        null_mask: vec![0],
-        ..Default::default()
-    };
-
-    let cpu_vals = column::Values {
-        f64_values: vec![0.31, 0.41, 0.2],
-        ..Default::default()
-    };
-    let cpu_column = Column {
-        column_name: "cpu".to_string(),
-        semantic_type: SEMANTIC_FIELD,
-        values: Some(cpu_vals),
-        null_mask: vec![2],
-        ..Default::default()
-    };
-
-    let mem_vals = column::Values {
-        f64_values: vec![0.1, 0.2, 0.3],
-        ..Default::default()
-    };
-    let mem_column = Column {
-        column_name: "memory".to_string(),
-        semantic_type: SEMANTIC_FIELD,
-        values: Some(mem_vals),
-        null_mask: vec![4],
-        ..Default::default()
-    };
-
-    let ts_vals = column::Values {
-        i64_values: vec![100, 101, 102, 103],
-        ..Default::default()
-    };
-    let ts_column = Column {
-        column_name: "ts".to_string(),
-        semantic_type: SEMANTIC_TS,
-        values: Some(ts_vals),
-        null_mask: vec![0],
-        ..Default::default()
-    };
-
-    (
-        vec![host_column, cpu_column, mem_column, ts_column],
-        row_count,
-    )
-}

src/client/examples/logical.rs

@@ -13,7 +13,6 @@
 // limitations under the License.
 
 use api::v1::{ColumnDataType, ColumnDef, CreateTableExpr, TableId};
-use client::admin::Admin;
 use client::{Client, Database};
 use prost_09::Message;
 use substrait_proto::protobuf::plan_rel::RelType as PlanRelType;
@@ -66,8 +65,8 @@ async fn run() {
         region_ids: vec![0],
     };
 
-    let admin = Admin::new("create table", client.clone());
-    let result = admin.create(create_table_expr).await.unwrap();
+    let db = Database::new("create table", client.clone());
+    let result = db.create(create_table_expr).await.unwrap();
     event!(Level::INFO, "create table result: {:#?}", result);
 
     let logical = mock_logical_plan();

src/client/src/admin.rs

@@ -1,137 +0,0 @@
-// Copyright 2022 Greptime Team
-//
-// Licensed under the Apache License, Version 2.0 (the "License");
-// you may not use this file except in compliance with the License.
-// You may obtain a copy of the License at
-//
-// http://www.apache.org/licenses/LICENSE-2.0
-//
-// Unless required by applicable law or agreed to in writing, software
-// distributed under the License is distributed on an "AS IS" BASIS,
-// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-// See the License for the specific language governing permissions and
-// limitations under the License.
-
-use api::v1::*;
-use common_error::prelude::StatusCode;
-use common_query::Output;
-use snafu::prelude::*;
-
-use crate::database::PROTOCOL_VERSION;
-use crate::{error, Client, Result};
-
-#[derive(Clone, Debug)]
-pub struct Admin {
-    name: String,
-    client: Client,
-}
-
-impl Admin {
-    pub fn new(name: impl Into<String>, client: Client) -> Self {
-        Self {
-            name: name.into(),
-            client,
-        }
-    }
-
-    pub async fn create(&self, expr: CreateTableExpr) -> Result<AdminResult> {
-        let header = ExprHeader {
-            version: PROTOCOL_VERSION,
-        };
-        let expr = AdminExpr {
-            header: Some(header),
-            expr: Some(admin_expr::Expr::CreateTable(expr)),
-        };
-        self.do_request(expr).await
-    }
-
-    pub async fn do_request(&self, expr: AdminExpr) -> Result<AdminResult> {
-        // `remove(0)` is safe because of `do_requests`'s invariants.
-        Ok(self.do_requests(vec![expr]).await?.remove(0))
-    }
-
-    pub async fn alter(&self, expr: AlterExpr) -> Result<AdminResult> {
-        let header = ExprHeader {
-            version: PROTOCOL_VERSION,
-        };
-        let expr = AdminExpr {
-            header: Some(header),
-            expr: Some(admin_expr::Expr::Alter(expr)),
-        };
-        self.do_request(expr).await
-    }
-
-    pub async fn drop_table(&self, expr: DropTableExpr) -> Result<AdminResult> {
-        let header = ExprHeader {
-            version: PROTOCOL_VERSION,
-        };
-        let expr = AdminExpr {
-            header: Some(header),
-            expr: Some(admin_expr::Expr::DropTable(expr)),
-        };
-
-        self.do_request(expr).await
-    }
-
-    /// Invariants: the lengths of input vec (`Vec<AdminExpr>`) and output vec (`Vec<AdminResult>`) are equal.
-    async fn do_requests(&self, exprs: Vec<AdminExpr>) -> Result<Vec<AdminResult>> {
-        let expr_count = exprs.len();
-        let req = AdminRequest {
-            name: self.name.clone(),
-            exprs,
-        };
-
-        let resp = self.client.admin(req).await?;
-
-        let results = resp.results;
-        ensure!(
-            results.len() == expr_count,
-            error::MissingResultSnafu {
-                name: "admin_results",
-                expected: expr_count,
-                actual: results.len(),
-            }
-        );
-        Ok(results)
-    }
-
-    pub async fn create_database(&self, expr: CreateDatabaseExpr) -> Result<AdminResult> {
-        let header = ExprHeader {
-            version: PROTOCOL_VERSION,
-        };
-        let expr = AdminExpr {
-            header: Some(header),
-            expr: Some(admin_expr::Expr::CreateDatabase(expr)),
-        };
-        Ok(self.do_requests(vec![expr]).await?.remove(0))
-    }
-}
-
-pub fn admin_result_to_output(admin_result: AdminResult) -> Result<Output> {
-    let header = admin_result.header.context(error::MissingHeaderSnafu)?;
-    if !StatusCode::is_success(header.code) {
-        return error::DatanodeSnafu {
-            code: header.code,
-            msg: header.err_msg,
-        }
-        .fail();
-    }
-
-    let result = admin_result.result.context(error::MissingResultSnafu {
-        name: "result".to_string(),
-        expected: 1_usize,
-        actual: 0_usize,
-    })?;
-    let output = match result {
-        admin_result::Result::Mutate(mutate) => {
-            if mutate.failure != 0 {
-                return error::MutateFailureSnafu {
-                    failure: mutate.failure,
-                }
-                .fail();
-            }
-            Output::AffectedRows(mutate.success as usize)
-        }
-    };
-    Ok(output)
-}

src/client/src/client.rs

@@ -104,20 +104,6 @@ impl Client {
         self.inner.set_peers(urls);
     }
 
-    pub async fn admin(&self, req: AdminRequest) -> Result<AdminResponse> {
-        let req = BatchRequest {
-            admins: vec![req],
-            ..Default::default()
-        };
-
-        let mut res = self.batch(req).await?;
-        res.admins.pop().context(error::MissingResultSnafu {
-            name: "admins",
-            expected: 1_usize,
-            actual: 0_usize,
-        })
-    }
-
     pub async fn database(&self, req: DatabaseRequest) -> Result<DatabaseResponse> {
         let req = BatchRequest {
             databases: vec![req],

src/client/src/database.rs

@@ -12,27 +12,22 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-use std::sync::Arc;
-
-use api::v1::codec::SelectResult as GrpcSelectResult;
-use api::v1::column::SemanticType;
+use api::v1::ddl_request::Expr as DdlExpr;
 use api::v1::{
-    object_expr, object_result, select_expr, DatabaseRequest, ExprHeader, InsertExpr,
-    MutateResult as GrpcMutateResult, ObjectExpr, ObjectResult as GrpcObjectResult, SelectExpr,
+    object_expr, query_request, AlterExpr, CreateTableExpr, DatabaseRequest, DdlRequest,
+    DropTableExpr, InsertRequest, ObjectExpr, ObjectResult as GrpcObjectResult, QueryRequest,
 };
 use common_error::status_code::StatusCode;
-use common_grpc_expr::column_to_vector;
+use common_grpc::flight::{
+    flight_messages_to_recordbatches, raw_flight_data_to_message, FlightMessage,
+};
 use common_query::Output;
-use common_recordbatch::{RecordBatch, RecordBatches};
-use datatypes::prelude::*;
-use datatypes::schema::{ColumnSchema, Schema};
+use common_recordbatch::RecordBatches;
 use snafu::{ensure, OptionExt, ResultExt};
 
-use crate::error::{ColumnToVectorSnafu, ConvertSchemaSnafu, DatanodeSnafu, DecodeSelectSnafu};
+use crate::error::{ConvertFlightDataSnafu, DatanodeSnafu, IllegalFlightMessagesSnafu};
 use crate::{error, Client, Result};
 
-pub const PROTOCOL_VERSION: u32 = 1;
-
 #[derive(Clone, Debug)]
 pub struct Database {
     name: String,
@@ -51,65 +46,63 @@ impl Database {
         &self.name
     }
 
-    pub async fn insert(&self, insert: InsertExpr) -> Result<ObjectResult> {
-        let header = ExprHeader {
-            version: PROTOCOL_VERSION,
-        };
+    pub async fn insert(&self, request: InsertRequest) -> Result<RpcOutput> {
         let expr = ObjectExpr {
-            header: Some(header),
-            expr: Some(object_expr::Expr::Insert(insert)),
+            request: Some(object_expr::Request::Insert(request)),
         };
         self.object(expr).await?.try_into()
     }
 
-    pub async fn batch_insert(&self, insert_exprs: Vec<InsertExpr>) -> Result<Vec<ObjectResult>> {
-        let header = ExprHeader {
-            version: PROTOCOL_VERSION,
+    pub async fn sql(&self, sql: &str) -> Result<RpcOutput> {
+        let query = QueryRequest {
+            query: Some(query_request::Query::Sql(sql.to_string())),
         };
-        let obj_exprs = insert_exprs
-            .into_iter()
-            .map(|expr| ObjectExpr {
-                header: Some(header.clone()),
-                expr: Some(object_expr::Expr::Insert(expr)),
-            })
-            .collect();
-        self.objects(obj_exprs)
-            .await?
-            .into_iter()
-            .map(|result| result.try_into())
-            .collect()
+        self.do_query(query).await
     }
 
-    pub async fn select(&self, expr: Select) -> Result<ObjectResult> {
-        let select_expr = match expr {
-            Select::Sql(sql) => SelectExpr {
-                expr: Some(select_expr::Expr::Sql(sql)),
-            },
+    pub async fn logical_plan(&self, logical_plan: Vec<u8>) -> Result<RpcOutput> {
+        let query = QueryRequest {
+            query: Some(query_request::Query::LogicalPlan(logical_plan)),
         };
-        self.do_select(select_expr).await
+        self.do_query(query).await
     }
 
-    pub async fn logical_plan(&self, logical_plan: Vec<u8>) -> Result<ObjectResult> {
-        let select_expr = SelectExpr {
-            expr: Some(select_expr::Expr::LogicalPlan(logical_plan)),
-        };
-        self.do_select(select_expr).await
-    }
-
-    async fn do_select(&self, select_expr: SelectExpr) -> Result<ObjectResult> {
-        let header = ExprHeader {
-            version: PROTOCOL_VERSION,
-        };
-
+    async fn do_query(&self, request: QueryRequest) -> Result<RpcOutput> {
         let expr = ObjectExpr {
-            header: Some(header),
-            expr: Some(object_expr::Expr::Select(select_expr)),
+            request: Some(object_expr::Request::Query(request)),
         };
 
         let obj_result = self.object(expr).await?;
         obj_result.try_into()
     }
 
+    pub async fn create(&self, expr: CreateTableExpr) -> Result<RpcOutput> {
+        let expr = ObjectExpr {
+            request: Some(object_expr::Request::Ddl(DdlRequest {
+                expr: Some(DdlExpr::CreateTable(expr)),
+            })),
+        };
+        self.object(expr).await?.try_into()
+    }
+
+    pub async fn alter(&self, expr: AlterExpr) -> Result<RpcOutput> {
+        let expr = ObjectExpr {
+            request: Some(object_expr::Request::Ddl(DdlRequest {
+                expr: Some(DdlExpr::Alter(expr)),
+            })),
+        };
+        self.object(expr).await?.try_into()
+    }
+
+    pub async fn drop_table(&self, expr: DropTableExpr) -> Result<RpcOutput> {
+        let expr = ObjectExpr {
+            request: Some(object_expr::Request::Ddl(DdlRequest {
+                expr: Some(DdlExpr::DropTable(expr)),
+            })),
+        };
+        self.object(expr).await?.try_into()
+    }
+
     pub async fn object(&self, expr: ObjectExpr) -> Result<GrpcObjectResult> {
         let res = self.objects(vec![expr]).await?.pop().unwrap();
         Ok(res)
@@ -139,12 +132,12 @@ impl Database {
 }
 
 #[derive(Debug)]
-pub enum ObjectResult {
-    Select(GrpcSelectResult),
-    Mutate(GrpcMutateResult),
+pub enum RpcOutput {
+    RecordBatches(RecordBatches),
+    AffectedRows(usize),
 }
 
-impl TryFrom<api::v1::ObjectResult> for ObjectResult {
+impl TryFrom<api::v1::ObjectResult> for RpcOutput {
     type Error = error::Error;
 
     fn try_from(object_result: api::v1::ObjectResult) -> std::result::Result<Self, Self::Error> {
@@ -157,92 +150,50 @@ impl TryFrom<api::v1::ObjectResult> for ObjectResult {
             .fail();
         }
 
-        let obj_result = object_result.result.context(error::MissingResultSnafu {
-            name: "result".to_string(),
-            expected: 1_usize,
-            actual: 0_usize,
-        })?;
-        Ok(match obj_result {
-            object_result::Result::Select(select) => {
-                let result = (*select.raw_data).try_into().context(DecodeSelectSnafu)?;
-                ObjectResult::Select(result)
-            }
-            object_result::Result::Mutate(mutate) => ObjectResult::Mutate(mutate),
-        })
-    }
-}
+        let flight_messages = raw_flight_data_to_message(object_result.flight_data)
+            .context(ConvertFlightDataSnafu)?;
 
-pub enum Select {
-    Sql(String),
-}
-
-impl TryFrom<ObjectResult> for Output {
-    type Error = error::Error;
-
-    fn try_from(value: ObjectResult) -> Result<Self> {
-        let output = match value {
-            ObjectResult::Select(select) => {
-                let vectors = select
-                    .columns
-                    .iter()
-                    .map(|column| {
-                        column_to_vector(column, select.row_count).context(ColumnToVectorSnafu)
-                    })
-                    .collect::<Result<Vec<VectorRef>>>()?;
-
-                let column_schemas = select
-                    .columns
-                    .iter()
-                    .zip(vectors.iter())
-                    .map(|(column, vector)| {
-                        let datatype = vector.data_type();
-                        // nullable or not, does not affect the output
-                        let mut column_schema =
-                            ColumnSchema::new(&column.column_name, datatype, true);
-                        if column.semantic_type == SemanticType::Timestamp as i32 {
-                            column_schema = column_schema.with_time_index(true);
-                        }
-                        column_schema
-                    })
-                    .collect::<Vec<ColumnSchema>>();
-
-                let schema = Arc::new(Schema::try_new(column_schemas).context(ConvertSchemaSnafu)?);
-                let recordbatches = if vectors.is_empty() {
-                    RecordBatches::try_new(schema, vec![])
-                } else {
-                    RecordBatch::new(schema, vectors)
-                        .and_then(|batch| RecordBatches::try_new(batch.schema.clone(), vec![batch]))
+        let output = if let Some(FlightMessage::AffectedRows(rows)) = flight_messages.get(0) {
+            ensure!(
+                flight_messages.len() == 1,
+                IllegalFlightMessagesSnafu {
+                    reason: "Expect 'AffectedRows' Flight messages to be one and only!"
                 }
-                .context(error::CreateRecordBatchesSnafu)?;
-                Output::RecordBatches(recordbatches)
-            }
-            ObjectResult::Mutate(mutate) => {
-                if mutate.failure != 0 {
-                    return error::MutateFailureSnafu {
-                        failure: mutate.failure,
-                    }
-                    .fail();
-                }
-                Output::AffectedRows(mutate.success as usize)
-            }
+            );
+            RpcOutput::AffectedRows(*rows)
+        } else {
+            let recordbatches = flight_messages_to_recordbatches(flight_messages)
+                .context(ConvertFlightDataSnafu)?;
+            RpcOutput::RecordBatches(recordbatches)
         };
         Ok(output)
     }
 }
 
+impl From<RpcOutput> for Output {
+    fn from(value: RpcOutput) -> Self {
+        match value {
+            RpcOutput::AffectedRows(x) => Output::AffectedRows(x),
+            RpcOutput::RecordBatches(x) => Output::RecordBatches(x),
+        }
+    }
+}
+
 #[cfg(test)]
 mod tests {
+    use std::sync::Arc;
+
     use api::helper::ColumnDataTypeWrapper;
     use api::v1::Column;
     use common_grpc::select::{null_mask, values};
+    use common_grpc_expr::column_to_vector;
+    use datatypes::prelude::{Vector, VectorRef};
     use datatypes::vectors::{
         BinaryVector, BooleanVector, DateTimeVector, DateVector, Float32Vector, Float64Vector,
         Int16Vector, Int32Vector, Int64Vector, Int8Vector, StringVector, UInt16Vector,
         UInt32Vector, UInt64Vector, UInt8Vector,
     };
 
-    use super::*;
-
     #[test]
     fn test_column_to_vector() {
         let mut column = create_test_column(Arc::new(BooleanVector::from(vec![true])));

src/client/src/error.rs

@@ -13,19 +13,15 @@
 // limitations under the License.
 
 use std::any::Any;
-use std::sync::Arc;
 
-use api::serde::DecodeError;
 use common_error::prelude::*;
-use datafusion::physical_plan::ExecutionPlan;
 
 #[derive(Debug, Snafu)]
 #[snafu(visibility(pub))]
 pub enum Error {
-    #[snafu(display("Connect failed to {}, source: {}", url, source))]
-    ConnectFailed {
-        url: String,
-        source: tonic::transport::Error,
+    #[snafu(display("Illegal Flight messages, reason: {}", reason))]
+    IllegalFlightMessages {
+        reason: String,
         backtrace: Backtrace,
     },
 
@@ -46,34 +42,21 @@ pub enum Error {
         backtrace: Backtrace,
     },
 
-    #[snafu(display("Fail to decode select result, source: {}", source))]
-    DecodeSelect { source: DecodeError },
-
     #[snafu(display("Error occurred on the data node, code: {}, msg: {}", code, msg))]
     Datanode { code: u32, msg: String },
 
-    #[snafu(display("Failed to encode physical plan: {:?}, source: {}", physical, source))]
-    EncodePhysical {
-        physical: Arc<dyn ExecutionPlan>,
+    #[snafu(display("Failed to convert FlightData, source: {}", source))]
+    ConvertFlightData {
         #[snafu(backtrace)]
         source: common_grpc::Error,
     },
 
-    #[snafu(display("Mutate result has failure {}", failure))]
-    MutateFailure { failure: u32, backtrace: Backtrace },
-
     #[snafu(display("Column datatype error, source: {}", source))]
     ColumnDataType {
         #[snafu(backtrace)]
         source: api::error::Error,
     },
 
-    #[snafu(display("Failed to create RecordBatches, source: {}", source))]
-    CreateRecordBatches {
-        #[snafu(backtrace)]
-        source: common_recordbatch::error::Error,
-    },
-
     #[snafu(display("Illegal GRPC client state: {}", err_msg))]
     IllegalGrpcClientState {
         err_msg: String,
@@ -83,12 +66,6 @@ pub enum Error {
     #[snafu(display("Missing required field in protobuf, field: {}", field))]
     MissingField { field: String, backtrace: Backtrace },
 
-    #[snafu(display("Failed to convert schema, source: {}", source))]
-    ConvertSchema {
-        #[snafu(backtrace)]
-        source: datatypes::error::Error,
-    },
-
     #[snafu(display(
         "Failed to create gRPC channel, peer address: {}, source: {}",
         addr,
@@ -99,12 +76,6 @@ pub enum Error {
         #[snafu(backtrace)]
         source: common_grpc::error::Error,
     },
-
-    #[snafu(display("Failed to convert column to vector, source: {}", source))]
-    ColumnToVector {
-        #[snafu(backtrace)]
-        source: common_grpc_expr::error::Error,
-    },
 }
 
 pub type Result<T> = std::result::Result<T, Error>;
@@ -112,21 +83,17 @@ pub type Result<T> = std::result::Result<T, Error>;
 impl ErrorExt for Error {
     fn status_code(&self) -> StatusCode {
         match self {
-            Error::ConnectFailed { .. }
+            Error::IllegalFlightMessages { .. }
             | Error::MissingResult { .. }
             | Error::MissingHeader { .. }
             | Error::TonicStatus { .. }
-            | Error::DecodeSelect { .. }
             | Error::Datanode { .. }
-            | Error::EncodePhysical { .. }
-            | Error::MutateFailure { .. }
             | Error::ColumnDataType { .. }
             | Error::MissingField { .. } => StatusCode::Internal,
-            Error::ConvertSchema { source } => source.status_code(),
-            Error::CreateRecordBatches { source } => source.status_code(),
-            Error::CreateChannel { source, .. } => source.status_code(),
+            Error::CreateChannel { source, .. } | Error::ConvertFlightData { source } => {
+                source.status_code()
+            }
             Error::IllegalGrpcClientState { .. } => StatusCode::Unexpected,
-            Error::ColumnToVector { source, .. } => source.status_code(),
         }
     }
 

src/client/src/lib.rs

@@ -12,7 +12,6 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-pub mod admin;
 mod client;
 mod database;
 mod error;
@@ -21,5 +20,5 @@ pub mod load_balance;
 pub use api;
 
 pub use self::client::Client;
-pub use self::database::{Database, ObjectResult, Select};
+pub use self::database::{Database, RpcOutput};
 pub use self::error::{Error, Result};

src/cmd/Cargo.toml

@@ -1,9 +1,9 @@
 [package]
 name = "cmd"
-version = "0.1.0"
-edition = "2021"
+version.workspace = true
+edition.workspace = true
+license.workspace = true
 default-run = "greptime"
-license = "Apache-2.0"
 
 [[bin]]
 name = "greptime"
@@ -18,17 +18,17 @@ common-telemetry = { path = "../common/telemetry", features = [
 ] }
 datanode = { path = "../datanode" }
 frontend = { path = "../frontend" }
-futures = "0.3"
+futures.workspace = true
 meta-client = { path = "../meta-client" }
 meta-srv = { path = "../meta-srv" }
-serde = "1.0"
+serde.workspace = true
 servers = { path = "../servers" }
-snafu = { version = "0.7", features = ["backtraces"] }
+snafu.workspace = true
 tokio = { version = "1.18", features = ["full"] }
 toml = "0.5"
 
 [dev-dependencies]
-serde = "1.0"
+serde.workspace = true
 tempdir = "0.3"
 
 [build-dependencies]

src/cmd/src/frontend.rs

@@ -12,7 +12,8 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-use anymap::AnyMap;
+use std::sync::Arc;
+
 use clap::Parser;
 use frontend::frontend::{Frontend, FrontendOptions};
 use frontend::grpc::GrpcOptions;
@@ -21,6 +22,7 @@ use frontend::instance::Instance;
 use frontend::mysql::MysqlOptions;
 use frontend::opentsdb::OpentsdbOptions;
 use frontend::postgres::PostgresOptions;
+use frontend::Plugins;
 use meta_client::MetaClientOpts;
 use servers::auth::UserProviderRef;
 use servers::http::HttpOptions;
@@ -86,21 +88,21 @@ pub struct StartCommand {
 
 impl StartCommand {
     async fn run(self) -> Result<()> {
-        let plugins = load_frontend_plugins(&self.user_provider)?;
+        let plugins = Arc::new(load_frontend_plugins(&self.user_provider)?);
         let opts: FrontendOptions = self.try_into()?;
-        let mut frontend = Frontend::new(
-            opts.clone(),
-            Instance::try_new_distributed(&opts)
-                .await
-                .context(error::StartFrontendSnafu)?,
-            plugins,
-        );
+
+        let mut instance = Instance::try_new_distributed(&opts)
+            .await
+            .context(error::StartFrontendSnafu)?;
+        instance.set_plugins(plugins.clone());
+
+        let mut frontend = Frontend::new(opts, instance, plugins);
         frontend.start().await.context(error::StartFrontendSnafu)
     }
 }
 
-pub fn load_frontend_plugins(user_provider: &Option<String>) -> Result<AnyMap> {
-    let mut plugins = AnyMap::new();
+pub fn load_frontend_plugins(user_provider: &Option<String>) -> Result<Plugins> {
+    let mut plugins = Plugins::new();
 
     if let Some(provider) = user_provider {
         let provider = auth::user_provider_from_option(provider).context(IllegalAuthConfigSnafu)?;

src/cmd/src/standalone.rs

@@ -12,7 +12,8 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-use anymap::AnyMap;
+use std::sync::Arc;
+
 use clap::Parser;
 use common_telemetry::info;
 use datanode::datanode::{Datanode, DatanodeOptions, ObjectStoreConfig};
@@ -25,6 +26,7 @@ use frontend::mysql::MysqlOptions;
 use frontend::opentsdb::OpentsdbOptions;
 use frontend::postgres::PostgresOptions;
 use frontend::prometheus::PrometheusOptions;
+use frontend::Plugins;
 use serde::{Deserialize, Serialize};
 use servers::http::HttpOptions;
 use servers::tls::{TlsMode, TlsOption};
@@ -150,7 +152,7 @@ impl StartCommand {
     async fn run(self) -> Result<()> {
         let enable_memory_catalog = self.enable_memory_catalog;
         let config_file = self.config_file.clone();
-        let plugins = load_frontend_plugins(&self.user_provider)?;
+        let plugins = Arc::new(load_frontend_plugins(&self.user_provider)?);
         let fe_opts = FrontendOptions::try_from(self)?;
         let dn_opts: DatanodeOptions = {
             let mut opts: StandaloneOptions = if let Some(path) = config_file {
@@ -187,11 +189,12 @@ impl StartCommand {
 /// Build frontend instance in standalone mode
 async fn build_frontend(
     fe_opts: FrontendOptions,
-    plugins: AnyMap,
+    plugins: Arc<Plugins>,
     datanode_instance: InstanceRef,
 ) -> Result<Frontend<FeInstance>> {
     let mut frontend_instance = FeInstance::new_standalone(datanode_instance.clone());
     frontend_instance.set_script_handler(datanode_instance);
+    frontend_instance.set_plugins(plugins.clone());
     Ok(Frontend::new(fe_opts, frontend_instance, plugins))
 }
 
@@ -221,8 +224,7 @@ impl TryFrom<StartCommand> for FrontendOptions {
             if addr == datanode_grpc_addr {
                 return IllegalConfigSnafu {
                     msg: format!(
-                        "gRPC listen address conflicts with datanode reserved gRPC addr: {}",
-                        datanode_grpc_addr
+                        "gRPC listen address conflicts with datanode reserved gRPC addr: {datanode_grpc_addr}",
                     ),
                 }
                 .fail();

src/common/base/Cargo.toml

@@ -1,8 +1,8 @@
 [package]
 name = "common-base"
-version = "0.1.0"
-edition = "2021"
-license = "Apache-2.0"
+version.workspace = true
+edition.workspace = true
+license.workspace = true
 
 [dependencies]
 bitvec = "1.0"
@@ -10,4 +10,4 @@ bytes = { version = "1.1", features = ["serde"] }
 common-error = { path = "../error" }
 paste = "1.0"
 serde = { version = "1.0", features = ["derive"] }
-snafu = { version = "0.7", features = ["backtraces"] }
+snafu.workspace = true

src/common/catalog/Cargo.toml

@@ -1,8 +1,8 @@
 [package]
 name = "common-catalog"
-version = "0.1.0"
-edition = "2021"
-license = "Apache-2.0"
+version.workspace = true
+edition.workspace = true
+license.workspace = true
 
 [dependencies]
 async-trait = "0.1"
@@ -11,7 +11,7 @@ common-telemetry = { path = "../telemetry" }
 datatypes = { path = "../../datatypes" }
 lazy_static = "1.4"
 regex = "1.6"
-serde = "1.0"
+serde.workspace = true
 serde_json = "1.0"
 snafu = { version = "0.7", features = ["backtraces"] }
 

src/common/error/Cargo.toml

@@ -1,8 +1,8 @@
 [package]
 name = "common-error"
-version = "0.1.0"
-edition = "2021"
-license = "Apache-2.0"
+version.workspace = true
+edition.workspace = true
+license.workspace = true
 
 [dependencies]
 snafu = { version = "0.7", features = ["backtraces"] }

src/common/error/src/ext.rs

@@ -131,7 +131,7 @@ mod tests {
 
         assert!(ErrorCompat::backtrace(&err).is_some());
 
-        let msg = format!("{:?}", err);
+        let msg = format!("{err:?}");
         assert!(msg.contains("\nBacktrace:\n"));
         let fmt_msg = format!("{:?}", DebugFormat::new(&err));
         assert_eq!(msg, fmt_msg);
@@ -151,7 +151,7 @@ mod tests {
         assert!(err.as_any().downcast_ref::<MockError>().is_some());
         assert!(err.source().is_some());
 
-        let msg = format!("{:?}", err);
+        let msg = format!("{err:?}");
         assert!(msg.contains("\nBacktrace:\n"));
         assert!(msg.contains("Caused by"));
 

src/common/error/src/format.rs

@@ -31,11 +31,11 @@ impl<'a, E: ErrorExt + ?Sized> fmt::Debug for DebugFormat<'a, E> {
         write!(f, "{}.", self.0)?;
         if let Some(source) = self.0.source() {
             // Source error use debug format for more verbose info.
-            write!(f, " Caused by: {:?}", source)?;
+            write!(f, " Caused by: {source:?}")?;
         }
         if let Some(backtrace) = self.0.backtrace_opt() {
             // Add a newline to separate causes and backtrace.
-            write!(f, "\nBacktrace:\n{}", backtrace)?;
+            write!(f, "\nBacktrace:\n{backtrace}")?;
         }
 
         Ok(())

src/common/error/src/status_code.rs

@@ -51,6 +51,7 @@ pub enum StatusCode {
     TableNotFound = 4001,
     TableColumnNotFound = 4002,
     TableColumnExists = 4003,
+    DatabaseNotFound = 4004,
     // ====== End of catalog related status code =======
 
     // ====== Begin of storage related status code =====
@@ -86,7 +87,7 @@ impl StatusCode {
 impl fmt::Display for StatusCode {
     fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
         // The current debug format is suitable to display.
-        write!(f, "{:?}", self)
+        write!(f, "{self:?}")
     }
 }
 
@@ -95,7 +96,7 @@ mod tests {
     use super::*;
 
     fn assert_status_code_display(code: StatusCode, msg: &str) {
-        let code_msg = format!("{}", code);
+        let code_msg = format!("{code}");
         assert_eq!(msg, code_msg);
     }
 

src/common/function-macro/Cargo.toml

@@ -1,8 +1,8 @@
 [package]
 name = "common-function-macro"
-version = "0.1.0"
-edition = "2021"
-license = "Apache-2.0"
+version.workspace = true
+edition.workspace = true
+license.workspace = true
 
 [lib]
 proc-macro = true
@@ -15,5 +15,5 @@ syn = "1.0"
 arc-swap = "1.0"
 common-query = { path = "../query" }
 datatypes = { path = "../../datatypes" }
-snafu = { version = "0.7", features = ["backtraces"] }
+snafu.workspace = true
 static_assertions = "1.1.0"

src/common/function/Cargo.toml

@@ -1,8 +1,8 @@
 [package]
-edition = "2021"
 name = "common-function"
-version = "0.1.0"
-license = "Apache-2.0"
+edition.workspace = true
+version.workspace = true
+license.workspace = true
 
 [dependencies]
 arc-swap = "1.0"
@@ -11,14 +11,14 @@ common-error = { path = "../error" }
 common-function-macro = { path = "../function-macro" }
 common-query = { path = "../query" }
 common-time = { path = "../time" }
-datafusion-common = "14.0.0"
+datafusion.workspace = true
 datatypes = { path = "../../datatypes" }
 libc = "0.2"
 num = "0.4"
 num-traits = "0.2"
 once_cell = "1.10"
 paste = "1.0"
-snafu = { version = "0.7", features = ["backtraces"] }
+snafu.workspace = true
 statrs = "0.15"
 
 [dev-dependencies]

src/common/function/src/scalars/numpy/interp.rs

@@ -343,7 +343,7 @@ mod tests {
             Arc::new(Int64Vector::from_vec(fp.clone())),
         ];
         let vector = interp(&args).unwrap();
-        assert!(matches!(vector.get(0), Value::Float64(v) if v==x[0] as f64));
+        assert!(matches!(vector.get(0), Value::Float64(v) if v == x[0]));
 
         // x=None output:Null
         let input = vec![None, Some(0.0), Some(0.3)];

src/common/function/src/scalars/udf.rs

@@ -127,12 +127,7 @@ mod tests {
 
                 assert_eq!(4, vec.len());
                 for i in 0..4 {
-                    assert_eq!(
-                        i == 0 || i == 3,
-                        vec.get_data(i).unwrap(),
-                        "failed at {}",
-                        i
-                    )
+                    assert_eq!(i == 0 || i == 3, vec.get_data(i).unwrap(), "Failed at {i}",)
                 }
             }
             _ => unreachable!(),

src/common/grpc-expr/Cargo.toml

@@ -1,12 +1,12 @@
 [package]
 name = "common-grpc-expr"
-version = "0.1.0"
-edition = "2021"
-license = "Apache-2.0"
+version.workspace = true
+edition.workspace = true
+license.workspace = true
 
 [dependencies]
 api = { path = "../../api" }
-async-trait = "0.1"
+async-trait.workspace = true
 common-base = { path = "../base" }
 common-catalog = { path = "../catalog" }
 common-error = { path = "../error" }

src/common/grpc-expr/src/alter.rs

@@ -106,7 +106,7 @@ pub fn create_table_schema(expr: &CreateTableExpr) -> Result<SchemaRef> {
             .iter()
             .any(|column| column.name == expr.time_index),
         MissingTimestampColumnSnafu {
-            msg: format!("CreateExpr: {:?}", expr)
+            msg: format!("CreateExpr: {expr:?}")
         }
     );
 

src/common/grpc-expr/src/insert.rs

@@ -12,14 +12,16 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-use std::collections::hash_map::Entry;
 use std::collections::{HashMap, HashSet};
-use std::sync::Arc;
 
 use api::helper::ColumnDataTypeWrapper;
 use api::v1::column::{SemanticType, Values};
-use api::v1::{AddColumn, AddColumns, Column, ColumnDataType, ColumnDef, CreateTableExpr};
+use api::v1::{
+    AddColumn, AddColumns, Column, ColumnDataType, ColumnDef, CreateTableExpr,
+    InsertRequest as GrpcInsertRequest,
+};
 use common_base::BitVec;
+use common_catalog::consts::DEFAULT_CATALOG_NAME;
 use common_time::timestamp::Timestamp;
 use common_time::{Date, DateTime};
 use datatypes::data_type::{ConcreteDataType, DataType};
@@ -30,7 +32,6 @@ use datatypes::vectors::MutableVector;
 use snafu::{ensure, OptionExt, ResultExt};
 use table::metadata::TableId;
 use table::requests::{AddColumnRequest, AlterKind, AlterTableRequest, InsertRequest};
-use table::Table;
 
 use crate::error::{
     ColumnDataTypeSnafu, ColumnNotFoundSnafu, CreateVectorSnafu, DuplicatedTimestampColumnSnafu,
@@ -154,7 +155,7 @@ fn collect_column_values(column_datatype: ColumnDataType, values: &Values) -> Ve
             collect_values!(values.i32_values, |v| ValueRef::from(*v))
         }
         ColumnDataType::Int64 => {
-            collect_values!(values.i64_values, |v| ValueRef::from(*v as i64))
+            collect_values!(values.i64_values, |v| ValueRef::from(*v))
         }
         ColumnDataType::Uint8 => {
             collect_values!(values.u8_values, |v| ValueRef::from(*v as u8))
@@ -166,7 +167,7 @@ fn collect_column_values(column_datatype: ColumnDataType, values: &Values) -> Ve
             collect_values!(values.u32_values, |v| ValueRef::from(*v))
         }
         ColumnDataType::Uint64 => {
-            collect_values!(values.u64_values, |v| ValueRef::from(*v as u64))
+            collect_values!(values.u64_values, |v| ValueRef::from(*v))
         }
         ColumnDataType::Float32 => collect_values!(values.f32_values, |v| ValueRef::from(*v)),
         ColumnDataType::Float64 => collect_values!(values.f64_values, |v| ValueRef::from(*v)),
@@ -280,50 +281,43 @@ pub fn build_create_expr_from_insertion(
     Ok(expr)
 }
 
-pub fn insertion_expr_to_request(
-    catalog_name: &str,
-    schema_name: &str,
-    table_name: &str,
-    insert_batches: Vec<(Vec<Column>, u32)>,
-    table: Arc<dyn Table>,
+pub fn to_table_insert_request(
+    request: GrpcInsertRequest,
+    schema: SchemaRef,
 ) -> Result<InsertRequest> {
-    let schema = table.schema();
-    let mut columns_builders = HashMap::with_capacity(schema.column_schemas().len());
+    let catalog_name = DEFAULT_CATALOG_NAME;
+    let schema_name = &request.schema_name;
+    let table_name = &request.table_name;
+    let row_count = request.row_count as usize;
 
-    for (columns, row_count) in insert_batches {
-        for Column {
-            column_name,
-            values,
-            null_mask,
-            ..
-        } in columns
-        {
-            let values = match values {
-                Some(vals) => vals,
-                None => continue,
-            };
+    let mut columns_values = HashMap::with_capacity(request.columns.len());
+    for Column {
+        column_name,
+        values,
+        null_mask,
+        ..
+    } in request.columns
+    {
+        let Some(values) = values else { continue };
 
-            let column = column_name.clone();
-            let vector_builder = match columns_builders.entry(column) {
-                Entry::Occupied(entry) => entry.into_mut(),
-                Entry::Vacant(entry) => {
-                    let column_schema = schema.column_schema_by_name(&column_name).context(
-                        ColumnNotFoundSnafu {
-                            column_name: &column_name,
-                            table_name,
-                        },
-                    )?;
-                    let data_type = &column_schema.data_type;
-                    entry.insert(data_type.create_mutable_vector(row_count as usize))
-                }
-            };
-            add_values_to_builder(vector_builder, values, row_count as usize, null_mask)?;
-        }
+        let vector_builder = &mut schema
+            .column_schema_by_name(&column_name)
+            .context(ColumnNotFoundSnafu {
+                column_name: &column_name,
+                table_name,
+            })?
+            .data_type
+            .create_mutable_vector(row_count);
+
+        add_values_to_builder(vector_builder, values, row_count, null_mask)?;
+
+        ensure!(
+            columns_values
+                .insert(column_name, vector_builder.to_vector())
+                .is_none(),
+            IllegalInsertDataSnafu
+        );
     }
-    let columns_values = columns_builders
-        .into_iter()
-        .map(|(column_name, mut vector_builder)| (column_name, vector_builder.to_vector()))
-        .collect();
 
     Ok(InsertRequest {
         catalog_name: catalog_name.to_string(),
@@ -479,10 +473,7 @@ mod tests {
     use table::metadata::TableInfoRef;
     use table::Table;
 
-    use super::{
-        build_create_expr_from_insertion, convert_values, insertion_expr_to_request, is_null,
-        TAG_SEMANTIC_TYPE, TIMESTAMP_SEMANTIC_TYPE,
-    };
+    use super::*;
     use crate::error;
     use crate::error::ColumnDataTypeSnafu;
     use crate::insert::find_new_columns;
@@ -628,12 +619,18 @@ mod tests {
     }
 
     #[test]
-    fn test_insertion_expr_to_request() {
+    fn test_to_table_insert_request() {
         let table: Arc<dyn Table> = Arc::new(DemoTable {});
 
-        let insert_batches = vec![mock_insert_batch()];
-        let insert_req =
-            insertion_expr_to_request("greptime", "public", "demo", insert_batches, table).unwrap();
+        let (columns, row_count) = mock_insert_batch();
+        let request = GrpcInsertRequest {
+            schema_name: "public".to_string(),
+            table_name: "demo".to_string(),
+            columns,
+            row_count,
+            region_number: 0,
+        };
+        let insert_req = to_table_insert_request(request, table.schema()).unwrap();
 
         assert_eq!("greptime", insert_req.catalog_name);
         assert_eq!("public", insert_req.schema_name);
@@ -725,7 +722,7 @@ mod tests {
 
         async fn scan(
             &self,
-            _projection: &Option<Vec<usize>>,
+            _projection: Option<&Vec<usize>>,
             _filters: &[Expr],
             _limit: Option<usize>,
         ) -> TableResult<PhysicalPlanRef> {

src/common/grpc-expr/src/lib.rs

@@ -1,4 +1,3 @@
-#![feature(assert_matches)]
 // Copyright 2022 Greptime Team
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
@@ -15,10 +14,9 @@
 
 mod alter;
 pub mod error;
-mod insert;
+pub mod insert;
 
 pub use alter::{alter_expr_to_request, create_expr_to_request, create_table_schema};
 pub use insert::{
-    build_alter_table_request, build_create_expr_from_insertion, column_to_vector,
-    find_new_columns, insertion_expr_to_request,
+    build_alter_table_request, build_create_expr_from_insertion, column_to_vector, find_new_columns,
 };

src/common/grpc/Cargo.toml

@@ -1,11 +1,12 @@
 [package]
 name = "common-grpc"
-version = "0.1.0"
-edition = "2021"
-license = "Apache-2.0"
+version.workspace = true
+edition.workspace = true
+license.workspace = true
 
 [dependencies]
 api = { path = "../../api" }
+arrow-flight.workspace = true
 async-trait = "0.1"
 common-base = { path = "../base" }
 common-error = { path = "../error" }
@@ -13,8 +14,11 @@ common-query = { path = "../query" }
 common-recordbatch = { path = "../recordbatch" }
 common-runtime = { path = "../runtime" }
 dashmap = "5.4"
-datafusion = "14.0.0"
+datafusion.workspace = true
 datatypes = { path = "../../datatypes" }
+flatbuffers = "22"
+futures = "0.3"
+prost = "0.11"
 snafu = { version = "0.7", features = ["backtraces"] }
 tokio = { version = "1.0", features = ["full"] }
 tonic = "0.8"

src/common/grpc/benches/channel_manager.rs

@@ -26,7 +26,7 @@ async fn do_bench_channel_manager() {
         let join = tokio::spawn(async move {
             for _ in 0..10000 {
                 let idx = rand::random::<usize>() % 100;
-                let ret = m_clone.get(format!("{}", idx));
+                let ret = m_clone.get(format!("{idx}"));
                 assert!(ret.is_ok());
             }
         });

src/common/grpc/src/channel_manager.rs

@@ -120,7 +120,7 @@ impl ChannelManager {
 
     fn build_endpoint(&self, addr: &str) -> Result<Endpoint> {
         let mut endpoint =
-            Endpoint::new(format!("http://{}", addr)).context(error::CreateChannelSnafu)?;
+            Endpoint::new(format!("http://{addr}")).context(error::CreateChannelSnafu)?;
 
         if let Some(dur) = self.config.timeout {
             endpoint = endpoint.timeout(dur);

src/common/grpc/src/error.rs

@@ -44,8 +44,8 @@ pub enum Error {
         backtrace: Backtrace,
     },
 
-    #[snafu(display("Failed to collect RecordBatches, source: {}", source))]
-    CollectRecordBatches {
+    #[snafu(display("Failed to create RecordBatch, source: {}", source))]
+    CreateRecordBatch {
         #[snafu(backtrace)]
         source: common_recordbatch::error::Error,
     },
@@ -58,15 +58,40 @@ pub enum Error {
         #[snafu(backtrace)]
         source: api::error::Error,
     },
+
+    #[snafu(display("Failed to decode FlightData, source: {}", source))]
+    DecodeFlightData {
+        source: api::DecodeError,
+        backtrace: Backtrace,
+    },
+
+    #[snafu(display("Invalid FlightData, reason: {}", reason))]
+    InvalidFlightData {
+        reason: String,
+        backtrace: Backtrace,
+    },
+
+    #[snafu(display("Failed to convert Arrow Schema, source: {}", source))]
+    ConvertArrowSchema {
+        #[snafu(backtrace)]
+        source: datatypes::error::Error,
+    },
 }
 
 impl ErrorExt for Error {
     fn status_code(&self) -> StatusCode {
         match self {
-            Error::MissingField { .. } | Error::TypeMismatch { .. } => StatusCode::InvalidArguments,
-            Error::CreateChannel { .. } | Error::Conversion { .. } => StatusCode::Internal,
-            Error::CollectRecordBatches { source } => source.status_code(),
+            Error::MissingField { .. }
+            | Error::TypeMismatch { .. }
+            | Error::InvalidFlightData { .. } => StatusCode::InvalidArguments,
+
+            Error::CreateChannel { .. }
+            | Error::Conversion { .. }
+            | Error::DecodeFlightData { .. } => StatusCode::Internal,
+
+            Error::CreateRecordBatch { source } => source.status_code(),
             Error::ColumnDataType { source } => source.status_code(),
+            Error::ConvertArrowSchema { source } => source.status_code(),
         }
     }
 

src/common/grpc/src/flight.rs

@@ -0,0 +1,334 @@
+// Copyright 2022 Greptime Team
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+use std::collections::HashMap;
+use std::pin::Pin;
+use std::sync::Arc;
+
+use api::result::ObjectResultBuilder;
+use api::v1::{FlightDataExt, ObjectResult};
+use arrow_flight::utils::{flight_data_from_arrow_batch, flight_data_to_arrow_batch};
+use arrow_flight::{FlightData, IpcMessage, SchemaAsIpc};
+use common_error::prelude::StatusCode;
+use common_recordbatch::{RecordBatch, RecordBatches};
+use datatypes::arrow;
+use datatypes::arrow::datatypes::Schema as ArrowSchema;
+use datatypes::arrow::ipc::{root_as_message, writer, MessageHeader};
+use datatypes::schema::{Schema, SchemaRef};
+use flatbuffers::FlatBufferBuilder;
+use futures::TryStreamExt;
+use prost::Message;
+use snafu::{OptionExt, ResultExt};
+use tonic::codegen::futures_core::Stream;
+use tonic::Response;
+
+use crate::error::{
+    ConvertArrowSchemaSnafu, CreateRecordBatchSnafu, DecodeFlightDataSnafu, InvalidFlightDataSnafu,
+    Result,
+};
+
+type TonicResult<T> = std::result::Result<T, tonic::Status>;
+type TonicStream<T> = Pin<Box<dyn Stream<Item = TonicResult<T>> + Send + Sync + 'static>>;
+
+#[derive(Debug, Clone)]
+pub enum FlightMessage {
+    Schema(SchemaRef),
+    Recordbatch(RecordBatch),
+    AffectedRows(usize),
+}
+
+#[derive(Default)]
+pub struct FlightEncoder {
+    write_options: writer::IpcWriteOptions,
+}
+
+impl FlightEncoder {
+    pub fn encode(&self, flight_message: FlightMessage) -> FlightData {
+        match flight_message {
+            FlightMessage::Schema(schema) => {
+                SchemaAsIpc::new(schema.arrow_schema(), &self.write_options).into()
+            }
+            FlightMessage::Recordbatch(recordbatch) => {
+                let (flight_dictionaries, flight_batch) = flight_data_from_arrow_batch(
+                    recordbatch.df_record_batch(),
+                    &self.write_options,
+                );
+
+                // TODO(LFC): Handle dictionary as FlightData here, when we supported Arrow's Dictionary DataType.
+                // Currently we don't have a datatype corresponding to Arrow's Dictionary DataType,
+                // so there won't be any "dictionaries" here. Assert to be sure about it, and
+                // perform a "testing guard" in case we forgot to handle the possible "dictionaries"
+                // here in the future.
+                debug_assert_eq!(flight_dictionaries.len(), 0);
+
+                flight_batch
+            }
+            FlightMessage::AffectedRows(rows) => {
+                let ext_data = FlightDataExt {
+                    affected_rows: rows as _,
+                }
+                .encode_to_vec();
+                FlightData::new(None, IpcMessage(build_none_flight_msg()), vec![], ext_data)
+            }
+        }
+    }
+}
+
+#[derive(Default)]
+pub struct FlightDecoder {
+    schema: Option<SchemaRef>,
+}
+
+impl FlightDecoder {
+    pub fn try_decode(&mut self, flight_data: FlightData) -> Result<FlightMessage> {
+        let message = root_as_message(flight_data.data_header.as_slice()).map_err(|e| {
+            InvalidFlightDataSnafu {
+                reason: e.to_string(),
+            }
+            .build()
+        })?;
+        match message.header_type() {
+            MessageHeader::NONE => {
+                let ext_data = FlightDataExt::decode(flight_data.data_body.as_slice())
+                    .context(DecodeFlightDataSnafu)?;
+                Ok(FlightMessage::AffectedRows(ext_data.affected_rows as _))
+            }
+            MessageHeader::Schema => {
+                let arrow_schema = ArrowSchema::try_from(&flight_data).map_err(|e| {
+                    InvalidFlightDataSnafu {
+                        reason: e.to_string(),
+                    }
+                    .build()
+                })?;
+                let schema =
+                    Arc::new(Schema::try_from(arrow_schema).context(ConvertArrowSchemaSnafu)?);
+
+                self.schema = Some(schema.clone());
+
+                Ok(FlightMessage::Schema(schema))
+            }
+            MessageHeader::RecordBatch => {
+                let schema = self.schema.clone().context(InvalidFlightDataSnafu {
+                    reason: "Should have decoded schema first!",
+                })?;
+                let arrow_schema = schema.arrow_schema().clone();
+
+                let arrow_batch =
+                    flight_data_to_arrow_batch(&flight_data, arrow_schema, &HashMap::new())
+                        .map_err(|e| {
+                            InvalidFlightDataSnafu {
+                                reason: e.to_string(),
+                            }
+                            .build()
+                        })?;
+                let recordbatch = RecordBatch::try_from_df_record_batch(schema, arrow_batch)
+                    .context(CreateRecordBatchSnafu)?;
+                Ok(FlightMessage::Recordbatch(recordbatch))
+            }
+            other => {
+                let name = other.variant_name().unwrap_or("UNKNOWN");
+                InvalidFlightDataSnafu {
+                    reason: format!("Unsupported FlightData type: {name}"),
+                }
+                .fail()
+            }
+        }
+    }
+}
+
+// TODO(LFC): Remove it once we completely get rid of old GRPC interface.
+pub async fn flight_data_to_object_result(
+    response: Response<TonicStream<FlightData>>,
+) -> Result<ObjectResult> {
+    let stream = response.into_inner();
+    let result: TonicResult<Vec<FlightData>> = stream.try_collect().await;
+    match result {
+        Ok(flight_data) => Ok(ObjectResultBuilder::new()
+            .status_code(StatusCode::Success as u32)
+            .flight_data(flight_data)
+            .build()),
+        Err(e) => Ok(ObjectResultBuilder::new()
+            .status_code(StatusCode::Internal as _)
+            .err_msg(e.to_string())
+            .build()),
+    }
+}
+
+pub fn raw_flight_data_to_message(raw_data: Vec<Vec<u8>>) -> Result<Vec<FlightMessage>> {
+    let flight_data = raw_data
+        .into_iter()
+        .map(|x| FlightData::decode(x.as_slice()).context(DecodeFlightDataSnafu))
+        .collect::<Result<Vec<FlightData>>>()?;
+
+    let decoder = &mut FlightDecoder::default();
+    flight_data
+        .into_iter()
+        .map(|x| decoder.try_decode(x))
+        .collect()
+}
+
+pub fn flight_messages_to_recordbatches(messages: Vec<FlightMessage>) -> Result<RecordBatches> {
+    if messages.is_empty() {
+        Ok(RecordBatches::empty())
+    } else {
+        let mut recordbatches = Vec::with_capacity(messages.len() - 1);
+
+        let schema = match &messages[0] {
+            FlightMessage::Schema(schema) => schema.clone(),
+            _ => {
+                return InvalidFlightDataSnafu {
+                    reason: "First Flight Message must be schema!",
+                }
+                .fail()
+            }
+        };
+
+        for message in messages.into_iter().skip(1) {
+            match message {
+                FlightMessage::Recordbatch(recordbatch) => recordbatches.push(recordbatch),
+                _ => {
+                    return InvalidFlightDataSnafu {
+                        reason: "Expect the following Flight Messages are all Recordbatches!",
+                    }
+                    .fail()
+                }
+            }
+        }
+
+        RecordBatches::try_new(schema, recordbatches).context(CreateRecordBatchSnafu)
+    }
+}
+
+fn build_none_flight_msg() -> Vec<u8> {
+    let mut builder = FlatBufferBuilder::new();
+
+    let mut message = arrow::ipc::MessageBuilder::new(&mut builder);
+    message.add_version(arrow::ipc::MetadataVersion::V5);
+    message.add_header_type(MessageHeader::NONE);
+    message.add_bodyLength(0);
+
+    let data = message.finish();
+    builder.finish(data, None);
+
+    builder.finished_data().to_vec()
+}
+
+#[cfg(test)]
+mod test {
+    use arrow_flight::utils::batches_to_flight_data;
+    use datatypes::arrow::datatypes::{DataType, Field};
+    use datatypes::prelude::ConcreteDataType;
+    use datatypes::schema::ColumnSchema;
+    use datatypes::vectors::Int32Vector;
+
+    use super::*;
+    use crate::Error;
+
+    #[test]
+    fn test_try_decode() {
+        let arrow_schema = ArrowSchema::new(vec![Field::new("n", DataType::Int32, true)]);
+        let schema = Arc::new(Schema::try_from(arrow_schema.clone()).unwrap());
+
+        let batch1 = RecordBatch::new(
+            schema.clone(),
+            vec![Arc::new(Int32Vector::from(vec![Some(1), None, Some(3)])) as _],
+        )
+        .unwrap();
+        let batch2 = RecordBatch::new(
+            schema.clone(),
+            vec![Arc::new(Int32Vector::from(vec![None, Some(5)])) as _],
+        )
+        .unwrap();
+
+        let flight_data = batches_to_flight_data(
+            arrow_schema,
+            vec![
+                batch1.clone().into_df_record_batch(),
+                batch2.clone().into_df_record_batch(),
+            ],
+        )
+        .unwrap();
+        assert_eq!(flight_data.len(), 3);
+        let [d1, d2, d3] = flight_data.as_slice() else { unreachable!() };
+
+        let decoder = &mut FlightDecoder::default();
+        assert!(decoder.schema.is_none());
+
+        let result = decoder.try_decode(d2.clone());
+        assert!(matches!(result, Err(Error::InvalidFlightData { .. })));
+        assert!(result
+            .unwrap_err()
+            .to_string()
+            .contains("Should have decoded schema first!"));
+
+        let message = decoder.try_decode(d1.clone()).unwrap();
+        assert!(matches!(message, FlightMessage::Schema(_)));
+        let FlightMessage::Schema(decoded_schema) = message else { unreachable!() };
+        assert_eq!(decoded_schema, schema);
+
+        assert!(decoder.schema.is_some());
+
+        let message = decoder.try_decode(d2.clone()).unwrap();
+        assert!(matches!(message, FlightMessage::Recordbatch(_)));
+        let FlightMessage::Recordbatch(actual_batch) = message else { unreachable!() };
+        assert_eq!(actual_batch, batch1);
+
+        let message = decoder.try_decode(d3.clone()).unwrap();
+        assert!(matches!(message, FlightMessage::Recordbatch(_)));
+        let FlightMessage::Recordbatch(actual_batch) = message else { unreachable!() };
+        assert_eq!(actual_batch, batch2);
+    }
+
+    #[test]
+    fn test_flight_messages_to_recordbatches() {
+        let schema = Arc::new(Schema::new(vec![ColumnSchema::new(
+            "m",
+            ConcreteDataType::int32_datatype(),
+            true,
+        )]));
+        let batch1 = RecordBatch::new(
+            schema.clone(),
+            vec![Arc::new(Int32Vector::from(vec![Some(2), None, Some(4)])) as _],
+        )
+        .unwrap();
+        let batch2 = RecordBatch::new(
+            schema.clone(),
+            vec![Arc::new(Int32Vector::from(vec![None, Some(6)])) as _],
+        )
+        .unwrap();
+        let recordbatches =
+            RecordBatches::try_new(schema.clone(), vec![batch1.clone(), batch2.clone()]).unwrap();
+
+        let m1 = FlightMessage::Schema(schema);
+        let m2 = FlightMessage::Recordbatch(batch1);
+        let m3 = FlightMessage::Recordbatch(batch2);
+
+        let result = flight_messages_to_recordbatches(vec![m2.clone(), m1.clone(), m3.clone()]);
+        assert!(matches!(result, Err(Error::InvalidFlightData { .. })));
+        assert!(result
+            .unwrap_err()
+            .to_string()
+            .contains("First Flight Message must be schema!"));
+
+        let result = flight_messages_to_recordbatches(vec![m1.clone(), m2.clone(), m1.clone()]);
+        assert!(matches!(result, Err(Error::InvalidFlightData { .. })));
+        assert!(result
+            .unwrap_err()
+            .to_string()
+            .contains("Expect the following Flight Messages are all Recordbatches!"));
+
+        let actual = flight_messages_to_recordbatches(vec![m1, m2, m3]).unwrap();
+        assert_eq!(actual, recordbatches);
+    }
+}

src/common/grpc/src/lib.rs

@@ -14,6 +14,7 @@
 
 pub mod channel_manager;
 pub mod error;
+pub mod flight;
 pub mod select;
 pub mod writer;
 

src/common/grpc/src/select.rs

@@ -12,17 +12,8 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-use api::helper::ColumnDataTypeWrapper;
-use api::result::{build_err_result, ObjectResultBuilder};
-use api::v1::codec::SelectResult;
-use api::v1::column::{SemanticType, Values};
-use api::v1::{Column, ObjectResult};
+use api::v1::column::Values;
 use common_base::BitVec;
-use common_error::prelude::ErrorExt;
-use common_error::status_code::StatusCode;
-use common_query::Output;
-use common_recordbatch::{RecordBatches, SendableRecordBatchStream};
-use datatypes::schema::SchemaRef;
 use datatypes::types::{TimestampType, WrapperType};
 use datatypes::vectors::{
     BinaryVector, BooleanVector, DateTimeVector, DateVector, Float32Vector, Float64Vector,
@@ -30,88 +21,9 @@ use datatypes::vectors::{
     TimestampMillisecondVector, TimestampNanosecondVector, TimestampSecondVector, UInt16Vector,
     UInt32Vector, UInt64Vector, UInt8Vector, VectorRef,
 };
-use snafu::{OptionExt, ResultExt};
+use snafu::OptionExt;
 
-use crate::error::{self, ConversionSnafu, Result};
-
-pub async fn to_object_result(output: std::result::Result<Output, impl ErrorExt>) -> ObjectResult {
-    let result = match output {
-        Ok(Output::AffectedRows(rows)) => Ok(ObjectResultBuilder::new()
-            .status_code(StatusCode::Success as u32)
-            .mutate_result(rows as u32, 0)
-            .build()),
-        Ok(Output::Stream(stream)) => collect(stream).await,
-        Ok(Output::RecordBatches(recordbatches)) => build_result(recordbatches),
-        Err(e) => return build_err_result(&e),
-    };
-    match result {
-        Ok(r) => r,
-        Err(e) => build_err_result(&e),
-    }
-}
-
-async fn collect(stream: SendableRecordBatchStream) -> Result<ObjectResult> {
-    let recordbatches = RecordBatches::try_collect(stream)
-        .await
-        .context(error::CollectRecordBatchesSnafu)?;
-    let object_result = build_result(recordbatches)?;
-    Ok(object_result)
-}
-
-fn build_result(recordbatches: RecordBatches) -> Result<ObjectResult> {
-    let select_result = try_convert(recordbatches)?;
-    let object_result = ObjectResultBuilder::new()
-        .status_code(StatusCode::Success as u32)
-        .select_result(select_result)
-        .build();
-    Ok(object_result)
-}
-
-#[inline]
-fn get_semantic_type(schema: &SchemaRef, idx: usize) -> i32 {
-    if Some(idx) == schema.timestamp_index() {
-        SemanticType::Timestamp as i32
-    } else {
-        // FIXME(dennis): set primary key's columns semantic type as Tag,
-        // but we can't get the table's schema here right now.
-        SemanticType::Field as i32
-    }
-}
-
-fn try_convert(record_batches: RecordBatches) -> Result<SelectResult> {
-    let schema = record_batches.schema();
-    let record_batches = record_batches.take();
-
-    let row_count: usize = record_batches.iter().map(|r| r.num_rows()).sum();
-
-    let schemas = schema.column_schemas();
-    let mut columns = Vec::with_capacity(schemas.len());
-
-    for (idx, column_schema) in schemas.iter().enumerate() {
-        let column_name = column_schema.name.clone();
-
-        let arrays: Vec<_> = record_batches
-            .iter()
-            .map(|r| r.column(idx).clone())
-            .collect();
-
-        let column = Column {
-            column_name,
-            values: Some(values(&arrays)?),
-            null_mask: null_mask(&arrays, row_count),
-            datatype: ColumnDataTypeWrapper::try_from(column_schema.data_type.clone())
-                .context(error::ColumnDataTypeSnafu)?
-                .datatype() as i32,
-            semantic_type: get_semantic_type(&schema, idx),
-        };
-        columns.push(column);
-    }
-
-    Ok(SelectResult {
-        columns,
-        row_count: row_count as u32,
-    })
-}
+use crate::error::{ConversionSnafu, Result};
 
 pub fn null_mask(arrays: &[VectorRef], row_count: usize) -> Vec<u8> {
     let null_count: usize = arrays.iter().map(|a| a.null_count()).sum();
@@ -263,34 +175,8 @@ pub fn values(arrays: &[VectorRef]) -> Result<Values> {
 mod tests {
     use std::sync::Arc;
 
-    use common_recordbatch::{RecordBatch, RecordBatches};
-    use datatypes::data_type::ConcreteDataType;
-    use datatypes::schema::{ColumnSchema, Schema};
-
     use super::*;
 
-    #[test]
-    fn test_convert_record_batches_to_select_result() {
-        let r1 = mock_record_batch();
-        let schema = r1.schema.clone();
-        let r2 = mock_record_batch();
-        let record_batches = vec![r1, r2];
-        let record_batches = RecordBatches::try_new(schema, record_batches).unwrap();
-
-        let s = try_convert(record_batches).unwrap();
-
-        let c1 = s.columns.get(0).unwrap();
-        let c2 = s.columns.get(1).unwrap();
-        assert_eq!("c1", c1.column_name);
-        assert_eq!("c2", c2.column_name);
-
-        assert_eq!(vec![0b0010_0100], c1.null_mask);
-        assert_eq!(vec![0b0011_0110], c2.null_mask);
-
-        assert_eq!(vec![1, 2, 1, 2], c1.values.as_ref().unwrap().u32_values);
-        assert_eq!(vec![1, 1], c2.values.as_ref().unwrap().u32_values);
-    }
-
     #[test]
     fn test_convert_arrow_arrays_i32() {
         let array = Int32Vector::from(vec![Some(1), Some(2), None, Some(3)]);
@@ -358,18 +244,4 @@ mod tests {
         let mask = null_mask(&[a1, a2], 3 + 3);
         assert_eq!(vec![0b0010_0000], mask);
     }
-
-    fn mock_record_batch() -> RecordBatch {
-        let column_schemas = vec![
-            ColumnSchema::new("c1", ConcreteDataType::uint32_datatype(), true),
-            ColumnSchema::new("c2", ConcreteDataType::uint32_datatype(), true),
-        ];
-        let schema = Arc::new(Schema::try_new(column_schemas).unwrap());
-
-        let v1 = Arc::new(UInt32Vector::from(vec![Some(1), Some(2), None]));
-        let v2 = Arc::new(UInt32Vector::from(vec![Some(1), None, None]));
-        let columns: Vec<VectorRef> = vec![v1, v2];
-
-        RecordBatch::new(schema, columns).unwrap()
-    }
 }

src/common/query/Cargo.toml

@@ -1,19 +1,19 @@
 [package]
 name = "common-query"
-version = "0.1.0"
-edition = "2021"
-license = "Apache-2.0"
+version.workspace = true
+edition.workspace = true
+license.workspace = true
 
 [dependencies]
-async-trait = "0.1"
+async-trait.workspace = true
 common-error = { path = "../error" }
 common-recordbatch = { path = "../recordbatch" }
 common-time = { path = "../time" }
-datafusion = "14.0.0"
-datafusion-common = "14.0.0"
-datafusion-expr = "14.0.0"
+datafusion.workspace = true
+datafusion-common.workspace = true
+datafusion-expr.workspace = true
 datatypes = { path = "../../datatypes" }
-snafu = { version = "0.7", features = ["backtraces"] }
+snafu.workspace = true
 statrs = "0.15"
 
 [dev-dependencies]

src/common/query/src/function.rs

@@ -161,12 +161,7 @@ mod tests {
 
                 assert_eq!(4, vec.len());
                 for i in 0..4 {
-                    assert_eq!(
-                        i == 0 || i == 3,
-                        vec.get_data(i).unwrap(),
-                        "failed at {}",
-                        i
-                    )
+                    assert_eq!(i == 0 || i == 3, vec.get_data(i).unwrap(), "Failed at {i}")
                 }
             }
             _ => unreachable!(),

src/common/query/src/logical_plan/accumulator.rs

@@ -18,7 +18,7 @@ use std::fmt::Debug;
 use std::sync::Arc;
 
 use datafusion_common::Result as DfResult;
-use datafusion_expr::{Accumulator as DfAccumulator, AggregateState};
+use datafusion_expr::Accumulator as DfAccumulator;
 use datatypes::arrow::array::ArrayRef;
 use datatypes::prelude::*;
 use datatypes::vectors::{Helper as VectorHelper, VectorRef};
@@ -126,24 +126,19 @@ impl DfAccumulatorAdaptor {
 }
 
 impl DfAccumulator for DfAccumulatorAdaptor {
-    fn state(&self) -> DfResult<Vec<AggregateState>> {
+    fn state(&self) -> DfResult<Vec<ScalarValue>> {
         let state_values = self.accumulator.state()?;
         let state_types = self.creator.state_types()?;
         if state_values.len() != state_types.len() {
             return error::BadAccumulatorImplSnafu {
-                err_msg: format!("Accumulator {:?} returned state values size do not match its state types size.", self),
+                err_msg: format!("Accumulator {self:?} returned state values size do not match its state types size."),
             }
             .fail()?;
         }
         Ok(state_values
             .into_iter()
             .zip(state_types.iter())
-            .map(|(v, t)| {
-                let scalar = v
-                    .try_to_scalar_value(t)
-                    .context(error::ToScalarValueSnafu)?;
-                Ok(AggregateState::Scalar(scalar))
-            })
+            .map(|(v, t)| v.try_to_scalar_value(t).context(error::ToScalarValueSnafu))
             .collect::<Result<Vec<_>>>()?)
     }
 
@@ -175,4 +170,9 @@ impl DfAccumulator for DfAccumulatorAdaptor {
             .map_err(Error::from)?;
         Ok(scalar_value)
     }
+
+    fn size(&self) -> usize {
+        // TODO(LFC): Implement new "size" method for Accumulator.
+        0
+    }
 }

src/common/query/src/physical_plan.rs

@@ -233,7 +233,7 @@ mod test {
         async fn scan(
             &self,
             _ctx: &SessionState,
-            _projection: &Option<Vec<usize>>,
+            _projection: Option<&Vec<usize>>,
             _filters: &[Expr],
             _limit: Option<usize>,
         ) -> DfResult<Arc<dyn DfPhysicalPlan>> {

src/common/recordbatch/Cargo.toml

@@ -1,15 +1,15 @@
 [package]
 name = "common-recordbatch"
-version = "0.1.0"
-edition = "2021"
-license = "Apache-2.0"
+version.workspace = true
+edition.workspace = true
+license.workspace = true
 
 [dependencies]
 common-error = { path = "../error" }
-datafusion = "14.0.0"
-datafusion-common = "14.0.0"
+datafusion.workspace = true
+datafusion-common.workspace = true
 datatypes = { path = "../../datatypes" }
-futures = "0.3"
+futures.workspace = true
 paste = "1.0"
 serde = "1.0"
 snafu = { version = "0.7", features = ["backtraces"] }

src/common/recordbatch/src/adapter.rs

@@ -121,7 +121,8 @@ impl Stream for RecordBatchStreamAdapter {
 
 enum AsyncRecordBatchStreamAdapterState {
     Uninit(FutureStream),
-    Inited(std::result::Result<DfSendableRecordBatchStream, DataFusionError>),
+    Ready(DfSendableRecordBatchStream),
+    Failed,
 }
 
 pub struct AsyncRecordBatchStreamAdapter {
@@ -151,28 +152,26 @@ impl Stream for AsyncRecordBatchStreamAdapter {
         loop {
             match &mut self.state {
                 AsyncRecordBatchStreamAdapterState::Uninit(stream_future) => {
-                    self.state = AsyncRecordBatchStreamAdapterState::Inited(ready!(Pin::new(
-                        stream_future
-                    )
-                    .poll(cx)));
-                    continue;
+                    match ready!(Pin::new(stream_future).poll(cx)) {
+                        Ok(stream) => {
+                            self.state = AsyncRecordBatchStreamAdapterState::Ready(stream);
+                            continue;
+                        }
+                        Err(e) => {
+                            self.state = AsyncRecordBatchStreamAdapterState::Failed;
+                            return Poll::Ready(Some(
+                                Err(e).context(error::InitRecordbatchStreamSnafu),
+                            ));
+                        }
+                    };
                 }
-                AsyncRecordBatchStreamAdapterState::Inited(stream) => match stream {
-                    Ok(stream) => {
-                        return Poll::Ready(ready!(Pin::new(stream).poll_next(cx)).map(|df| {
-                            let df_record_batch = df.context(error::PollStreamSnafu)?;
-                            RecordBatch::try_from_df_record_batch(self.schema(), df_record_batch)
-                        }));
-                    }
-                    Err(e) => {
-                        return Poll::Ready(Some(
-                            error::CreateRecordBatchesSnafu {
-                                reason: format!("Read error {:?} from stream", e),
-                            }
-                            .fail(),
-                        ))
-                    }
-                },
+                AsyncRecordBatchStreamAdapterState::Ready(stream) => {
+                    return Poll::Ready(ready!(Pin::new(stream).poll_next(cx)).map(|x| {
+                        let df_record_batch = x.context(error::PollStreamSnafu)?;
+                        RecordBatch::try_from_df_record_batch(self.schema(), df_record_batch)
+                    }))
+                }
+                AsyncRecordBatchStreamAdapterState::Failed => return Poll::Ready(None),
             }
         }
     }
@@ -183,3 +182,104 @@ impl Stream for AsyncRecordBatchStreamAdapter {
         (0, None)
     }
 }
+
+#[cfg(test)]
+mod test {
+    use common_error::mock::MockError;
+    use common_error::prelude::{BoxedError, StatusCode};
+    use datatypes::prelude::ConcreteDataType;
+    use datatypes::schema::ColumnSchema;
+    use datatypes::vectors::Int32Vector;
+
+    use super::*;
+    use crate::RecordBatches;
+
+    #[tokio::test]
+    async fn test_async_recordbatch_stream_adaptor() {
+        struct MaybeErrorRecordBatchStream {
+            items: Vec<Result<RecordBatch>>,
+        }
+
+        impl RecordBatchStream for MaybeErrorRecordBatchStream {
+            fn schema(&self) -> SchemaRef {
+                unimplemented!()
+            }
+        }
+
+        impl Stream for MaybeErrorRecordBatchStream {
+            type Item = Result<RecordBatch>;
+
+            fn poll_next(
+                mut self: Pin<&mut Self>,
+                _: &mut Context<'_>,
+            ) -> Poll<Option<Self::Item>> {
+                if let Some(batch) = self.items.pop() {
+                    Poll::Ready(Some(Ok(batch?)))
+                } else {
+                    Poll::Ready(None)
+                }
+            }
+        }
+
+        fn new_future_stream(
+            maybe_recordbatches: Result<Vec<Result<RecordBatch>>>,
+        ) -> FutureStream {
+            Box::pin(async move {
+                maybe_recordbatches
+                    .map(|items| {
+                        Box::pin(DfRecordBatchStreamAdapter::new(Box::pin(
+                            MaybeErrorRecordBatchStream { items },
+                        ))) as _
+                    })
+                    .map_err(|e| DataFusionError::External(Box::new(e)))
+            })
+        }
+
+        let schema = Arc::new(Schema::new(vec![ColumnSchema::new(
+            "a",
+            ConcreteDataType::int32_datatype(),
+            false,
+        )]));
+        let batch1 = RecordBatch::new(
+            schema.clone(),
+            vec![Arc::new(Int32Vector::from_slice(&[1])) as _],
+        )
+        .unwrap();
+        let batch2 = RecordBatch::new(
+            schema.clone(),
+            vec![Arc::new(Int32Vector::from_slice(&[2])) as _],
+        )
+        .unwrap();
+
+        let success_stream = new_future_stream(Ok(vec![Ok(batch1.clone()), Ok(batch2.clone())]));
+        let adapter = AsyncRecordBatchStreamAdapter::new(schema.clone(), success_stream);
+        let collected = RecordBatches::try_collect(Box::pin(adapter)).await.unwrap();
+        assert_eq!(
+            collected,
+            RecordBatches::try_new(schema.clone(), vec![batch2.clone(), batch1.clone()]).unwrap()
+        );
+
+        let poll_err_stream = new_future_stream(Ok(vec![
+            Ok(batch1.clone()),
+            Err(error::Error::External {
+                source: BoxedError::new(MockError::new(StatusCode::Unknown)),
+            }),
+        ]));
+        let adapter = AsyncRecordBatchStreamAdapter::new(schema.clone(), poll_err_stream);
+        let result = RecordBatches::try_collect(Box::pin(adapter)).await;
+        assert_eq!(
+            result.unwrap_err().to_string(),
+            "Failed to poll stream, source: External error: External error, source: Unknown"
+        );
+
+        let failed_to_init_stream = new_future_stream(Err(error::Error::External {
+            source: BoxedError::new(MockError::new(StatusCode::Internal)),
+        }));
+        let adapter = AsyncRecordBatchStreamAdapter::new(schema.clone(), failed_to_init_stream);
+        let result = RecordBatches::try_collect(Box::pin(adapter)).await;
+        assert_eq!(
+            result.unwrap_err().to_string(),
+            "Failed to init Recordbatch stream, source: External error: External error, source: Internal"
+        );
+    }
+}

src/common/recordbatch/src/error.rs

@@ -64,6 +64,12 @@ pub enum Error {
         source: datatypes::arrow::error::ArrowError,
         backtrace: Backtrace,
     },
+
+    #[snafu(display("Failed to init Recordbatch stream, source: {}", source))]
+    InitRecordbatchStream {
+        source: datafusion_common::DataFusionError,
+        backtrace: Backtrace,
+    },
 }
 
 impl ErrorExt for Error {
@@ -74,7 +80,8 @@ impl ErrorExt for Error {
             Error::DataTypes { .. }
             | Error::CreateRecordBatches { .. }
             | Error::PollStream { .. }
-            | Error::Format { .. } => StatusCode::Internal,
+            | Error::Format { .. }
+            | Error::InitRecordbatchStream { .. } => StatusCode::Internal,
 
             Error::External { source } => source.status_code(),
 

src/common/recordbatch/src/lib.rs

@@ -231,8 +231,7 @@ mod tests {
         assert_eq!(
             result.unwrap_err().to_string(),
             format!(
-                "Failed to create RecordBatches, reason: expect RecordBatch schema equals {:?}, actual: {:?}",
-                schema1, schema2
+                "Failed to create RecordBatches, reason: expect RecordBatch schema equals {schema1:?}, actual: {schema2:?}",
             )
         );
 

src/common/recordbatch/src/recordbatch.rs

@@ -151,7 +151,7 @@ impl<'a> RecordBatchRowIterator<'a> {
 }
 
 impl<'a> Iterator for RecordBatchRowIterator<'a> {
-    type Item = Result<Vec<Value>>;
+    type Item = Vec<Value>;
 
     fn next(&mut self) -> Option<Self::Item> {
         if self.row_cursor == self.rows {
@@ -165,7 +165,7 @@ impl<'a> Iterator for RecordBatchRowIterator<'a> {
             }
 
             self.row_cursor += 1;
-            Some(Ok(row))
+            Some(row)
         }
     }
 }
@@ -227,7 +227,7 @@ mod tests {
 
         let output = serde_json::to_string(&batch).unwrap();
         assert_eq!(
-            r#"{"schema":{"fields":[{"name":"number","data_type":"UInt32","nullable":false,"dict_id":0,"dict_is_ordered":false}],"metadata":{"greptime:version":"0"}},"columns":[[0,1,2,3,4,5,6,7,8,9]]}"#,
+            r#"{"schema":{"fields":[{"name":"number","data_type":"UInt32","nullable":false,"dict_id":0,"dict_is_ordered":false,"metadata":{}}],"metadata":{"greptime:version":"0"}},"columns":[[0,1,2,3,4,5,6,7,8,9]]}"#,
             output
         );
     }
@@ -256,7 +256,6 @@ mod tests {
             record_batch_iter
                 .next()
                 .unwrap()
-                .unwrap()
                 .into_iter()
                 .collect::<Vec<Value>>()
         );
@@ -266,7 +265,6 @@ mod tests {
             record_batch_iter
                 .next()
                 .unwrap()
-                .unwrap()
                 .into_iter()
                 .collect::<Vec<Value>>()
         );
@@ -276,7 +274,6 @@ mod tests {
             record_batch_iter
                 .next()
                 .unwrap()
-                .unwrap()
                 .into_iter()
                 .collect::<Vec<Value>>()
         );
@@ -286,7 +283,6 @@ mod tests {
             record_batch_iter
                 .next()
                 .unwrap()
-                .unwrap()
                 .into_iter()
                 .collect::<Vec<Value>>()
         );

src/common/runtime/Cargo.toml

@@ -1,17 +1,17 @@
 [package]
 name = "common-runtime"
-version = "0.1.0"
-edition = "2021"
-license = "Apache-2.0"
+version.workspace = true
+edition.workspace = true
+license.workspace = true
 
 [dependencies]
 common-error = { path = "../error" }
 common-telemetry = { path = "../telemetry" }
 metrics = "0.20"
 once_cell = "1.12"
-paste = "1.0"
-snafu = { version = "0.7", features = ["backtraces"] }
-tokio = { version = "1.18", features = ["full"] }
+paste.workspace = true
+snafu.workspace = true
+tokio.workspace = true
 
 [dev-dependencies]
 tokio-test = "0.4"

src/common/substrait/Cargo.toml

@@ -1,8 +1,8 @@
 [package]
 name = "substrait"
-version = "0.1.0"
-edition = "2021"
-license = "Apache-2.0"
+version.workspace = true
+edition.workspace = true
+license.workspace = true
 
 [dependencies]
 bytes = "1.1"
@@ -10,12 +10,12 @@ catalog = { path = "../../catalog" }
 common-catalog = { path = "../catalog" }
 common-error = { path = "../error" }
 common-telemetry = { path = "../telemetry" }
-datafusion = "14.0.0"
-datafusion-expr = "14.0.0"
+datafusion.workspace = true
+datafusion-expr.workspace = true
 datatypes = { path = "../../datatypes" }
 futures = "0.3"
 prost = "0.9"
-snafu = { version = "0.7", features = ["backtraces"] }
+snafu.workspace = true
 table = { path = "../../table" }
 
 [dependencies.substrait_proto]

src/common/substrait/src/df_expr.rs

@@ -16,6 +16,7 @@ use std::collections::VecDeque;
 use std::str::FromStr;
 
 use datafusion::common::Column;
+use datafusion_expr::expr::Sort;
 use datafusion_expr::{expr_fn, lit, Between, BinaryExpr, BuiltinScalarFunction, Expr, Operator};
 use datatypes::schema::Schema;
 use snafu::{ensure, OptionExt};
@@ -61,7 +62,7 @@ pub(crate) fn to_df_expr(
         | RexType::Cast(_)
         | RexType::Subquery(_)
         | RexType::Enum(_) => UnsupportedExprSnafu {
-            name: format!("substrait expression {:?}", expr_rex_type),
+            name: format!("substrait expression {expr_rex_type:?}"),
         }
         .fail()?,
     }
@@ -109,7 +110,7 @@ pub fn convert_scalar_function(
     let fn_name = ctx
         .find_scalar_fn(anchor)
         .with_context(|| InvalidParametersSnafu {
-            reason: format!("Unregistered scalar function reference: {}", anchor),
+            reason: format!("Unregistered scalar function reference: {anchor}"),
         })?;
 
     // convenient util
@@ -331,19 +332,19 @@ pub fn convert_scalar_function(
         // skip Cast and TryCast, is covered in substrait::Cast.
         "sort" | "sort_des" => {
             ensure_arg_len(1)?;
-            Expr::Sort {
+            Expr::Sort(Sort {
                 expr: Box::new(inputs.pop_front().unwrap()),
                 asc: false,
                 nulls_first: false,
-            }
+            })
         }
         "sort_asc" => {
             ensure_arg_len(1)?;
-            Expr::Sort {
+            Expr::Sort(Sort {
                 expr: Box::new(inputs.pop_front().unwrap()),
                 asc: true,
                 nulls_first: false,
-            }
+            })
         }
         // those are datafusion built-in "scalar functions".
         "abs"
@@ -435,7 +436,7 @@ pub fn convert_scalar_function(
         // skip Wildcard, unimplemented.
         // end other direct expr
         _ => UnsupportedExprSnafu {
-            name: format!("scalar function {}", fn_name),
+            name: format!("scalar function {fn_name}"),
         }
         .fail()?,
     };
@@ -537,11 +538,11 @@ pub fn expression_from_df_expr(
             name: expr.to_string(),
         }
         .fail()?,
-        Expr::Sort {
+        Expr::Sort(Sort {
             expr,
             asc,
             nulls_first: _,
-        } => {
+        }) => {
             let expr = expression_from_df_expr(ctx, expr, schema)?;
             let arguments = utils::expression_to_argument(vec![expr]);
             let op_name = if *asc { "sort_asc" } else { "sort_des" };
@@ -577,6 +578,7 @@ pub fn expression_from_df_expr(
         | Expr::Exists { .. }
         | Expr::InSubquery { .. }
         | Expr::ScalarSubquery(..)
+        | Expr::Placeholder { .. }
         | Expr::QualifiedWildcard { .. } => todo!(),
         Expr::GroupingSet(_) => UnsupportedExprSnafu {
             name: expr.to_string(),
@@ -595,8 +597,8 @@ pub fn convert_column(column: &Column, schema: &Schema) -> Result<FieldReference
         schema
             .column_index_by_name(column_name)
             .with_context(|| MissingFieldSnafu {
-                field: format!("{:?}", column),
-                plan: format!("schema: {:?}", schema),
+                field: format!("{column:?}"),
+                plan: format!("schema: {schema:?}"),
             })?;
 
     Ok(FieldReference {
@@ -646,6 +648,8 @@ mod utils {
             Operator::BitwiseShiftRight => "bitwise_shift_right",
             Operator::BitwiseShiftLeft => "bitwise_shift_left",
             Operator::StringConcat => "string_concat",
+            Operator::ILike => "i_like",
+            Operator::NotILike => "not_i_like",
         }
     }
 

src/common/substrait/src/df_logical.rs

@@ -19,7 +19,7 @@ use catalog::CatalogManagerRef;
 use common_error::prelude::BoxedError;
 use common_telemetry::debug;
 use datafusion::arrow::datatypes::SchemaRef as ArrowSchemaRef;
-use datafusion::common::ToDFSchema;
+use datafusion::common::{DFField, DFSchema};
 use datafusion::datasource::DefaultTableSource;
 use datafusion::physical_plan::project_schema;
 use datafusion_expr::{Filter, LogicalPlan, TableScan, TableSource};
@@ -236,7 +236,7 @@ impl DFLogicalSubstraitConvertor {
             .map_err(BoxedError::new)
             .context(InternalSnafu)?
             .context(TableNotFoundSnafu {
-                name: format!("{}.{}.{}", catalog_name, schema_name, table_name),
+                name: format!("{catalog_name}.{schema_name}.{table_name}"),
             })?;
         let adapter = Arc::new(DefaultTableSource::new(Arc::new(
             DfTableProviderAdapter::new(table_ref),
@@ -262,16 +262,26 @@ impl DFLogicalSubstraitConvertor {
         };
 
         // Calculate the projected schema
-        let projected_schema = project_schema(&stored_schema, projection.as_ref())
-            .context(DFInternalSnafu)?
-            .to_dfschema_ref()
-            .context(DFInternalSnafu)?;
+        let qualified = &format!("{catalog_name}.{schema_name}.{table_name}");
+        let projected_schema = Arc::new(
+            project_schema(&stored_schema, projection.as_ref())
+                .and_then(|x| {
+                    DFSchema::new_with_metadata(
+                        x.fields()
+                            .iter()
+                            .map(|f| DFField::from_qualified(qualified, f.clone()))
+                            .collect(),
+                        x.metadata().clone(),
+                    )
+                })
+                .context(DFInternalSnafu)?,
+        );
 
         ctx.set_df_schema(projected_schema.clone());
 
         // TODO(ruihang): Support limit(fetch)
         Ok(LogicalPlan::TableScan(TableScan {
-            table_name: format!("{}.{}.{}", catalog_name, schema_name, table_name),
+            table_name: format!("{catalog_name}.{schema_name}.{table_name}"),
             source: adapter,
             projection,
             projected_schema,
@@ -385,10 +395,10 @@ impl DFLogicalSubstraitConvertor {
             | LogicalPlan::Values(_)
             | LogicalPlan::Explain(_)
             | LogicalPlan::Analyze(_)
-            | LogicalPlan::Extension(_) => InvalidParametersSnafu {
+            | LogicalPlan::Extension(_)
+            | LogicalPlan::Prepare(_) => InvalidParametersSnafu {
                 reason: format!(
-                    "Trying to convert DDL/DML plan to substrait proto, plan: {:?}",
-                    plan
+                    "Trying to convert DDL/DML plan to substrait proto, plan: {plan:?}",
                 ),
             }
             .fail()?,
@@ -562,7 +572,7 @@ mod test {
         let proto = convertor.encode(plan.clone()).unwrap();
         let tripped_plan = convertor.decode(proto, catalog).unwrap();
 
-        assert_eq!(format!("{:?}", plan), format!("{:?}", tripped_plan));
+        assert_eq!(format!("{plan:?}"), format!("{tripped_plan:?}"));
     }
 
     #[tokio::test]
@@ -596,8 +606,7 @@ mod test {
 
         let table_scan_plan = LogicalPlan::TableScan(TableScan {
             table_name: format!(
-                "{}.{}.{}",
-                DEFAULT_CATALOG_NAME, DEFAULT_SCHEMA_NAME, DEFAULT_TABLE_NAME
+                "{DEFAULT_CATALOG_NAME}.{DEFAULT_SCHEMA_NAME}.{DEFAULT_TABLE_NAME}",
             ),
             source: adapter,
             projection: Some(projection),

src/common/substrait/src/types.rs

@@ -87,7 +87,7 @@ pub fn to_concrete_type(ty: &SType) -> Result<(ConcreteDataType, bool)> {
         | Kind::List(_)
         | Kind::Map(_)
         | Kind::UserDefinedTypeReference(_) => UnsupportedSubstraitTypeSnafu {
-            ty: format!("{:?}", kind),
+            ty: format!("{kind:?}"),
         }
         .fail(),
     }
@@ -154,7 +154,7 @@ pub(crate) fn scalar_value_as_literal_type(v: &ScalarValue) -> Result<LiteralTyp
             // TODO(LFC): Implement other conversions: ScalarValue => LiteralType
             _ => {
                 return error::UnsupportedExprSnafu {
-                    name: format!("{:?}", v),
+                    name: format!("{v:?}"),
                 }
                 .fail()
             }
@@ -177,7 +177,7 @@ pub(crate) fn literal_type_to_scalar_value(t: LiteralType) -> Result<ScalarValue
             // TODO(LFC): Implement other conversions: Kind => ScalarValue
             _ => {
                 return error::UnsupportedSubstraitTypeSnafu {
-                    ty: format!("{:?}", kind),
+                    ty: format!("{kind:?}"),
                 }
                 .fail()
             }
@@ -194,7 +194,7 @@ pub(crate) fn literal_type_to_scalar_value(t: LiteralType) -> Result<ScalarValue
         // TODO(LFC): Implement other conversions: LiteralType => ScalarValue
         _ => {
             return error::UnsupportedSubstraitTypeSnafu {
-                ty: format!("{:?}", t),
+                ty: format!("{t:?}"),
             }
             .fail()
         }

src/common/telemetry/Cargo.toml

@@ -1,8 +1,8 @@
 [package]
 name = "common-telemetry"
-version = "0.1.0"
-edition = "2021"
-license = "Apache-2.0"
+version.workspace = true
+edition.workspace = true
+license.workspace = true
 
 [features]
 console = ["console-subscriber"]

src/common/telemetry/src/panic_hook.rs

@@ -28,7 +28,7 @@ pub fn set_panic_hook() {
     let default_hook = panic::take_hook();
     panic::set_hook(Box::new(move |panic| {
         let backtrace = Backtrace::new();
-        let backtrace = format!("{:?}", backtrace);
+        let backtrace = format!("{backtrace:?}");
         if let Some(location) = panic.location() {
             tracing::error!(
                 message = %panic,

src/common/time/Cargo.toml

@@ -1,8 +1,8 @@
 [package]
 name = "common-time"
-version = "0.1.0"
-edition = "2021"
-license = "Apache-2.0"
+version.workspace = true
+edition.workspace = true
+license.workspace = true
 
 [dependencies]
 chrono = "0.4"

src/datanode/Cargo.toml

@@ -1,16 +1,18 @@
 [package]
 name = "datanode"
-version = "0.1.0"
-edition = "2021"
-license = "Apache-2.0"
+version.workspace = true
+edition.workspace = true
+license.workspace = true
 
 [features]
 default = ["python"]
 python = ["dep:script"]
 
 [dependencies]
+async-stream.workspace = true
+async-trait.workspace = true
 api = { path = "../api" }
-async-trait = "0.1"
+arrow-flight.workspace = true
 axum = "0.6"
 axum-macros = "0.3"
 backon = "0.2"
@@ -25,7 +27,7 @@ common-recordbatch = { path = "../common/recordbatch" }
 common-runtime = { path = "../common/runtime" }
 common-telemetry = { path = "../common/telemetry" }
 common-time = { path = "../common/time" }
-datafusion = "14.0.0"
+datafusion.workspace = true
 datatypes = { path = "../datatypes" }
 futures = "0.3"
 hyper = { version = "0.14", features = ["full"] }
@@ -35,6 +37,8 @@ meta-srv = { path = "../meta-srv", features = ["mock"] }
 metrics = "0.20"
 mito = { path = "../mito", features = ["test"] }
 object-store = { path = "../object-store" }
+pin-project = "1.0"
+prost = "0.11"
 query = { path = "../query" }
 script = { path = "../script", features = ["python"], optional = true }
 serde = "1.0"
@@ -57,5 +61,5 @@ tower-http = { version = "0.3", features = ["full"] }
 axum-test-helper = { git = "https://github.com/sunng87/axum-test-helper.git", branch = "patch-1" }
 client = { path = "../client" }
 common-query = { path = "../common/query" }
-datafusion-common = "14.0.0"
+datafusion-common.workspace = true
 tempdir = "0.3"

src/datanode/src/error.rs

@@ -36,11 +36,8 @@ pub enum Error {
         source: substrait::error::Error,
     },
 
-    #[snafu(display("Failed to execute physical plan, source: {}", source))]
-    ExecutePhysicalPlan {
-        #[snafu(backtrace)]
-        source: query::error::Error,
-    },
+    #[snafu(display("Incorrect internal state: {}", state))]
+    IncorrectInternalState { state: String, backtrace: Backtrace },
 
     #[snafu(display("Failed to create catalog list, source: {}", source))]
     NewCatalog {
@@ -155,14 +152,11 @@ pub enum Error {
 
     #[snafu(display("Failed to init backend, config: {:#?}, source: {}", config, source))]
     InitBackend {
-        config: ObjectStoreConfig,
+        config: Box<ObjectStoreConfig>,
         source: object_store::Error,
         backtrace: Backtrace,
     },
 
-    #[snafu(display("Unsupported expr type: {}", name))]
-    UnsupportedExpr { name: String },
-
     #[snafu(display("Runtime resource error, source: {}", source))]
     RuntimeResource {
         #[snafu(backtrace)]
@@ -211,12 +205,6 @@ pub enum Error {
         source: catalog::error::Error,
     },
 
-    #[snafu(display("Failed to decode as physical plan, source: {}", source))]
-    IntoPhysicalPlan {
-        #[snafu(backtrace)]
-        source: common_grpc::Error,
-    },
-
     #[snafu(display("Failed to convert alter expr to request: {}", source))]
     AlterExprToRequest {
         #[snafu(backtrace)]
@@ -276,9 +264,6 @@ pub enum Error {
         source: common_grpc_expr::error::Error,
     },
 
-    #[snafu(display("Insert batch is empty"))]
-    EmptyInsertBatch,
-
     #[snafu(display(
         "Table id provider not found, cannot execute SQL directly on datanode in distributed mode"
     ))]
@@ -301,6 +286,33 @@ pub enum Error {
 
     #[snafu(display("Missing node id option in distributed mode"))]
     MissingMetasrvOpts { backtrace: Backtrace },
+
+    #[snafu(display("Invalid Flight ticket, source: {}", source))]
+    InvalidFlightTicket {
+        source: api::DecodeError,
+        backtrace: Backtrace,
+    },
+
+    #[snafu(display("Missing required field: {}", name))]
+    MissingRequiredField { name: String, backtrace: Backtrace },
+
+    #[snafu(display("Failed to poll recordbatch stream, source: {}", source))]
+    PollRecordbatchStream {
+        #[snafu(backtrace)]
+        source: common_recordbatch::error::Error,
+    },
+
+    #[snafu(display("Invalid FlightData, source: {}", source))]
+    InvalidFlightData {
+        #[snafu(backtrace)]
+        source: common_grpc::Error,
+    },
+
+    #[snafu(display("Failed to do Flight get, source: {}", source))]
+    FlightGet {
+        source: tonic::Status,
+        backtrace: Backtrace,
+    },
 }
 
 pub type Result<T> = std::result::Result<T, Error>;
@@ -310,7 +322,6 @@ impl ErrorExt for Error {
         match self {
             Error::ExecuteSql { source } => source.status_code(),
             Error::DecodeLogicalPlan { source } => source.status_code(),
-            Error::ExecutePhysicalPlan { source } => source.status_code(),
             Error::NewCatalog { source } => source.status_code(),
             Error::FindTable { source, .. } => source.status_code(),
             Error::CreateTable { source, .. }
@@ -328,7 +339,11 @@ impl ErrorExt for Error {
             }
 
             Error::AlterExprToRequest { source, .. }
-            | Error::CreateExprToRequest { source, .. } => source.status_code(),
+            | Error::CreateExprToRequest { source }
+            | Error::InsertData { source } => source.status_code(),
+
+            Error::InvalidFlightData { source } => source.status_code(),
+
             Error::CreateSchema { source, .. }
             | Error::ConvertSchema { source, .. }
             | Error::VectorComputation { source } => source.status_code(),
@@ -351,9 +366,11 @@ impl ErrorExt for Error {
             | Error::CreateDir { .. }
             | Error::InsertSystemCatalog { .. }
             | Error::RegisterSchema { .. }
-            | Error::IntoPhysicalPlan { .. }
-            | Error::UnsupportedExpr { .. }
-            | Error::Catalog { .. } => StatusCode::Internal,
+            | Error::Catalog { .. }
+            | Error::MissingRequiredField { .. }
+            | Error::FlightGet { .. }
+            | Error::InvalidFlightTicket { .. }
+            | Error::IncorrectInternalState { .. } => StatusCode::Internal,
 
             Error::InitBackend { .. } => StatusCode::StorageUnavailable,
             Error::OpenLogStore { source } => source.status_code(),
@@ -361,13 +378,12 @@ impl ErrorExt for Error {
             Error::OpenStorageEngine { source } => source.status_code(),
             Error::RuntimeResource { .. } => StatusCode::RuntimeResourcesExhausted,
             Error::MetaClientInit { source, .. } => source.status_code(),
-            Error::InsertData { source, .. } => source.status_code(),
-            Error::EmptyInsertBatch => StatusCode::InvalidArguments,
             Error::TableIdProviderNotFound { .. } => StatusCode::Unsupported,
             Error::BumpTableId { source, .. } => source.status_code(),
             Error::MissingNodeId { .. } => StatusCode::InvalidArguments,
             Error::MissingMetasrvOpts { .. } => StatusCode::InvalidArguments,
             Error::StartLogStore { source, .. } => source.status_code(),
+            Error::PollRecordbatchStream { source } => source.status_code(),
         }
     }
 

src/datanode/src/instance.rs

@@ -48,6 +48,7 @@ use crate::heartbeat::HeartbeatTask;
 use crate::script::ScriptExecutor;
 use crate::sql::SqlHandler;
 
+mod flight;
 mod grpc;
 mod script;
 mod sql;
@@ -233,7 +234,7 @@ pub(crate) async fn new_fs_object_store(data_dir: &str) -> Result<ObjectStore> {
         .context(error::CreateDirSnafu { dir: &data_dir })?;
     info!("The file storage directory is: {}", &data_dir);
 
-    let atomic_write_dir = format!("{}/.tmp/", data_dir);
+    let atomic_write_dir = format!("{data_dir}/.tmp/");
 
     let accessor = FsBuilder::default()
         .root(&data_dir)

src/datanode/src/instance/flight.rs

@@ -0,0 +1,472 @@
+// Copyright 2022 Greptime Team
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+mod stream;
+
+use std::pin::Pin;
+
+use api::v1::ddl_request::Expr as DdlExpr;
+use api::v1::object_expr::Request as GrpcRequest;
+use api::v1::query_request::Query;
+use api::v1::{DdlRequest, InsertRequest, ObjectExpr};
+use arrow_flight::flight_service_server::FlightService;
+use arrow_flight::{
+    Action, ActionType, Criteria, Empty, FlightData, FlightDescriptor, FlightInfo,
+    HandshakeRequest, HandshakeResponse, PutResult, SchemaResult, Ticket,
+};
+use async_trait::async_trait;
+use common_catalog::consts::DEFAULT_CATALOG_NAME;
+use common_grpc::flight::{FlightEncoder, FlightMessage};
+use common_query::Output;
+use futures::Stream;
+use prost::Message;
+use session::context::QueryContext;
+use snafu::{OptionExt, ResultExt};
+use tonic::{Request, Response, Streaming};
+
+use crate::error::{
+    CatalogSnafu, ExecuteSqlSnafu, InsertDataSnafu, InsertSnafu, InvalidFlightTicketSnafu,
+    MissingRequiredFieldSnafu, Result, TableNotFoundSnafu,
+};
+use crate::instance::flight::stream::FlightRecordBatchStream;
+use crate::instance::Instance;
+
+type TonicResult<T> = std::result::Result<T, tonic::Status>;
+type TonicStream<T> = Pin<Box<dyn Stream<Item = TonicResult<T>> + Send + Sync + 'static>>;
+
+#[async_trait]
+impl FlightService for Instance {
+    type HandshakeStream = TonicStream<HandshakeResponse>;
+
+    async fn handshake(
+        &self,
+        _request: Request<Streaming<HandshakeRequest>>,
+    ) -> TonicResult<Response<Self::HandshakeStream>> {
+        Err(tonic::Status::unimplemented("Not yet implemented"))
+    }
+
+    type ListFlightsStream = TonicStream<FlightInfo>;
+
+    async fn list_flights(
+        &self,
+        _request: Request<Criteria>,
+    ) -> TonicResult<Response<Self::ListFlightsStream>> {
+        Err(tonic::Status::unimplemented("Not yet implemented"))
+    }
+    async fn get_flight_info(
+        &self,
+        _request: Request<FlightDescriptor>,
+    ) -> TonicResult<Response<FlightInfo>> {
+        Err(tonic::Status::unimplemented("Not yet implemented"))
+    }
+    async fn get_schema(
+        &self,
+        _request: Request<FlightDescriptor>,
+    ) -> TonicResult<Response<SchemaResult>> {
+        Err(tonic::Status::unimplemented("Not yet implemented"))
+    }
+
+    type DoGetStream = TonicStream<FlightData>;
+
+    async fn do_get(&self, request: Request<Ticket>) -> TonicResult<Response<Self::DoGetStream>> {
+        let ticket = request.into_inner().ticket;
+        let request = ObjectExpr::decode(ticket.as_slice())
+            .context(InvalidFlightTicketSnafu)?
+            .request
+            .context(MissingRequiredFieldSnafu { name: "request" })?;
+        let output = match request {
+            GrpcRequest::Insert(request) => self.handle_insert(request).await?,
+            GrpcRequest::Query(query_request) => {
+                let query = query_request
+                    .query
+                    .context(MissingRequiredFieldSnafu { name: "query" })?;
+                self.handle_query(query).await?
+            }
+            GrpcRequest::Ddl(request) => self.handle_ddl(request).await?,
+        };
+        let stream = to_flight_data_stream(output);
+        Ok(Response::new(stream))
+    }
+
+    type DoPutStream = TonicStream<PutResult>;
+
+    async fn do_put(
+        &self,
+        _request: Request<Streaming<FlightData>>,
+    ) -> TonicResult<Response<Self::DoPutStream>> {
+        Err(tonic::Status::unimplemented("Not yet implemented"))
+    }
+
+    type DoExchangeStream = TonicStream<FlightData>;
+
+    async fn do_exchange(
+        &self,
+        _request: Request<Streaming<FlightData>>,
+    ) -> TonicResult<Response<Self::DoExchangeStream>> {
+        Err(tonic::Status::unimplemented("Not yet implemented"))
+    }
+
+    type DoActionStream = TonicStream<arrow_flight::Result>;
+
+    async fn do_action(
+        &self,
+        _request: Request<Action>,
+    ) -> TonicResult<Response<Self::DoActionStream>> {
+        Err(tonic::Status::unimplemented("Not yet implemented"))
+    }
+
+    type ListActionsStream = TonicStream<ActionType>;
+
+    async fn list_actions(
+        &self,
+        _request: Request<Empty>,
+    ) -> TonicResult<Response<Self::ListActionsStream>> {
+        Err(tonic::Status::unimplemented("Not yet implemented"))
+    }
+}
+
+impl Instance {
+    async fn handle_query(&self, query: Query) -> Result<Output> {
+        Ok(match query {
+            Query::Sql(sql) => {
+                let stmt = self
+                    .query_engine
+                    .sql_to_statement(&sql)
+                    .context(ExecuteSqlSnafu)?;
+                self.execute_stmt(stmt, QueryContext::arc()).await?
+            }
+            Query::LogicalPlan(plan) => self.execute_logical(plan).await?,
+        })
+    }
+
+    pub async fn handle_insert(&self, request: InsertRequest) -> Result<Output> {
+        let table_name = &request.table_name.clone();
+        // TODO(LFC): InsertRequest should carry catalog name, too.
+        let table = self
+            .catalog_manager
+            .table(DEFAULT_CATALOG_NAME, &request.schema_name, table_name)
+            .context(CatalogSnafu)?
+            .context(TableNotFoundSnafu { table_name })?;
+
+        let request = common_grpc_expr::insert::to_table_insert_request(request, table.schema())
+            .context(InsertDataSnafu)?;
+
+        let affected_rows = table
+            .insert(request)
+            .await
+            .context(InsertSnafu { table_name })?;
+        Ok(Output::AffectedRows(affected_rows))
+    }
+
+    async fn handle_ddl(&self, request: DdlRequest) -> Result<Output> {
+        let expr = request
+            .expr
+            .context(MissingRequiredFieldSnafu { name: "expr" })?;
+        match expr {
+            DdlExpr::CreateTable(expr) => self.handle_create(expr).await,
+            DdlExpr::Alter(expr) => self.handle_alter(expr).await,
+            DdlExpr::CreateDatabase(expr) => self.handle_create_database(expr).await,
+            DdlExpr::DropTable(expr) => self.handle_drop_table(expr).await,
+        }
+    }
+}
+
+fn to_flight_data_stream(output: Output) -> TonicStream<FlightData> {
+    match output {
+        Output::Stream(stream) => {
+            let stream = FlightRecordBatchStream::new(stream);
+            Box::pin(stream) as _
+        }
+        Output::RecordBatches(x) => {
+            let stream = FlightRecordBatchStream::new(x.as_stream());
+            Box::pin(stream) as _
+        }
+        Output::AffectedRows(rows) => {
+            let stream = tokio_stream::once(Ok(
+                FlightEncoder::default().encode(FlightMessage::AffectedRows(rows))
+            ));
+            Box::pin(stream) as _
+        }
+    }
+}
+
+#[cfg(test)]
+mod test {
+    use api::v1::column::{SemanticType, Values};
+    use api::v1::{
+        alter_expr, AddColumn, AddColumns, AlterExpr, Column, ColumnDataType, ColumnDef,
+        CreateDatabaseExpr, CreateTableExpr, QueryRequest,
+    };
+    use client::RpcOutput;
+    use common_grpc::flight;
+    use common_recordbatch::RecordBatches;
+    use datatypes::prelude::*;
+
+    use super::*;
+    use crate::tests::test_util::{self, MockInstance};
+
+    async fn boarding(instance: &MockInstance, ticket: Request<Ticket>) -> RpcOutput {
+        let response = instance.inner().do_get(ticket).await.unwrap();
+        let result = flight::flight_data_to_object_result(response)
+            .await
+            .unwrap();
+        result.try_into().unwrap()
+    }
+
+    #[tokio::test(flavor = "multi_thread")]
+    async fn test_handle_ddl() {
+        let instance = MockInstance::new("test_handle_ddl").await;
+
+        let ticket = Request::new(Ticket {
+            ticket: ObjectExpr {
+                request: Some(GrpcRequest::Ddl(DdlRequest {
+                    expr: Some(DdlExpr::CreateDatabase(CreateDatabaseExpr {
+                        database_name: "my_database".to_string(),
+                    })),
+                })),
+            }
+            .encode_to_vec(),
+        });
+
+        let output = boarding(&instance, ticket).await;
+        assert!(matches!(output, RpcOutput::AffectedRows(1)));
+
+        let ticket = Request::new(Ticket {
+            ticket: ObjectExpr {
+                request: Some(GrpcRequest::Ddl(DdlRequest {
+                    expr: Some(DdlExpr::CreateTable(CreateTableExpr {
+                        catalog_name: "greptime".to_string(),
+                        schema_name: "my_database".to_string(),
+                        table_name: "my_table".to_string(),
+                        desc: "blabla".to_string(),
+                        column_defs: vec![
+                            ColumnDef {
+                                name: "a".to_string(),
+                                datatype: ColumnDataType::String as i32,
+                                is_nullable: true,
+                                default_constraint: vec![],
+                            },
+                            ColumnDef {
+                                name: "ts".to_string(),
+                                datatype: ColumnDataType::TimestampMillisecond as i32,
+                                is_nullable: false,
+                                default_constraint: vec![],
+                            },
+                        ],
+                        time_index: "ts".to_string(),
+                        ..Default::default()
+                    })),
+                })),
+            }
+            .encode_to_vec(),
+        });
+
+        let output = boarding(&instance, ticket).await;
+        assert!(matches!(output, RpcOutput::AffectedRows(1)));
+
+        let ticket = Request::new(Ticket {
+            ticket: ObjectExpr {
+                request: Some(GrpcRequest::Ddl(DdlRequest {
+                    expr: Some(DdlExpr::Alter(AlterExpr {
+                        catalog_name: "greptime".to_string(),
+                        schema_name: "my_database".to_string(),
+                        table_name: "my_table".to_string(),
+                        kind: Some(alter_expr::Kind::AddColumns(AddColumns {
+                            add_columns: vec![AddColumn {
+                                column_def: Some(ColumnDef {
+                                    name: "b".to_string(),
+                                    datatype: ColumnDataType::Int32 as i32,
+                                    is_nullable: true,
+                                    default_constraint: vec![],
+                                }),
+                                is_key: true,
+                            }],
+                        })),
+                    })),
+                })),
+            }
+            .encode_to_vec(),
+        });
+
+        let output = boarding(&instance, ticket).await;
+        assert!(matches!(output, RpcOutput::AffectedRows(0)));
+
+        let output = instance
+            .inner()
+            .execute_sql(
+                "INSERT INTO my_database.my_table (a, b, ts) VALUES ('s', 1, 1672384140000)",
+                QueryContext::arc(),
+            )
+            .await
+            .unwrap();
+        assert!(matches!(output, Output::AffectedRows(1)));
+
+        let output = instance
+            .inner()
+            .execute_sql(
+                "SELECT ts, a, b FROM my_database.my_table",
+                QueryContext::arc(),
+            )
+            .await
+            .unwrap();
+        let Output::Stream(stream) = output else { unreachable!() };
+        let recordbatches = RecordBatches::try_collect(stream).await.unwrap();
+        let expected = "\
++---------------------+---+---+
+| ts                  | a | b |
++---------------------+---+---+
+| 2022-12-30T07:09:00 | s | 1 |
++---------------------+---+---+";
+        assert_eq!(recordbatches.pretty_print().unwrap(), expected);
+    }
+
+    #[tokio::test(flavor = "multi_thread")]
+    async fn test_handle_insert() {
+        let instance = MockInstance::new("test_handle_insert").await;
+        test_util::create_test_table(
+            &instance,
+            ConcreteDataType::timestamp_millisecond_datatype(),
+        )
+        .await
+        .unwrap();
+
+        let insert = InsertRequest {
+            schema_name: "public".to_string(),
+            table_name: "demo".to_string(),
+            columns: vec![
+                Column {
+                    column_name: "host".to_string(),
+                    values: Some(Values {
+                        string_values: vec![
+                            "host1".to_string(),
+                            "host2".to_string(),
+                            "host3".to_string(),
+                        ],
+                        ..Default::default()
+                    }),
+                    semantic_type: SemanticType::Tag as i32,
+                    datatype: ColumnDataType::String as i32,
+                    ..Default::default()
+                },
+                Column {
+                    column_name: "cpu".to_string(),
+                    values: Some(Values {
+                        f64_values: vec![1.0, 3.0],
+                        ..Default::default()
+                    }),
+                    null_mask: vec![2],
+                    semantic_type: SemanticType::Field as i32,
+                    datatype: ColumnDataType::Float64 as i32,
+                },
+                Column {
+                    column_name: "ts".to_string(),
+                    values: Some(Values {
+                        ts_millisecond_values: vec![1672384140000, 1672384141000, 1672384142000],
+                        ..Default::default()
+                    }),
+                    semantic_type: SemanticType::Timestamp as i32,
+                    datatype: ColumnDataType::TimestampMillisecond as i32,
+                    ..Default::default()
+                },
+            ],
+            row_count: 3,
+            ..Default::default()
+        };
+
+        let ticket = Request::new(Ticket {
+            ticket: ObjectExpr {
+                request: Some(GrpcRequest::Insert(insert)),
+            }
+            .encode_to_vec(),
+        });
+
+        let output = boarding(&instance, ticket).await;
+        assert!(matches!(output, RpcOutput::AffectedRows(3)));
+
+        let output = instance
+            .inner()
+            .execute_sql("SELECT ts, host, cpu FROM demo", QueryContext::arc())
+            .await
+            .unwrap();
+        let Output::Stream(stream) = output else { unreachable!() };
+        let recordbatches = RecordBatches::try_collect(stream).await.unwrap();
+        let expected = "\
++---------------------+-------+-----+
+| ts                  | host  | cpu |
++---------------------+-------+-----+
+| 2022-12-30T07:09:00 | host1 | 1   |
+| 2022-12-30T07:09:01 | host2 |     |
+| 2022-12-30T07:09:02 | host3 | 3   |
++---------------------+-------+-----+";
+        assert_eq!(recordbatches.pretty_print().unwrap(), expected);
+    }
+
+    #[tokio::test(flavor = "multi_thread")]
+    async fn test_handle_query() {
+        let instance = MockInstance::new("test_handle_query").await;
+        test_util::create_test_table(
+            &instance,
+            ConcreteDataType::timestamp_millisecond_datatype(),
+        )
+        .await
+        .unwrap();
+
+        let ticket = Request::new(Ticket {
+            ticket: ObjectExpr {
+                request: Some(GrpcRequest::Query(QueryRequest {
+                    query: Some(Query::Sql(
+                        "INSERT INTO demo(host, cpu, memory, ts) VALUES \
+                            ('host1', 66.6, 1024, 1672201025000),\
+                            ('host2', 88.8, 333.3, 1672201026000)"
+                            .to_string(),
+                    )),
+                })),
+            }
+            .encode_to_vec(),
+        });
+
+        let output = boarding(&instance, ticket).await;
+        assert!(matches!(output, RpcOutput::AffectedRows(2)));
+
+        let ticket = Request::new(Ticket {
+            ticket: ObjectExpr {
+                request: Some(GrpcRequest::Query(QueryRequest {
+                    query: Some(Query::Sql(
+                        "SELECT ts, host, cpu, memory FROM demo".to_string(),
+                    )),
+                })),
+            }
+            .encode_to_vec(),
+        });
+
+        let response = instance.inner().do_get(ticket).await.unwrap();
+        let result = flight::flight_data_to_object_result(response)
+            .await
+            .unwrap();
+        let raw_data = result.flight_data;
+        let messages = flight::raw_flight_data_to_message(raw_data).unwrap();
+        assert_eq!(messages.len(), 2);
+
+        let recordbatch = flight::flight_messages_to_recordbatches(messages).unwrap();
+        let expected = "\
++---------------------+-------+------+--------+
+| ts                  | host  | cpu  | memory |
++---------------------+-------+------+--------+
+| 2022-12-28T04:17:05 | host1 | 66.6 | 1024   |
+| 2022-12-28T04:17:06 | host2 | 88.8 | 333.3  |
++---------------------+-------+------+--------+";
+        let actual = recordbatch.pretty_print().unwrap();
+        assert_eq!(actual, expected);
+    }
+}

src/datanode/src/instance/flight/stream.rs

@@ -0,0 +1,178 @@
+// Copyright 2022 Greptime Team
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+use std::pin::Pin;
+use std::task::{Context, Poll};
+
+use arrow_flight::FlightData;
+use common_grpc::flight::{FlightEncoder, FlightMessage};
+use common_recordbatch::SendableRecordBatchStream;
+use common_telemetry::warn;
+use futures::channel::mpsc;
+use futures::channel::mpsc::Sender;
+use futures::{SinkExt, Stream, StreamExt};
+use pin_project::{pin_project, pinned_drop};
+use snafu::ResultExt;
+use tokio::task::JoinHandle;
+
+use crate::error;
+use crate::instance::flight::TonicResult;
+
+#[pin_project(PinnedDrop)]
+pub(super) struct FlightRecordBatchStream {
+    #[pin]
+    rx: mpsc::Receiver<Result<FlightMessage, tonic::Status>>,
+    join_handle: JoinHandle<()>,
+    done: bool,
+    encoder: FlightEncoder,
+}
+
+impl FlightRecordBatchStream {
+    pub(super) fn new(recordbatches: SendableRecordBatchStream) -> Self {
+        let (tx, rx) = mpsc::channel::<TonicResult<FlightMessage>>(1);
+        let join_handle =
+            common_runtime::spawn_read(
+                async move { Self::flight_data_stream(recordbatches, tx).await },
+            );
+        Self {
+            rx,
+            join_handle,
+            done: false,
+            encoder: FlightEncoder::default(),
+        }
+    }
+
+    async fn flight_data_stream(
+        mut recordbatches: SendableRecordBatchStream,
+        mut tx: Sender<TonicResult<FlightMessage>>,
+    ) {
+        let schema = recordbatches.schema();
+        if let Err(e) = tx.send(Ok(FlightMessage::Schema(schema))).await {
+            warn!("stop sending Flight data, err: {e}");
+            return;
+        }
+
+        while let Some(batch_or_err) = recordbatches.next().await {
+            match batch_or_err {
+                Ok(recordbatch) => {
+                    if let Err(e) = tx.send(Ok(FlightMessage::Recordbatch(recordbatch))).await {
+                        warn!("stop sending Flight data, err: {e}");
+                        return;
+                    }
+                }
+                Err(e) => {
+                    let e = Err(e).context(error::PollRecordbatchStreamSnafu);
+                    if let Err(e) = tx.send(e.map_err(|x| x.into())).await {
+                        warn!("stop sending Flight data, err: {e}");
+                    }
+                    return;
+                }
+            }
+        }
+    }
+}
+
+#[pinned_drop]
+impl PinnedDrop for FlightRecordBatchStream {
+    fn drop(self: Pin<&mut Self>) {
+        self.join_handle.abort();
+    }
+}
+
+impl Stream for FlightRecordBatchStream {
+    type Item = TonicResult<FlightData>;
+
+    fn poll_next(self: Pin<&mut Self>, cx: &mut Context<'_>) -> Poll<Option<Self::Item>> {
+        let this = self.project();
+        if *this.done {
+            Poll::Ready(None)
+        } else {
+            match this.rx.poll_next(cx) {
+                Poll::Ready(None) => {
+                    *this.done = true;
+                    Poll::Ready(None)
+                }
+                Poll::Ready(Some(result)) => match result {
+                    Ok(flight_message) => {
+                        let flight_data = this.encoder.encode(flight_message);
+                        Poll::Ready(Some(Ok(flight_data)))
+                    }
+                    Err(e) => {
+                        *this.done = true;
+                        Poll::Ready(Some(Err(e)))
+                    }
+                },
+                Poll::Pending => Poll::Pending,
+            }
+        }
+    }
+}
+
+#[cfg(test)]
+mod test {
+    use std::sync::Arc;
+
+    use common_grpc::flight::{FlightDecoder, FlightMessage};
+    use common_recordbatch::{RecordBatch, RecordBatches};
+    use datatypes::prelude::*;
+    use datatypes::schema::{ColumnSchema, Schema};
+    use datatypes::vectors::Int32Vector;
+    use futures::StreamExt;
+
+    use super::*;
+
+    #[tokio::test]
+    async fn test_flight_record_batch_stream() {
+        let schema = Arc::new(Schema::new(vec![ColumnSchema::new(
+            "a",
+            ConcreteDataType::int32_datatype(),
+            false,
+        )]));
+
+        let v: VectorRef = Arc::new(Int32Vector::from_slice(&[1, 2]));
+        let recordbatch = RecordBatch::new(schema.clone(), vec![v]).unwrap();
+
+        let recordbatches = RecordBatches::try_new(schema.clone(), vec![recordbatch.clone()])
+            .unwrap()
+            .as_stream();
+        let mut stream = FlightRecordBatchStream::new(recordbatches);
+
+        let mut raw_data = Vec::with_capacity(2);
+        raw_data.push(stream.next().await.unwrap().unwrap());
+        raw_data.push(stream.next().await.unwrap().unwrap());
+        assert!(stream.next().await.is_none());
+        assert!(stream.done);
+
+        let decoder = &mut FlightDecoder::default();
+        let mut flight_messages = raw_data
+            .into_iter()
+            .map(|x| decoder.try_decode(x).unwrap())
+            .collect::<Vec<FlightMessage>>();
+        assert_eq!(flight_messages.len(), 2);
+
+        match flight_messages.remove(0) {
+            FlightMessage::Schema(actual_schema) => {
+                assert_eq!(actual_schema, schema);
+            }
+            _ => unreachable!(),
+        }
+
+        match flight_messages.remove(0) {
+            FlightMessage::Recordbatch(actual_recordbatch) => {
+                assert_eq!(actual_recordbatch, recordbatch);
+            }
+            _ => unreachable!(),
+        }
+    }
+}

src/datanode/src/instance/grpc.rs

@@ -12,139 +12,42 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-use std::sync::Arc;
-
-use api::result::{build_err_result, AdminResultBuilder, ObjectResultBuilder};
-use api::v1::{
-    admin_expr, object_expr, select_expr, AdminExpr, AdminResult, Column, CreateDatabaseExpr,
-    ObjectExpr, ObjectResult, SelectExpr,
-};
+use api::v1::{CreateDatabaseExpr, ObjectExpr, ObjectResult};
+use arrow_flight::flight_service_server::FlightService;
+use arrow_flight::Ticket;
 use async_trait::async_trait;
-use common_catalog::consts::DEFAULT_CATALOG_NAME;
-use common_error::ext::ErrorExt;
-use common_error::status_code::StatusCode;
-use common_grpc::select::to_object_result;
-use common_grpc_expr::insertion_expr_to_request;
+use common_error::prelude::BoxedError;
+use common_grpc::flight;
 use common_query::Output;
+use prost::Message;
 use query::plan::LogicalPlan;
-use servers::query_handler::{GrpcAdminHandler, GrpcQueryHandler};
-use session::context::QueryContext;
+use servers::query_handler::GrpcQueryHandler;
 use snafu::prelude::*;
 use substrait::{DFLogicalSubstraitConvertor, SubstraitPlan};
 use table::requests::CreateDatabaseRequest;
+use tonic::Request;
 
 use crate::error::{
-    CatalogNotFoundSnafu, CatalogSnafu, DecodeLogicalPlanSnafu, EmptyInsertBatchSnafu,
-    ExecuteSqlSnafu, InsertDataSnafu, InsertSnafu, Result, SchemaNotFoundSnafu, TableNotFoundSnafu,
-    UnsupportedExprSnafu,
+    DecodeLogicalPlanSnafu, ExecuteSqlSnafu, FlightGetSnafu, InvalidFlightDataSnafu, Result,
 };
 use crate::instance::Instance;
 
 impl Instance {
-    pub async fn execute_grpc_insert(
-        &self,
-        catalog_name: &str,
-        schema_name: &str,
-        table_name: &str,
-        insert_batches: Vec<(Vec<Column>, u32)>,
-    ) -> Result<Output> {
-        let schema_provider = self
-            .catalog_manager
-            .catalog(catalog_name)
-            .context(CatalogSnafu)?
-            .context(CatalogNotFoundSnafu { name: catalog_name })?
-            .schema(schema_name)
-            .context(CatalogSnafu)?
-            .context(SchemaNotFoundSnafu { name: schema_name })?;
-
-        ensure!(!insert_batches.is_empty(), EmptyInsertBatchSnafu);
-        let table = schema_provider
-            .table(table_name)
-            .context(CatalogSnafu)?
-            .context(TableNotFoundSnafu { table_name })?;
-
-        let insert = insertion_expr_to_request(
-            catalog_name,
-            schema_name,
-            table_name,
-            insert_batches,
-            table.clone(),
-        )
-        .context(InsertDataSnafu)?;
-
-        let affected_rows = table
-            .insert(insert)
+    async fn boarding(&self, ticket: Request<Ticket>) -> Result<ObjectResult> {
+        let response = self.do_get(ticket).await.context(FlightGetSnafu)?;
+        flight::flight_data_to_object_result(response)
             .await
-            .context(InsertSnafu { table_name })?;
-
-        Ok(Output::AffectedRows(affected_rows))
+            .context(InvalidFlightDataSnafu)
     }
 
-    async fn handle_insert(
-        &self,
-        catalog_name: &str,
-        schema_name: &str,
-        table_name: &str,
-        insert_batches: Vec<(Vec<Column>, u32)>,
-    ) -> ObjectResult {
-        match self
-            .execute_grpc_insert(catalog_name, schema_name, table_name, insert_batches)
-            .await
-        {
-            Ok(Output::AffectedRows(rows)) => ObjectResultBuilder::new()
-                .status_code(StatusCode::Success as u32)
-                .mutate_result(rows as u32, 0)
-                .build(),
-            Err(err) => {
-                common_telemetry::error!(err; "Failed to handle insert, catalog name: {}, schema name: {}, table name: {}", catalog_name, schema_name, table_name);
-                // TODO(fys): failure count
-                build_err_result(&err)
-            }
-            _ => unreachable!(),
-        }
-    }
-
-    async fn handle_select(&self, select_expr: SelectExpr) -> ObjectResult {
-        let result = self.do_handle_select(select_expr).await;
-        to_object_result(result).await
-    }
-
-    async fn do_handle_select(&self, select_expr: SelectExpr) -> Result<Output> {
-        let expr = select_expr.expr;
-        match expr {
-            Some(select_expr::Expr::Sql(sql)) => {
-                self.execute_sql(&sql, Arc::new(QueryContext::new())).await
-            }
-            Some(select_expr::Expr::LogicalPlan(plan)) => self.execute_logical(plan).await,
-            _ => UnsupportedExprSnafu {
-                name: format!("{:?}", expr),
-            }
-            .fail(),
-        }
-    }
-
-    async fn execute_create_database(
-        &self,
-        create_database_expr: CreateDatabaseExpr,
-    ) -> AdminResult {
+    pub(crate) async fn handle_create_database(&self, expr: CreateDatabaseExpr) -> Result<Output> {
         let req = CreateDatabaseRequest {
-            db_name: create_database_expr.database_name,
+            db_name: expr.database_name,
         };
-        let result = self.sql_handler.create_database(req).await;
-        match result {
-            Ok(Output::AffectedRows(rows)) => AdminResultBuilder::default()
-                .status_code(StatusCode::Success as u32)
-                .mutate_result(rows as u32, 0)
-                .build(),
-            Ok(Output::Stream(_)) | Ok(Output::RecordBatches(_)) => unreachable!(),
-            Err(err) => AdminResultBuilder::default()
-                .status_code(err.status_code() as u32)
-                .err_msg(err.to_string())
-                .build(),
-        }
+        self.sql_handler().create_database(req).await
     }
 
-    async fn execute_logical(&self, plan_bytes: Vec<u8>) -> Result<Output> {
+    pub(crate) async fn execute_logical(&self, plan_bytes: Vec<u8>) -> Result<Output> {
         let logical_plan = DFLogicalSubstraitConvertor
             .decode(plan_bytes.as_slice(), self.catalog_manager.clone())
             .context(DecodeLogicalPlanSnafu)?;
@@ -159,52 +62,15 @@ impl Instance {
 #[async_trait]
 impl GrpcQueryHandler for Instance {
     async fn do_query(&self, query: ObjectExpr) -> servers::error::Result<ObjectResult> {
-        let object_resp = match query.expr {
-            Some(object_expr::Expr::Insert(insert_expr)) => {
-                let catalog_name = DEFAULT_CATALOG_NAME;
-                let schema_name = &insert_expr.schema_name;
-                let table_name = &insert_expr.table_name;
-
-                // TODO(fys): _region_number is for later use.
-                let _region_number: u32 = insert_expr.region_number;
-
-                let insert_batches = vec![(insert_expr.columns, insert_expr.row_count)];
-                self.handle_insert(catalog_name, schema_name, table_name, insert_batches)
-                    .await
-            }
-            Some(object_expr::Expr::Select(select_expr)) => self.handle_select(select_expr).await,
-            other => {
-                return servers::error::NotSupportedSnafu {
-                    feat: format!("{:?}", other),
-                }
-                .fail();
-            }
-        };
-        Ok(object_resp)
-    }
-}
-
-#[async_trait]
-impl GrpcAdminHandler for Instance {
-    async fn exec_admin_request(&self, expr: AdminExpr) -> servers::error::Result<AdminResult> {
-        let admin_resp = match expr.expr {
-            Some(admin_expr::Expr::CreateTable(create_expr)) => {
-                self.handle_create(create_expr).await
-            }
-            Some(admin_expr::Expr::Alter(alter_expr)) => self.handle_alter(alter_expr).await,
-            Some(admin_expr::Expr::CreateDatabase(create_database_expr)) => {
-                self.execute_create_database(create_database_expr).await
-            }
-            Some(admin_expr::Expr::DropTable(drop_table_expr)) => {
-                self.handle_drop_table(drop_table_expr).await
-            }
-            other => {
-                return servers::error::NotSupportedSnafu {
-                    feat: format!("{:?}", other),
-                }
-                .fail();
-            }
-        };
-        Ok(admin_resp)
+        let ticket = Request::new(Ticket {
+            ticket: query.encode_to_vec(),
+        });
+        // TODO(LFC): Temporarily use old GRPC interface here, will get rid of them near the end of Arrow Flight adoption.
+        self.boarding(ticket)
+            .await
+            .map_err(BoxedError::new)
+            .with_context(|_| servers::error::ExecuteQuerySnafu {
+                query: format!("{query:?}"),
+            })
     }
 }

src/datanode/src/instance/sql.rs

@@ -187,8 +187,7 @@ fn table_idents_to_full_name(
         )),
         _ => error::InvalidSqlSnafu {
             msg: format!(
-                "expect table name to be <catalog>.<schema>.<table>, <schema>.<table> or <table>, actual: {}",
-                obj_name
+                "expect table name to be <catalog>.<schema>.<table>, <schema>.<table> or <table>, actual: {obj_name}",
             ),
         }.fail(),
     }
@@ -228,6 +227,13 @@ impl SqlQueryHandler for Instance {
             })
             .context(servers::error::ExecuteStatementSnafu)
     }
+
+    fn is_valid_schema(&self, catalog: &str, schema: &str) -> servers::error::Result<bool> {
+        self.catalog_manager
+            .schema(catalog, schema)
+            .map(|s| s.is_some())
+            .context(servers::error::CatalogSnafu)
+    }
 }
 
 #[cfg(test)]

src/datanode/src/server.rs

@@ -40,7 +40,7 @@ impl Services {
     pub async fn try_new(instance: InstanceRef, opts: &DatanodeOptions) -> Result<Self> {
         let grpc_runtime = Arc::new(
             RuntimeBuilder::default()
-                .worker_threads(opts.rpc_runtime_size as usize)
+                .worker_threads(opts.rpc_runtime_size)
                 .thread_name("grpc-io-handlers")
                 .build()
                 .context(RuntimeResourceSnafu)?,
@@ -54,7 +54,7 @@ impl Services {
             Mode::Distributed => {
                 let mysql_io_runtime = Arc::new(
                     RuntimeBuilder::default()
-                        .worker_threads(opts.mysql_runtime_size as usize)
+                        .worker_threads(opts.mysql_runtime_size)
                         .thread_name("mysql-io-handlers")
                         .build()
                         .context(RuntimeResourceSnafu)?,
@@ -69,7 +69,7 @@ impl Services {
         };
 
         Ok(Self {
-            grpc_server: GrpcServer::new(instance.clone(), instance, grpc_runtime),
+            grpc_server: GrpcServer::new(instance, grpc_runtime),
             mysql_server,
         })
     }

src/datanode/src/server/grpc.rs

@@ -12,144 +12,77 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-use std::sync::Arc;
-
-use api::result::AdminResultBuilder;
-use api::v1::{AdminResult, AlterExpr, CreateTableExpr, DropTableExpr};
-use common_error::prelude::{ErrorExt, StatusCode};
+use api::v1::{AlterExpr, CreateTableExpr, DropTableExpr};
 use common_grpc_expr::{alter_expr_to_request, create_expr_to_request};
 use common_query::Output;
-use common_telemetry::{error, info};
-use futures::TryFutureExt;
+use common_telemetry::info;
 use session::context::QueryContext;
 use snafu::prelude::*;
 use table::requests::DropTableRequest;
 
-use crate::error::{AlterExprToRequestSnafu, BumpTableIdSnafu, CreateExprToRequestSnafu};
+use crate::error::{
+    AlterExprToRequestSnafu, BumpTableIdSnafu, CreateExprToRequestSnafu,
+    IncorrectInternalStateSnafu, Result,
+};
 use crate::instance::Instance;
 use crate::sql::SqlRequest;
 
 impl Instance {
     /// Handle gRPC create table requests.
-    pub(crate) async fn handle_create(&self, expr: CreateTableExpr) -> AdminResult {
+    pub(crate) async fn handle_create(&self, expr: CreateTableExpr) -> Result<Output> {
+        let table_name = format!(
+            "{}.{}.{}",
+            expr.catalog_name, expr.schema_name, expr.table_name
+        );
+
+        // TODO(LFC): Revisit table id related feature, add more tests.
+        // Also merge this mod with mod instance::grpc.
+
         // Respect CreateExpr's table id and region ids if present, or allocate table id
         // from local table id provider and set region id to 0.
         let table_id = if let Some(table_id) = &expr.table_id {
             info!(
-                "Creating table {:?}.{:?}.{:?} with table id from frontend: {}",
-                expr.catalog_name, expr.schema_name, expr.table_name, table_id.id
+                "Creating table {table_name} with table id {} from Frontend",
+                table_id.id
             );
             table_id.id
         } else {
-            match self.table_id_provider.as_ref() {
-                None => {
-                    return AdminResultBuilder::default()
-                        .status_code(StatusCode::Internal as u32)
-                        .err_msg("Table id provider absent in standalone mode".to_string())
-                        .build();
-                }
-                Some(table_id_provider) => {
-                    match table_id_provider
-                        .next_table_id()
-                        .await
-                        .context(BumpTableIdSnafu)
-                    {
-                        Ok(table_id) => {
-                            info!(
-                        "Creating table {:?}.{:?}.{:?} with table id from catalog manager: {}",
-                        &expr.catalog_name, &expr.schema_name, expr.table_name, table_id
-                    );
-                            table_id
-                        }
-                        Err(e) => {
-                            error!(e;"Failed to create table id when creating table: {:?}.{:?}.{:?}", &expr.catalog_name, &expr.schema_name, expr.table_name);
-                            return AdminResultBuilder::default()
-                                .status_code(e.status_code() as u32)
-                                .err_msg(e.to_string())
-                                .build();
-                        }
-                    }
-                }
-            }
+            let provider =
+                self.table_id_provider
+                    .as_ref()
+                    .context(IncorrectInternalStateSnafu {
+                        state: "Table id provider absent in standalone mode",
+                    })?;
+            let table_id = provider.next_table_id().await.context(BumpTableIdSnafu)?;
+            info!("Creating table {table_name} with table id {table_id} from TableIdProvider");
+            table_id
         };
 
-        let request = create_expr_to_request(table_id, expr).context(CreateExprToRequestSnafu);
-        let result = futures::future::ready(request)
-            .and_then(|request| {
-                self.sql_handler().execute(
-                    SqlRequest::CreateTable(request),
-                    Arc::new(QueryContext::new()),
-                )
-            })
-            .await;
-        match result {
-            Ok(Output::AffectedRows(rows)) => AdminResultBuilder::default()
-                .status_code(StatusCode::Success as u32)
-                .mutate_result(rows as u32, 0)
-                .build(),
-            // Unreachable because we are executing "CREATE TABLE"; otherwise it's an internal bug.
-            Ok(Output::Stream(_)) | Ok(Output::RecordBatches(_)) => unreachable!(),
-            Err(err) => AdminResultBuilder::default()
-                .status_code(err.status_code() as u32)
-                .err_msg(err.to_string())
-                .build(),
-        }
+        let request = create_expr_to_request(table_id, expr).context(CreateExprToRequestSnafu)?;
+
+        self.sql_handler()
+            .execute(SqlRequest::CreateTable(request), QueryContext::arc())
+            .await
     }
 
-    pub(crate) async fn handle_alter(&self, expr: AlterExpr) -> AdminResult {
-        let request = match alter_expr_to_request(expr)
-            .context(AlterExprToRequestSnafu)
-            .transpose()
-        {
-            None => {
-                return AdminResultBuilder::default()
-                    .status_code(StatusCode::Success as u32)
-                    .mutate_result(0, 0)
-                    .build()
-            }
-            Some(req) => req,
-        };
+    pub(crate) async fn handle_alter(&self, expr: AlterExpr) -> Result<Output> {
+        let request = alter_expr_to_request(expr).context(AlterExprToRequestSnafu)?;
+        let Some(request) = request else { return Ok(Output::AffectedRows(0)) };
 
-        let result = futures::future::ready(request)
-            .and_then(|request| {
-                self.sql_handler()
-                    .execute(SqlRequest::Alter(request), Arc::new(QueryContext::new()))
-            })
-            .await;
-        match result {
-            Ok(Output::AffectedRows(rows)) => AdminResultBuilder::default()
-                .status_code(StatusCode::Success as u32)
-                .mutate_result(rows as u32, 0)
-                .build(),
-            Ok(Output::Stream(_)) | Ok(Output::RecordBatches(_)) => unreachable!(),
-            Err(err) => AdminResultBuilder::default()
-                .status_code(err.status_code() as u32)
-                .err_msg(err.to_string())
-                .build(),
-        }
+        self.sql_handler()
+            .execute(SqlRequest::Alter(request), QueryContext::arc())
+            .await
     }
 
-    pub(crate) async fn handle_drop_table(&self, expr: DropTableExpr) -> AdminResult {
+    pub(crate) async fn handle_drop_table(&self, expr: DropTableExpr) -> Result<Output> {
         let req = DropTableRequest {
             catalog_name: expr.catalog_name,
             schema_name: expr.schema_name,
             table_name: expr.table_name,
         };
-        let result = self
-            .sql_handler()
-            .execute(SqlRequest::DropTable(req), Arc::new(QueryContext::new()))
-            .await;
-        match result {
-            Ok(Output::AffectedRows(rows)) => AdminResultBuilder::default()
-                .status_code(StatusCode::Success as u32)
-                .mutate_result(rows as _, 0)
-                .build(),
-            Ok(Output::Stream(_)) | Ok(Output::RecordBatches(_)) => unreachable!(),
-            Err(err) => AdminResultBuilder::default()
-                .status_code(err.status_code() as u32)
-                .err_msg(err.to_string())
-                .build(),
-        }
+        self.sql_handler()
+            .execute(SqlRequest::DropTable(req), QueryContext::arc())
+            .await
     }
 }
 
@@ -202,8 +135,7 @@ mod tests {
         let err_msg = result.unwrap_err().to_string();
         assert!(
             err_msg.contains("Missing timestamp column"),
-            "actual: {}",
-            err_msg
+            "actual: {err_msg}",
         );
     }
 

src/datanode/src/sql.rs

@@ -96,7 +96,7 @@ impl SqlHandler {
         result
     }
 
-    pub(crate) fn get_table<'a>(&self, table_ref: &'a TableReference) -> Result<TableRef> {
+    pub(crate) fn get_table(&self, table_ref: &TableReference) -> Result<TableRef> {
         self.table_engine
             .get_table(&EngineContext::default(), table_ref)
             .with_context(|_| GetTableSnafu {
@@ -176,7 +176,7 @@ mod tests {
 
         async fn scan(
             &self,
-            _projection: &Option<Vec<usize>>,
+            _projection: Option<&Vec<usize>>,
             _filters: &[Expr],
             _limit: Option<usize>,
         ) -> TableResult<PhysicalPlanRef> {

src/datanode/src/sql/alter.rs

@@ -61,7 +61,7 @@ impl SqlHandler {
         let alter_kind = match alter_table.alter_operation() {
             AlterTableOperation::AddConstraint(table_constraint) => {
                 return error::InvalidSqlSnafu {
-                    msg: format!("unsupported table constraint {}", table_constraint),
+                    msg: format!("unsupported table constraint {table_constraint}"),
                 }
                 .fail()
             }
@@ -76,6 +76,13 @@ impl SqlHandler {
             AlterTableOperation::DropColumn { name } => AlterKind::DropColumns {
                 names: vec![name.value.clone()],
             },
+            AlterTableOperation::RenameTable { .. } => {
+                // TODO update proto to support alter table name
+                return error::InvalidSqlSnafu {
+                    msg: "rename table not unsupported yet".to_string(),
+                }
+                .fail();
+            }
         };
         Ok(AlterTableRequest {
             catalog_name: Some(table_ref.catalog.to_string()),
@@ -133,4 +140,14 @@ mod tests {
             _ => unreachable!(),
         }
     }
+
+    #[tokio::test]
+    async fn test_alter_to_request_with_renaming_table() {
+        let handler = create_mock_sql_handler().await;
+        let alter_table = parse_sql("ALTER TABLE test_table RENAME table_t;");
+        let err = handler
+            .alter_to_request(alter_table, TableReference::bare("test_table"))
+            .unwrap_err();
+        assert_matches!(err, crate::error::Error::InvalidSql { .. });
+    }
 }

src/datanode/src/sql/create.rs

@@ -143,7 +143,7 @@ impl SqlHandler {
                             )?;
                         } else {
                             return error::InvalidSqlSnafu {
-                                msg: format!("Cannot recognize named UNIQUE constraint: {}", name),
+                                msg: format!("Cannot recognize named UNIQUE constraint: {name}"),
                             }
                             .fail();
                         }
@@ -158,8 +158,7 @@ impl SqlHandler {
                     } else {
                         return error::InvalidSqlSnafu {
                             msg: format!(
-                                "Unrecognized non-primary unnamed UNIQUE constraint: {:?}",
-                                name
+                                "Unrecognized non-primary unnamed UNIQUE constraint: {name:?}",
                             ),
                         }
                         .fail();
@@ -167,7 +166,7 @@ impl SqlHandler {
                 }
                 _ => {
                     return ConstraintNotSupportedSnafu {
-                        constraint: format!("{:?}", c),
+                        constraint: format!("{c:?}"),
                     }
                     .fail();
                 }

src/datanode/src/tests/instance_test.rs

@@ -21,17 +21,11 @@ use datatypes::data_type::ConcreteDataType;
 use datatypes::vectors::{Int64Vector, StringVector, UInt64Vector, VectorRef};
 use session::context::QueryContext;
 
-use crate::instance::Instance;
-use crate::tests::test_util;
+use crate::tests::test_util::{self, MockInstance};
 
 #[tokio::test(flavor = "multi_thread")]
 async fn test_create_database_and_insert_query() {
-    common_telemetry::init_default_ut_logging();
-
-    let (opts, _guard) =
-        test_util::create_tmp_dir_and_datanode_opts("create_database_and_insert_query");
-    let instance = Instance::with_mock_meta_client(&opts).await.unwrap();
-    instance.start().await.unwrap();
+    let instance = MockInstance::new("create_database_and_insert_query").await;
 
     let output = execute_sql(&instance, "create database test").await;
     assert!(matches!(output, Output::AffectedRows(1)));
@@ -77,12 +71,7 @@ async fn test_create_database_and_insert_query() {
 }
 #[tokio::test(flavor = "multi_thread")]
 async fn test_issue477_same_table_name_in_different_databases() {
-    common_telemetry::init_default_ut_logging();
-
-    let (opts, _guard) =
-        test_util::create_tmp_dir_and_datanode_opts("create_database_and_insert_query");
-    let instance = Instance::with_mock_meta_client(&opts).await.unwrap();
-    instance.start().await.unwrap();
+    let instance = MockInstance::new("test_issue477_same_table_name_in_different_databases").await;
 
     // Create database a and b
     let output = execute_sql(&instance, "create database a").await;
@@ -149,7 +138,7 @@ async fn test_issue477_same_table_name_in_different_databases() {
     .await;
 }
 
-async fn assert_query_result(instance: &Instance, sql: &str, ts: i64, host: &str) {
+async fn assert_query_result(instance: &MockInstance, sql: &str, ts: i64, host: &str) {
     let query_output = execute_sql(instance, sql).await;
     match query_output {
         Output::Stream(s) => {
@@ -169,16 +158,11 @@ async fn assert_query_result(instance: &Instance, sql: &str, ts: i64, host: &str
     }
 }
 
-async fn setup_test_instance(test_name: &str) -> Instance {
-    common_telemetry::init_default_ut_logging();
-
-    let (opts, _guard) = test_util::create_tmp_dir_and_datanode_opts(test_name);
-    let instance = Instance::with_mock_meta_client(&opts).await.unwrap();
-    instance.start().await.unwrap();
+async fn setup_test_instance(test_name: &str) -> MockInstance {
+    let instance = MockInstance::new(test_name).await;
 
     test_util::create_test_table(
-        instance.catalog_manager(),
-        instance.sql_handler(),
+        &instance,
         ConcreteDataType::timestamp_millisecond_datatype(),
     )
     .await
@@ -203,19 +187,11 @@ async fn test_execute_insert() {
 
 #[tokio::test(flavor = "multi_thread")]
 async fn test_execute_insert_query_with_i64_timestamp() {
-    common_telemetry::init_default_ut_logging();
+    let instance = MockInstance::new("insert_query_i64_timestamp").await;
 
-    let (opts, _guard) = test_util::create_tmp_dir_and_datanode_opts("insert_query_i64_timestamp");
-    let instance = Instance::with_mock_meta_client(&opts).await.unwrap();
-    instance.start().await.unwrap();
-
-    test_util::create_test_table(
-        instance.catalog_manager(),
-        instance.sql_handler(),
-        ConcreteDataType::int64_datatype(),
-    )
-    .await
-    .unwrap();
+    test_util::create_test_table(&instance, ConcreteDataType::int64_datatype())
+        .await
+        .unwrap();
 
     let output = execute_sql(
         &instance,
@@ -262,9 +238,7 @@ async fn test_execute_insert_query_with_i64_timestamp() {
 
 #[tokio::test(flavor = "multi_thread")]
 async fn test_execute_query() {
-    let (opts, _guard) = test_util::create_tmp_dir_and_datanode_opts("execute_query");
-    let instance = Instance::with_mock_meta_client(&opts).await.unwrap();
-    instance.start().await.unwrap();
+    let instance = MockInstance::new("execute_query").await;
 
     let output = execute_sql(&instance, "select sum(number) from numbers limit 20").await;
     match output {
@@ -284,10 +258,7 @@ async fn test_execute_query() {
 
 #[tokio::test(flavor = "multi_thread")]
 async fn test_execute_show_databases_tables() {
-    let (opts, _guard) =
-        test_util::create_tmp_dir_and_datanode_opts("execute_show_databases_tables");
-    let instance = Instance::with_mock_meta_client(&opts).await.unwrap();
-    instance.start().await.unwrap();
+    let instance = MockInstance::new("execute_show_databases_tables").await;
 
     let output = execute_sql(&instance, "show databases").await;
     match output {
@@ -331,8 +302,7 @@ async fn test_execute_show_databases_tables() {
 
     // creat a table
     test_util::create_test_table(
-        instance.catalog_manager(),
-        instance.sql_handler(),
+        &instance,
         ConcreteDataType::timestamp_millisecond_datatype(),
     )
     .await
@@ -367,11 +337,7 @@ async fn test_execute_show_databases_tables() {
 
 #[tokio::test(flavor = "multi_thread")]
 pub async fn test_execute_create() {
-    common_telemetry::init_default_ut_logging();
-
-    let (opts, _guard) = test_util::create_tmp_dir_and_datanode_opts("execute_create");
-    let instance = Instance::with_mock_meta_client(&opts).await.unwrap();
-    instance.start().await.unwrap();
+    let instance = MockInstance::new("execute_create").await;
 
     let output = execute_sql(
         &instance,
@@ -480,19 +446,16 @@ async fn test_alter_table() {
 }
 
 async fn test_insert_with_default_value_for_type(type_name: &str) {
-    let (opts, _guard) = test_util::create_tmp_dir_and_datanode_opts("execute_create");
-    let instance = Instance::with_mock_meta_client(&opts).await.unwrap();
-    instance.start().await.unwrap();
+    let instance = MockInstance::new("execute_create").await;
 
     let create_sql = format!(
         r#"create table test_table(
         host string,
-        ts {} DEFAULT CURRENT_TIMESTAMP,
+        ts {type_name} DEFAULT CURRENT_TIMESTAMP,
         cpu double default 0,
         TIME INDEX (ts),
         PRIMARY KEY(host)
     ) engine=mito with(regions=1);"#,
-        type_name
     );
     let output = execute_sql(&instance, &create_sql).await;
     assert!(matches!(output, Output::AffectedRows(1)));
@@ -528,17 +491,13 @@ async fn test_insert_with_default_value_for_type(type_name: &str) {
 
 #[tokio::test(flavor = "multi_thread")]
 async fn test_insert_with_default_value() {
-    common_telemetry::init_default_ut_logging();
-
     test_insert_with_default_value_for_type("timestamp").await;
     test_insert_with_default_value_for_type("bigint").await;
 }
 
 #[tokio::test(flavor = "multi_thread")]
 async fn test_use_database() {
-    let (opts, _guard) = test_util::create_tmp_dir_and_datanode_opts("use_database");
-    let instance = Instance::with_mock_meta_client(&opts).await.unwrap();
-    instance.start().await.unwrap();
+    let instance = MockInstance::new("test_use_database").await;
 
     let output = execute_sql(&instance, "create database db1").await;
     assert!(matches!(output, Output::AffectedRows(1)));
@@ -595,11 +554,11 @@ async fn test_use_database() {
     check_output_stream(output, expected).await;
 }
 
-async fn execute_sql(instance: &Instance, sql: &str) -> Output {
+async fn execute_sql(instance: &MockInstance, sql: &str) -> Output {
     execute_sql_in_db(instance, sql, DEFAULT_SCHEMA_NAME).await
 }
 
-async fn execute_sql_in_db(instance: &Instance, sql: &str, db: &str) -> Output {
+async fn execute_sql_in_db(instance: &MockInstance, sql: &str, db: &str) -> Output {
     let query_ctx = Arc::new(QueryContext::with_current_schema(db.to_string()));
-    instance.execute_sql(sql, query_ctx).await.unwrap()
+    instance.inner().execute_sql(sql, query_ctx).await.unwrap()
 }

src/datanode/src/tests/test_util.rs

@@ -15,7 +15,6 @@
 use std::collections::HashMap;
 use std::sync::Arc;
 
-use catalog::CatalogManagerRef;
 use common_catalog::consts::{DEFAULT_CATALOG_NAME, DEFAULT_SCHEMA_NAME, MIN_USER_TABLE_ID};
 use datatypes::data_type::ConcreteDataType;
 use datatypes::schema::{ColumnSchema, SchemaBuilder};
@@ -30,18 +29,37 @@ use tempdir::TempDir;
 
 use crate::datanode::{DatanodeOptions, ObjectStoreConfig};
 use crate::error::{CreateTableSnafu, Result};
+use crate::instance::Instance;
 use crate::sql::SqlHandler;
 
-/// Create a tmp dir(will be deleted once it goes out of scope.) and a default `DatanodeOptions`,
-/// Only for test.
-pub struct TestGuard {
+pub(crate) struct MockInstance {
+    instance: Instance,
+    _guard: TestGuard,
+}
+
+impl MockInstance {
+    pub(crate) async fn new(name: &str) -> Self {
+        let (opts, _guard) = create_tmp_dir_and_datanode_opts(name);
+
+        let instance = Instance::with_mock_meta_client(&opts).await.unwrap();
+        instance.start().await.unwrap();
+
+        MockInstance { instance, _guard }
+    }
+
+    pub(crate) fn inner(&self) -> &Instance {
+        &self.instance
+    }
+}
+
+struct TestGuard {
     _wal_tmp_dir: TempDir,
     _data_tmp_dir: TempDir,
 }
 
-pub fn create_tmp_dir_and_datanode_opts(name: &str) -> (DatanodeOptions, TestGuard) {
-    let wal_tmp_dir = TempDir::new(&format!("gt_wal_{}", name)).unwrap();
-    let data_tmp_dir = TempDir::new(&format!("gt_data_{}", name)).unwrap();
+fn create_tmp_dir_and_datanode_opts(name: &str) -> (DatanodeOptions, TestGuard) {
+    let wal_tmp_dir = TempDir::new(&format!("gt_wal_{name}")).unwrap();
+    let data_tmp_dir = TempDir::new(&format!("gt_data_{name}")).unwrap();
     let opts = DatanodeOptions {
         wal_dir: wal_tmp_dir.path().to_str().unwrap().to_string(),
         storage: ObjectStoreConfig::File {
@@ -59,9 +77,8 @@ pub fn create_tmp_dir_and_datanode_opts(name: &str) -> (DatanodeOptions, TestGua
     )
 }
 
-pub async fn create_test_table(
-    catalog_manager: &CatalogManagerRef,
-    sql_handler: &SqlHandler,
+pub(crate) async fn create_test_table(
+    instance: &MockInstance,
     ts_type: ConcreteDataType,
 ) -> Result<()> {
     let column_schemas = vec![
@@ -72,7 +89,7 @@ pub async fn create_test_table(
     ];
 
     let table_name = "demo";
-    let table_engine: TableEngineRef = sql_handler.table_engine();
+    let table_engine: TableEngineRef = instance.inner().sql_handler().table_engine();
     let table = table_engine
         .create_table(
             &EngineContext::default(),
@@ -97,11 +114,10 @@ pub async fn create_test_table(
         .await
         .context(CreateTableSnafu { table_name })?;
 
-    let schema_provider = catalog_manager
-        .catalog(DEFAULT_CATALOG_NAME)
-        .unwrap()
-        .unwrap()
-        .schema(DEFAULT_SCHEMA_NAME)
+    let schema_provider = instance
+        .inner()
+        .catalog_manager
+        .schema(DEFAULT_CATALOG_NAME, DEFAULT_SCHEMA_NAME)
         .unwrap()
         .unwrap();
     schema_provider

src/datatypes/Cargo.toml

@@ -1,25 +1,25 @@
 [package]
 name = "datatypes"
-version = "0.1.0"
-edition = "2021"
-license = "Apache-2.0"
+version.workspace = true
+edition.workspace = true
+license.workspace = true
 
 [features]
 default = []
 test = []
 
 [dependencies]
-arrow = { version = "26.0" }
-arrow-schema = { version = "26.0", features = ["serde"] }
+arrow.workspace = true
+arrow-schema.workspace = true
 common-base = { path = "../common/base" }
 common-error = { path = "../common/error" }
 common-time = { path = "../common/time" }
-datafusion-common = "14.0"
+datafusion-common.workspace = true
 enum_dispatch = "0.3"
 num = "0.4"
 num-traits = "0.2"
 ordered-float = { version = "3.0", features = ["serde"] }
 paste = "1.0"
-serde = { version = "1.0", features = ["derive"] }
+serde.workspace = true
 serde_json = "1.0"
 snafu = { version = "0.7", features = ["backtraces"] }

src/datatypes/src/error.rs

@@ -139,7 +139,7 @@ mod tests {
         map.insert(false, 2);
 
         let result = serde_json::to_string(&map).context(SerializeSnafu);
-        assert!(result.is_err(), "serialize result is: {:?}", result);
+        assert!(result.is_err(), "serialize result is: {result:?}");
         let err = serde_json::to_string(&map)
             .context(SerializeSnafu)
             .err()

src/datatypes/src/lib.rs

@@ -12,9 +12,6 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#![feature(generic_associated_types)]
-#![feature(assert_matches)]
-
 pub mod arrow_array;
 pub mod data_type;
 pub mod error;