mirror of
https://github.com/GreptimeTeam/greptimedb.git
synced 2026-07-03 12:30:40 +00:00
* ci: add sqlness compat smoke Signed-off-by: discord9 <discord9@163.com> * ci: limit compat smoke pull request trigger Signed-off-by: discord9 <discord9@163.com> * ci: run compat smoke in merge queue Signed-off-by: discord9 <discord9@163.com> * ci: configure compat version window Signed-off-by: discord9 <discord9@163.com> * ci: move compat smoke logic into script Signed-off-by: discord9 <discord9@163.com> * ci: expand compat version window Signed-off-by: discord9 <discord9@163.com> * ci: rename compat job for recent releases Signed-off-by: discord9 <discord9@163.com> * ci: report compat test failures Signed-off-by: discord9 <discord9@163.com> --------- Signed-off-by: discord9 <discord9@163.com>
3.0 KiB
3.0 KiB
Agent Guidance for Compatibility Framework
This file is intended for AI agents editing compat cases or the compat runner. Follow these rules to avoid common pitfalls.
verify.result is Expected Output (Not Auto-Generated Silently)
verify.resultcontains the expected output ofverify.sql.- If the file is missing, the runner generates it from actual output and fails.
The agent must review the generated file (
git diff), hand-verify correctness, and commit it before rerunning. Do not blindly commit generated output. - If actual output differs from the expected file, the runner updates
verify.resultwith actual output and fails. The agent must inspect the diff and decide whether the change is intentional (accept) or a bug (fix code).
Namespace Isolation
- Each case owns a unique namespace. No shared namespace support exists.
- Duplicate namespaces are a hard error detected before version filtering.
- The removed
isolationfield is no longer recognized;case.tomlusesdeny_unknown_fields, so any staleisolation = "shared"entry causes a parse error.
case.toml is Strict
deny_unknown_fieldsis enabled. Unknown keys cause a hard parse error.- Version constraint entries in
from_range/to_rangeare validated early; invalid constraints (e.g.>=not-a-version) are hard errors, not silent skips. - All required fields must be non-empty:
name,reason,introduced_by,topologies,from_range,to_range,features,owner.
Phase Semantics
setup.sqlruns on the old (from) binary. Only success is required; output is not compared to any file.verify.sqlruns on the new (to) binary. Output is compared againstverify.result.
PostgreSQL Protocol Cases
- When using
-- SQLNESS PROTOCOL POSTGRES, avoid unqualified table names starting withpg_. GreptimeDB issue #8359 causes the parser to rewrite them topg_catalog.<table>. Qualify such names explicitly or rename the table.
Previewing with --dry-run
cargo run -p sqlness-runner -- compat --dry-run [--from-version vX.Y.Z] [--test-filter "..."]
The dry-run performs full discovery and filtering (name, topology, metadata validation, namespace dedup, version-range matching) but starts no services, creates no temp dirs, and mutates no files. Use it to check which cases would be selected before a real run.
CI Version Window
tests/compatibility/ci.tomlcontrols the small sliding window of recent released versions used by the CI job. Do not hard-code old versions directly in workflow YAML.- Keep the PR/merge-queue window short; wider compatibility coverage belongs in nightly or release-validation workflows.
- Case
from_range/to_rangemetadata still controls whether each case runs for a sampled version pair. .github/scripts/run-compat.pyowns the CI-side window parsing and compat invocation. Keep workflow YAML thin; update the script instead of embedding parsing or loops in.github/workflows/develop.yml.