fix: treat a merge as a source of deletions

The classifier only marked an Update as changing rows, but merge_insert
commits an Update too and its by-source arm removes rows rather than
changing them. A merge that deleted source rows left the view holding
them, since nothing enabled deletion-delta processing for that span.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
Wyatt Alt
2026-08-16 20:48:55 -07:00
co-authored by Claude Fable 5
parent 5fcf1387eb
commit 2e007ae6d0
@@ -405,6 +405,9 @@ async fn appends_and_rewrites(cur: &Dataset, from: u64, to: u64) -> Option<TxnDe
..
} => {
delta.updated_rows = true;
// merge_insert reaches here too, and its by-source arm deletes
// rows rather than changing them.
delta.deleted_rows = true;
delta.rewritten.extend(removed_fragment_ids.iter().copied());
delta.produced.extend(new_fragments.iter().map(|f| f.id));
delta
@@ -1269,6 +1272,26 @@ mod tests {
assert_eq!(read(view.table(), "twice").await, vec![6, 8]);
}
/// merge_insert commits an `Update`, and its by-source arm removes rows
/// rather than changing them, so the classifier must treat that
/// transaction form as a source of deletions.
#[tokio::test]
async fn test_merge_insert_by_source_delete_evicts_the_view_rows() {
let (conn, source) = db_with_source(vec![1, 2, 3]).await;
let view = doubled_view(&conn).await;
view.refresh().execute().await.unwrap();
let batch = record_batch!(("x", Int32, vec![1, 3])).unwrap();
let reader = arrow_array::RecordBatchIterator::new(vec![Ok(batch.clone())], batch.schema());
let mut merge = source.merge_insert(&["x"]);
merge.when_not_matched_by_source_delete(None);
merge.execute(Box::new(reader)).await.unwrap();
let result = view.refresh().execute().await.unwrap();
assert_eq!(result.mode, RefreshMode::Incremental);
assert_eq!(read(view.table(), "twice").await, vec![2, 6]);
}
async fn compact(source: &Table) {
source
.optimize(OptimizeAction::Compact {