rust/lancedb
1
0
Fork 0
mirror of https://github.com/lancedb/lancedb.git synced 2026-01-06 03:42:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

add a default value for search.limit to be consistent with python sdk (#1191)

Browse Source 
Changed the default value for search.limit to be 10
This commit is contained in:
QianZhu
2024-04-04 12:22:10 -07:00
committed by Weston Pace
parent a900bc0827
commit 871500db70
2 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
node/src/query.ts
View File

@@ -38,7 +38,7 @@ export class Query<T = number[]> {
constructor (query?: T, tbl?: any, embeddings?: EmbeddingFunction<T>) {
this._tbl = tbl
this._query = query
this._limit = undefined
this._limit = 10
this._nprobes = 20
this._refineFactor = undefined
this._select = undefined
@@ -50,6 +50,7 @@ export class Query<T = number[]> {
/***
* Sets the number of results that will be returned
* default value is 10
* @param value number of results
*/
limit (value: number): Query<T> {

4
node/src/test/test.ts
View File

@@ -124,9 +124,9 @@ describe('LanceDB client', function () {
const uri = await createTestDB(2, 100)
const con = await lancedb.connect(uri)
const table = (await con.openTable('vectors')) as LocalTable
let results = await table.filter('id % 2 = 0').execute()
let results = await table.filter('id % 2 = 0').limit(100).execute()
assertResults(results)
results = await table.where('id % 2 = 0').execute()
results = await table.where('id % 2 = 0').limit(100).execute()
assertResults(results)
// Should reject a bad filter