rust/lancedb
1
0
Fork 0
mirror of https://github.com/lancedb/lancedb.git synced 2026-01-05 11:22:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

Revert "support passing write parameters to merge_insert"

Browse Source 
This reverts commit 783e99feb7.
This commit is contained in:
albertlockett
2024-07-19 11:28:07 -03:00
parent c011539905
commit a2fa15606f
2 changed files with 1 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
rust/lancedb/src/table.rs
View File

@@ -1840,12 +1840,6 @@ impl TableInternal for NativeTable {
} else {
builder.when_not_matched_by_source(WhenNotMatchedBySource::Keep);
}
if let Some(write_options) = params.write_options {
if let Some(write_params) = &write_options.lance_write_params {
builder.with_write_params(write_params.clone());
}
}
let job = builder.try_build()?;
let (new_dataset, _stats) = job.execute_reader(new_data).await?;
self.dataset.set_latest(new_dataset.as_ref().clone()).await;

11
rust/lancedb/src/table/merge.rs
View File

@@ -18,7 +18,7 @@ use arrow_array::RecordBatchReader;
use crate::Result;
use super::{TableInternal, WriteOptions};
use super::TableInternal;
/// A builder used to create and run a merge insert operation
///
@@ -32,8 +32,6 @@ pub struct MergeInsertBuilder {
pub(super) when_not_matched_insert_all: bool,
pub(super) when_not_matched_by_source_delete: bool,
pub(super) when_not_matched_by_source_delete_filt: Option<String>,
pub(crate) write_options: Option<WriteOptions>
}
impl MergeInsertBuilder {
@@ -46,7 +44,6 @@ impl MergeInsertBuilder {
when_not_matched_insert_all: false,
when_not_matched_by_source_delete: false,
when_not_matched_by_source_delete_filt: None,
write_options: None,
}
}
@@ -98,12 +95,6 @@ impl MergeInsertBuilder {
self
}
/// Apply the given write options when updating the dataset
pub fn write_options(&mut self, write_options: Option<WriteOptions>) -> &mut Self {
self.write_options = write_options;
self
}
/// Executes the merge insert operation
///
/// Nothing is returned but the [`super::Table`] is updated