rust/lancedb
1
0
Fork 0
mirror of https://github.com/lancedb/lancedb.git synced 2026-01-10 13:52:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat: support offset in remote client (#1923)

Browse Source 
Closes https://github.com/lancedb/lancedb/issues/1876
This commit is contained in:
Will Jones
2024-12-09 17:04:18 -08:00
committed by GitHub
parent db125013fc
commit ab5316b4fa
2 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
python/python/tests/test_remote_db.py
View File

@@ -343,6 +343,7 @@ def test_query_sync_maximal():
assert body == {
"distance_type": "cosine",
"k": 42,
"offset": 10,
"prefilter": True,
"refine_factor": 10,
"vector": [1.0, 2.0, 3.0],
@@ -363,6 +364,7 @@ def test_query_sync_maximal():
table.search([1, 2, 3], vector_column_name="vector2", fast_search=True)
.metric("cosine")
.limit(42)
.offset(10)
.refine_factor(10)
.nprobes(5)
.where("id > 0", prefilter=True)

8
rust/lancedb/src/remote/table.rs
View File

@@ -145,10 +145,8 @@ impl<S: HttpSend> RemoteTable<S> {
}
fn apply_query_params(body: &mut serde_json::Value, params: &Query) -> Result<()> {
if params.offset.is_some() {
return Err(Error::NotSupported {
message: "Offset is not yet supported in LanceDB Cloud".into(),
});
if let Some(offset) = params.offset {
body["offset"] = serde_json::Value::Number(serde_json::Number::from(offset));
}
if let Some(limit) = params.limit {
@@ -1348,6 +1346,7 @@ mod tests {
"vector_column": "my_vector",
"prefilter": false,
"k": 42,
"offset": 10,
"distance_type": "cosine",
"bypass_vector_index": true,
"columns": ["a", "b"],
@@ -1376,6 +1375,7 @@ mod tests {
let _ = table
.query()
.limit(42)
.offset(10)
.select(Select::columns(&["a", "b"]))
.nearest_to(vec![0.1, 0.2, 0.3])
.unwrap()