rust/lancedb
1
0
Fork 0
mirror of https://github.com/lancedb/lancedb.git synced 2026-11-14 06:36:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: leave untouched storage accessors alone when stripping creation keys

Browse Source 
The strip rebuilt the accessor unconditionally, so a provider-backed
accessor with no static options became one caching an empty map, and its
credentials were never fetched. The accessor is now rebuilt only when a
creation key was actually removed, and a provider-only accessor is rebuilt
with the provider alone.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
Wyatt Alt
2026-08-14 01:23:53 -07:00
co-authored by Claude Fable 5
parent f57da536ba
commit e5ff759c15
1 changed files with 23 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files
rust/lancedb/src/database/listing.rs
+23 -15
View File
@@ -821,29 +821,37 @@ impl ListingDatabase {
// The new-table keys are creation configuration, not store options:
// strip them so a request carrying only them keeps the connection's
// store instead of forking a new one.
// store instead of forking a new one. An accessor that carried none
// of them is left alone -- rebuilding a provider-backed accessor
// around a cached map would stop its credentials being fetched.
if let Some(store_params) = write_params.store_params.as_mut() {
let mut options = store_params.storage_options().cloned().unwrap_or_default();
let mut removed = false;
for key in [
OPT_NEW_TABLE_STORAGE_VERSION,
OPT_NEW_TABLE_V2_MANIFEST_PATHS,
OPT_NEW_TABLE_ENABLE_STABLE_ROW_IDS,
] {
options.remove(key);
removed |= options.remove(key).is_some();
}
if removed {
let provider = store_params
.storage_options_accessor
.as_ref()
.and_then(|accessor| accessor.provider().cloned());
store_params.storage_options_accessor = match (options.is_empty(), provider) {
(true, None) => None,
(true, Some(provider)) => {
Some(Arc::new(StorageOptionsAccessor::with_provider(provider)))
}
(false, Some(provider)) => Some(Arc::new(
StorageOptionsAccessor::with_initial_and_provider(options, provider),
)),
(false, None) => Some(Arc::new(StorageOptionsAccessor::with_static_options(
options,
))),
};
}
let provider = store_params
.storage_options_accessor
.as_ref()
.and_then(|accessor| accessor.provider().cloned());
store_params.storage_options_accessor = match (options.is_empty(), provider) {
(true, None) => None,
(_, Some(provider)) => Some(Arc::new(
StorageOptionsAccessor::with_initial_and_provider(options, provider),
)),
(false, None) => Some(Arc::new(StorageOptionsAccessor::with_static_options(
options,
))),
};
}
// Only modify the storage options if we actually have something to