Bump version: 0.39.0-beta.5 → 0.39.0-beta.6

.github/workflows/typos.yml

@@ -1,20 +0,0 @@
-name: Typo checker
-on:
-  push:
-    branches:
-      - main
-  pull_request:
-
-permissions:
-  contents: read
-
-jobs:
-  run:
-    name: Spell Check with Typos
-    runs-on: ubuntu-latest
-    steps:
-      - name: Check out code
-        uses: actions/checkout@v6
-
-      - name: Check spelling of the entire repository
-        uses: crate-ci/typos@6802cc60d4e7f78b9d5454f6cf3935c042d5e1e3 # v1.26.0

.pre-commit-config.yaml

@@ -10,10 +10,6 @@ repos:
     rev: v0.9.9
     hooks:
       - id: ruff
-  - repo: https://github.com/crate-ci/typos
-    rev: v1.26.0
-    hooks:
-      - id: typos
   # - repo: https://github.com/RobertCraigie/pyright-python
   #   rev: v1.1.395
   #   hooks:

.typos.toml

@@ -1,19 +0,0 @@
-[default]
-extend-ignore-re = ["(?Rm)^.*(#|//)\\s*spellchecker:disable-line$"]
-
-[default.extend-words]
-# Azure Kubernetes Service, mentioned in rust/lancedb/src/remote/oauth.rs.
-AKS = "AKS"
-# RabitQ is the name of a vector quantization algorithm, not a typo of "Rabbit".
-Rabit = "Rabit"
-# `VarBuilder::from_mmaped_safetensors` is the real (if oddly-spelled) name of
-# the candle-core API we call in rust/lancedb/src/embeddings/sentence_transformers.rs.
-mmaped = "mmaped"
-# `WriteableBuffer` is the real name of a type from Python's `_typeshed` stubs,
-# used in python/python/lancedb/_blob.py.
-Writeable = "Writeable"
-
-[files]
-extend-exclude = [
-    "*_THIRD_PARTY_LICENSES.*",
-]

Cargo.toml

@@ -13,20 +13,20 @@ categories = ["database-implementations"]
 rust-version = "1.91.0"
 
 [workspace.dependencies]
-lance = { "version" = "=12.0.0-beta.18", default-features = false, "tag" = "v12.0.0-beta.18", "git" = "https://github.com/lance-format/lance.git" }
-lance-core = { "version" = "=12.0.0-beta.18", "tag" = "v12.0.0-beta.18", "git" = "https://github.com/lance-format/lance.git" }
-lance-datagen = { "version" = "=12.0.0-beta.18", "tag" = "v12.0.0-beta.18", "git" = "https://github.com/lance-format/lance.git" }
-lance-file = { "version" = "=12.0.0-beta.18", "tag" = "v12.0.0-beta.18", "git" = "https://github.com/lance-format/lance.git" }
-lance-io = { "version" = "=12.0.0-beta.18", default-features = false, "tag" = "v12.0.0-beta.18", "git" = "https://github.com/lance-format/lance.git" }
-lance-index = { "version" = "=12.0.0-beta.18", "tag" = "v12.0.0-beta.18", "git" = "https://github.com/lance-format/lance.git" }
-lance-linalg = { "version" = "=12.0.0-beta.18", "tag" = "v12.0.0-beta.18", "git" = "https://github.com/lance-format/lance.git" }
-lance-namespace = { "version" = "=12.0.0-beta.18", "tag" = "v12.0.0-beta.18", "git" = "https://github.com/lance-format/lance.git" }
-lance-namespace-impls = { "version" = "=12.0.0-beta.18", default-features = false, "tag" = "v12.0.0-beta.18", "git" = "https://github.com/lance-format/lance.git" }
-lance-table = { "version" = "=12.0.0-beta.18", "tag" = "v12.0.0-beta.18", "git" = "https://github.com/lance-format/lance.git" }
-lance-testing = { "version" = "=12.0.0-beta.18", "tag" = "v12.0.0-beta.18", "git" = "https://github.com/lance-format/lance.git" }
-lance-datafusion = { "version" = "=12.0.0-beta.18", "tag" = "v12.0.0-beta.18", "git" = "https://github.com/lance-format/lance.git" }
-lance-encoding = { "version" = "=12.0.0-beta.18", "tag" = "v12.0.0-beta.18", "git" = "https://github.com/lance-format/lance.git" }
-lance-arrow = { "version" = "=12.0.0-beta.18", "tag" = "v12.0.0-beta.18", "git" = "https://github.com/lance-format/lance.git" }
+lance = { "version" = "=12.0.0-beta.15", default-features = false, "tag" = "v12.0.0-beta.15", "git" = "https://github.com/lance-format/lance.git" }
+lance-core = { "version" = "=12.0.0-beta.15", "tag" = "v12.0.0-beta.15", "git" = "https://github.com/lance-format/lance.git" }
+lance-datagen = { "version" = "=12.0.0-beta.15", "tag" = "v12.0.0-beta.15", "git" = "https://github.com/lance-format/lance.git" }
+lance-file = { "version" = "=12.0.0-beta.15", "tag" = "v12.0.0-beta.15", "git" = "https://github.com/lance-format/lance.git" }
+lance-io = { "version" = "=12.0.0-beta.15", default-features = false, "tag" = "v12.0.0-beta.15", "git" = "https://github.com/lance-format/lance.git" }
+lance-index = { "version" = "=12.0.0-beta.15", "tag" = "v12.0.0-beta.15", "git" = "https://github.com/lance-format/lance.git" }
+lance-linalg = { "version" = "=12.0.0-beta.15", "tag" = "v12.0.0-beta.15", "git" = "https://github.com/lance-format/lance.git" }
+lance-namespace = { "version" = "=12.0.0-beta.15", "tag" = "v12.0.0-beta.15", "git" = "https://github.com/lance-format/lance.git" }
+lance-namespace-impls = { "version" = "=12.0.0-beta.15", default-features = false, "tag" = "v12.0.0-beta.15", "git" = "https://github.com/lance-format/lance.git" }
+lance-table = { "version" = "=12.0.0-beta.15", "tag" = "v12.0.0-beta.15", "git" = "https://github.com/lance-format/lance.git" }
+lance-testing = { "version" = "=12.0.0-beta.15", "tag" = "v12.0.0-beta.15", "git" = "https://github.com/lance-format/lance.git" }
+lance-datafusion = { "version" = "=12.0.0-beta.15", "tag" = "v12.0.0-beta.15", "git" = "https://github.com/lance-format/lance.git" }
+lance-encoding = { "version" = "=12.0.0-beta.15", "tag" = "v12.0.0-beta.15", "git" = "https://github.com/lance-format/lance.git" }
+lance-arrow = { "version" = "=12.0.0-beta.15", "tag" = "v12.0.0-beta.15", "git" = "https://github.com/lance-format/lance.git" }
 lancedb = { path = "rust/lancedb", default-features = false }
 ahash = "0.8"
 # Note that this one does not include pyarrow
@@ -60,7 +60,7 @@ log = "0.4"
 metrics = "0.24"
 metrics-util = "0.19"
 moka = { version = "0.12", features = ["future"] }
-object_store = "0.14.1"
+object_store = "0.13.2"
 pin-project = "1.0.7"
 rand = "0.9"
 snafu = "0.8"

docs/openapi.yml

@@ -155,7 +155,7 @@ paths:
                 vector:
                   type: FixedSizeList
                   description: |
-                    The targeted vector to search for. Required.
+                    The targetted vector to search for. Required.
                 vector_column:
                   type: string
                   description: |

docs/src/js/classes/BlobFile.md

@@ -1,62 +0,0 @@
-[**@lancedb/lancedb**](../README.md) • **Docs**
-
-***
-
-[@lancedb/lancedb](../globals.md) / BlobFile
-
-# Class: BlobFile
-
-A lazy handle to blob bytes. Create one with [Table.fetchBlobFiles](Table.md#fetchblobfiles).
-
-## Methods
-
-### read()
-
-```ts
-read(): Promise<Buffer>
-```
-
-Reads from the cursor to the end and advances the cursor.
-
-A second call returns an empty buffer. [BlobFile.readRange](BlobFile.md#readrange) does
-not move the cursor.
-
-#### Returns
-
-`Promise`&lt;`Buffer`&gt;
-
-***
-
-### readRange()
-
-```ts
-readRange(start, end): Promise<Buffer>
-```
-
-Reads the half-open byte range `[start, end)`.
-
-Fails when `end` is past the blob size. Does not move the cursor.
-
-#### Parameters
-
-* **start**: `bigint`
-
-* **end**: `bigint`
-
-#### Returns
-
-`Promise`&lt;`Buffer`&gt;
-
-***
-
-### size()
-
-```ts
-size(): bigint
-```
-
-Returns the blob size in bytes.
-
-#### Returns
-
-`bigint`

docs/src/js/classes/MergeInsertBuilder.md

@@ -141,7 +141,7 @@ Currently this causes multiple copies of the row to be created
 but that behavior is subject to change.
 
 An optional condition may be specified.  If it is, then only
-matched rows that satisfy the condition will be updated.  Any
+matched rows that satisfy the condtion will be updated.  Any
 rows that do not satisfy the condition will be left as they
 are.  Failing to satisfy the condition does not cause a
 "matched row" to become a "not matched" row.

docs/src/js/classes/Table.md

@@ -137,20 +137,6 @@ containing the new version number of the table after altering the columns.
 
 ***
 
-### blobColumns()
-
-```ts
-abstract blobColumns(): Promise<string[]>
-```
-
-Blob v2 columns, including nested dotted paths.
-
-#### Returns
-
-`Promise`&lt;`string`[]&gt;
-
-***
-
 ### branches()
 
 ```ts
@@ -513,54 +499,6 @@ Drop an index from the table.
 
 ***
 
-### fetchBlobFiles()
-
-```ts
-abstract fetchBlobFiles(column, rowIds): Promise<(null | BlobFile)[]>
-```
-
-Opens lazy blob handles for `column` at the given row IDs using the
-table's current checkout.
-
-Preserves input order, duplicates, and nulls. Use this for large payloads.
-See [Table.fetchBlobs](Table.md#fetchblobs) for row-ID validity across versions.
-
-#### Parameters
-
-* **column**: `string`
-
-* **rowIds**: readonly (`number` \| `bigint`)[]
-
-#### Returns
-
-`Promise`&lt;(`null` \| [`BlobFile`](BlobFile.md))[]&gt;
-
-***
-
-### fetchBlobs()
-
-```ts
-abstract fetchBlobs(column, rowIds): Promise<(null | Buffer)[]>
-```
-
-Bytes for `column` at row IDs from [Query.withRowId](Query.md#withrowid).
-
-Reads the table's current checkout. IDs from another version can fail after
-compaction unless stable row ids are enabled. Results keep input order and
-duplicates. Null blobs are `null`. Empty blobs are empty buffers.
-
-#### Parameters
-
-* **column**: `string`
-
-* **rowIds**: readonly (`number` \| `bigint`)[]
-
-#### Returns
-
-`Promise`&lt;(`null` \| `Buffer`)[]&gt;
-
-***
-
 ### flushLsm()
 
 ```ts
@@ -1328,7 +1266,7 @@ value is 0")
 Note: if your condition is something like "some_id_column == 7" and
 you are updating many rows (with different ids) then you will get
 better performance with a single [`merge_insert`] call instead of
-repeatedly calling this method.
+repeatedly calilng this method.
 
 ##### Parameters
 

docs/src/js/functions/blob.md

@@ -1,55 +0,0 @@
-[**@lancedb/lancedb**](../README.md) • **Docs**
-
-***
-
-[@lancedb/lancedb](../globals.md) / blob
-
-# Function: blob()
-
-```ts
-function blob(name, options): Field
-```
-
-Declares a `lance.blob.v2` column.
-
-Query results are descriptors, not payload bytes. Use [Table.fetchBlobs](../classes/Table.md#fetchblobs)
-or [Table.fetchBlobFiles](../classes/Table.md#fetchblobfiles) to read bytes.
-
-## Parameters
-
-* **name**: `string`
-
-* **options**: [`BlobOptions`](../type-aliases/BlobOptions.md) = `{}`
-
-## Returns
-
-`Field`
-
-## Example
-
-```ts
-import { readFile } from "node:fs/promises";
-import { Field, Int64, Schema } from "apache-arrow";
-import { blob, connect } from "@lancedb/lancedb";
-
-const db = await connect("./data");
-const video = await readFile("clip.mp4");
-const table = await db.createTable(
-  "videos",
-  [{ id: 1n, video }],
-  {
-    schema: new Schema([
-      new Field("id", new Int64()),
-      blob("video"),
-    ]),
-  },
-);
-
-const rows = await table.query().select(["id"]).withRowId().toArray();
-const rowIds = rows.map((row) => row._rowid as bigint);
-const bytes = await table.fetchBlobs("video", rowIds);
-
-const [handle] = await table.fetchBlobFiles("video", rowIds);
-const size = handle!.size();
-const header = await handle!.readRange(0n, size < 65536n ? size : 65536n);
-```

docs/src/js/functions/isBlobField.md

@@ -1,22 +0,0 @@
-[**@lancedb/lancedb**](../README.md) • **Docs**
-
-***
-
-[@lancedb/lancedb](../globals.md) / isBlobField
-
-# Function: isBlobField()
-
-```ts
-function isBlobField(field): boolean
-```
-
-Checks for the `lance.blob.v2` extension marker. Does not validate the
-field's storage type.
-
-## Parameters
-
-* **field**: `Field`<`any`>
-
-## Returns
-
-`boolean`

docs/src/js/globals.md

@@ -19,7 +19,6 @@
 ## Classes
 
 - [AutoQuery](classes/AutoQuery.md)
-- [BlobFile](classes/BlobFile.md)
 - [BooleanQuery](classes/BooleanQuery.md)
 - [BoostQuery](classes/BoostQuery.md)
 - [BranchContents](classes/BranchContents.md)
@@ -144,7 +143,6 @@
 
 - [AnalyzePlanDistributedMetrics](type-aliases/AnalyzePlanDistributedMetrics.md)
 - [BaseTokenizer](type-aliases/BaseTokenizer.md)
-- [BlobOptions](type-aliases/BlobOptions.md)
 - [Data](type-aliases/Data.md)
 - [DataLike](type-aliases/DataLike.md)
 - [FieldLike](type-aliases/FieldLike.md)
@@ -160,11 +158,9 @@
 ## Functions
 
 - [RecordBatchIterator](functions/RecordBatchIterator.md)
-- [blob](functions/blob.md)
 - [connect](functions/connect.md)
 - [connectNamespace](functions/connectNamespace.md)
 - [instrumentLanceDbMetrics](functions/instrumentLanceDbMetrics.md)
-- [isBlobField](functions/isBlobField.md)
 - [makeArrowTable](functions/makeArrowTable.md)
 - [packBits](functions/packBits.md)
 - [permutationBuilder](functions/permutationBuilder.md)

docs/src/js/interfaces/HnswPqOptions.md

@@ -118,7 +118,7 @@ Number of sub-vectors of PQ.
 This value controls how much the vector is compressed during the quantization step.
 The more sub vectors there are the less the vector is compressed.  The default is
 the dimension of the vector divided by 16.  If the dimension is not evenly divisible
-by 16 we use the dimension divided by 8.
+by 16 we use the dimension divded by 8.
 
 The above two cases are highly preferred.  Having 8 or 16 values per subvector allows
 us to use efficient SIMD instructions.

docs/src/js/interfaces/IndexOptions.md

@@ -16,7 +16,7 @@ optional config: Index;
 
 Advanced index configuration
 
-This option allows you to specify a specific index to create and also
+This option allows you to specify a specfic index to create and also
 allows you to pass in configuration for training the index.
 
 See the static methods on Index for details on the various index types.

docs/src/js/interfaces/IvfPqOptions.md

@@ -112,7 +112,7 @@ Number of sub-vectors of PQ.
 This value controls how much the vector is compressed during the quantization step.
 The more sub vectors there are the less the vector is compressed.  The default is
 the dimension of the vector divided by 16.  If the dimension is not evenly divisible
-by 16 we use the dimension divided by 8.
+by 16 we use the dimension divded by 8.
 
 The above two cases are highly preferred.  Having 8 or 16 values per subvector allows
 us to use efficient SIMD instructions.

docs/src/js/type-aliases/BlobOptions.md

@@ -1,48 +0,0 @@
-[**@lancedb/lancedb**](../README.md) • **Docs**
-
-***
-
-[@lancedb/lancedb](../globals.md) / BlobOptions
-
-# Type Alias: BlobOptions
-
-```ts
-type BlobOptions: object;
-```
-
-## Type declaration
-
-### dedicatedSizeThreshold?
-
-```ts
-optional dedicatedSizeThreshold: number;
-```
-
-Max payload bytes stored in a packed sidecar before a dedicated file. Must
-be a positive safe integer.
-
-### inlineSizeThreshold?
-
-```ts
-optional inlineSizeThreshold: number;
-```
-
-Max payload bytes kept inline in the data file. Zero is allowed. Must be a
-safe integer.
-
-### nullable?
-
-```ts
-optional nullable: boolean;
-```
-
-Defaults to true.
-
-### packFileSizeThreshold?
-
-```ts
-optional packFileSizeThreshold: number;
-```
-
-Max bytes in one packed sidecar before starting another. Must be a positive
-safe integer.

java/pom.xml

@@ -28,7 +28,7 @@
     <properties>
         <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
         <arrow.version>15.0.0</arrow.version>
-        <lance-core.version>12.0.0-beta.18</lance-core.version>
+        <lance-core.version>12.0.0-beta.15</lance-core.version>
         <spotless.skip>false</spotless.skip>
         <spotless.version>2.30.0</spotless.version>
         <spotless.java.googlejavaformat.version>1.7</spotless.java.googlejavaformat.version>

nodejs/__test__/blob.test.ts

@@ -1,185 +0,0 @@
-// SPDX-License-Identifier: Apache-2.0
-// SPDX-FileCopyrightText: Copyright The LanceDB Authors
-
-import { Field, Int64, List, Schema, Struct, Utf8 } from "apache-arrow";
-import { makeArrowTable } from "../lancedb/arrow";
-import { BlobFile, blob, coerceBlobValue, isBlobField } from "../lancedb/blob";
-
-describe("blob()", () => {
-  it("marks the field as lance.blob.v2", () => {
-    const field = blob("image", { nullable: false });
-    expect(field.nullable).toBe(false);
-    expect(isBlobField(field)).toBe(true);
-    expect(field.metadata.get("ARROW:extension:name")).toBe("lance.blob.v2");
-  });
-
-  it("writes encoding thresholds as field metadata", () => {
-    const field = blob("video", {
-      inlineSizeThreshold: 1024,
-      dedicatedSizeThreshold: 2 * 1024 * 1024,
-      packFileSizeThreshold: 64 * 1024 * 1024,
-    });
-    expect(
-      field.metadata.get("lance-encoding:blob-inline-size-threshold"),
-    ).toBe("1024");
-    expect(
-      field.metadata.get("lance-encoding:blob-dedicated-size-threshold"),
-    ).toBe(String(2 * 1024 * 1024));
-    expect(
-      field.metadata.get("lance-encoding:blob-pack-file-size-threshold"),
-    ).toBe(String(64 * 1024 * 1024));
-  });
-
-  it("rejects invalid thresholds", () => {
-    expect(() => blob("image", { inlineSizeThreshold: -1 })).toThrow(
-      /inlineSizeThreshold must be non-negative/,
-    );
-    expect(() => blob("image", { dedicatedSizeThreshold: 0 })).toThrow(
-      /dedicatedSizeThreshold must be positive/,
-    );
-    expect(() => blob("image", { packFileSizeThreshold: 1.5 })).toThrow(
-      /packFileSizeThreshold must be a safe integer/,
-    );
-    expect(() =>
-      blob("image", { dedicatedSizeThreshold: Number.MAX_SAFE_INTEGER + 1 }),
-    ).toThrow(/dedicatedSizeThreshold must be a safe integer/);
-  });
-});
-
-describe("coerceBlobValue", () => {
-  it.each([
-    ["Buffer", Buffer.from("x"), { data: Buffer.from("x"), uri: null }],
-    [
-      "Uint8Array",
-      new Uint8Array([120]),
-      { data: new Uint8Array([120]), uri: null },
-    ],
-    ["URI string", "s3://bucket/key", { data: null, uri: "s3://bucket/key" }],
-    [
-      "data struct",
-      { data: Buffer.from("y") },
-      { data: Buffer.from("y"), uri: null },
-    ],
-    [
-      "uri struct",
-      { uri: "s3://bucket/key" },
-      { data: null, uri: "s3://bucket/key" },
-    ],
-    ["null", null, null],
-  ])("accepts %s", (_name, input, expected) => {
-    expect(coerceBlobValue(input)).toEqual(expected);
-  });
-
-  it.each([
-    ["empty URI", "", /uri cannot be empty/],
-    ["object without data or uri", { position: 0 }, /data' or 'uri/],
-    [
-      "Int16Array",
-      new Int16Array([1]),
-      /Blob data must be Buffer or Uint8Array/,
-    ],
-    [
-      "both data and uri",
-      { data: Buffer.from("y"), uri: "s3://bucket/key" },
-      /exactly one of 'data' or 'uri'/,
-    ],
-    [
-      "neither data nor uri",
-      { data: null, uri: null },
-      /exactly one of 'data' or 'uri'/,
-    ],
-  ])("rejects %s", (_name, input, message) => {
-    expect(() => coerceBlobValue(input)).toThrow(message);
-  });
-});
-
-describe("BlobFile", () => {
-  it("rejects constructing BlobFile without a native handle", () => {
-    expect(() => new (BlobFile as unknown as { new (): BlobFile })()).toThrow(
-      /fetchBlobFiles/,
-    );
-  });
-});
-
-describe("makeArrowTable blob columns", () => {
-  it("coerces Buffer input onto a blob field", () => {
-    const schema = new Schema([
-      new Field("id", new Int64(), true),
-      blob("image"),
-    ]);
-    const table = makeArrowTable([{ id: 1n, image: Buffer.from("hello") }], {
-      schema,
-    });
-    expect(isBlobField(table.schema.fields[1])).toBe(true);
-    const image = table.getChild("image")!;
-    expect(image.nullCount).toBe(0);
-    expect(image.getChild("uri")!.get(0)).toBeNull();
-    expect(image.getChild("data")!.nullCount).toBe(0);
-    expect(Buffer.from(image.getChild("data")!.get(0)!).toString()).toBe(
-      "hello",
-    );
-  });
-
-  it("coerces Buffer elements inside a list and keeps null slots", () => {
-    const schema = new Schema([
-      new Field("id", new Int64(), true),
-      new Field("images", new List(blob("image")), true),
-    ]);
-    const table = makeArrowTable(
-      [
-        { id: 1n, images: [Buffer.from("a"), Buffer.from("bb")] },
-        { id: 2n, images: null },
-        { id: 3n, images: [Buffer.from("c"), null] },
-        { id: 4n, images: [] },
-      ],
-      { schema },
-    );
-    const images = table.getChild("images")!;
-    expect(images.nullCount).toBe(1);
-    const rows = images.toArray();
-    expect(rows[1]).toBeNull();
-    expect(Array.from(rows[3] as Iterable<unknown>)).toHaveLength(0);
-    const first = Array.from(rows[0] as Iterable<{ data: Uint8Array | null }>);
-    expect(Buffer.from(first[0].data!).toString()).toBe("a");
-    expect(Buffer.from(first[1].data!).toString()).toBe("bb");
-    const third = Array.from(
-      rows[2] as Iterable<{ data: Uint8Array | null } | null>,
-    );
-    expect(Buffer.from(third[0]!.data!).toString()).toBe("c");
-    expect(third[1]).toBeNull();
-  });
-
-  it("coerces Buffer fields inside list structs", () => {
-    const schema = new Schema([
-      new Field("id", new Int64(), true),
-      new Field(
-        "items",
-        new List(
-          new Field(
-            "item",
-            new Struct([new Field("name", new Utf8(), true), blob("image")]),
-            true,
-          ),
-        ),
-        true,
-      ),
-    ]);
-    const table = makeArrowTable(
-      [
-        {
-          id: 1n,
-          items: [{ name: "one", image: Buffer.from("alpha") }],
-        },
-      ],
-      { schema },
-    );
-    const items = Array.from(
-      table.getChild("items")!.toArray()[0] as Iterable<{
-        name: string;
-        image: { data: Uint8Array | null };
-      }>,
-    );
-    expect(items[0].name).toBe("one");
-    expect(Buffer.from(items[0].image.data!).toString()).toBe("alpha");
-  });
-});

nodejs/__test__/table.test.ts

@@ -18,7 +18,6 @@ import {
   Query,
   Table,
   VectorQuery,
-  blob,
   connect,
   tokenize,
 } from "../lancedb";
@@ -2402,276 +2401,6 @@ describe("when dealing with versioning", () => {
   });
 });
 
-describe("when dealing with blob columns", () => {
-  let tmpDir: tmp.DirResult;
-  beforeEach(() => {
-    tmpDir = tmp.dirSync({ unsafeCleanup: true });
-  });
-  afterEach(() => {
-    tmpDir.removeCallback();
-  });
-
-  it("discovers blob columns", async () => {
-    const { table } = await openBlobTable();
-    expect(await table.blobColumns()).toEqual(["image"]);
-  });
-
-  it("preserves order, duplicates, and nulls", async () => {
-    const { table, rowIds } = await openBlobTable();
-    const [alphaId, betaId, nullId] = rowIds;
-    const bytes = await table.fetchBlobs("image", [
-      betaId,
-      alphaId,
-      betaId,
-      nullId,
-    ]);
-    expect(bytes.map((b) => (b == null ? null : b.toString()))).toEqual([
-      "beta",
-      "alpha",
-      "beta",
-      null,
-    ]);
-    const files = await table.fetchBlobFiles("image", [
-      betaId,
-      nullId,
-      alphaId,
-    ]);
-    expect(files.map((f) => f == null)).toEqual([false, true, false]);
-  });
-
-  it("reads full blob contents", async () => {
-    const { table, rowIds, alpha, beta } = await openBlobTable();
-    const bytes = await table.fetchBlobs("image", rowIds);
-    expect(bytes[0]!.equals(alpha)).toBe(true);
-    expect(bytes[1]!.equals(beta)).toBe(true);
-    const files = await table.fetchBlobFiles("image", rowIds);
-    expect(files[0]!.size()).toBe(BigInt(alpha.length));
-    expect(Buffer.from(await files[0]!.read()).toString()).toBe("alpha");
-    expect(Buffer.from(await files[1]!.read()).toString()).toBe("beta");
-  });
-
-  it("reads a half-open range", async () => {
-    const { table, rowIds } = await openBlobTable();
-    const files = await table.fetchBlobFiles("image", rowIds);
-    expect(Buffer.from(await files[0]!.readRange(0n, 2n)).toString()).toBe(
-      "al",
-    );
-  });
-
-  it("readRange does not move the cursor", async () => {
-    const { table, rowIds, alpha } = await openBlobTable();
-    const [handle] = await table.fetchBlobFiles("image", rowIds);
-    expect((await handle!.readRange(1n, 3n)).toString()).toBe("lp");
-    expect(await handle!.read()).toEqual(alpha);
-    expect(await handle!.read()).toEqual(Buffer.alloc(0));
-  });
-
-  it("fails when readRange end is past the blob size", async () => {
-    const { table, rowIds, alpha } = await openBlobTable();
-    const files = await table.fetchBlobFiles("image", rowIds);
-    await expect(
-      files[0]!.readRange(0n, BigInt(alpha.length + 1)),
-    ).rejects.toThrow(/exceeds blob size/);
-  });
-
-  it("rejects fetchBlobs on a non-blob column", async () => {
-    const { table, rowIds } = await openBlobTable();
-    await expect(table.fetchBlobs("id", rowIds)).rejects.toThrow(/blob/i);
-  });
-
-  it("discovers and fetches nested blob columns", async () => {
-    const db = await connect(tmpDir.name);
-    const schema = new Schema([
-      new Field("id", new Int64(), true),
-      new Field("info", new Struct([blob("image")]), true),
-    ]);
-    const payload = Buffer.from("nested");
-    const table = await db.createTable(
-      "nested_blobs",
-      [{ id: 1n, info: { image: payload } }],
-      { schema },
-    );
-    expect(await table.blobColumns()).toEqual(["info.image"]);
-    const rows = await table.query().withRowId().toArray();
-    const bytes = await table.fetchBlobs("info.image", [
-      rows[0]._rowid as bigint,
-    ]);
-    expect(bytes[0]!.equals(payload)).toBe(true);
-  });
-
-  it("creates and adds list blob columns", async () => {
-    const db = await connect(tmpDir.name);
-    const schema = new Schema([
-      new Field("id", new Int64(), true),
-      new Field("images", new List(blob("image")), true),
-    ]);
-    const alpha = Buffer.from("alpha");
-    const beta = Buffer.from("beta");
-    const gamma = Buffer.from("gamma");
-    const table = await db.createTable(
-      "list_blobs",
-      [{ id: 1n, images: [alpha, beta] }],
-      { schema },
-    );
-    await table.add([
-      { id: 2n, images: null },
-      { id: 3n, images: [gamma, null] },
-      { id: 4n, images: [] },
-    ]);
-    expect(await table.blobColumns()).toEqual(["images.image"]);
-    const rows = await table.query().toArray();
-    const byId = new Map(rows.map((row) => [Number(row.id), row]));
-    expect(descriptorSizes(byId.get(1)!.images)).toEqual([
-      alpha.length,
-      beta.length,
-    ]);
-    expect(byId.get(2)!.images).toBeNull();
-    expect(descriptorSizes(byId.get(3)!.images)).toEqual([gamma.length, null]);
-    expect(Array.from(byId.get(4)!.images as Iterable<unknown>)).toHaveLength(
-      0,
-    );
-  });
-
-  it("creates and adds list struct blob columns", async () => {
-    const db = await connect(tmpDir.name);
-    const schema = new Schema([
-      new Field("id", new Int64(), true),
-      new Field(
-        "items",
-        new List(
-          new Field(
-            "item",
-            new Struct([new Field("name", new Utf8(), true), blob("image")]),
-            true,
-          ),
-        ),
-        true,
-      ),
-    ]);
-    const alpha = Buffer.from("nested-alpha");
-    const beta = Buffer.from("nested-beta");
-    const table = await db.createTable(
-      "list_struct_blobs",
-      [{ id: 1n, items: [{ name: "one", image: alpha }] }],
-      { schema },
-    );
-    await table.add([
-      {
-        id: 2n,
-        items: [
-          { name: "two", image: beta },
-          { name: "three", image: null },
-        ],
-      },
-    ]);
-    const rows = await table.query().toArray();
-    const byId = new Map(rows.map((row) => [Number(row.id), row]));
-    expect(
-      descriptorSizes(
-        Array.from(byId.get(1)!.items as Iterable<{ image: unknown }>).map(
-          (item) => item.image,
-        ),
-      ),
-    ).toEqual([alpha.length]);
-    expect(
-      descriptorSizes(
-        Array.from(byId.get(2)!.items as Iterable<{ image: unknown }>).map(
-          (item) => item.image,
-        ),
-      ),
-    ).toEqual([beta.length, null]);
-  });
-
-  it("rejects blob fields inside a fixed-size list", async () => {
-    const db = await connect(tmpDir.name);
-    const schema = new Schema([
-      new Field("id", new Int64(), true),
-      new Field("frames", new FixedSizeList(2, blob("frame")), true),
-    ]);
-    await expect(
-      db.createTable(
-        "fsl_blobs",
-        [{ id: 1n, frames: [Buffer.from("a"), Buffer.from("b")] }],
-        { schema },
-      ),
-    ).rejects.toThrow(
-      "Blob fields inside FixedSizeList are not supported. Use List instead.",
-    );
-  });
-
-  it("rejects blob fields inside a nested fixed-size list", async () => {
-    const db = await connect(tmpDir.name);
-    const schema = new Schema([
-      new Field("id", new Int64(), true),
-      new Field(
-        "clip",
-        new Struct([
-          new Field("frames", new FixedSizeList(2, blob("frame")), true),
-        ]),
-        true,
-      ),
-    ]);
-    await expect(
-      db.createTable(
-        "nested_fsl_blobs",
-        [
-          {
-            id: 1n,
-            clip: { frames: [Buffer.from("a"), Buffer.from("b")] },
-          },
-        ],
-        { schema },
-      ),
-    ).rejects.toThrow(
-      "Blob fields inside FixedSizeList are not supported. Use List instead.",
-    );
-  });
-
-  it("rejects an Arrow table with blob fields inside a fixed-size list", async () => {
-    const db = await connect(tmpDir.name);
-    const schema = new Schema([
-      new Field("id", new Int64(), true),
-      new Field("frames", new FixedSizeList(2, blob("frame")), true),
-    ]);
-    await expect(
-      db.createTable("fsl_blobs_ipc", new ArrowTable(schema)),
-    ).rejects.toThrow(
-      "Blob fields inside FixedSizeList are not supported. Use List instead.",
-    );
-  });
-
-  function descriptorSizes(values: unknown): (number | null)[] {
-    return Array.from(
-      values as Iterable<{ size?: bigint | number } | null>,
-    ).map((value) => (value == null ? null : Number(value.size)));
-  }
-
-  async function openBlobTable() {
-    const db = await connect(tmpDir.name);
-    const schema = new Schema([
-      new Field("id", new Int64(), true),
-      blob("image"),
-    ]);
-    const alpha = Buffer.from("alpha");
-    const beta = Buffer.from("beta");
-    const table = await db.createTable(
-      "blobs",
-      [
-        { id: 1n, image: alpha },
-        { id: 2n, image: beta },
-        { id: 3n, image: null },
-      ],
-      { schema },
-    );
-    const rows = await table.query().withRowId().toArray();
-    const rowIdById = new Map(
-      rows.map((r) => [Number(r.id), r._rowid as bigint]),
-    );
-    const rowIds = [1, 2, 3].map((id) => rowIdById.get(id)!);
-    return { table, rowIds, alpha, beta };
-  }
-});
-
 describe("when dealing with tags", () => {
   let tmpDir: tmp.DirResult;
   beforeEach(() => {
@@ -3523,7 +3252,7 @@ describe.each([arrow15, arrow16, arrow17, arrow18])(
       const db = await connect(tmpDir.name);
       const data = [
         { text: "fa", vector: [0.1, 0.2, 0.3] },
-        { text: "fo", vector: [0.4, 0.5, 0.6] }, // spellchecker:disable-line
+        { text: "fo", vector: [0.4, 0.5, 0.6] },
         { text: "fob", vector: [0.4, 0.5, 0.6] },
         { text: "focus", vector: [0.4, 0.5, 0.6] },
         { text: "foo", vector: [0.4, 0.5, 0.6] },
@@ -3548,7 +3277,7 @@ describe.each([arrow15, arrow16, arrow17, arrow18])(
       const resultSet = new Set(fuzzyResults.map((r) => r.text));
       expect(resultSet.has("foo")).toBe(true);
       expect(resultSet.has("fob")).toBe(true);
-      expect(resultSet.has("fo")).toBe(true); // spellchecker:disable-line
+      expect(resultSet.has("fo")).toBe(true);
       expect(resultSet.has("food")).toBe(true);
 
       const prefixResults = await table

nodejs/lancedb/arrow.ts

@@ -40,7 +40,6 @@ import {
 } from "apache-arrow";
 import { Buffers } from "apache-arrow/data";
 import { typedArrayToArrowType } from "./arrow_type";
-import { coerceBlobValue, isBlobField } from "./blob";
 import { type EmbeddingFunction } from "./embedding/embedding_function";
 import {
   EmbeddingFunctionConfig,
@@ -431,14 +430,12 @@ export function makeArrowTable(
       throw new Error("A schema must be provided if data is empty");
     } else {
       schema = new Schema(schema.fields, schemaMetadata);
-      validateBlobSchema(schema);
       return new ArrowTable(schema);
     }
   }
 
   let inferredSchema = inferSchema(data, schema, opt);
   inferredSchema = new Schema(inferredSchema.fields, schemaMetadata);
-  validateBlobSchema(inferredSchema);
 
   const finalColumns: Record<string, Vector> = {};
   for (const field of inferredSchema.fields) {
@@ -448,35 +445,6 @@ export function makeArrowTable(
   return new ArrowTable(inferredSchema, finalColumns);
 }
 
-function validateBlobSchema(schema: Schema): void {
-  for (const field of schema.fields) {
-    validateBlobField(field);
-  }
-}
-
-function validateBlobField(field: Field): void {
-  if (
-    isFixedSizeList(field.type) &&
-    containsBlobField(field.type.children[0])
-  ) {
-    throw new Error(
-      "Blob fields inside FixedSizeList are not supported. Use List instead.",
-    );
-  }
-  for (const child of field.type.children ?? []) {
-    validateBlobField(child);
-  }
-}
-
-function containsBlobField(field: Field): boolean {
-  if (isBlobField(field)) {
-    return true;
-  }
-  return (field.type.children ?? []).some((child: Field) =>
-    containsBlobField(child),
-  );
-}
-
 function isObject(value: unknown): value is Record<string, unknown> {
   return (
     typeof value === "object" &&
@@ -512,32 +480,6 @@ function transposeData(
   path: string[] = [],
 ): Vector {
   const valuesPath = [...path, field.name];
-  if (isBlobField(field) && field.type instanceof Struct) {
-    const blobRows = data.map((datum) =>
-      coerceBlobValue(valueAtPath(datum, valuesPath)),
-    );
-    const childVectors = field.type.children.map((child) => {
-      const values = blobRows.map((row) =>
-        row == null ? null : (row[child.name as "data" | "uri"] ?? null),
-      );
-      return makeVector(values, child.type, undefined, child.nullable);
-    });
-    const nullCount = blobRows.filter((row) => row === null).length;
-    const structData = makeData({
-      type: field.type,
-      length: blobRows.length,
-      nullCount,
-      nullBitmap:
-        nullCount > 0
-          ? arrowUtil.packBools(blobRows.map((row) => row !== null))
-          : undefined,
-      children: childVectors.map((v) => v.data[0]),
-    });
-    return arrowMakeVector(structData);
-  }
-  if (isList(field.type) && containsBlobField(field.type.children[0])) {
-    return transposeListData(data, field, valuesPath);
-  }
   const values = data.map((datum) => valueAtPath(datum, valuesPath));
   if (field.type instanceof Struct) {
     const childFields = field.type.children;
@@ -553,7 +495,7 @@ function transposeData(
         nullCount > 0
           ? arrowUtil.packBools(values.map((value) => value !== null))
           : undefined,
-      children: childVectors.map((v) => v.data[0]),
+      children: childVectors as unknown as ArrowData<DataType>[],
     });
     return arrowMakeVector(structData);
   } else {
@@ -561,48 +503,6 @@ function transposeData(
   }
 }
 
-function transposeListData(
-  data: Record<string, unknown>[],
-  field: Field,
-  valuesPath: string[],
-): Vector {
-  const listType = field.type as List;
-  const childField = listType.children[0];
-  const lists = data.map((datum) => valueAtPath(datum, valuesPath));
-  const flattened: Record<string, unknown>[] = [];
-  const validity: boolean[] = [];
-  const offsets: number[] = [0];
-
-  for (const list of lists) {
-    if (list == null) {
-      validity.push(false);
-      offsets.push(flattened.length);
-      continue;
-    }
-    if (!Array.isArray(list)) {
-      throw new Error(`expected an array for list field '${field.name}'`);
-    }
-    validity.push(true);
-    for (const element of list) {
-      flattened.push({ [childField.name]: element });
-    }
-    offsets.push(flattened.length);
-  }
-
-  const childVector = transposeData(flattened, childField, []);
-  const nullCount = validity.filter((valid) => !valid).length;
-  return arrowMakeVector(
-    makeData({
-      type: listType,
-      length: lists.length,
-      nullCount,
-      nullBitmap: nullCount > 0 ? arrowUtil.packBools(validity) : undefined,
-      valueOffsets: Int32Array.from(offsets),
-      child: childVector.data[0],
-    }),
-  );
-}
-
 /**
  * Create an empty Arrow table with the provided schema
  */
@@ -700,7 +600,7 @@ function makeVector(
   }
   if (values.length === 0) {
     throw Error(
-      "makeVector requires at least one value or the type must be specified",
+      "makeVector requires at least one value or the type must be specfied",
     );
   }
   const sampleValue = values.find((val) => val !== null && val !== undefined);
@@ -958,7 +858,7 @@ async function applyEmbeddings<T>(
  * customized by the `embeddingDataType` property of the embedding function.
  *
  * If a schema is provided in `makeTableOptions` then it should include the
- * embedding columns.  If no schema is provided then embedding columns will
+ * embedding columns.  If no schema is provded then embedding columns will
  * be placed at the end of the table, after all of the input columns.
  */
 export async function convertToTable(
@@ -1052,7 +952,6 @@ export async function fromTableToBuffer(
     schema = sanitizeSchema(schema);
   }
   const tableWithEmbeddings = await applyEmbeddings(table, embeddings, schema);
-  validateBlobSchema(tableWithEmbeddings.schema);
   const writer = RecordBatchFileWriter.writeAll(tableWithEmbeddings);
   return Buffer.from(await writer.toUint8Array());
 }

nodejs/lancedb/blob.ts

@@ -1,236 +0,0 @@
-// SPDX-License-Identifier: Apache-2.0
-// SPDX-FileCopyrightText: Copyright The LanceDB Authors
-
-import { Field, LargeBinary, Struct, Utf8 } from "apache-arrow";
-import { BlobFile as NativeBlobFile } from "./native";
-
-const BLOB_V2_EXTENSION_NAME = "lance.blob.v2";
-
-const INLINE_SIZE_THRESHOLD_KEY = "lance-encoding:blob-inline-size-threshold";
-const DEDICATED_SIZE_THRESHOLD_KEY =
-  "lance-encoding:blob-dedicated-size-threshold";
-const PACK_FILE_SIZE_THRESHOLD_KEY =
-  "lance-encoding:blob-pack-file-size-threshold";
-
-export type BlobInput = {
-  data: Buffer | Uint8Array | null;
-  uri: string | null;
-};
-
-export type BlobOptions = {
-  /** Defaults to true. */
-  nullable?: boolean;
-  /**
-   * Max payload bytes kept inline in the data file. Zero is allowed. Must be a
-   * safe integer.
-   */
-  inlineSizeThreshold?: number;
-  /**
-   * Max payload bytes stored in a packed sidecar before a dedicated file. Must
-   * be a positive safe integer.
-   */
-  dedicatedSizeThreshold?: number;
-  /**
-   * Max bytes in one packed sidecar before starting another. Must be a positive
-   * safe integer.
-   */
-  packFileSizeThreshold?: number;
-};
-
-/**
- * Declares a `lance.blob.v2` column.
- *
- * Query results are descriptors, not payload bytes. Use {@link Table.fetchBlobs}
- * or {@link Table.fetchBlobFiles} to read bytes.
- *
- * @example
- * ```ts
- * import { readFile } from "node:fs/promises";
- * import { Field, Int64, Schema } from "apache-arrow";
- * import { blob, connect } from "@lancedb/lancedb";
- *
- * const db = await connect("./data");
- * const video = await readFile("clip.mp4");
- * const table = await db.createTable(
- *   "videos",
- *   [{ id: 1n, video }],
- *   {
- *     schema: new Schema([
- *       new Field("id", new Int64()),
- *       blob("video"),
- *     ]),
- *   },
- * );
- *
- * const rows = await table.query().select(["id"]).withRowId().toArray();
- * const rowIds = rows.map((row) => row._rowid as bigint);
- * const bytes = await table.fetchBlobs("video", rowIds);
- *
- * const [handle] = await table.fetchBlobFiles("video", rowIds);
- * const size = handle!.size();
- * const header = await handle!.readRange(0n, size < 65536n ? size : 65536n);
- * ```
- */
-export function blob(name: string, options: BlobOptions = {}): Field {
-  const metadata = new Map<string, string>([
-    ["ARROW:extension:name", BLOB_V2_EXTENSION_NAME],
-  ]);
-  setThreshold(
-    metadata,
-    INLINE_SIZE_THRESHOLD_KEY,
-    "inlineSizeThreshold",
-    options.inlineSizeThreshold,
-    0,
-  );
-  setThreshold(
-    metadata,
-    DEDICATED_SIZE_THRESHOLD_KEY,
-    "dedicatedSizeThreshold",
-    options.dedicatedSizeThreshold,
-    1,
-  );
-  setThreshold(
-    metadata,
-    PACK_FILE_SIZE_THRESHOLD_KEY,
-    "packFileSizeThreshold",
-    options.packFileSizeThreshold,
-    1,
-  );
-  return new Field(
-    name,
-    new Struct([
-      new Field("data", new LargeBinary(), true),
-      new Field("uri", new Utf8(), true),
-    ]),
-    options.nullable ?? true,
-    metadata,
-  );
-}
-
-/**
- * Checks for the `lance.blob.v2` extension marker. Does not validate the
- * field's storage type.
- */
-export function isBlobField(field: Field): boolean {
-  return field.metadata?.get("ARROW:extension:name") === BLOB_V2_EXTENSION_NAME;
-}
-
-/**
- * A lazy handle to blob bytes. Create one with {@link Table.fetchBlobFiles}.
- *
- * @hideconstructor
- */
-export class BlobFile {
-  private readonly inner: NativeBlobFile;
-
-  private constructor(inner: NativeBlobFile) {
-    if (!(inner instanceof NativeBlobFile)) {
-      throw new Error("BlobFile handles come from Table.fetchBlobFiles");
-    }
-    this.inner = inner;
-  }
-
-  /** @ignore */
-  static fromNative(inner: NativeBlobFile): BlobFile {
-    return new BlobFile(inner);
-  }
-
-  /** Returns the blob size in bytes. */
-  size(): bigint {
-    return this.inner.size();
-  }
-
-  /**
-   * Reads from the cursor to the end and advances the cursor.
-   *
-   * A second call returns an empty buffer. {@link BlobFile.readRange} does
-   * not move the cursor.
-   */
-  read(): Promise<Buffer> {
-    return this.inner.read();
-  }
-
-  /**
-   * Reads the half-open byte range `[start, end)`.
-   *
-   * Fails when `end` is past the blob size. Does not move the cursor.
-   */
-  readRange(start: bigint, end: bigint): Promise<Buffer> {
-    return this.inner.readRange(start, end);
-  }
-}
-
-export function coerceBlobValue(value: unknown): BlobInput | null {
-  if (value == null) {
-    return null;
-  }
-  if (isBlobBytes(value)) {
-    return { data: value, uri: null };
-  }
-  if (ArrayBuffer.isView(value)) {
-    throw new Error("Blob data must be Buffer or Uint8Array");
-  }
-  if (typeof value === "string") {
-    if (value === "") {
-      throw new Error("Blob uri cannot be empty");
-    }
-    return { data: null, uri: value };
-  }
-  if (typeof value === "object") {
-    const record = value as Record<string, unknown>;
-    if (!("data" in record) && !("uri" in record)) {
-      throw new Error(
-        "Blob struct values must include a 'data' or 'uri' field",
-      );
-    }
-    const uri = record.uri;
-    if (uri === "") {
-      throw new Error("Blob uri cannot be empty");
-    }
-    if (uri != null && typeof uri !== "string") {
-      throw new Error(`Blob uri must be a string or null, got ${typeof uri}`);
-    }
-    const data = record.data;
-    if (data != null && !isBlobBytes(data)) {
-      throw new Error("Blob data must be Buffer, Uint8Array, or null");
-    }
-    const bytes = (data as Buffer | Uint8Array | null | undefined) ?? null;
-    const uriValue = uri ?? null;
-    if ((bytes == null) === (uriValue == null)) {
-      throw new Error(
-        "Blob struct values must set exactly one of 'data' or 'uri'",
-      );
-    }
-    return { data: bytes, uri: uriValue };
-  }
-  throw new Error(
-    "Blob column values must be Buffer, Uint8Array, a URI string, null, or { data?, uri? }",
-  );
-}
-
-function isBlobBytes(value: unknown): value is Buffer | Uint8Array {
-  return Buffer.isBuffer(value) || value instanceof Uint8Array;
-}
-
-function setThreshold(
-  metadata: Map<string, string>,
-  key: string,
-  optionName: string,
-  value: number | undefined,
-  minimum: number,
-): void {
-  if (value === undefined) {
-    return;
-  }
-  if (!Number.isSafeInteger(value)) {
-    throw new Error(`${optionName} must be a safe integer`);
-  }
-  if (value < minimum) {
-    throw new Error(
-      minimum <= 0
-        ? `${optionName} must be non-negative`
-        : `${optionName} must be positive`,
-    );
-  }
-  metadata.set(key, String(value));
-}

nodejs/lancedb/index.ts

@@ -77,9 +77,6 @@ export {
   VectorColumnOptions,
 } from "./arrow";
 
-export { blob, isBlobField, BlobFile } from "./blob";
-export type { BlobOptions } from "./blob";
-
 export {
   Connection,
   CreateTableOptions,

nodejs/lancedb/indices.ts

@@ -26,7 +26,7 @@ export interface IvfPqOptions {
    * This value controls how much the vector is compressed during the quantization step.
    * The more sub vectors there are the less the vector is compressed.  The default is
    * the dimension of the vector divided by 16.  If the dimension is not evenly divisible
-   * by 16 we use the dimension divided by 8.
+   * by 16 we use the dimension divded by 8.
    *
    * The above two cases are highly preferred.  Having 8 or 16 values per subvector allows
    * us to use efficient SIMD instructions.
@@ -228,7 +228,7 @@ export interface HnswPqOptions {
    * This value controls how much the vector is compressed during the quantization step.
    * The more sub vectors there are the less the vector is compressed.  The default is
    * the dimension of the vector divided by 16.  If the dimension is not evenly divisible
-   * by 16 we use the dimension divided by 8.
+   * by 16 we use the dimension divded by 8.
    *
    * The above two cases are highly preferred.  Having 8 or 16 values per subvector allows
    * us to use efficient SIMD instructions.
@@ -825,7 +825,7 @@ export interface IndexOptions {
   /**
    * Advanced index configuration
    *
-   * This option allows you to specify a specific index to create and also
+   * This option allows you to specify a specfic index to create and also
    * allows you to pass in configuration for training the index.
    *
    * See the static methods on Index for details on the various index types.

nodejs/lancedb/merge.ts

@@ -27,7 +27,7 @@ export class MergeInsertBuilder {
    * but that behavior is subject to change.
    *
    * An optional condition may be specified.  If it is, then only
-   * matched rows that satisfy the condition will be updated.  Any
+   * matched rows that satisfy the condtion will be updated.  Any
    * rows that do not satisfy the condition will be left as they
    * are.  Failing to satisfy the condition does not cause a
    * "matched row" to become a "not matched" row.

nodejs/lancedb/sanitize.ts

@@ -3,7 +3,7 @@
 
 // The utilities in this file help sanitize data from the user's arrow
 // library into the types expected by vectordb's arrow library.  Node
-// generally allows for multiple versions of the same library (and sometimes
+// generally allows for mulitple versions of the same library (and sometimes
 // even multiple copies of the same version) to be installed at the same
 // time.  However, arrow-js uses instanceof which expected that the input
 // comes from the exact same library instance.  This is not always the case

nodejs/lancedb/table.ts

@@ -17,7 +17,6 @@ import {
   tableFromIPC,
 } from "./arrow";
 
-import { BlobFile } from "./blob";
 import { EmbeddingFunctionConfig, getRegistry } from "./embedding/registry";
 import { IndexOptions } from "./indices";
 import { Job } from "./job";
@@ -314,7 +313,7 @@ export abstract class Table {
    * Note: if your condition is something like "some_id_column == 7" and
    * you are updating many rows (with different ids) then you will get
    * better performance with a single [`merge_insert`] call instead of
-   * repeatedly calling this method.
+   * repeatedly calilng this method.
    * @param {Map<string, string> | Record<string, string>} updates - the
    * columns to update
    * @returns {Promise<UpdateResult>} A promise that resolves to an object
@@ -511,35 +510,6 @@ export abstract class Table {
    */
   abstract takeRowIds(rowIds: readonly (bigint | number)[]): TakeQuery;
 
-  /**
-   * Blob v2 columns, including nested dotted paths.
-   */
-  abstract blobColumns(): Promise<string[]>;
-
-  /**
-   * Bytes for `column` at row IDs from {@link Query.withRowId}.
-   *
-   * Reads the table's current checkout. IDs from another version can fail after
-   * compaction unless stable row ids are enabled. Results keep input order and
-   * duplicates. Null blobs are `null`. Empty blobs are empty buffers.
-   */
-  abstract fetchBlobs(
-    column: string,
-    rowIds: readonly (bigint | number)[],
-  ): Promise<(Buffer | null)[]>;
-
-  /**
-   * Opens lazy blob handles for `column` at the given row IDs using the
-   * table's current checkout.
-   *
-   * Preserves input order, duplicates, and nulls. Use this for large payloads.
-   * See {@link Table.fetchBlobs} for row-ID validity across versions.
-   */
-  abstract fetchBlobFiles(
-    column: string,
-    rowIds: readonly (bigint | number)[],
-  ): Promise<(BlobFile | null)[]>;
-
   /**
    * Create a search query to find the nearest neighbors
    * of the given query
@@ -1190,34 +1160,23 @@ export class LocalTable extends Table {
   }
 
   takeRowIds(rowIds: readonly (bigint | number)[]): TakeQuery {
-    return new TakeQuery(this.inner.takeRowIds(rowIdsToBigInts(rowIds)));
-  }
+    const ids = rowIds.map((id) => {
+      if (typeof id === "bigint") {
+        return id;
+      }
+      if (!Number.isInteger(id)) {
+        throw new Error("Row id must be an integer (or bigint)");
+      }
+      if (id < 0) {
+        throw new Error("Row id cannot be negative");
+      }
+      if (!Number.isSafeInteger(id)) {
+        throw new Error("Row id is too large for number; use bigint instead");
+      }
+      return BigInt(id);
+    });
 
-  blobColumns(): Promise<string[]> {
-    return this.inner.blobColumns();
-  }
-
-  async fetchBlobs(
-    column: string,
-    rowIds: readonly (bigint | number)[],
-  ): Promise<(Buffer | null)[]> {
-    const values = await this.inner.fetchBlobs(column, rowIdsToBigInts(rowIds));
-    // N-API Option maps missing values to undefined. Collapse those to null.
-    return values.map((value) => value ?? null);
-  }
-
-  async fetchBlobFiles(
-    column: string,
-    rowIds: readonly (bigint | number)[],
-  ): Promise<(BlobFile | null)[]> {
-    const files = await this.inner.fetchBlobFiles(
-      column,
-      rowIdsToBigInts(rowIds),
-    );
-    // N-API Option maps missing values to undefined. Collapse those to null.
-    return files.map((file) =>
-      file == null ? null : BlobFile.fromNative(file),
-    );
+    return new TakeQuery(this.inner.takeRowIds(ids));
   }
 
   query(): Query {
@@ -1774,21 +1733,3 @@ export class Branches {
     )) as unknown as CherryPickResult;
   }
 }
-
-function rowIdsToBigInts(rowIds: readonly (bigint | number)[]): bigint[] {
-  return rowIds.map((id) => {
-    if (typeof id === "bigint") {
-      return id;
-    }
-    if (!Number.isInteger(id)) {
-      throw new Error("Row id must be an integer (or bigint)");
-    }
-    if (id < 0) {
-      throw new Error("Row id cannot be negative");
-    }
-    if (!Number.isSafeInteger(id)) {
-      throw new Error("Row id is too large for number; use bigint instead");
-    }
-    return BigInt(id);
-  });
-}

nodejs/src/blob.rs

@@ -1,95 +0,0 @@
-// SPDX-License-Identifier: Apache-2.0
-// SPDX-FileCopyrightText: Copyright The LanceDB Authors
-
-use std::ops::Range;
-use std::sync::Arc;
-
-use arrow_array::{Array, LargeBinaryArray};
-use lancedb::blob::BlobFile as LanceBlobFile;
-use napi::bindgen_prelude::*;
-use napi_derive::napi;
-
-use crate::error::convert_error;
-
-#[napi]
-pub struct BlobFile {
-    inner: Arc<LanceBlobFile>,
-}
-
-impl BlobFile {
-    pub(crate) fn new(inner: LanceBlobFile) -> Self {
-        Self {
-            inner: Arc::new(inner),
-        }
-    }
-}
-
-#[napi]
-impl BlobFile {
-    #[napi]
-    pub fn size(&self) -> BigInt {
-        BigInt::from(self.inner.size())
-    }
-
-    #[napi]
-    pub async fn read(&self) -> napi::Result<Buffer> {
-        let bytes = self.inner.read().await.map_err(|err| convert_error(&err))?;
-        Ok(Buffer::from(bytes.as_ref()))
-    }
-
-    #[napi]
-    pub async fn read_range(&self, start: BigInt, end: BigInt) -> napi::Result<Buffer> {
-        let range = bigint_range(start, end)?;
-        let bytes = self
-            .inner
-            .read_range(range)
-            .await
-            .map_err(|err| convert_error(&err))?;
-        Ok(Buffer::from(bytes.as_ref()))
-    }
-}
-
-fn bigint_range(start: BigInt, end: BigInt) -> napi::Result<Range<u64>> {
-    let start = parse_u64(start, "start")?;
-    let end = parse_u64(end, "end")?;
-    if start > end {
-        return Err(napi::Error::from_reason(format!(
-            "invalid blob range: start ({start}) > end ({end})"
-        )));
-    }
-    Ok(start..end)
-}
-
-fn parse_u64(value: BigInt, name: &str) -> napi::Result<u64> {
-    let (negative, value, lossless) = value.get_u64();
-    if negative {
-        return Err(napi::Error::from_reason(format!(
-            "{name} cannot be negative"
-        )));
-    }
-    if !lossless {
-        return Err(napi::Error::from_reason(format!(
-            "{name} is too large to fit in u64"
-        )));
-    }
-    Ok(value)
-}
-
-pub fn parse_row_ids(row_ids: Vec<BigInt>) -> napi::Result<Vec<u64>> {
-    row_ids
-        .into_iter()
-        .map(|id| parse_u64(id, "row id"))
-        .collect()
-}
-
-pub fn copy_blob_buffers(array: LargeBinaryArray) -> Vec<Option<Buffer>> {
-    (0..array.len())
-        .map(|i| {
-            if array.is_null(i) {
-                None
-            } else {
-                Some(Buffer::from(array.value(i).to_vec()))
-            }
-        })
-        .collect()
-}

nodejs/src/lib.rs

@@ -10,7 +10,6 @@ use std::collections::HashMap;
 use env_logger::Env;
 use napi_derive::*;
 
-mod blob;
 mod connection;
 mod error;
 mod header;

nodejs/src/table.rs

@@ -15,7 +15,6 @@ use napi::bindgen_prelude::*;
 use napi::threadsafe_function::{ThreadsafeFunction, ThreadsafeFunctionCallMode};
 use napi_derive::napi;
 
-use crate::blob::{BlobFile, copy_blob_buffers, parse_row_ids};
 use crate::error::NapiErrorExt;
 use crate::index::Index;
 use crate::merge::NativeMergeInsertBuilder;
@@ -330,44 +329,6 @@ impl Table {
         ))
     }
 
-    #[napi(catch_unwind)]
-    pub async fn blob_columns(&self) -> napi::Result<Vec<String>> {
-        self.inner_ref()?.blob_columns().await.default_error()
-    }
-
-    #[napi(catch_unwind)]
-    pub async fn fetch_blobs(
-        &self,
-        column: String,
-        row_ids: Vec<BigInt>,
-    ) -> napi::Result<Vec<Option<Buffer>>> {
-        let row_ids = parse_row_ids(row_ids)?;
-        let array = self
-            .inner_ref()?
-            .fetch_blobs(column.as_str(), &row_ids)
-            .await
-            .default_error()?;
-        Ok(copy_blob_buffers(array))
-    }
-
-    #[napi(catch_unwind)]
-    pub async fn fetch_blob_files(
-        &self,
-        column: String,
-        row_ids: Vec<BigInt>,
-    ) -> napi::Result<Vec<Option<BlobFile>>> {
-        let row_ids = parse_row_ids(row_ids)?;
-        let files = self
-            .inner_ref()?
-            .fetch_blob_files(column.as_str(), &row_ids)
-            .await
-            .default_error()?;
-        Ok(files
-            .into_iter()
-            .map(|file| file.map(BlobFile::new))
-            .collect())
-    }
-
     #[napi(catch_unwind)]
     pub fn vector_search(&self, vector: Float32Array) -> napi::Result<VectorQuery> {
         self.query()?.nearest_to(vector)

python/python/lancedb/embeddings/gte.py

@@ -21,7 +21,7 @@ class GteEmbeddings(TextEmbeddingFunction):
     An embedding function that uses GTE-LARGE MLX format(for Apple silicon devices only)
     as well as the standard cpu/gpu version from: https://huggingface.co/thenlper/gte-large.
 
-    For Apple users, you will need the mlx package installed, which can be done with:
+    For Apple users, you will need the mlx package insalled, which can be done with:
         pip install mlx
 
     Parameters

python/python/lancedb/embeddings/instructor.py

@@ -60,7 +60,7 @@ class InstructorEmbeddingFunction(TextEmbeddingFunction):
 
     import lancedb
     from lancedb.pydantic import LanceModel, Vector
-    from lancedb.embeddings import get_registry, InstructorEmbeddingFunction
+    from lancedb.embeddings import get_registry, InstuctorEmbeddingFunction
 
     instructor = get_registry().get("instructor").create(
         source_instruction="represent the document for retrieval",

python/python/lancedb/index.py

@@ -751,7 +751,7 @@ class IvfPq:
         This value controls how much the vector is compressed during the
         quantization step.  The more sub vectors there are the less the vector is
         compressed.  The default is the dimension of the vector divided by 16.  If
-        the dimension is not evenly divisible by 16 we use the dimension divided by
+        the dimension is not evenly divisible by 16 we use the dimension divded by
         8.
 
         The above two cases are highly preferred.  Having 8 or 16 values per

python/python/lancedb/query.py

@@ -78,10 +78,6 @@ if TYPE_CHECKING:
 T = TypeVar("T", bound="LanceModel")
 AnalyzePlanDistributedMetrics = Literal["aggregate", "per_worker", "full"]
 
-# Number of rows a hybrid query returns when no limit was set on it. This
-# mirrors the default the Rust query builder applies to its sub-queries.
-DEFAULT_HYBRID_LIMIT = 10
-
 
 @runtime_checkable
 class _LanceScanner(Protocol):
@@ -863,7 +859,7 @@ class Query(pydantic.BaseModel):
         return query
 
     # This tells pydantic to allow custom types (needed for the `vector` query since
-    # pa.Array wouldn't be allowed otherwise)
+    # pa.Array wouln't be allowed otherwise)
     model_config = pydantic.ConfigDict(arbitrary_types_allowed=True)
 
 
@@ -3897,54 +3893,14 @@ class AsyncHybridQuery(AsyncStandardQuery, AsyncVectorQueryBase):
 
         return self
 
-    def _create_child_queries(
-        self,
-    ) -> Tuple["AsyncFTSQuery", "AsyncVectorQuery", int, int]:
-        """Build the sub-queries that make up this hybrid query.
-
-        Execution, `explain_plan` and `analyze_plan` all go through here so that
-        the plans that are reported are the plans that actually run.
-
-        Returns the two sub-queries along with the effective limit and offset of
-        the hybrid query itself.
-        """
-        fts_query = AsyncFTSQuery(self._inner.to_fts_query(), self._table)
-        vec_query = AsyncVectorQuery(self._inner.to_vector_query(), self._table)
-
-        fts_req = fts_query._inner.to_query_request()
-        vec_req = vec_query._inner.to_query_request()
-
-        # Only one of the two sub-queries carries the limit when it was never
-        # set explicitly: nearest_to()/nearest_to_text() build the sibling query
-        # from scratch, and that is where the default gets filled in. Which one
-        # that is depends on the order the hybrid query was built in, so look at
-        # both rather than at a single side.
-        limit = fts_req.limit if fts_req.limit is not None else vec_req.limit
-        if limit is None:
-            limit = DEFAULT_HYBRID_LIMIT
-        offset = fts_req.offset or vec_req.offset or 0
-
-        fts_query.with_row_id()
-        vec_query.with_row_id()
-
-        # offset() pushes the offset down into both sub-queries, which would make
-        # each of them skip its own first `offset` rows. The window has to be
-        # taken out of the combined, reranked results instead, so fetch the
-        # skipped prefix here too and slice it off afterwards.
-        fts_query.limit(limit + offset)
-        vec_query.limit(limit + offset)
-        fts_query.offset(0)
-        vec_query.offset(0)
-
-        return fts_query, vec_query, limit, offset
-
     async def to_batches(
         self,
         *,
         max_batch_length: Optional[int] = None,
         timeout: Optional[timedelta] = None,
     ) -> AsyncRecordBatchReader:
-        fts_query, vec_query, limit, offset = self._create_child_queries()
+        fts_query = AsyncFTSQuery(self._inner.to_fts_query(), self._table)
+        vec_query = AsyncVectorQuery(self._inner.to_vector_query(), self._table)
 
         req = fts_query._inner.to_query_request()
         blob_auto_row_id = False
@@ -3964,6 +3920,9 @@ class AsyncHybridQuery(AsyncStandardQuery, AsyncVectorQueryBase):
         self._blob_auto_row_id = blob_auto_row_id
         self._blob_paths = blob_paths
 
+        fts_query.with_row_id()
+        vec_query.with_row_id()
+
         fts_results, vector_results = await asyncio.gather(
             fts_query.to_arrow(timeout=timeout),
             vec_query.to_arrow(timeout=timeout),
@@ -3975,9 +3934,8 @@ class AsyncHybridQuery(AsyncStandardQuery, AsyncVectorQueryBase):
             norm=self._norm,
             fts_query=fts_query.get_query(),
             reranker=self._reranker,
-            limit=limit,
+            limit=self._inner.get_limit(),
             with_row_ids=True,
-            offset=offset,
         )
         if (
             not self._user_requested_row_id()
@@ -4006,14 +3964,14 @@ class AsyncHybridQuery(AsyncStandardQuery, AsyncVectorQueryBase):
         ...     print(plan)
         >>> asyncio.run(doctest_example()) # doctest: +ELLIPSIS, +NORMALIZE_WHITESPACE
         RRFReranker(K=60)
-            ProjectionExec: expr=[vector@0 as vector, text@3 as text, _distance@2 as _distance, _rowid@1 as _rowid]
+            ProjectionExec: expr=[vector@0 as vector, text@3 as text, _distance@2 as _distance]
               LanceRead: uri=..., projection=[text], source=stream(_rowid)
                 GlobalLimitExec: skip=0, fetch=10
                   FilterExec: _distance@2 IS NOT NULL
                     SortExec: TopK(fetch=10), expr=[_distance@2 ASC NULLS LAST, _rowid@1 ASC NULLS LAST], preserve_partitioning=[false]
                       KNNVectorDistance: metric=l2
                         LanceRead: uri=..., projection=[vector], ...
-            ProjectionExec: expr=[vector@2 as vector, text@3 as text, _score@1 as _score, _rowid@0 as _rowid]
+            ProjectionExec: expr=[vector@2 as vector, text@3 as text, _score@1 as _score]
               LanceRead: uri=..., projection=[vector, text], source=stream(_rowid)
                 GlobalLimitExec: skip=0, fetch=10
                   MatchQuery: column=text, query=[hello]
@@ -4028,9 +3986,8 @@ class AsyncHybridQuery(AsyncStandardQuery, AsyncVectorQueryBase):
         plan : str
         """  # noqa: E501
 
-        fts_query, vec_query, _, _ = self._create_child_queries()
-        vector_plan = await vec_query.explain_plan(verbose)
-        fts_plan = await fts_query.explain_plan(verbose)
+        vector_plan = await self._inner.to_vector_query().explain_plan(verbose)
+        fts_plan = await self._inner.to_fts_query().explain_plan(verbose)
         # Indent sub-plans under the reranker
         indented_vector = "\n".join("  " + line for line in vector_plan.splitlines())
         indented_fts = "\n".join("  " + line for line in fts_plan.splitlines())
@@ -4057,12 +4014,14 @@ class AsyncHybridQuery(AsyncStandardQuery, AsyncVectorQueryBase):
         -------
         plan : str
         """
-        fts_query, vec_query, _, _ = self._create_child_queries()
-
         results = ["Vector Search Query:"]
-        results.append(await vec_query.analyze_plan(distributed_metrics))
+        results.append(
+            await self._inner.to_vector_query().analyze_plan(distributed_metrics)
+        )
         results.append("FTS Search Query:")
-        results.append(await fts_query.analyze_plan(distributed_metrics))
+        results.append(
+            await self._inner.to_fts_query().analyze_plan(distributed_metrics)
+        )
 
         return "\n".join(results)
 

python/python/lancedb/remote/table.py

@@ -720,7 +720,7 @@ class RemoteTable(Table):
         Parameters
         ----------
         query: list/np.ndarray/str/PIL.Image.Image, default None
-            The targeted vector to search for.
+            The targetted vector to search for.
 
             - *default None*.
             Acceptable types are: list, np.ndarray, PIL.Image.Image

python/python/lancedb/rerankers/base.py

@@ -175,7 +175,7 @@ class Reranker(ABC):
             if the results haven't been executed yet or the results in arrow format.
         query : str or None,
             The input query. Some rerankers might not need the query to rerank.
-            In that case, it can be set to None explicitly. This is intended to
+            In that case, it can be set to None explicitly. This is inteded to
             be handled by the reranker implementations.
         deduplicate : bool, optional
             Whether to deduplicate the results based on the `_rowid` column,

python/python/lancedb/table.py

@@ -1619,7 +1619,7 @@ class Table(ABC):
         Parameters
         ----------
         query: list/np.ndarray/str/PIL.Image.Image, default None
-            The targeted vector to search for.
+            The targetted vector to search for.
 
             - *default None*.
             Acceptable types are: list, np.ndarray, PIL.Image.Image
@@ -3841,7 +3841,7 @@ class LanceTable(Table):
         Parameters
         ----------
         query: list/np.ndarray/str/PIL.Image.Image, default None
-            The targeted vector to search for.
+            The targetted vector to search for.
 
             - *default None*.
             Acceptable types are: list, np.ndarray, PIL.Image.Image
@@ -5638,7 +5638,7 @@ class AsyncTable:
         if fill_value is None:
             fill_value = 0.0
 
-        # _sanitize_data is an old code path, but we will use it until the
+        # _santitize_data is an old code path, but we will use it until the
         # new code path is ready.
         if mode == "overwrite":
             # For overwrite, apply the same preprocessing as create_table
@@ -5814,7 +5814,7 @@ class AsyncTable:
         Parameters
         ----------
         query: list/np.ndarray/str/PIL.Image.Image, default None
-            The targeted vector to search for.
+            The targetted vector to search for.
 
             - *default None*.
             Acceptable types are: list, np.ndarray, PIL.Image.Image

python/python/tests/test_embeddings.py

@@ -327,8 +327,8 @@ def test_embedding_function_with_pandas(tmp_path):
         ) -> List[np.array]:
             return [np.random.randn(self.ndims()).tolist() for _ in range(len(texts))]
 
-    registry = get_registry()
-    func = registry.get("mock-embedding").create()
+    registery = get_registry()
+    func = registery.get("mock-embedding").create()
 
     class TestSchema(LanceModel):
         text: str = func.SourceField()
@@ -394,9 +394,9 @@ def test_multiple_embeddings_for_pandas(tmp_path):
         ) -> List[np.array]:
             return [np.random.randn(self.ndims()).tolist() for _ in range(len(texts))]
 
-    registry = get_registry()
-    func1 = registry.get("mock-embedding").create()
-    func2 = registry.get("mock-embedding2").create()
+    registery = get_registry()
+    func1 = registery.get("mock-embedding").create()
+    func2 = registery.get("mock-embedding2").create()
 
     class TestSchema(LanceModel):
         text: str = func1.SourceField()

python/python/tests/test_fts.py

@@ -1011,13 +1011,8 @@ def test_fts_ngram(mem_db: DBConnection):
     assert set(r["text"] for r in results) == {"lance database", "lance is cool"}
 
     results = (
-        table.search(
-            "nce",  # spellchecker:disable-line
-            query_type="fts",
-        )
-        .limit(10)
-        .to_list()
-    )
+        table.search("nce", query_type="fts").limit(10).to_list()
+    )  # spellchecker:disable-line
     assert len(results) == 2
     assert set(r["text"] for r in results) == {"lance database", "lance is cool"}
 
@@ -1039,13 +1034,8 @@ def test_fts_ngram(mem_db: DBConnection):
     assert set(r["text"] for r in results) == {"lance database", "lance is cool"}
 
     results = (
-        table.search(
-            "nce",  # spellchecker:disable-line
-            query_type="fts",
-        )
-        .limit(10)
-        .to_list()
-    )
+        table.search("nce", query_type="fts").limit(10).to_list()
+    )  # spellchecker:disable-line
     assert len(results) == 0
 
     results = table.search("la", query_type="fts").limit(10).to_list()

python/python/tests/test_hybrid_query.py

@@ -203,93 +203,6 @@ async def test_async_hybrid_query_default_limit(table: AsyncTable):
     assert texts.count("a") == 1
 
 
-@pytest.mark.asyncio
-async def test_async_hybrid_query_offset(table: AsyncTable):
-    # The offset window of a hybrid query must be a suffix of the same query
-    # run without an offset. Skipping the first rows of each sub-query instead
-    # of the first rows of the fused result silently changes which rows land in
-    # the window.
-    full = await (
-        table.query()
-        .nearest_to([0.0, 0.4])
-        .nearest_to_text("dog")
-        .limit(4)
-        .with_row_id()
-        .to_arrow()
-    )
-    assert len(full) == 4
-
-    second_page = await (
-        table.query()
-        .nearest_to([0.0, 0.4])
-        .nearest_to_text("dog")
-        .offset(2)
-        .limit(2)
-        .with_row_id()
-        .to_arrow()
-    )
-    assert second_page["_rowid"].to_pylist() == full["_rowid"].to_pylist()[2:]
-
-    first_page = await (
-        table.query()
-        .nearest_to([0.0, 0.4])
-        .nearest_to_text("dog")
-        .limit(2)
-        .with_row_id()
-        .to_arrow()
-    )
-    # Paging through the result must visit every row exactly once: no row
-    # repeated from the previous page and none dropped between the two.
-    paged = first_page["_rowid"].to_pylist() + second_page["_rowid"].to_pylist()
-    assert sorted(paged) == sorted(full["_rowid"].to_pylist())
-
-
-@pytest.mark.asyncio
-async def test_async_hybrid_query_fts_first_default_limit(table: AsyncTable):
-    # nearest_to() and nearest_to_text() build their new sibling sub-query from
-    # scratch, and that is the sub-query the default limit ends up on. So the
-    # side that carries the limit depends on the order the hybrid query was
-    # built in, and looking at only one side loses the limit for half the ways
-    # a hybrid query can be written. Without a limit the combined results are
-    # not truncated at all and the whole union of both candidate lists is
-    # returned.
-    await table.add([{"text": "dog", "vector": [50.0 + i, 50.0]} for i in range(10)])
-
-    result = await (
-        table.query().nearest_to_text("dog").nearest_to([0.1, 0.1]).to_arrow()
-    )
-    assert len(result) == 10
-
-    offset_result = await (
-        table.query().nearest_to_text("dog").nearest_to([0.1, 0.1]).offset(2).to_arrow()
-    )
-    assert len(offset_result) == 10
-
-
-@pytest.mark.asyncio
-async def test_async_hybrid_query_explain_plan_matches_execution(table: AsyncTable):
-    # Paging rewrites the sub-queries: each one fetches limit + offset rows with
-    # no offset of its own, and the window is sliced out after fusion. The plans
-    # have to be built from those rewritten sub-queries, otherwise explain_plan
-    # and analyze_plan describe a query that is never run.
-    query = (
-        table.query().nearest_to([0.0, 0.4]).nearest_to_text("dog").offset(2).limit(2)
-    )
-    await query.to_arrow()
-
-    plan = await query.explain_plan()
-    assert [
-        line.strip() for line in plan.splitlines() if "GlobalLimitExec" in line
-    ] == [
-        "GlobalLimitExec: skip=0, fetch=4",
-        "GlobalLimitExec: skip=0, fetch=4",
-    ]
-
-    analyzed = await query.analyze_plan()
-    assert analyzed.count("skip=0, fetch=4") == 2
-    assert "skip=2" not in analyzed
-
-
 def test_hybrid_query_offset(sync_table: Table):
     # The offset window of a hybrid query must be a suffix of the same query
     # run without an offset -- it must not be silently ignored.

python/python/tests/test_rerankers.py

@@ -81,7 +81,7 @@ def get_test_table(tmp_path):
         "but his son was mortal",
         "there hasn't been a good battlefield game since 2142",
         "I wish they would make another one",
-        "campaigns are not as good as they used to be",
+        "campains are not as good as they used to be",
         "Multiplayer and open world games have destroyed the single player experience",
         "Maybe the future is console games",
         "I don't know",

python/python/tests/test_table.py

@@ -3354,7 +3354,7 @@ def test_empty_query(mem_db: DBConnection):
     # None is the same as default
     df = table.search().select(["id"]).limit(None).to_arrow()
     assert df.num_rows == 100
-    # invalid limist is the same as None, which is the same as default
+    # invalid limist is the same as None, wihch is the same as default
     df = table.search().select(["id"]).limit(-1).to_arrow()
     assert df.num_rows == 100
     # valid limit should work

python/src/query.rs

@@ -334,7 +334,7 @@ pub struct PyQueryRequest {
     pub column: Option<String>,
     pub query_vector: Option<PyQueryVectors>,
     pub minimum_nprobes: Option<usize>,
-    // None means user did not set it and default should be used (currently 20)
+    // None means user did not set it and default shoud be used (currenty 20)
     // Some(0) means user set it to None and there is no limit
     pub maximum_nprobes: Option<usize>,
     pub lower_bound: Option<f32>,

rust/lancedb/src/arrow.rs

@@ -163,7 +163,7 @@ pub struct PolarsDataFrameRecordBatchReader {
 impl PolarsDataFrameRecordBatchReader {
     /// Creates a new `PolarsDataFrameRecordBatchReader` from a given Polars DataFrame.
     /// If the input dataframe does not have aligned chunks, this function undergoes
-    /// the costly operation of reallocating each series as a single contiguous chunk.
+    /// the costly operation of reallocating each series as a single contigous chunk.
     pub fn new(mut df: DataFrame) -> Result<Self> {
         df.align_chunks();
         let arrow_schema =

rust/lancedb/src/connection.rs

@@ -827,7 +827,7 @@ impl Connection {
 pub struct ConnectRequest {
     /// Database URI
     ///
-    /// ### Accepted URI formats
+    /// ### Accpeted URI formats
     ///
     /// - `/path/to/database` - local database on file system.
     /// - `s3://bucket/path/to/database` or `gs://bucket/path/to/database` - database on cloud object store

rust/lancedb/src/database/listing.rs

@@ -512,7 +512,7 @@ impl ListingDatabase {
                 // iter thru the query params and extract the commit store param
                 let mut engine = None;
                 let mut mirrored_store = None;
-                let mut filtered_queries = vec![];
+                let mut filtered_querys = vec![];
 
                 // WARNING: specifying engine is NOT a publicly supported feature in lancedb yet
                 // THE API WILL CHANGE
@@ -528,13 +528,13 @@ impl ListingDatabase {
                         mirrored_store = Some(value.to_string());
                     } else {
                         // to owned so we can modify the url
-                        filtered_queries.push((key.to_string(), value.to_string()));
+                        filtered_querys.push((key.to_string(), value.to_string()));
                     }
                 }
 
                 // Filter out the commit store query param -- it's a lancedb param
                 url.query_pairs_mut().clear();
-                url.query_pairs_mut().extend_pairs(filtered_queries);
+                url.query_pairs_mut().extend_pairs(filtered_querys);
                 // Take a copy of the query string so we can propagate it to lance.
                 // `query_pairs_mut()` leaves the URL with `Some("")` even when no
                 // pairs survive (or none existed in the first place), so an empty
@@ -896,11 +896,11 @@ impl Database for ListingDatabase {
     }
 
     async fn read_consistency(&self) -> Result<ReadConsistency> {
-        if let Some(interval) = self.read_consistency_interval {
-            if interval.is_zero() {
+        if let Some(read_consistency_inverval) = self.read_consistency_interval {
+            if read_consistency_inverval.is_zero() {
                 Ok(ReadConsistency::Strong)
             } else {
-                Ok(ReadConsistency::Eventual(interval))
+                Ok(ReadConsistency::Eventual(read_consistency_inverval))
             }
         } else {
             Ok(ReadConsistency::Manual)
@@ -3043,15 +3043,15 @@ mod tests {
     /// across platforms — see the `file://` test below).
     fn capture_query_like_connect(input_uri: &str) -> Option<String> {
         let mut url = url::Url::parse(input_uri).unwrap();
-        let mut filtered_queries = Vec::new();
+        let mut filtered_querys = Vec::new();
         for (key, value) in url.query_pairs() {
             if key == ENGINE || key == MIRRORED_STORE {
                 continue;
             }
-            filtered_queries.push((key.to_string(), value.to_string()));
+            filtered_querys.push((key.to_string(), value.to_string()));
         }
         url.query_pairs_mut().clear();
-        url.query_pairs_mut().extend_pairs(filtered_queries);
+        url.query_pairs_mut().extend_pairs(filtered_querys);
         url.query().filter(|q| !q.is_empty()).map(|s| s.to_string())
     }
 

rust/lancedb/src/database/namespace.rs

@@ -251,11 +251,11 @@ impl Database for LanceNamespaceDatabase {
     }
 
     async fn read_consistency(&self) -> Result<ReadConsistency> {
-        if let Some(interval) = self.read_consistency_interval {
-            if interval.is_zero() {
+        if let Some(read_consistency_inverval) = self.read_consistency_interval {
+            if read_consistency_inverval.is_zero() {
                 Ok(ReadConsistency::Strong)
             } else {
-                Ok(ReadConsistency::Eventual(interval))
+                Ok(ReadConsistency::Eventual(read_consistency_inverval))
             }
         } else {
             Ok(ReadConsistency::Manual)

rust/lancedb/src/index/vector.rs

@@ -125,7 +125,7 @@ macro_rules! impl_pq_params_setter {
         /// This value controls how much the vector is compressed during the quantization step.
         /// The more sub vectors there are the less the vector is compressed.  The default is
         /// the dimension of the vector divided by 16.  If the dimension is not evenly divisible
-        /// by 16 we use the dimension divided by 8.
+        /// by 16 we use the dimension divded by 8.
         ///
         /// The above two cases are highly preferred.  Having 8 or 16 values per subvector allows
         /// us to use efficient SIMD instructions.

rust/lancedb/src/query.rs

@@ -1299,7 +1299,7 @@ impl VectorQuery {
     /// This can be useful when there is a narrow filter to allow these queries to
     /// spend more time searching and avoid potential false negatives.
     ///
-    /// Set to None to search all partitions, if needed, to satisfy the limit
+    /// Set to None to search all partitions, if needed, to satsify the limit
     pub fn maximum_nprobes(mut self, maximum_nprobes: Option<usize>) -> Result<Self> {
         if let Some(maximum_nprobes) = maximum_nprobes {
             if maximum_nprobes == 0 {

rust/lancedb/src/table.rs

@@ -240,7 +240,7 @@ enum BadVectorHandling {
     /// An error is returned
     #[default]
     Error,
-    /// The offending row is dropped
+    /// The offending row is droppped
     Drop,
     /// The invalid/missing items are replaced by fill_value
     Fill(f32),
@@ -1326,7 +1326,7 @@ impl Table {
     /// Note: if your condition is something like "some_id_column == 7" and
     /// you are updating many rows (with different ids) then you will get
     /// better performance with a single [`merge_insert`] call instead of
-    /// repeatedly calling this method.
+    /// repeatedly calilng this method.
     pub fn update(&self) -> UpdateBuilder {
         UpdateBuilder::new(self.inner.clone())
     }

rust/lancedb/src/table/dataset.rs

@@ -52,7 +52,7 @@ enum ConsistencyMode {
     /// refresh_window = min(3s, TTL/4)
     ///
     /// | t < TTL - refresh_window | t < TTL                           | t >= TTL            |
-    /// |  Return value            | Background refresh & return value |  synchronous refresh |
+    /// |  Return value            | Background refresh & return value |  syncronous refresh |
     Eventual(BackgroundCache<Arc<Dataset>, Error>),
 }
 

rust/lancedb/src/table/merge.rs

@@ -103,7 +103,7 @@ impl MergeInsertBuilder {
     /// but that behavior is subject to change.
     ///
     /// An optional condition may be specified.  If it is, then only
-    /// matched rows that satisfy the condition will be updated.  Any
+    /// matched rows that satisfy the condtion will be updated.  Any
     /// rows that do not satisfy the condition will be left as they
     /// are.  Failing to satisfy the condition does not cause a
     /// "matched row" to become a "not matched" row.

rust/lancedb/src/table/merge/lsm.rs

@@ -904,7 +904,7 @@ fn unsharded_shard_id() -> Uuid {
 
 /// Build a [`ShardWriterConfig`] from the persisted `writer_config_defaults`.
 ///
-/// Unknown or unparsable keys are ignored; absent keys keep the
+/// Unknown or unparseable keys are ignored; absent keys keep the
 /// [`ShardWriterConfig`] default. The shard id is set by `mem_wal_writer`.
 fn shard_writer_config_from_defaults(defaults: &HashMap<String, String>) -> ShardWriterConfig {
     let mut config = ShardWriterConfig::default().with_shard_spec_id(SHARDING_SPEC_ID);