mirror of
https://github.com/lancedb/lancedb.git
synced 2026-10-25 21:22:29 +00:00
KarthikSandXuanwo
702389654e
Fixes #4248. The preview index still contains pylance 1.0.0b6. uv's default first-index resolution can select it, or backtrack to an old LanceDB release when installing the extra. Meanwhile, the extra still permits pylance 5 even though current main bundles Lance 14. Raise the optional dependency to `pylance>=14.0.0b12`, the version already pinned in the test extra, and keep the lockfile metadata consistent. Document both Fury indexes and uv's `unsafe-best-match` strategy in the Python README and the source-owned quickstart (`docs/web/quickstart.mdx`). Explain the index trust requirement and recommend installing the extra to enforce the version floor. Add CI checks that reject older Lance majors and ensure the pylance and tests extras remain compatible. Run these checks when either dependency manifest changes, so a future Lance major bump cannot silently leave the Python minimum behind. ### Validation - Recreated the reported install on Ubuntu 26.04 / CPython 3.12.15 with uv 0.12.23: `lancedb==0.40.0b5` plus the old index selects `pylance==1.0.0b6`. Reproduced both the missing `blob_array` import and the unexpected `blob_handling` scanner argument using a real blob table. - Resolved the modified `python/pyproject.toml` with the pylance extra against both indexes: selects `pylance==14.0.0b18`, matching the current Rust pin. - Ran both documented pip and uv installations in isolated environments: `lancedb==0.41.0b7`, `pylance==14.0.0b18`; blob-array construction and a blob-bytes round trip through `to_pandas(blob_mode="bytes")` pass. Both package dependency checks pass. - New regression fails on the original dependency bound (27 rejected-version cases incorrectly accepted), then passes with the fix. Full CI-script suite: 3 tests pass. - `uv lock --check` with both indexes passes; focused Ruff checks pass; `git diff --check` passes. - Repository-wide Ruff reports 49 existing errors in untouched `docs/web-tests` files. Unrelated formatting changes were discarded. Runtime smoke checks used released native wheels; source dependency resolution was tested directly from the modified pyproject. No Rust or Python runtime code changes. --------- Co-authored-by: Xuanwo <github@xuanwo.io>
48 lines
1.9 KiB
Python
48 lines
1.9 KiB
Python
import tomllib
|
|
import unittest
|
|
from pathlib import Path
|
|
|
|
from packaging.requirements import Requirement
|
|
from packaging.version import Version
|
|
|
|
|
|
REPO_ROOT = Path(__file__).resolve().parents[2]
|
|
|
|
|
|
class PythonDependenciesTest(unittest.TestCase):
|
|
def setUp(self):
|
|
with (REPO_ROOT / "python/pyproject.toml").open("rb") as f:
|
|
self.project = tomllib.load(f)["project"]
|
|
self.pylance = Requirement(self.project["optional-dependencies"]["pylance"][0])
|
|
|
|
def test_pylance_extra_excludes_older_lance_majors(self):
|
|
with (REPO_ROOT / "Cargo.toml").open("rb") as f:
|
|
lance = tomllib.load(f)["workspace"]["dependencies"]["lance"]
|
|
if "version" not in lance:
|
|
self.skipTest("Local Lance checkout has no version requirement")
|
|
major = Version(lance["version"].lstrip("=")).major
|
|
for older_major in range(major):
|
|
for suffix in (".0.0", ".0.0b6", ".999.999"):
|
|
version = f"{older_major}{suffix}"
|
|
with self.subTest(version=version):
|
|
self.assertFalse(
|
|
self.pylance.specifier.contains(version, prereleases=True),
|
|
f"The pylance extra must exclude Lance {version}; "
|
|
f"the bundled Lance is major {major}",
|
|
)
|
|
|
|
def test_pylance_extra_accepts_tested_version(self):
|
|
requirements = [
|
|
Requirement(dep) for dep in self.project["optional-dependencies"]["tests"]
|
|
]
|
|
tested = next(dep for dep in requirements if dep.name == "pylance")
|
|
pin = next(spec for spec in tested.specifier if spec.operator == "==")
|
|
self.assertTrue(
|
|
self.pylance.specifier.contains(pin.version, prereleases=True),
|
|
f"The tests and pylance extras must be installable together: {tested}",
|
|
)
|
|
|
|
|
|
if __name__ == "__main__":
|
|
unittest.main()
|