mirror of
https://github.com/lancedb/lancedb.git
synced 2026-01-05 03:12:57 +00:00
cc81f3e1a5
@wjones127 is there a standard way you guys setup your virtualenv? I can
either relist all the dependencies in the pyright precommit section, or
specify a venv, or the user has to be in the virtual environment when
they run git commit. If the venv location was standardized or a python
manager like `uv` was used it would be easier to avoid duplicating the
pyright dependency list.
Per your suggestion, in `pyproject.toml` I added in all the passing
files to the `includes` section.
For ruff I upgraded the version and removed "TCH" which doesn't exist as
an option.
I added a `pyright_report.csv` which contains a list of all files sorted
by pyright errors ascending as a todo list to work on.
I fixed about 30 issues in `table.py` stemming from str's being passed
into methods that required a string within a set of string Literals by
extracting them into `types.py`
Can you verify in the rust bridge that the schema should be a property
and not a method here? If it's a method, then there's another place in
the code where `inner.schema` should be `inner.schema()`
``` python
class RecordBatchStream:
@property
def schema(self) -> pa.Schema: ...
```
Also unless the `_lancedb.pyi` file is wrong, then there is no
`__anext__` here for `__inner` when it's not an `AsyncGenerator` and
only `next` is defined:
``` python
async def __anext__(self) -> pa.RecordBatch:
return await self._inner.__anext__()
if isinstance(self._inner, AsyncGenerator):
batch = await self._inner.__anext__()
else:
batch = await self._inner.next()
if batch is None:
raise StopAsyncIteration
return batch
```
in the else statement, `_inner` is a `RecordBatchStream`
```python
class RecordBatchStream:
@property
def schema(self) -> pa.Schema: ...
async def next(self) -> Optional[pa.RecordBatch]: ...
```
---------
Co-authored-by: Will Jones <willjones127@gmail.com>
37 lines
833 B
Makefile
37 lines
833 B
Makefile
PIP_EXTRA_INDEX_URL ?= https://pypi.fury.io/lancedb/
|
|
|
|
help: ## Show this help.
|
|
@sed -ne '/@sed/!s/## //p' $(MAKEFILE_LIST)
|
|
|
|
.PHONY: develop
|
|
develop: ## Install the package in development mode.
|
|
PIP_EXTRA_INDEX_URL=$(PIP_EXTRA_INDEX_URL) maturin develop --extras tests,dev,embeddings
|
|
|
|
.PHONY: format
|
|
format: ## Format the code.
|
|
cargo fmt
|
|
ruff format python
|
|
|
|
.PHONY: check
|
|
check: ## Check formatting and lints.
|
|
cargo fmt --check
|
|
ruff format --check python
|
|
cargo clippy
|
|
ruff check python
|
|
|
|
.PHONY: fix
|
|
fix: ## Fix python lints
|
|
ruff check python --fix
|
|
|
|
.PHONY: typecheck
|
|
typecheck: ## Run type checking with pyright.
|
|
pyright
|
|
|
|
.PHONY: doctest
|
|
doctest: ## Run documentation tests.
|
|
pytest --doctest-modules python/lancedb
|
|
|
|
.PHONY: test
|
|
test: ## Run tests.
|
|
pytest python/tests -vv --durations=10 -m "not slow and not s3_test"
|