leptos-shadcn-ui/docs/remediation/component-fixes/input-tests-refactoring.md

🔧 Input Component Tests Refactoring

File: packages/leptos/input/src/implementation_tests.rs
Current Size: 867 lines
Target: Split into 6 modules of ~150 lines each
Priority: 🔴 CRITICAL

🚨 Current Issues

File Size Problems

• 867 lines in a single file
• Mixed test categories in one file
• Hard to navigate and maintain
• Poor LLM comprehension due to size

Test Organization Issues

• Basic functionality tests mixed with complex integration tests
• Performance tests scattered throughout
• Error handling tests not grouped
• Accessibility tests not separated

🎯 Refactoring Strategy

New Module Structure

packages/leptos/input/src/implementation_tests/
├── mod.rs                    // Module declarations (~20 lines)
├── prop_handling_tests.rs    // Prop handling tests (~150 lines)
├── signal_management_tests.rs // Signal management tests (~150 lines)
├── event_handling_tests.rs   // Event handling tests (~150 lines)
├── validation_tests.rs       // Validation tests (~150 lines)
├── styling_tests.rs          // Styling tests (~150 lines)
└── integration_tests.rs      // Integration tests (~150 lines)

Module Breakdown

1. Prop Handling Tests (~150 lines)

// packages/leptos/input/src/implementation_tests/prop_handling_tests.rs
#[cfg(test)]
mod prop_handling_tests {
    use super::*;
    
    #[test]
    fn test_input_placeholder_prop() {
        // Test placeholder prop handling
    }
    
    #[test]
    fn test_input_disabled_prop() {
        // Test disabled prop handling
    }
    
    #[test]
    fn test_input_required_prop() {
        // Test required prop handling
    }
    
    #[test]
    fn test_input_type_prop() {
        // Test input type prop handling
    }
    
    #[test]
    fn test_input_value_prop() {
        // Test value prop handling
    }
    
    #[test]
    fn test_input_class_prop() {
        // Test class prop handling
    }
    
    #[test]
    fn test_input_id_prop() {
        // Test id prop handling
    }
    
    #[test]
    fn test_input_name_prop() {
        // Test name prop handling
    }
    
    #[test]
    fn test_input_autocomplete_prop() {
        // Test autocomplete prop handling
    }
    
    #[test]
    fn test_input_maxlength_prop() {
        // Test maxlength prop handling
    }
}

2. Signal Management Tests (~150 lines)

// packages/leptos/input/src/implementation_tests/signal_management_tests.rs
#[cfg(test)]
mod signal_management_tests {
    use super::*;
    
    #[test]
    fn test_input_value_signal() {
        // Test value signal management
    }
    
    #[test]
    fn test_input_disabled_signal() {
        // Test disabled signal management
    }
    
    #[test]
    fn test_input_required_signal() {
        // Test required signal management
    }
    
    #[test]
    fn test_input_focus_signal() {
        // Test focus signal management
    }
    
    #[test]
    fn test_input_error_signal() {
        // Test error signal management
    }
    
    #[test]
    fn test_input_validation_signal() {
        // Test validation signal management
    }
    
    #[test]
    fn test_input_signal_derivation() {
        // Test signal derivation
    }
    
    #[test]
    fn test_input_signal_memory_management() {
        // Test signal memory management
    }
    
    #[test]
    fn test_input_signal_performance() {
        // Test signal performance
    }
    
    #[test]
    fn test_input_signal_integration() {
        // Test signal integration
    }
}

3. Event Handling Tests (~150 lines)

// packages/leptos/input/src/implementation_tests/event_handling_tests.rs
#[cfg(test)]
mod event_handling_tests {
    use super::*;
    
    #[test]
    fn test_input_on_change_event() {
        // Test on_change event handling
    }
    
    #[test]
    fn test_input_on_input_event() {
        // Test on_input event handling
    }
    
    #[test]
    fn test_input_on_focus_event() {
        // Test on_focus event handling
    }
    
    #[test]
    fn test_input_on_blur_event() {
        // Test on_blur event handling
    }
    
    #[test]
    fn test_input_on_keydown_event() {
        // Test on_keydown event handling
    }
    
    #[test]
    fn test_input_on_keyup_event() {
        // Test on_keyup event handling
    }
    
    #[test]
    fn test_input_on_enter_event() {
        // Test on_enter event handling
    }
    
    #[test]
    fn test_input_on_escape_event() {
        // Test on_escape event handling
    }
    
    #[test]
    fn test_input_event_propagation() {
        // Test event propagation
    }
    
    #[test]
    fn test_input_event_prevention() {
        // Test event prevention
    }
}

4. Validation Tests (~150 lines)

// packages/leptos/input/src/implementation_tests/validation_tests.rs
#[cfg(test)]
mod validation_tests {
    use super::*;
    
    #[test]
    fn test_input_required_validation() {
        // Test required field validation
    }
    
    #[test]
    fn test_input_email_validation() {
        // Test email validation
    }
    
    #[test]
    fn test_input_password_validation() {
        // Test password validation
    }
    
    #[test]
    fn test_input_number_validation() {
        // Test number validation
    }
    
    #[test]
    fn test_input_url_validation() {
        // Test URL validation
    }
    
    #[test]
    fn test_input_minlength_validation() {
        // Test minlength validation
    }
    
    #[test]
    fn test_input_maxlength_validation() {
        // Test maxlength validation
    }
    
    #[test]
    fn test_input_pattern_validation() {
        // Test pattern validation
    }
    
    #[test]
    fn test_input_custom_validation() {
        // Test custom validation
    }
    
    #[test]
    fn test_input_validation_error_display() {
        // Test validation error display
    }
}

5. Styling Tests (~150 lines)

// packages/leptos/input/src/implementation_tests/styling_tests.rs
#[cfg(test)]
mod styling_tests {
    use super::*;
    
    #[test]
    fn test_input_default_styling() {
        // Test default styling
    }
    
    #[test]
    fn test_input_variant_styling() {
        // Test variant styling
    }
    
    #[test]
    fn test_input_size_styling() {
        // Test size styling
    }
    
    #[test]
    fn test_input_disabled_styling() {
        // Test disabled styling
    }