leptos-shadcn-ui/docs/remediation/components/button/REMEDIATION_PLAN.md

🛠️ Button Component Remediation Plan

Senior Rust Staff Engineer Review - September 20, 2025

📋 Current Status

File Size Violations

File	Current Lines	Target Lines	Status	Priority
implementation_tests.rs	527	< 300	❌ CRITICAL	P0
new_york_tests.rs	638	< 300	❌ CRITICAL	P0
standardized.rs	569	< 300	❌ CRITICAL	P0
tests_legacy.rs	843	< 300	❌ CRITICAL	P0

Test Coverage Status

• Current: 8 test files - ✅ EXCELLENT
• Target: Maintain excellent coverage while reducing file sizes
• Focus: Refactor large files into smaller, focused modules

---

🎯 Refactoring Strategy

Phase 1: implementation_tests.rs (527 lines → < 300 lines)

Target: Split into 2-3 focused modules

Module 1: implementation_tests/enum_conversions.rs (~150 lines)

• ButtonVariant enum conversions
• ButtonSize enum conversions
• Default implementations
• Equality and comparison tests

Module 2: implementation_tests/prop_handling.rs (~150 lines)

• Prop validation tests
• Prop combination tests
• Edge case prop handling
• Invalid prop handling

Module 3: implementation_tests/rendering.rs (~150 lines)

• Basic rendering tests
• Variant rendering tests
• Size rendering tests
• CSS class application tests

Phase 2: new_york_tests.rs (638 lines → < 300 lines)

Target: Split into 2-3 focused modules

Module 1: new_york_tests/variant_tests.rs (~200 lines)

• New York variant specific tests
• Variant comparison tests
• Style application tests

Module 2: new_york_tests/integration_tests.rs (~200 lines)

• Integration with other components
• Complex usage scenarios
• Performance tests

Module 3: new_york_tests/accessibility_tests.rs (~150 lines)

• Accessibility features
• Keyboard navigation
• Screen reader support

Phase 3: standardized.rs (569 lines → < 300 lines)

Target: Split into 2 focused modules

Module 1: standardized/api_contracts.rs (~250 lines)

• API contract validation
• Prop standardization
• Event handling standardization

Module 2: standardized/behavior_tests.rs (~250 lines)

• Standardized behavior tests
• Cross-platform compatibility
• Performance benchmarks

Phase 4: tests_legacy.rs (843 lines → < 300 lines)

Target: Split into 3 focused modules

Module 1: tests_legacy/basic_rendering.rs (~250 lines)

• Basic rendering tests
• Element type tests
• Content display tests

Module 2: tests_legacy/interaction_tests.rs (~250 lines)

• Click handling tests
• Keyboard interaction tests
• Event propagation tests

Module 3: tests_legacy/advanced_features.rs (~250 lines)

• Advanced feature tests
• Edge case handling
• Error condition tests

---

🚀 Implementation Plan

Week 1: Core Refactoring

• Day 1-2: Refactor implementation_tests.rs into 3 modules
• Day 3-4: Refactor new_york_tests.rs into 3 modules
• Day 5: Refactor standardized.rs into 2 modules

Week 2: Legacy Tests & Validation

• Day 1-2: Refactor tests_legacy.rs into 3 modules
• Day 3-4: Update module imports and dependencies
• Day 5: Run comprehensive tests and validation

Week 3: Optimization & Documentation

• Day 1-2: Optimize test performance and memory usage
• Day 3-4: Update documentation and examples
• Day 5: Final testing and validation

---

📊 Success Metrics

File Size Compliance

• Target: All files under 300 lines
• Current: 4 files exceed 300 lines
• Goal: 100% compliance

Test Coverage Maintenance

• Target: Maintain 8 test files
• Current: 8 test files
• Goal: No reduction in test coverage

Performance

• Target: No performance degradation
• Current: Baseline performance
• Goal: Maintain or improve performance

Code Quality

• Target: Improved maintainability
• Current: Large, monolithic files
• Goal: Small, focused modules

---

🎯 Expected Outcomes

Immediate Benefits

• File Size Compliance: All files under 300 lines
• Improved Maintainability: Smaller, focused modules
• Better Organization: Logical grouping of related tests
• Enhanced Readability: Clearer code structure

Long-term Benefits

• Easier Debugging: Smaller files are easier to debug
• Faster Development: Developers can focus on specific areas
• Better Testing: More focused test modules
• Improved Performance: Better module loading and compilation

---

🚨 Risk Mitigation

Potential Risks

• Test Coverage Loss: Risk of losing test coverage during refactoring
• Import Issues: Risk of breaking module imports
• Performance Impact: Risk of performance degradation
• Compilation Issues: Risk of breaking compilation

Mitigation Strategies

• Incremental Refactoring: Refactor one module at a time
• Comprehensive Testing: Run tests after each refactoring step
• Backup Strategy: Keep original files until validation complete
• Performance Monitoring: Monitor performance throughout process

---

🎯 Conclusion

The Button component requires immediate attention due to 4 critical file size violations. The refactoring plan will split large files into smaller, focused modules while maintaining excellent test coverage and improving code organization.

Key Focus Areas:

1. File Size Compliance: All files under 300 lines
2. Test Coverage Maintenance: No loss of test coverage
3. Code Organization: Logical grouping of related functionality
4. Performance: Maintain or improve performance

Expected Outcome: A well-organized, maintainable, fully-tested Button component that meets enterprise standards.

---

Button Component Remediation Plan created: September 20, 2025
Next review: October 20, 2025