Merge pull request #371 from mibac138/master

Box a large enum variant, minor code cleanup

lettre/src/lib.rs

@@ -86,7 +86,7 @@ impl AsRef<str> for EmailAddress {
 
 impl AsRef<OsStr> for EmailAddress {
     fn as_ref(&self) -> &OsStr {
-        &self.0.as_ref()
+        self.0.as_ref()
     }
 }
 

lettre/src/smtp/client/mod.rs

@@ -28,9 +28,7 @@ impl ClientCodec {
     pub fn new() -> Self {
         ClientCodec::default()
     }
-}
 
-impl ClientCodec {
     /// Adds transparency
     /// TODO: replace CR and LF by CRLF
     fn encode(&mut self, frame: &[u8], buf: &mut Vec<u8>) -> Result<(), Error> {

lettre/src/smtp/client/net.rs

@@ -33,7 +33,7 @@ pub enum NetworkStream {
     /// Plain TCP stream
     Tcp(TcpStream),
     /// Encrypted TCP stream
-    Tls(TlsStream<TcpStream>),
+    Tls(Box<TlsStream<TcpStream>>),
     /// Mock stream
     Mock(MockStream),
 }
@@ -118,7 +118,7 @@ impl Connector for NetworkStream {
             Some(context) => context
                 .connector
                 .connect(context.domain.as_ref(), tcp_stream)
-                .map(NetworkStream::Tls)
+                .map(|tls| NetworkStream::Tls(Box::new(tls)))
                 .map_err(|e| io::Error::new(ErrorKind::Other, e)),
             None => Ok(NetworkStream::Tcp(tcp_stream)),
         }
@@ -131,7 +131,7 @@ impl Connector for NetworkStream {
                 .connector
                 .connect(tls_parameters.domain.as_ref(), stream.try_clone().unwrap())
             {
-                Ok(tls_stream) => NetworkStream::Tls(tls_stream),
+                Ok(tls_stream) => NetworkStream::Tls(Box::new(tls_stream)),
                 Err(err) => return Err(io::Error::new(ErrorKind::Other, err)),
             },
             NetworkStream::Tls(_) => return Ok(()),

lettre/src/smtp/mod.rs

@@ -470,7 +470,7 @@ impl<'a> Transport<'a> for SmtpTransport {
         // Message content
         let result = self.client.message(Box::new(email.message()));
 
-        if result.is_ok() {
+        if let Ok(ref result) = result {
             // Increment the connection reuse counter
             self.state.connection_reuse_count += 1;
 
@@ -480,9 +480,6 @@ impl<'a> Transport<'a> for SmtpTransport {
                 message_id,
                 self.state.connection_reuse_count,
                 result
-                    .as_ref()
-                    .ok()
-                    .unwrap()
                     .message
                     .iter()
                     .next()