Formatting with rustfmt

Cargo.toml

@@ -1,14 +1,13 @@
 [package]
 
 name = "smtp"
-version = "0.1.0"
+version = "0.3.0"
 description = "Simple SMTP client"
 readme = "README.md"
-documentation = "http://amousset.github.io/rust-smtp/smtp/"
+documentation = "http://amousset.me/rust-smtp/smtp/"
 repository = "https://github.com/amousset/rust-smtp"
-homepage = "https://github.com/amousset/rust-smtp"
-license = "MIT/Apache-2.0"
-authors = ["Alexis Mousset <contact@amousset.me>"]
+license = "MIT"
+authors = ["Alexis Mousset <alexis.mousset@gmx.fr>"]
 keywords = ["email", "smtp", "mailer"]
 
 [dependencies]
@@ -19,6 +18,7 @@ rustc-serialize = "0.3"
 rust-crypto = "0.2"
 bufstream = "0.1"
 email = "0.0"
+openssl = "0.6"
 
 [dev-dependencies]
 env_logger = "0.3"

README.md

@@ -1,4 +1,4 @@
-rust-smtp [![Build Status](https://travis-ci.org/amousset/rust-smtp.svg?branch=master)](https://travis-ci.org/amousset/rust-smtp) [![Coverage Status](https://coveralls.io/repos/github/amousset/rust-smtp/badge.svg?branch=master)](https://coveralls.io/github/amousset/rust-smtp?branch=master) [![](https://meritbadge.herokuapp.com/smtp)](https://crates.io/crates/smtp)[![MIT licensed](https://img.shields.io/badge/license-MIT-blue.svg)](./LICENSE)
+rust-smtp [![Build Status](https://travis-ci.org/amousset/rust-smtp.svg?branch=master)](https://travis-ci.org/amousset/rust-smtp) [![Coverage Status](https://coveralls.io/repos/github/amousset/rust-smtp/badge.svg?branch=master)](https://coveralls.io/github/amousset/rust-smtp?branch=master) [![Crate](https://meritbadge.herokuapp.com/smtp)](https://crates.io/crates/smtp) [![MIT licensed](https://img.shields.io/badge/license-MIT-blue.svg)](./LICENSE)
 =========
 
 This library implements a simple SMTP client.
@@ -11,7 +11,7 @@ To use this library, add the following to your `Cargo.toml`:
 
 ```toml
 [dependencies]
-smtp = "0.1"
+smtp = "0.2"
 ```
 
 License

examples/client.rs

@@ -17,7 +17,7 @@ fn main() {
 
 	let mut threads = Vec::new();
     for _ in 1..5 {
-    	
+
     	let th_sender = sender.clone();
     	threads.push(thread::spawn(move || {
 
@@ -27,15 +27,15 @@ fn main() {
                     	.body("Hello World!")
                     	.subject("Hello")
                     	.build();
-    			
+
     		let _ = th_sender.lock().unwrap().send(email);
 		}));
     }
-    
+
     for thread in threads {
     	let _ = thread.join();
     }
-    
+
     let email = EmailBuilder::new()
                     .to("user@localhost")
                     .from("user@localhost")

src/authentication.rs

@@ -25,12 +25,12 @@ pub enum Mecanism {
 
 impl Display for Mecanism {
     fn fmt(&self, f: &mut Formatter) -> fmt::Result {
-        write!(f, "{}",
-            match *self {
-                Mecanism::Plain => "PLAIN",
-                Mecanism::CramMd5 => "CRAM-MD5",
-            }
-        )
+        write!(f,
+               "{}",
+               match *self {
+                   Mecanism::Plain => "PLAIN",
+                   Mecanism::CramMd5 => "CRAM-MD5",
+               })
     }
 }
 
@@ -43,15 +43,22 @@ impl Mecanism {
         }
     }
 
- /// Returns the string to send to the server, using the provided username, password and challenge in some cases
-    pub fn response(&self, username: &str, password: &str, challenge: Option<&str>) -> Result<String, Error> {
+    /// Returns the string to send to the server, using the provided username, password and
+    /// challenge in some cases
+    pub fn response(&self,
+                    username: &str,
+                    password: &str,
+                    challenge: Option<&str>)
+                    -> Result<String, Error> {
         match *self {
             Mecanism::Plain => {
                 match challenge {
                     Some(_) => Err(Error::ClientError("This mecanism does not expect a challenge")),
-                    None => Ok(format!("{}{}{}{}", NUL, username, NUL, password).as_bytes().to_base64(base64::STANDARD)),
+                    None => Ok(format!("{}{}{}{}", NUL, username, NUL, password)
+                                   .as_bytes()
+                                   .to_base64(base64::STANDARD)),
                 }
-            },
+            }
             Mecanism::CramMd5 => {
                 let encoded_challenge = match challenge {
                     Some(challenge) => challenge,
@@ -66,8 +73,10 @@ impl Mecanism {
                 let mut hmac = Hmac::new(Md5::new(), password.as_bytes());
                 hmac.input(&decoded_challenge);
 
-                Ok(format!("{} {}", username, hmac.result().code().to_hex()).as_bytes().to_base64(base64::STANDARD))
-            },
+                Ok(format!("{} {}", username, hmac.result().code().to_hex())
+                       .as_bytes()
+                       .to_base64(base64::STANDARD))
+            }
         }
     }
 }
@@ -80,15 +89,21 @@ mod test {
     fn test_plain() {
         let mecanism = Mecanism::Plain;
 
-        assert_eq!(mecanism.response("username", "password", None).unwrap(), "AHVzZXJuYW1lAHBhc3N3b3Jk");
+        assert_eq!(mecanism.response("username", "password", None).unwrap(),
+                   "AHVzZXJuYW1lAHBhc3N3b3Jk");
+        assert!(mecanism.response("username", "password", Some("test")).is_err());
     }
 
     #[test]
     fn test_cram_md5() {
         let mecanism = Mecanism::CramMd5;
 
-        assert_eq!(mecanism.response("alice", "wonderland",
-            Some("PDE3ODkzLjEzMjA2NzkxMjNAdGVzc2VyYWN0LnN1c2FtLmluPg==")).unwrap(),
-            "YWxpY2UgNjRiMmE0M2MxZjZlZDY4MDZhOTgwOTE0ZTIzZTc1ZjA=");
+        assert_eq!(mecanism.response("alice",
+                                     "wonderland",
+                                     Some("PDE3ODkzLjEzMjA2NzkxMjNAdGVzc2VyYWN0LnN1c2FtLmluPg=="))
+                           .unwrap(),
+                   "YWxpY2UgNjRiMmE0M2MxZjZlZDY4MDZhOTgwOTE0ZTIzZTc1ZjA=");
+        assert!(mecanism.response("alice", "wonderland", Some("tést")).is_err());
+        assert!(mecanism.response("alice", "wonderland", None).is_err());
     }
 }

src/client/mod.rs

@@ -1,15 +1,18 @@
 //! SMTP client
 
 use std::string::String;
-use std::net::{SocketAddr, ToSocketAddrs};
+use std::net::ToSocketAddrs;
 use std::io::{BufRead, Read, Write};
+use std::io;
+use std::fmt::Debug;
 
 use bufstream::BufStream;
+use openssl::ssl::SslContext;
 
 use response::ResponseParser;
 use authentication::Mecanism;
 use error::{Error, SmtpResult};
-use client::net::{Connector, SmtpStream};
+use client::net::{Connector, NetworkStream};
 use {CRLF, MESSAGE_ENDING};
 
 pub mod net;
@@ -23,8 +26,9 @@ fn escape_dot(string: &str) -> String {
         format!(".{}", string)
     } else {
         string.to_string()
-    }.replace("\r.", "\r..")
-     .replace("\n.", "\n..")
+    }
+        .replace("\r.", "\r..")
+        .replace("\n.", "\n..")
 }
 
 /// Returns the string replacing all the CRLF with "\<CRLF\>"
@@ -40,12 +44,10 @@ fn remove_crlf(string: &str) -> String {
 }
 
 /// Structure that implements the SMTP client
-pub struct Client<S: Write + Read = SmtpStream> {
+pub struct Client<S: Write + Read = NetworkStream> {
     /// TCP stream between client and server
     /// Value is None before connection
     stream: Option<BufStream<S>>,
-    /// Socket we are connecting to
-    server_addr: SocketAddr,
 }
 
 macro_rules! return_err (
@@ -54,39 +56,53 @@ macro_rules! return_err (
     })
 );
 
-impl<S: Write + Read = SmtpStream> Client<S> {
+impl<S: Write + Read = NetworkStream> Client<S> {
     /// Creates a new SMTP client
     ///
     /// It does not connects to the server, but only creates the `Client`
-    pub fn new<A: ToSocketAddrs>(addr: A) -> Result<Client<S>, Error> {
-    	let mut addresses = try!(addr.to_socket_addrs());
-    	
-		match addresses.next() {
-    		Some(addr) => Ok(Client {
-    			stream: None,
-            	server_addr: addr,
-        	}),
-    		None => Err(From::from("Could nor resolve hostname")),
-    	}
+    pub fn new() -> Client<S> {
+        Client { stream: None }
     }
 }
 
-impl<S: Connector + Write + Read = SmtpStream> Client<S> {
+impl<S: Connector + Write + Read + Debug + Clone = NetworkStream> Client<S> {
     /// Closes the SMTP transaction if possible
     pub fn close(&mut self) {
         let _ = self.quit();
         self.stream = None;
     }
 
+    /// Sets the underlying stream
+    pub fn set_stream(&mut self, stream: S) {
+        self.stream = Some(BufStream::new(stream));
+    }
+
+    /// Upgrades the underlying connection to SSL/TLS
+    pub fn upgrade_tls_stream(&mut self, ssl_context: &SslContext) -> io::Result<()> {
+        //let current_stream = self.stream.clone();
+        if self.stream.is_some() {
+            self.stream.as_mut().unwrap().get_mut().upgrade_tls(ssl_context)
+        } else {
+            Ok(())
+        }
+    }
+
     /// Connects to the configured server
-    pub fn connect(&mut self) -> SmtpResult {
+    pub fn connect<A: ToSocketAddrs>(&mut self, addr: &A) -> SmtpResult {
         // Connect should not be called when the client is already connected
         if self.stream.is_some() {
             return_err!("The connection is already established", self);
         }
 
+        let mut addresses = try!(addr.to_socket_addrs());
+
+        let server_addr = match addresses.next() {
+            Some(addr) => addr,
+            None => return_err!("Could not resolve hostname", self),
+        };
+
         // Try to connect
-        self.stream = Some(BufStream::new(try!(Connector::connect(&self.server_addr))));
+        self.set_stream(try!(Connector::connect(&server_addr, None)));
 
         self.get_reply()
     }
@@ -101,12 +117,7 @@ impl<S: Connector + Write + Read = SmtpStream> Client<S> {
         self.send_server(command, CRLF)
     }
 
-    /// Send a HELO command and fills `server_info`
-    pub fn helo(&mut self, hostname: &str) -> SmtpResult {
-        self.command(&format!("HELO {}", hostname))
-    }
-
-    /// Sends a EHLO command and fills `server_info`
+    /// Sends a EHLO command
     pub fn ehlo(&mut self, hostname: &str) -> SmtpResult {
         self.command(&format!("EHLO {}", hostname))
     }
@@ -166,19 +177,30 @@ impl<S: Connector + Write + Read = SmtpStream> Client<S> {
     pub fn auth(&mut self, mecanism: Mecanism, username: &str, password: &str) -> SmtpResult {
 
         if mecanism.supports_initial_response() {
-            self.command(&format!("AUTH {} {}", mecanism, try!(mecanism.response(username, password, None))))
+            self.command(&format!("AUTH {} {}",
+                                  mecanism,
+                                  try!(mecanism.response(username, password, None))))
         } else {
             let encoded_challenge = match try!(self.command("AUTH CRAM-MD5")).first_word() {
                 Some(challenge) => challenge,
                 None => return Err(Error::ResponseParsingError("Could not read CRAM challenge")),
             };
 
-            let cram_response = try!(mecanism.response(username, password, Some(&encoded_challenge)));
+            debug!("CRAM challenge: {}", encoded_challenge);
 
-            self.command(&format!("AUTH CRAM-MD5 {}", cram_response))
+            let cram_response = try!(mecanism.response(username,
+                                                       password,
+                                                       Some(&encoded_challenge)));
+
+            self.command(&format!("{}", cram_response))
         }
     }
 
+    /// Sends a STARTTLS command
+    pub fn starttls(&mut self) -> SmtpResult {
+        self.command("STARTTLS")
+    }
+
     /// Sends the message content
     pub fn message(&mut self, message_content: &str) -> SmtpResult {
         self.send_server(&escape_dot(message_content), MESSAGE_ENDING)
@@ -206,6 +228,8 @@ impl<S: Connector + Write + Read = SmtpStream> Client<S> {
         let mut line = String::new();
         try!(self.stream.as_mut().unwrap().read_line(&mut line));
 
+        debug!("Read: {}", escape_crlf(line.as_ref()));
+
         while try!(parser.read_line(remove_crlf(line.as_ref()).as_ref())) {
             line.clear();
             try!(self.stream.as_mut().unwrap().read_line(&mut line));
@@ -236,19 +260,15 @@ mod test {
     fn test_remove_crlf() {
         assert_eq!(remove_crlf("\r\n"), "");
         assert_eq!(remove_crlf("EHLO my_name\r\n"), "EHLO my_name");
-        assert_eq!(
-            remove_crlf("EHLO my_name\r\nSIZE 42\r\n"),
-            "EHLO my_nameSIZE 42"
-        );
+        assert_eq!(remove_crlf("EHLO my_name\r\nSIZE 42\r\n"),
+                   "EHLO my_nameSIZE 42");
     }
 
     #[test]
     fn test_escape_crlf() {
         assert_eq!(escape_crlf("\r\n"), "<CR><LF>");
         assert_eq!(escape_crlf("EHLO my_name\r\n"), "EHLO my_name<CR><LF>");
-        assert_eq!(
-            escape_crlf("EHLO my_name\r\nSIZE 42\r\n"),
-            "EHLO my_name<CR><LF>SIZE 42<CR><LF>"
-        );
+        assert_eq!(escape_crlf("EHLO my_name\r\nSIZE 42\r\n"),
+                   "EHLO my_name<CR><LF>SIZE 42<CR><LF>");
     }
 }

src/client/net.rs

@@ -1,23 +1,94 @@
 //! A trait to represent a stream
 
 use std::io;
+use std::io::{Read, Write, ErrorKind};
 use std::net::SocketAddr;
 use std::net::TcpStream;
+use std::fmt;
+use std::fmt::{Debug, Formatter};
+use openssl::ssl::{SslContext, SslStream};
 
 /// A trait for the concept of opening a stream
 pub trait Connector {
     /// Opens a connection to the given IP socket
-    fn connect(addr: &SocketAddr) -> io::Result<Self>;
+    fn connect(addr: &SocketAddr, ssl_context: Option<&SslContext>) -> io::Result<Self>;
+    /// Upgrades to TLS connection
+    fn upgrade_tls(&mut self, ssl_context: &SslContext) -> io::Result<()>;
 }
 
-impl Connector for SmtpStream {
-    fn connect(addr: &SocketAddr) -> io::Result<SmtpStream> {
-        TcpStream::connect(addr)
+impl Connector for NetworkStream {
+    fn connect(addr: &SocketAddr, ssl_context: Option<&SslContext>) -> io::Result<NetworkStream> {
+        let tcp_stream = try!(TcpStream::connect(addr));
+
+        match ssl_context {
+            Some(context) => match SslStream::new(&context, tcp_stream) {
+                Ok(stream) => Ok(NetworkStream::Ssl(stream)),
+                Err(err) => Err(io::Error::new(ErrorKind::Other, err)),
+            },
+            None => Ok(NetworkStream::Plain(tcp_stream)),
+        }
+    }
+
+    fn upgrade_tls(&mut self, ssl_context: &SslContext) -> io::Result<()> {
+        *self = match self.clone() {
+            NetworkStream::Plain(stream) => match SslStream::new(ssl_context, stream) {
+                Ok(ssl_stream) => NetworkStream::Ssl(ssl_stream),
+                Err(err) => return Err(io::Error::new(ErrorKind::Other, err)),
+            },
+            NetworkStream::Ssl(stream) => NetworkStream::Ssl(stream),
+        };
+        Ok(())
     }
 }
 
-/// Represents an atual SMTP network stream
-//Used later for ssl
-pub type SmtpStream = TcpStream;
 
+/// Represents the different types of underlying network streams
+pub enum NetworkStream {
+    /// Plain TCP
+    Plain(TcpStream),
+    /// SSL over TCP
+    Ssl(SslStream<TcpStream>),
+}
 
+impl Clone for NetworkStream {
+    #[inline]
+    fn clone(&self) -> NetworkStream {
+        match self {
+            &NetworkStream::Plain(ref stream) => NetworkStream::Plain(stream.try_clone().unwrap()),
+            &NetworkStream::Ssl(ref stream) => NetworkStream::Ssl(stream.try_clone().unwrap()),
+        }
+    }
+}
+
+impl Debug for NetworkStream {
+    fn fmt(&self, f: &mut Formatter) -> fmt::Result {
+        f.write_str("NetworkStream(_)")
+    }
+}
+
+impl Read for NetworkStream {
+    #[inline]
+    fn read(&mut self, buf: &mut [u8]) -> io::Result<usize> {
+        match *self {
+            NetworkStream::Plain(ref mut stream) => stream.read(buf),
+            NetworkStream::Ssl(ref mut stream) => stream.read(buf),
+        }
+    }
+}
+
+impl Write for NetworkStream {
+    #[inline]
+    fn write(&mut self, msg: &[u8]) -> io::Result<usize> {
+        match *self {
+            NetworkStream::Plain(ref mut stream) => stream.write(msg),
+            NetworkStream::Ssl(ref mut stream) => stream.write(msg),
+        }
+    }
+    #[inline]
+    fn flush(&mut self) -> io::Result<()> {
+        match *self {
+            NetworkStream::Plain(ref mut stream) => stream.flush(),
+            NetworkStream::Ssl(ref mut stream) => stream.flush(),
+        }
+    }
+}

src/email.rs

@@ -74,9 +74,7 @@ pub struct Email {
 
 impl Display for Email {
     fn fmt(&self, f: &mut Formatter) -> Result {
-        write!(f, "{}",
-            self.message.as_string()
-        )
+        write!(f, "{}", self.message.as_string())
     }
 }
 
@@ -92,7 +90,8 @@ impl EmailBuilder {
             message_id: current_message,
         };
 
-        match Header::new_with_value("Message-ID".to_string(), format!("<{}@rust-smtp>", current_message)) {
+        match Header::new_with_value("Message-ID".to_string(),
+                                     format!("<{}@rust-smtp>", current_message)) {
             Ok(header) => email.message.headers.insert(header),
             Err(_) => (),
         }
@@ -166,7 +165,7 @@ impl EmailBuilder {
 
     /// Adds a `Date` header with the given date
     pub fn date(mut self, date: &Tm) -> EmailBuilder {
-        self.insert_header(("Date", Tm::rfc822(date).to_string().as_ref()));
+        self.insert_header(("Date", Tm::rfc822z(date).to_string().as_ref()));
         self.date_issued = true;
         self
     }
@@ -174,7 +173,7 @@ impl EmailBuilder {
     /// Build the Email
     pub fn build(mut self) -> Email {
         if !self.date_issued {
-            self.insert_header(("Date", Tm::rfc822(&now()).to_string().as_ref()));
+            self.insert_header(("Date", Tm::rfc822z(&now()).to_string().as_ref()));
         }
         self.content.message.update_headers();
         self.content
@@ -239,7 +238,7 @@ impl SendableEmail for Email {
         if self.to.is_empty() {
             None
         } else {
-        	Some(self.to.clone())
+            Some(self.to.clone())
         }
     }
 
@@ -280,22 +279,21 @@ mod test {
             message_id: current_message,
         };
 
-        email.message.headers.insert(
-            Header::new_with_value("Message-ID".to_string(),
-                format!("<{}@rust-smtp>", current_message)
-            ).unwrap()
-        );
+        email.message.headers.insert(Header::new_with_value("Message-ID".to_string(),
+                                                            format!("<{}@rust-smtp>",
+                                                                    current_message))
+                                         .unwrap());
 
-        email.message.headers.insert(
-            Header::new_with_value("To".to_string(), "to@example.com".to_string()).unwrap()
-        );
+        email.message
+             .headers
+             .insert(Header::new_with_value("To".to_string(), "to@example.com".to_string())
+                         .unwrap());
 
         email.message.body = "body".to_string();
 
-        assert_eq!(
-            format!("{}", email),
-            format!("Message-ID: <{}@rust-smtp>\r\nTo: to@example.com\r\n\r\nbody\r\n", current_message)
-        );
+        assert_eq!(format!("{}", email),
+                   format!("Message-ID: <{}@rust-smtp>\r\nTo: to@example.com\r\n\r\nbody\r\n",
+                           current_message));
         assert_eq!(current_message.to_string(), email.message_id().unwrap());
     }
 
@@ -305,21 +303,23 @@ mod test {
         let date_now = now();
 
         let email = email_builder.to("user@localhost")
-                             .from("user@localhost")
-                             .cc(("cc@localhost", "Alias"))
-                             .reply_to("reply@localhost")
-                             .sender("sender@localhost")
-                             .body("Hello World!")
-                             .date(&date_now)
-                             .subject("Hello")
-                             .add_header(("X-test", "value"))
-                             .build();
+                                 .from("user@localhost")
+                                 .cc(("cc@localhost", "Alias"))
+                                 .reply_to("reply@localhost")
+                                 .sender("sender@localhost")
+                                 .body("Hello World!")
+                                 .date(&date_now)
+                                 .subject("Hello")
+                                 .add_header(("X-test", "value"))
+                                 .build();
 
-        assert_eq!(
-            format!("{}", email),
-            format!("Message-ID: <{}@rust-smtp>\r\nTo: <user@localhost>\r\nFrom: <user@localhost>\r\nCc: \"Alias\" <cc@localhost>\r\nReply-To: <reply@localhost>\r\nSender: <sender@localhost>\r\nDate: {}\r\nSubject: Hello\r\nX-test: value\r\n\r\nHello World!\r\n",
-                    email.message_id().unwrap(), date_now.rfc822())
-        );
+        assert_eq!(format!("{}", email),
+                   format!("Message-ID: <{}@rust-smtp>\r\nTo: <user@localhost>\r\nFrom: \
+                            <user@localhost>\r\nCc: \"Alias\" <cc@localhost>\r\nReply-To: \
+                            <reply@localhost>\r\nSender: <sender@localhost>\r\nDate: \
+                            {}\r\nSubject: Hello\r\nX-test: value\r\n\r\nHello World!\r\n",
+                           email.message_id().unwrap(),
+                           date_now.rfc822z()));
     }
 
     #[test]
@@ -328,28 +328,21 @@ mod test {
         let date_now = now();
 
         let email = email_builder.to("user@localhost")
-                             .from("user@localhost")
-                             .cc(("cc@localhost", "Alias"))
-                             .reply_to("reply@localhost")
-                             .sender("sender@localhost")
-                             .body("Hello World!")
-                             .date(&date_now)
-                             .subject("Hello")
-                             .add_header(("X-test", "value"))
-                             .build();
+                                 .from("user@localhost")
+                                 .cc(("cc@localhost", "Alias"))
+                                 .reply_to("reply@localhost")
+                                 .sender("sender@localhost")
+                                 .body("Hello World!")
+                                 .date(&date_now)
+                                 .subject("Hello")
+                                 .add_header(("X-test", "value"))
+                                 .build();
 
-        assert_eq!(
-            email.from_address().unwrap(),
-            "sender@localhost".to_string()
-        );
-        assert_eq!(
-            email.to_addresses().unwrap(),
-            vec!["user@localhost".to_string(), "cc@localhost".to_string()]
-        );
-        assert_eq!(
-            email.message().unwrap(),
-            format!("{}", email)
-        );
+        assert_eq!(email.from_address().unwrap(),
+                   "sender@localhost".to_string());
+        assert_eq!(email.to_addresses().unwrap(),
+                   vec!["user@localhost".to_string(), "cc@localhost".to_string()]);
+        assert_eq!(email.message().unwrap(), format!("{}", email));
     }
 
 }

src/error.rs

@@ -70,7 +70,7 @@ impl From<Response> for Error {
         match response.severity() {
             Severity::TransientNegativeCompletion => TransientError(response),
             Severity::PermanentNegativeCompletion => PermanentError(response),
-            _ => ClientError("Unknown error code")
+            _ => ClientError("Unknown error code"),
         }
     }
 }

src/extension.rs

@@ -54,13 +54,13 @@ pub struct ServerInfo {
 
 impl Display for ServerInfo {
     fn fmt(&self, f: &mut Formatter) -> fmt::Result {
-        write!(f, "{} with {}",
-            self.name,
-            match self.features.is_empty() {
-                true => "no supported features".to_string(),
-                false => format! ("{:?}", self.features),
-            }
-        )
+        write!(f,
+               "{} with {}",
+               self.name,
+               match self.features.is_empty() {
+                   true => "no supported features".to_string(),
+                   false => format!("{:?}", self.features),
+               })
     }
 }
 
@@ -69,32 +69,42 @@ impl ServerInfo {
     pub fn from_response(response: &Response) -> Result<ServerInfo, Error> {
         let name = match response.first_word() {
             Some(name) => name,
-            None => return Err(Error::ResponseParsingError("Could not read server name"))
+            None => return Err(Error::ResponseParsingError("Could not read server name")),
         };
 
         let mut features: HashSet<Extension> = HashSet::new();
 
         for line in response.message() {
 
-            let splitted : Vec<&str> = line.split_whitespace().collect();
+            let splitted: Vec<&str> = line.split_whitespace().collect();
             let _ = match splitted[0] {
-                "8BITMIME" => {features.insert(Extension::EightBitMime);},
-                "SMTPUTF8" => {features.insert(Extension::SmtpUtfEight);},
-                "STARTTLS" => {features.insert(Extension::StartTls);},
+                "8BITMIME" => {
+                    features.insert(Extension::EightBitMime);
+                }
+                "SMTPUTF8" => {
+                    features.insert(Extension::SmtpUtfEight);
+                }
+                "STARTTLS" => {
+                    features.insert(Extension::StartTls);
+                }
                 "AUTH" => {
                     for &mecanism in &splitted[1..] {
                         match mecanism {
-                            "PLAIN" => {features.insert(Extension::Authentication(Mecanism::Plain));},
-                            "CRAM-MD5" => {features.insert(Extension::Authentication(Mecanism::CramMd5));},
+                            "PLAIN" => {
+                                features.insert(Extension::Authentication(Mecanism::Plain));
+                            }
+                            "CRAM-MD5" => {
+                                features.insert(Extension::Authentication(Mecanism::CramMd5));
+                            }
                             _ => (),
                         }
                     }
-                },
+                }
                 _ => (),
             };
         }
 
-        Ok(ServerInfo{
+        Ok(ServerInfo {
             name: name,
             features: features,
         })
@@ -113,85 +123,98 @@ impl ServerInfo {
 
 #[cfg(test)]
 mod test {
-	use std::collections::HashSet;
-	
+    use std::collections::HashSet;
+
     use super::{ServerInfo, Extension};
     use authentication::Mecanism;
     use response::{Code, Response, Severity, Category};
-    
+
     #[test]
     fn test_extension_fmt() {
-		assert_eq!(format!("{}", Extension::EightBitMime), "8BITMIME".to_string());
-		assert_eq!(format!("{}", Extension::Authentication(Mecanism::Plain)), "AUTH PLAIN".to_string());
+        assert_eq!(format!("{}", Extension::EightBitMime),
+                   "8BITMIME".to_string());
+        assert_eq!(format!("{}", Extension::Authentication(Mecanism::Plain)),
+                   "AUTH PLAIN".to_string());
     }
-    
+
     #[test]
     fn test_serverinfo_fmt() {
-    	let mut eightbitmime = HashSet::new();
-    	assert!(eightbitmime.insert(Extension::EightBitMime));
-    	
-        assert_eq!(format!("{}", ServerInfo{
-            name: "name".to_string(),
-            features: eightbitmime.clone()
-        }), "name with {EightBitMime}".to_string());
-        
+        let mut eightbitmime = HashSet::new();
+        assert!(eightbitmime.insert(Extension::EightBitMime));
+
+        assert_eq!(format!("{}",
+                           ServerInfo {
+                               name: "name".to_string(),
+                               features: eightbitmime.clone(),
+                           }),
+                   "name with {EightBitMime}".to_string());
+
         let empty = HashSet::new();
-        
-        assert_eq!(format!("{}", ServerInfo{
-            name: "name".to_string(),
-            features: empty,
-        }), "name with no supported features".to_string());
-        
+
+        assert_eq!(format!("{}",
+                           ServerInfo {
+                               name: "name".to_string(),
+                               features: empty,
+                           }),
+                   "name with no supported features".to_string());
+
         let mut plain = HashSet::new();
-    	assert!(plain.insert(Extension::Authentication(Mecanism::Plain)));
-    	
-    	assert_eq!(format!("{}", ServerInfo{
-            name: "name".to_string(),
-            features: plain.clone()
-        }), "name with {Authentication(Plain)}".to_string());
+        assert!(plain.insert(Extension::Authentication(Mecanism::Plain)));
+
+        assert_eq!(format!("{}",
+                           ServerInfo {
+                               name: "name".to_string(),
+                               features: plain.clone(),
+                           }),
+                   "name with {Authentication(Plain)}".to_string());
     }
-    
+
     #[test]
     fn test_serverinfo() {
-    	let response = Response::new(
-            Code::new(Severity::PositiveCompletion, Category::Unspecified4, 1),
-            vec!["me".to_string(), "8BITMIME".to_string(), "SIZE 42".to_string()]
-        );
-    	
-    	let mut features = HashSet::new();
-    	assert!(features.insert(Extension::EightBitMime));
-    	
-    	let server_info = ServerInfo {
-    		name: "me".to_string(),
-    		features: features,
-    	};
-    	
-    	assert_eq!(ServerInfo::from_response(&response).unwrap(), server_info);
-    	
-    	assert!(server_info.supports_feature(&Extension::EightBitMime));
-    	assert!(!server_info.supports_feature(&Extension::StartTls));
-    	assert!(!server_info.supports_auth_mecanism(Mecanism::CramMd5));
-    	
-    	let response2 = Response::new(
-            Code::new(Severity::PositiveCompletion, Category::Unspecified4, 1),
-            vec!["me".to_string(), "AUTH PLAIN CRAM-MD5 OTHER".to_string(), "8BITMIME".to_string(), "SIZE 42".to_string()]
-        );
-    	
-    	let mut features2 = HashSet::new();
-    	assert!(features2.insert(Extension::EightBitMime));
-    	assert!(features2.insert(Extension::Authentication(Mecanism::Plain)));
-    	assert!(features2.insert(Extension::Authentication(Mecanism::CramMd5)));
-    	
-    	let server_info2 = ServerInfo {
-    		name: "me".to_string(),
-    		features: features2,
-    	};
-    	
-    	assert_eq!(ServerInfo::from_response(&response2).unwrap(), server_info2);
-    	
-    	assert!(server_info2.supports_feature(&Extension::EightBitMime));
-    	assert!(server_info2.supports_auth_mecanism(Mecanism::Plain));
-    	assert!(server_info2.supports_auth_mecanism(Mecanism::CramMd5));
-    	assert!(!server_info2.supports_feature(&Extension::StartTls));
+        let response = Response::new(Code::new(Severity::PositiveCompletion,
+                                               Category::Unspecified4,
+                                               1),
+                                     vec!["me".to_string(),
+                                          "8BITMIME".to_string(),
+                                          "SIZE 42".to_string()]);
+
+        let mut features = HashSet::new();
+        assert!(features.insert(Extension::EightBitMime));
+
+        let server_info = ServerInfo {
+            name: "me".to_string(),
+            features: features,
+        };
+
+        assert_eq!(ServerInfo::from_response(&response).unwrap(), server_info);
+
+        assert!(server_info.supports_feature(&Extension::EightBitMime));
+        assert!(!server_info.supports_feature(&Extension::StartTls));
+        assert!(!server_info.supports_auth_mecanism(Mecanism::CramMd5));
+
+        let response2 = Response::new(Code::new(Severity::PositiveCompletion,
+                                                Category::Unspecified4,
+                                                1),
+                                      vec!["me".to_string(),
+                                           "AUTH PLAIN CRAM-MD5 OTHER".to_string(),
+                                           "8BITMIME".to_string(),
+                                           "SIZE 42".to_string()]);
+
+        let mut features2 = HashSet::new();
+        assert!(features2.insert(Extension::EightBitMime));
+        assert!(features2.insert(Extension::Authentication(Mecanism::Plain)));
+        assert!(features2.insert(Extension::Authentication(Mecanism::CramMd5)));
+
+        let server_info2 = ServerInfo {
+            name: "me".to_string(),
+            features: features2,
+        };
+
+        assert_eq!(ServerInfo::from_response(&response2).unwrap(), server_info2);
+
+        assert!(server_info2.supports_feature(&Extension::EightBitMime));
+        assert!(server_info2.supports_auth_mecanism(Mecanism::Plain));
+        assert!(server_info2.supports_auth_mecanism(Mecanism::CramMd5));
+        assert!(!server_info2.supports_feature(&Extension::StartTls));
     }
 }

src/lib.rs

@@ -2,17 +2,17 @@
 //!
 //! This client should tend to follow [RFC 5321](https://tools.ietf.org/html/rfc5321), but is still
 //! a work in progress. It is designed to efficiently send emails from an application to a
-//! relay email server, as it relies as much as possible on the relay server for sanity and RFC compliance
-//! checks.
+//! relay email server, as it relies as much as possible on the relay server for sanity and RFC
+//! compliance checks.
 //!
 //! It implements the following extensions:
 //!
 //! * 8BITMIME ([RFC 6152](https://tools.ietf.org/html/rfc6152))
 //! * AUTH ([RFC 4954](http://tools.ietf.org/html/rfc4954)) with PLAIN and CRAM-MD5 mecanisms
+//! * STARTTLS ([RFC 2487](http://tools.ietf.org/html/rfc2487))
 //!
 //! It will eventually implement the following extensions:
 //!
-//! * STARTTLS ([RFC 2487](http://tools.ietf.org/html/rfc2487))
 //! * SMTPUTF8 ([RFC 6531](http://tools.ietf.org/html/rfc6531))
 //!
 //! ## Architecture
@@ -56,6 +56,8 @@
 //! ```rust,no_run
 //! use smtp::sender::{Sender, SenderBuilder};
 //! use smtp::email::EmailBuilder;
+//! use smtp::authentication::Mecanism;
+//! use smtp::SUBMISSION_PORT;
 //!
 //! let mut builder = EmailBuilder::new();
 //! builder = builder.to(("user@example.org", "Alias name"));
@@ -71,11 +73,16 @@
 //! let email = builder.build();
 //!
 //! // Connect to a remote server on a custom port
-//! let mut sender = SenderBuilder::new(("server.tld", 10025)).unwrap()
+//! let mut sender = SenderBuilder::new(("server.tld", SUBMISSION_PORT)).unwrap()
 //!     // Set the name sent during EHLO/HELO, default is `localhost`
 //!     .hello_name("my.hostname.tld")
 //!     // Add credentials for authentication
 //!     .credentials("username", "password")
+//!     // Use TLS with STARTTLS, you can also specify a specific SSL context
+//!     // with `.ssl_context(context)`
+//!     .starttls()
+//!     // Configure accepted authetication mecanisms
+//!     .authentication_mecanisms(vec![Mecanism::CramMd5])
 //!     // Enable connection reuse
 //!     .enable_connection_reuse(true).build();
 //!
@@ -116,12 +123,11 @@
 //!
 //! ```rust,no_run
 //! use smtp::client::Client;
-//! use smtp::client::net::SmtpStream;
 //! use smtp::SMTP_PORT;
-//! use std::net::TcpStream;
+//! use smtp::client::net::NetworkStream;
 //!
-//! let mut email_client: Client<SmtpStream> = Client::new(("localhost", SMTP_PORT)).unwrap();
-//! let _ = email_client.connect();
+//! let mut email_client: Client<NetworkStream> = Client::new();
+//! let _ = email_client.connect(&("localhost", SMTP_PORT));
 //! let _ = email_client.ehlo("my_hostname");
 //! let _ = email_client.mail("user@example.com", None);
 //! let _ = email_client.rcpt("user@example.org");
@@ -132,13 +138,15 @@
 
 #![deny(missing_docs)]
 
-#[macro_use] extern crate log;
+#[macro_use]
+extern crate log;
 extern crate rustc_serialize as serialize;
 extern crate crypto;
 extern crate time;
 extern crate uuid;
 extern crate email as email_format;
 extern crate bufstream;
+extern crate openssl;
 
 mod extension;
 pub mod client;

src/response.rs

@@ -2,7 +2,7 @@
 
 use std::str::FromStr;
 use std::fmt::{Display, Formatter, Result};
-use std::result::Result as RResult;
+use std::result;
 
 use self::Severity::*;
 use self::Category::*;
@@ -23,7 +23,7 @@ pub enum Severity {
 
 impl FromStr for Severity {
     type Err = Error;
-    fn from_str(s: &str) -> RResult<Severity, Error> {
+    fn from_str(s: &str) -> result::Result<Severity, Error> {
         match s {
             "2" => Ok(PositiveCompletion),
             "3" => Ok(PositiveIntermediate),
@@ -36,14 +36,14 @@ impl FromStr for Severity {
 
 impl Display for Severity {
     fn fmt(&self, f: &mut Formatter) -> Result {
-        write!(f, "{}",
-            match *self {
-                PositiveCompletion => 2,
-                PositiveIntermediate => 3,
-                TransientNegativeCompletion => 4,
-                PermanentNegativeCompletion => 5,
-            }
-        )
+        write!(f,
+               "{}",
+               match *self {
+                   PositiveCompletion => 2,
+                   PositiveIntermediate => 3,
+                   TransientNegativeCompletion => 4,
+                   PermanentNegativeCompletion => 5,
+               })
     }
 }
 
@@ -66,7 +66,7 @@ pub enum Category {
 
 impl FromStr for Category {
     type Err = Error;
-    fn from_str(s: &str) -> RResult<Category, Error> {
+    fn from_str(s: &str) -> result::Result<Category, Error> {
         match s {
             "0" => Ok(Syntax),
             "1" => Ok(Information),
@@ -81,16 +81,16 @@ impl FromStr for Category {
 
 impl Display for Category {
     fn fmt(&self, f: &mut Formatter) -> Result {
-        write!(f, "{}",
-            match *self {
-                Syntax => 0,
-                Information => 1,
-                Connections => 2,
-                Unspecified3 => 3,
-                Unspecified4 => 4,
-                MailSystem => 5,
-            }
-        )
+        write!(f,
+               "{}",
+               match *self {
+                   Syntax => 0,
+                   Information => 1,
+                   Connections => 2,
+                   Unspecified3 => 3,
+                   Unspecified4 => 4,
+                   MailSystem => 5,
+               })
     }
 }
 
@@ -109,10 +109,16 @@ impl FromStr for Code {
     type Err = Error;
 
     #[inline]
-    fn from_str(s: &str) -> RResult<Code, Error> {
+    fn from_str(s: &str) -> result::Result<Code, Error> {
         if s.len() == 3 {
-            match (s[0..1].parse::<Severity>(), s[1..2].parse::<Category>(), s[2..3].parse::<u8>()) {
-                (Ok(severity), Ok(category), Ok(detail)) => Ok(Code {severity: severity, category: category, detail: detail}),
+            match (s[0..1].parse::<Severity>(),
+                   s[1..2].parse::<Category>(),
+                   s[2..3].parse::<u8>()) {
+                (Ok(severity), Ok(category), Ok(detail)) => Ok(Code {
+                    severity: severity,
+                    category: category,
+                    detail: detail,
+                }),
                 _ => return Err(Error::ResponseParsingError("Could not parse response code")),
             }
         } else {
@@ -144,7 +150,7 @@ pub struct ResponseParser {
     code: Option<Code>,
     /// Server response string (optional)
     /// Handle multiline responses
-    message: Vec<String>
+    message: Vec<String>,
 }
 
 impl ResponseParser {
@@ -157,7 +163,7 @@ impl ResponseParser {
     }
 
     /// Parses a line and return a `bool` indicating if there are more lines to come
-    pub fn read_line(&mut self, line: &str) -> RResult<bool, Error> {
+    pub fn read_line(&mut self, line: &str) -> result::Result<bool, Error> {
 
         if line.len() < 3 {
             return Err(Error::ResponseParsingError("Wrong code length (should be 3 digit)"));
@@ -166,10 +172,11 @@ impl ResponseParser {
         match self.code {
             Some(ref code) => {
                 if code.code() != line[0..3] {
-                    return Err(Error::ResponseParsingError("Response code has changed during a reponse"));
+                    return Err(Error::ResponseParsingError("Response code has changed during a \
+                                                            reponse"));
                 }
-            },
-            None => self.code = Some(try!(line[0..3].parse::<Code>()))
+            }
+            None => self.code = Some(try!(line[0..3].parse::<Code>())),
         }
 
         if line.len() > 4 {
@@ -188,7 +195,8 @@ impl ResponseParser {
     pub fn response(self) -> SmtpResult {
         match self.code {
             Some(code) => Ok(Response::new(code, self.message)),
-            None => Err(Error::ResponseParsingError("Incomplete response, could not read response code"))
+            None => Err(Error::ResponseParsingError("Incomplete response, could not read \
+                                                     response code")),
         }
     }
 }
@@ -202,7 +210,7 @@ pub struct Response {
     code: Code,
     /// Server response string (optional)
     /// Handle multiline responses
-    message: Vec<String>
+    message: Vec<String>,
 }
 
 impl Response {
@@ -260,7 +268,7 @@ impl Response {
             false => match self.message[0].split_whitespace().next() {
                 Some(word) => Some(word.to_string()),
                 None => None,
-            }
+            },
         }
     }
 }
@@ -271,8 +279,10 @@ mod test {
 
     #[test]
     fn test_severity_from_str() {
-        assert_eq!("2".parse::<Severity>().unwrap(), Severity::PositiveCompletion);
-        assert_eq!("4".parse::<Severity>().unwrap(), Severity::TransientNegativeCompletion);
+        assert_eq!("2".parse::<Severity>().unwrap(),
+                   Severity::PositiveCompletion);
+        assert_eq!("4".parse::<Severity>().unwrap(),
+                   Severity::TransientNegativeCompletion);
         assert!("1".parse::<Severity>().is_err());
     }
 
@@ -295,26 +305,24 @@ mod test {
 
     #[test]
     fn test_code_new() {
-        assert_eq!(
-            Code::new(Severity::TransientNegativeCompletion, Category::Connections, 0),
-            Code {
-                severity: Severity::TransientNegativeCompletion,
-                category: Category::Connections,
-                detail: 0,
-            }
-        );
+        assert_eq!(Code::new(Severity::TransientNegativeCompletion,
+                             Category::Connections,
+                             0),
+                   Code {
+                       severity: Severity::TransientNegativeCompletion,
+                       category: Category::Connections,
+                       detail: 0,
+                   });
     }
 
     #[test]
     fn test_code_from_str() {
-        assert_eq!(
-            "421".parse::<Code>().unwrap(),
-            Code {
-                severity: Severity::TransientNegativeCompletion,
-                category: Category::Connections,
-                detail: 1,
-            }
-        );
+        assert_eq!("421".parse::<Code>().unwrap(),
+                   Code {
+                       severity: Severity::TransientNegativeCompletion,
+                       category: Category::Connections,
+                       detail: 1,
+                   });
     }
 
     #[test]
@@ -330,36 +338,38 @@ mod test {
 
     #[test]
     fn test_response_new() {
-        assert_eq!(Response::new(
-            Code {
-                severity: "2".parse::<Severity>().unwrap(),
-                category: "4".parse::<Category>().unwrap(),
-                detail: 1,
-            },
-            vec!["me".to_string(), "8BITMIME".to_string(), "SIZE 42".to_string()]
-        ), Response {
-            code: Code {
-                severity: Severity::PositiveCompletion,
-                category: Category::Unspecified4,
-                detail: 1,
-            },
-            message: vec!["me".to_string(), "8BITMIME".to_string(), "SIZE 42".to_string()],
-        });
-        assert_eq!(Response::new(
-            Code {
-                severity: "2".parse::<Severity>().unwrap(),
-                category: "4".parse::<Category>().unwrap(),
-                detail:1,
-            },
-            vec![]
-        ), Response {
-            code: Code {
-                severity: Severity::PositiveCompletion,
-                category: Category::Unspecified4,
-                detail: 1,
-            },
-            message: vec![],
-        });
+        assert_eq!(Response::new(Code {
+                                     severity: "2".parse::<Severity>().unwrap(),
+                                     category: "4".parse::<Category>().unwrap(),
+                                     detail: 1,
+                                 },
+                                 vec!["me".to_string(),
+                                      "8BITMIME".to_string(),
+                                      "SIZE 42".to_string()]),
+                   Response {
+                       code: Code {
+                           severity: Severity::PositiveCompletion,
+                           category: Category::Unspecified4,
+                           detail: 1,
+                       },
+                       message: vec!["me".to_string(),
+                                     "8BITMIME".to_string(),
+                                     "SIZE 42".to_string()],
+                   });
+        assert_eq!(Response::new(Code {
+                                     severity: "2".parse::<Severity>().unwrap(),
+                                     category: "4".parse::<Category>().unwrap(),
+                                     detail: 1,
+                                 },
+                                 vec![]),
+                   Response {
+                       code: Code {
+                           severity: Severity::PositiveCompletion,
+                           category: Category::Unspecified4,
+                           detail: 1,
+                       },
+                       message: vec![],
+                   });
     }
 
     #[test]
@@ -373,186 +383,206 @@ mod test {
 
         let response = parser.response().unwrap();
 
-        assert_eq!(
-            response,
-            Response {
-                code: Code {
-                    severity: Severity::PositiveCompletion,
-                    category: Category::MailSystem,
-                    detail: 0,
-                },
-                message: vec!["me".to_string(), "8BITMIME".to_string(),
-                              "SIZE 42".to_string(), "AUTH PLAIN CRAM-MD5".to_string()],
-            }
-        );
+        assert_eq!(response,
+                   Response {
+                       code: Code {
+                           severity: Severity::PositiveCompletion,
+                           category: Category::MailSystem,
+                           detail: 0,
+                       },
+                       message: vec!["me".to_string(),
+                                     "8BITMIME".to_string(),
+                                     "SIZE 42".to_string(),
+                                     "AUTH PLAIN CRAM-MD5".to_string()],
+                   });
     }
 
     #[test]
     fn test_response_is_positive() {
-        assert!(Response::new(
-            Code {
-                severity: "2".parse::<Severity>().unwrap(),
-                category: "4".parse::<Category>().unwrap(),
-                detail:1,
-            },
-            vec!["me".to_string(), "8BITMIME".to_string(), "SIZE 42".to_string()]
-        ).is_positive());
-        assert!(! Response::new(
-            Code {
-                severity: "5".parse::<Severity>().unwrap(),
-                category: "4".parse::<Category>().unwrap(),
-                detail:1,
-            },
-            vec!["me".to_string(), "8BITMIME".to_string(), "SIZE 42".to_string()]
-        ).is_positive());
+        assert!(Response::new(Code {
+                                  severity: "2".parse::<Severity>().unwrap(),
+                                  category: "4".parse::<Category>().unwrap(),
+                                  detail: 1,
+                              },
+                              vec!["me".to_string(),
+                                   "8BITMIME".to_string(),
+                                   "SIZE 42".to_string()])
+                    .is_positive());
+        assert!(!Response::new(Code {
+                                   severity: "5".parse::<Severity>().unwrap(),
+                                   category: "4".parse::<Category>().unwrap(),
+                                   detail: 1,
+                               },
+                               vec!["me".to_string(),
+                                    "8BITMIME".to_string(),
+                                    "SIZE 42".to_string()])
+                     .is_positive());
     }
 
     #[test]
     fn test_response_message() {
-        assert_eq!(Response::new(
-            Code {
-                severity: "2".parse::<Severity>().unwrap(),
-                category: "4".parse::<Category>().unwrap(),
-                detail:1,
-            },
-            vec!["me".to_string(), "8BITMIME".to_string(), "SIZE 42".to_string()]
-        ).message(), vec!["me".to_string(), "8BITMIME".to_string(), "SIZE 42".to_string()]);
+        assert_eq!(Response::new(Code {
+                                     severity: "2".parse::<Severity>().unwrap(),
+                                     category: "4".parse::<Category>().unwrap(),
+                                     detail: 1,
+                                 },
+                                 vec!["me".to_string(),
+                                      "8BITMIME".to_string(),
+                                      "SIZE 42".to_string()])
+                       .message(),
+                   vec!["me".to_string(), "8BITMIME".to_string(), "SIZE 42".to_string()]);
         let empty_message: Vec<String> = vec![];
-        assert_eq!(Response::new(
-            Code {
-                severity: "2".parse::<Severity>().unwrap(),
-                category: "4".parse::<Category>().unwrap(),
-                detail:1,
-            },
-            vec![]
-        ).message(), empty_message);
+        assert_eq!(Response::new(Code {
+                                     severity: "2".parse::<Severity>().unwrap(),
+                                     category: "4".parse::<Category>().unwrap(),
+                                     detail: 1,
+                                 },
+                                 vec![])
+                       .message(),
+                   empty_message);
     }
 
     #[test]
     fn test_response_severity() {
-        assert_eq!(Response::new(
-            Code {
-                severity: "2".parse::<Severity>().unwrap(),
-                category: "4".parse::<Category>().unwrap(),
-                detail:1,
-            },
-            vec!["me".to_string(), "8BITMIME".to_string(), "SIZE 42".to_string()]
-        ).severity(), Severity::PositiveCompletion);
-        assert_eq!(Response::new(
-            Code {
-                severity: "5".parse::<Severity>().unwrap(),
-                category: "4".parse::<Category>().unwrap(),
-                detail: 1,
-            },
-            vec!["me".to_string(), "8BITMIME".to_string(), "SIZE 42".to_string()]
-        ).severity(), Severity::PermanentNegativeCompletion);
+        assert_eq!(Response::new(Code {
+                                     severity: "2".parse::<Severity>().unwrap(),
+                                     category: "4".parse::<Category>().unwrap(),
+                                     detail: 1,
+                                 },
+                                 vec!["me".to_string(),
+                                      "8BITMIME".to_string(),
+                                      "SIZE 42".to_string()])
+                       .severity(),
+                   Severity::PositiveCompletion);
+        assert_eq!(Response::new(Code {
+                                     severity: "5".parse::<Severity>().unwrap(),
+                                     category: "4".parse::<Category>().unwrap(),
+                                     detail: 1,
+                                 },
+                                 vec!["me".to_string(),
+                                      "8BITMIME".to_string(),
+                                      "SIZE 42".to_string()])
+                       .severity(),
+                   Severity::PermanentNegativeCompletion);
     }
 
     #[test]
     fn test_response_category() {
-        assert_eq!(Response::new(
-            Code {
-                severity: "2".parse::<Severity>().unwrap(),
-                category: "4".parse::<Category>().unwrap(),
-                detail:1,
-            },
-            vec!["me".to_string(), "8BITMIME".to_string(), "SIZE 42".to_string()]
-        ).category(), Category::Unspecified4);
+        assert_eq!(Response::new(Code {
+                                     severity: "2".parse::<Severity>().unwrap(),
+                                     category: "4".parse::<Category>().unwrap(),
+                                     detail: 1,
+                                 },
+                                 vec!["me".to_string(),
+                                      "8BITMIME".to_string(),
+                                      "SIZE 42".to_string()])
+                       .category(),
+                   Category::Unspecified4);
     }
 
     #[test]
     fn test_response_detail() {
-        assert_eq!(Response::new(
-            Code {
-                severity: "2".parse::<Severity>().unwrap(),
-                category: "4".parse::<Category>().unwrap(),
-                detail:1,
-            },
-            vec!["me".to_string(), "8BITMIME".to_string(), "SIZE 42".to_string()]
-        ).detail(), 1);
+        assert_eq!(Response::new(Code {
+                                     severity: "2".parse::<Severity>().unwrap(),
+                                     category: "4".parse::<Category>().unwrap(),
+                                     detail: 1,
+                                 },
+                                 vec!["me".to_string(),
+                                      "8BITMIME".to_string(),
+                                      "SIZE 42".to_string()])
+                       .detail(),
+                   1);
     }
 
     #[test]
     fn test_response_code() {
-        assert_eq!(Response::new(
-            Code {
-                severity: "2".parse::<Severity>().unwrap(),
-                category: "4".parse::<Category>().unwrap(),
-                detail:1,
-            },
-            vec!["me".to_string(), "8BITMIME".to_string(), "SIZE 42".to_string()]
-        ).code(), "241");
+        assert_eq!(Response::new(Code {
+                                     severity: "2".parse::<Severity>().unwrap(),
+                                     category: "4".parse::<Category>().unwrap(),
+                                     detail: 1,
+                                 },
+                                 vec!["me".to_string(),
+                                      "8BITMIME".to_string(),
+                                      "SIZE 42".to_string()])
+                       .code(),
+                   "241");
     }
 
     #[test]
     fn test_response_has_code() {
-        assert!(Response::new(
-            Code {
-                severity: "2".parse::<Severity>().unwrap(),
-                category: "4".parse::<Category>().unwrap(),
-                detail:1,
-            },
-            vec!["me".to_string(), "8BITMIME".to_string(), "SIZE 42".to_string()]
-        ).has_code(241));
-        assert!(! Response::new(
-            Code {
-                severity: "2".parse::<Severity>().unwrap(),
-                category: "4".parse::<Category>().unwrap(),
-                detail:1,
-            },
-            vec!["me".to_string(), "8BITMIME".to_string(), "SIZE 42".to_string()]
-        ).has_code(251));
+        assert!(Response::new(Code {
+                                  severity: "2".parse::<Severity>().unwrap(),
+                                  category: "4".parse::<Category>().unwrap(),
+                                  detail: 1,
+                              },
+                              vec!["me".to_string(),
+                                   "8BITMIME".to_string(),
+                                   "SIZE 42".to_string()])
+                    .has_code(241));
+        assert!(!Response::new(Code {
+                                   severity: "2".parse::<Severity>().unwrap(),
+                                   category: "4".parse::<Category>().unwrap(),
+                                   detail: 1,
+                               },
+                               vec!["me".to_string(),
+                                    "8BITMIME".to_string(),
+                                    "SIZE 42".to_string()])
+                     .has_code(251));
     }
 
     #[test]
     fn test_response_first_word() {
-        assert_eq!(Response::new(
-            Code {
-                severity: "2".parse::<Severity>().unwrap(),
-                category: "4".parse::<Category>().unwrap(),
-                detail:1,
-            },
-            vec!["me".to_string(), "8BITMIME".to_string(), "SIZE 42".to_string()]
-        ).first_word(), Some("me".to_string()));
-        assert_eq!(Response::new(
-            Code {
-                severity: "2".parse::<Severity>().unwrap(),
-                category: "4".parse::<Category>().unwrap(),
-                detail:1,
-            },
-            vec!["me mo".to_string(), "8BITMIME".to_string(), "SIZE 42".to_string()]
-        ).first_word(), Some("me".to_string()));
-        assert_eq!(Response::new(
-            Code {
-                severity: "2".parse::<Severity>().unwrap(),
-                category: "4".parse::<Category>().unwrap(),
-                detail:1,
-            },
-            vec![]
-        ).first_word(), None);
-        assert_eq!(Response::new(
-            Code {
-                severity: "2".parse::<Severity>().unwrap(),
-                category: "4".parse::<Category>().unwrap(),
-                detail:1,
-            },
-            vec![" ".to_string()]
-        ).first_word(), None);
-        assert_eq!(Response::new(
-            Code {
-                severity: "2".parse::<Severity>().unwrap(),
-                category: "4".parse::<Category>().unwrap(),
-                detail:1,
-            },
-            vec!["  ".to_string()]
-        ).first_word(), None);
-        assert_eq!(Response::new(
-            Code {
-                severity: "2".parse::<Severity>().unwrap(),
-                category: "4".parse::<Category>().unwrap(),
-                detail:1,
-            },
-            vec!["".to_string()]
-        ).first_word(), None);
+        assert_eq!(Response::new(Code {
+                                     severity: "2".parse::<Severity>().unwrap(),
+                                     category: "4".parse::<Category>().unwrap(),
+                                     detail: 1,
+                                 },
+                                 vec!["me".to_string(),
+                                      "8BITMIME".to_string(),
+                                      "SIZE 42".to_string()])
+                       .first_word(),
+                   Some("me".to_string()));
+        assert_eq!(Response::new(Code {
+                                     severity: "2".parse::<Severity>().unwrap(),
+                                     category: "4".parse::<Category>().unwrap(),
+                                     detail: 1,
+                                 },
+                                 vec!["me mo".to_string(),
+                                      "8BITMIME".to_string(),
+                                      "SIZE 42".to_string()])
+                       .first_word(),
+                   Some("me".to_string()));
+        assert_eq!(Response::new(Code {
+                                     severity: "2".parse::<Severity>().unwrap(),
+                                     category: "4".parse::<Category>().unwrap(),
+                                     detail: 1,
+                                 },
+                                 vec![])
+                       .first_word(),
+                   None);
+        assert_eq!(Response::new(Code {
+                                     severity: "2".parse::<Severity>().unwrap(),
+                                     category: "4".parse::<Category>().unwrap(),
+                                     detail: 1,
+                                 },
+                                 vec![" ".to_string()])
+                       .first_word(),
+                   None);
+        assert_eq!(Response::new(Code {
+                                     severity: "2".parse::<Severity>().unwrap(),
+                                     category: "4".parse::<Category>().unwrap(),
+                                     detail: 1,
+                                 },
+                                 vec!["  ".to_string()])
+                       .first_word(),
+                   None);
+        assert_eq!(Response::new(Code {
+                                     severity: "2".parse::<Severity>().unwrap(),
+                                     category: "4".parse::<Category>().unwrap(),
+                                     detail: 1,
+                                 },
+                                 vec!["".to_string()])
+                       .first_word(),
+                   None);
     }
 }

src/sender.rs

@@ -3,12 +3,13 @@
 use std::string::String;
 use std::net::{SocketAddr, ToSocketAddrs};
 
+use openssl::ssl::{SslMethod, SslContext};
+
 use SMTP_PORT;
 use extension::{Extension, ServerInfo};
 use error::{SmtpResult, Error};
 use email::SendableEmail;
 use client::Client;
-use client::net::SmtpStream;
 use authentication::Mecanism;
 
 /// Contains client configuration
@@ -25,25 +26,30 @@ pub struct SenderBuilder {
     credentials: Option<(String, String)>,
     /// Socket we are connecting to
     server_addr: SocketAddr,
+    /// SSL contexyt to use
+    ssl_context: Option<SslContext>,
+    /// List of authentication mecanism, sorted by priority
+    authentication_mecanisms: Vec<Mecanism>,
 }
 
 /// Builder for the SMTP Sender
 impl SenderBuilder {
     /// Creates a new local SMTP client
     pub fn new<A: ToSocketAddrs>(addr: A) -> Result<SenderBuilder, Error> {
-    	let mut addresses = try!(addr.to_socket_addrs());
-    	
-    	
-    	match addresses.next() {
-    		Some(addr) => Ok(SenderBuilder {
-	            server_addr: addr,
-	            credentials: None,
-	            connection_reuse_count_limit: 100,
-	            enable_connection_reuse: false,
-	            hello_name: "localhost".to_string(),
-        	}),
-    		None => Err(From::from("Could nor resolve hostname")),
-    	}        
+        let mut addresses = try!(addr.to_socket_addrs());
+
+        match addresses.next() {
+            Some(addr) => Ok(SenderBuilder {
+                server_addr: addr,
+                ssl_context: None,
+                credentials: None,
+                connection_reuse_count_limit: 100,
+                enable_connection_reuse: false,
+                hello_name: "localhost".to_string(),
+                authentication_mecanisms: vec![Mecanism::CramMd5, Mecanism::Plain],
+            }),
+            None => Err(From::from("Could nor resolve hostname")),
+        }
     }
 
     /// Creates a new local SMTP client to port 25
@@ -51,6 +57,17 @@ impl SenderBuilder {
         SenderBuilder::new(("localhost", SMTP_PORT))
     }
 
+    /// Use STARTTLS with a specific context
+    pub fn ssl_context(mut self, ssl_context: SslContext) -> SenderBuilder {
+        self.ssl_context = Some(ssl_context);
+        self
+    }
+
+    /// Require SSL/TLS using STARTTLS
+    pub fn starttls(self) -> SenderBuilder {
+        self.ssl_context(SslContext::new(SslMethod::Tlsv1).unwrap())
+    }
+
     /// Set the name used during HELO or EHLO
     pub fn hello_name(mut self, name: &str) -> SenderBuilder {
         self.hello_name = name.to_string();
@@ -75,6 +92,12 @@ impl SenderBuilder {
         self
     }
 
+    /// Set the authentication mecanisms
+    pub fn authentication_mecanisms(mut self, mecanisms: Vec<Mecanism>) -> SenderBuilder {
+        self.authentication_mecanisms = mecanisms;
+        self
+    }
+
     /// Build the SMTP client
     ///
     /// It does not connects to the server, but only creates the `Sender`
@@ -102,7 +125,7 @@ pub struct Sender {
     /// Information about the client
     client_info: SenderBuilder,
     /// Low level client
-    client: Client<SmtpStream>,
+    client: Client,
 }
 
 macro_rules! try_smtp (
@@ -125,8 +148,10 @@ impl Sender {
     ///
     /// It does not connects to the server, but only creates the `Sender`
     pub fn new(builder: SenderBuilder) -> Sender {
-        let client: Client<SmtpStream> = Client::new(builder.server_addr).unwrap();
-        Sender{
+
+        let client = Client::new();
+
+        Sender {
             client: client,
             server_info: None,
             client_info: builder,
@@ -153,6 +178,19 @@ impl Sender {
         self.client.close();
     }
 
+    /// Gets the EHLO response and updates server information
+    pub fn get_ehlo(&mut self) -> SmtpResult {
+        // Extended Hello
+        let ehlo_response = try_smtp!(self.client.ehlo(&self.client_info.hello_name), self);
+
+        self.server_info = Some(try_smtp!(ServerInfo::from_response(&ehlo_response), self));
+
+        // Print server information
+        debug!("server {}", self.server_info.as_ref().unwrap());
+
+        Ok(ehlo_response)
+    }
+
     /// Sends an email
     pub fn send<T: SendableEmail>(&mut self, email: T) -> SmtpResult {
         // Check if the connection is still available
@@ -164,56 +202,51 @@ impl Sender {
 
         // If there is a usable connection, test if the server answers and hello has been sent
         if self.state.connection_reuse_count == 0 {
-            try!(self.client.connect());
+            try!(self.client.connect(&self.client_info.server_addr));
 
             // Log the connection
             info!("connection established to {}", self.client_info.server_addr);
 
-            // Extended Hello or Hello if needed
-            let hello_response = match self.client.ehlo(&self.client_info.hello_name) {
-                Ok(response) => response,
-                Err(error) => match error {
-                    Error::PermanentError(ref response) if response.has_code(550) => {
-                        match self.client.helo(&self.client_info.hello_name) {
-                            Ok(response) => response,
-                            Err(error) => try_smtp!(Err(error), self)
-                        }
-                    },
-                    _ => {
-                        try_smtp!(Err(error), self)
-                    },
-                },
-            };
+            try!(self.get_ehlo());
 
-            self.server_info = Some(try_smtp!(ServerInfo::from_response(&hello_response), self));
+            if self.client_info.ssl_context.is_some() {
+                try_smtp!(self.client.starttls(), self);
 
-            // Print server information
-            debug!("server {}", self.server_info.as_ref().unwrap());
-        }
+                try!(self.client
+                         .upgrade_tls_stream(self.client_info.ssl_context.as_ref().unwrap()));
 
-        // TODO: Use PLAIN AUTH in encrypted connections, CRAM-MD5 otherwise
-        if self.client_info.credentials.is_some() && self.state.connection_reuse_count == 0 {
+                try!(self.get_ehlo());
+            }
 
-            let (username, password) = self.client_info.credentials.clone().unwrap();
+            if self.client_info.credentials.is_some() && self.state.connection_reuse_count == 0 {
+                let (username, password) = self.client_info.credentials.clone().unwrap();
 
-            if self.server_info.as_ref().unwrap().supports_auth_mecanism(Mecanism::CramMd5) {
-                let result = self.client.auth(Mecanism::CramMd5, &username, &password);
-                try_smtp!(result, self);
-            } else if self.server_info.as_ref().unwrap().supports_auth_mecanism(Mecanism::Plain) {
-                let result = self.client.auth(Mecanism::Plain, &username, &password);
-                try_smtp!(result, self);
-            } else {
-                debug!("No supported authentication mecanisms available");
+                let mut found = false;
+
+                for mecanism in self.client_info.authentication_mecanisms.clone() {
+                    if self.server_info.as_ref().unwrap().supports_auth_mecanism(mecanism) {
+                        found = true;
+                        let result = self.client.auth(mecanism, &username, &password);
+                        try_smtp!(result, self);
+                    }
+                }
+
+                if !found {
+                    debug!("No supported authentication mecanisms available");
+                }
             }
         }
 
         let current_message = try!(email.message_id().ok_or("Missing Message-ID"));
-        let from_address = try!(email.from_address().ok_or("Missing Message-ID"));
-        let to_addresses = try!(email.to_addresses().ok_or("Missing Message-ID"));
-        let message = try!(email.message().ok_or("Missing Message-ID"));
+        let from_address = try!(email.from_address().ok_or("Missing From address"));
+        let to_addresses = try!(email.to_addresses().ok_or("Missing To address"));
+        let message = try!(email.message().ok_or("Missing message"));
 
         // Mail
-        let mail_options = match self.server_info.as_ref().unwrap().supports_feature(&Extension::EightBitMime) {
+        let mail_options = match self.server_info
+                                     .as_ref()
+                                     .unwrap()
+                                     .supports_feature(&Extension::EightBitMime) {
             true => Some("BODY=8BITMIME"),
             false => None,
         };
@@ -241,15 +274,22 @@ impl Sender {
             self.state.connection_reuse_count = self.state.connection_reuse_count + 1;
 
             // Log the message
-            info!("{}: conn_use={}, size={}, status=sent ({})", current_message,
-                self.state.connection_reuse_count, message.len(),
-                result.as_ref().ok().unwrap().message().iter().next().unwrap_or(&"no response".to_string())
-            );
+            info!("{}: conn_use={}, size={}, status=sent ({})",
+                  current_message,
+                  self.state.connection_reuse_count,
+                  message.len(),
+                  result.as_ref()
+                        .ok()
+                        .unwrap()
+                        .message()
+                        .iter()
+                        .next()
+                        .unwrap_or(&"no response".to_string()));
         }
 
         // Test if we can reuse the existing connection
         if (!self.client_info.enable_connection_reuse) ||
-            (self.state.connection_reuse_count >= self.client_info.connection_reuse_count_limit) {
+           (self.state.connection_reuse_count >= self.client_info.connection_reuse_count_limit) {
             self.reset();
         }