rust/neon
1
0
Fork 0
mirror of https://github.com/neondatabase/neon.git synced 2026-01-06 21:12:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

Don't rerun failed tests in 'Build and Test with Sanitizers' workflow (#12259)

Browse Source 
## Problem

We could easily miss a sanitizer-detected defect, if it occurred due to
some race condition, as we just rerun the test and if it succeeds, the
overall test run is considered successful. It was more reasonable
before, when we had much more unstable tests in main, but now we can
track all test failures.

## Summary of changes
Don't rerun failed tests.
This commit is contained in:
Alexander Lakhin
2025-06-17 11:08:43 +03:00
committed by GitHub
parent f669e18477
commit 01ccb34118
4 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
.github/workflows/_build-and-test-locally.yml vendored
View File

@@ -38,7 +38,7 @@ on:
required: false required: false
default: 1 default: 1
type: number type: number
rerun_failed: rerun-failed:
description: 'rerun failed tests to ignore flaky tests' description: 'rerun failed tests to ignore flaky tests'
required: false required: false
default: true default: true
@@ -392,7 +392,7 @@ jobs:
run_with_real_s3: true run_with_real_s3: true
real_s3_bucket: neon-github-ci-tests real_s3_bucket: neon-github-ci-tests
real_s3_region: eu-central-1 real_s3_region: eu-central-1
rerun_failed: ${{ inputs.rerun_failed }} rerun_failed: ${{ inputs.rerun-failed }}
pg_version: ${{ matrix.pg_version }} pg_version: ${{ matrix.pg_version }}
sanitizers: ${{ inputs.sanitizers }} sanitizers: ${{ inputs.sanitizers }}
aws-oidc-role-arn: ${{ vars.DEV_AWS_OIDC_ROLE_ARN }} aws-oidc-role-arn: ${{ vars.DEV_AWS_OIDC_ROLE_ARN }}

2
.github/workflows/build_and_run_selected_test.yml vendored
View File

@@ -58,7 +58,7 @@ jobs:
test-cfg: ${{ inputs.pg-versions }} test-cfg: ${{ inputs.pg-versions }}
test-selection: ${{ inputs.test-selection }} test-selection: ${{ inputs.test-selection }}
test-run-count: ${{ fromJson(inputs.run-count) }} test-run-count: ${{ fromJson(inputs.run-count) }}
rerun_failed: false rerun-failed: false
secrets: inherit secrets: inherit
create-test-report: create-test-report:

2
.github/workflows/build_and_test_fully.yml vendored
View File

@@ -79,7 +79,7 @@ jobs:
build-tools-image: ${{ needs.build-build-tools-image.outputs.image }}-bookworm build-tools-image: ${{ needs.build-build-tools-image.outputs.image }}-bookworm
build-tag: ${{ needs.tag.outputs.build-tag }} build-tag: ${{ needs.tag.outputs.build-tag }}
build-type: ${{ matrix.build-type }} build-type: ${{ matrix.build-type }}
rerun_failed: false rerun-failed: false
test-cfg: '[{"pg_version":"v14", "lfc_state": "with-lfc"}, test-cfg: '[{"pg_version":"v14", "lfc_state": "with-lfc"},
{"pg_version":"v15", "lfc_state": "with-lfc"}, {"pg_version":"v15", "lfc_state": "with-lfc"},
{"pg_version":"v16", "lfc_state": "with-lfc"}, {"pg_version":"v16", "lfc_state": "with-lfc"},

1
.github/workflows/build_and_test_with_sanitizers.yml vendored
View File

@@ -79,6 +79,7 @@ jobs:
build-tools-image: ${{ needs.build-build-tools-image.outputs.image }}-bookworm build-tools-image: ${{ needs.build-build-tools-image.outputs.image }}-bookworm
build-tag: ${{ needs.tag.outputs.build-tag }} build-tag: ${{ needs.tag.outputs.build-tag }}
build-type: ${{ matrix.build-type }} build-type: ${{ matrix.build-type }}
rerun-failed: false
test-cfg: '[{"pg_version":"v17"}]' test-cfg: '[{"pg_version":"v17"}]'
sanitizers: enabled sanitizers: enabled
secrets: inherit secrets: inherit