rust/neon
1
0
Fork 0
mirror of https://github.com/neondatabase/neon.git synced 2026-05-19 06:00:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

improve XXX above remove_dir_all regarding atomicity

Browse Source 
With this PR, we're now atomic, if remote storage is configured.
This commit is contained in:
Christian Schwarz
2023-05-03 19:38:05 +02:00
parent 30ea7b141b
commit 08558b83ed
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
pageserver/src/tenant.rs
View File

@@ -1446,8 +1446,12 @@ impl Tenant {
Err(anyhow::anyhow!("failpoint: timeline-delete-before-rm"))?
});
// XXX make this atomic so that, if we crash-mid-way, the timeline won't be picked up
// with some layers missing.
// NB: This need not be atomic because the deleted flag in the IndexPart
// will be observed during tenant/timeline load. The deletion will be resumed there.
//
// For configurations without remote storage, we tolerate that we're not crash-safe here.
// The timeline may come up Active but with missing layer files, in such setups.
// See https://github.com/neondatabase/neon/pull/3919#issuecomment-1531726720
std::fs::remove_dir_all(&local_timeline_directory).with_context(|| {
format!(
"Failed to remove local timeline directory '{}'",