rust/neon
1
0
Fork 0
mirror of https://github.com/neondatabase/neon.git synced 2026-01-07 13:32:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

pageserver: always upload tenant manifest

Browse Source
This commit is contained in:
Erik Grinaker
2025-07-17 13:44:32 +02:00
parent 5dd24c7ad8
commit 0e295391d9
1 changed files with 11 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
pageserver/src/tenant.rs
View File

@@ -1908,16 +1908,20 @@ impl TenantShard {
.map_err(LoadLocalTimelineError::ResumeDeletion)?;
}
// Stash the preloaded tenant manifest, and upload a new manifest if changed.
// Upload the tenant manifest.
//
// This is uploaded unconditionally on every attach. This prevents races where a stale,
// still-alive tenant may modify a past manifest, and a future tenant loads it after this
// tenant has acted on it. Uploading a new manifest effectively hands over ownership of the
// manifest state. See: <https://databricks.atlassian.net/browse/LKB-165>.
//
// NB: this must happen after the tenant is fully populated above. In particular the
// offloaded timelines, which are included in the manifest.
{
let mut guard = self.remote_tenant_manifest.lock().await;
assert!(guard.is_none(), "tenant manifest set before preload"); // first populated here
*guard = preload.tenant_manifest;
}
self.maybe_upload_tenant_manifest().await?;
assert!(
self.remote_tenant_manifest.lock().await.is_none(),
"tenant manifest set before attach"
);
self.maybe_upload_tenant_manifest().await?; // always uploads, remote_tenant_manifest is None
// The local filesystem contents are a cache of what's in the remote IndexPart;
// IndexPart is the source of truth.