rust/neon
1
0
Fork 0
mirror of https://github.com/neondatabase/neon.git synced 2026-01-15 17:32:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

doc: comment cleanup

Browse Source
This commit is contained in:
Joonas Koivunen
2024-07-19 14:51:54 +00:00
parent a179283f86
commit 1348dbf0f1
1 changed files with 3 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
pageserver/src/tenant/timeline/detach_ancestor.rs
View File

@@ -202,28 +202,23 @@ impl SharedState {
let completion = {
let mut guard = self.inner.lock().unwrap();
let completion = guard.start_new(&detached.timeline_id)?;
// now that we changed the contents, notify any long-sleeping gc
self.gc_waiting.notify_one();
completion
};
let started_at = std::time::Instant::now();
let mut cancelled = std::pin::pin!(detached.cancel.cancelled());
loop {
tokio::select! {
_ = &mut cancelled => { return Err(Error::ShuttingDown); },
_ = self.attempt_waiting.notified() => {
// reading a notification which was not intended for us is not a problem,
// because we check if *our* progress has been witnessed by gc.
},
_ = self.attempt_waiting.notified() => {},
};
// reading a notification which was not intended for us is not a problem,
// because we check if *our* progress has been witnessed by gc.
let g = self.inner.lock().unwrap();
if g.is_gc_paused(&detached.timeline_id) {
break;
@@ -232,7 +227,6 @@ impl SharedState {
// finally
let gate_entered = detached.gate.enter().map_err(|_| Error::ShuttingDown)?;
let synced_in = started_at.elapsed();
detached