initial set of fixups

libs/neon_failpoint/src/macros.rs

@@ -303,6 +303,7 @@ macro_rules! pausable_failpoint {
     }};
     ($name:literal, $cancel:expr) => {{
         if cfg!(feature = "testing") {
+            ::tracing::info!("at failpoint {}", $name); // tests rely on this
             match $crate::failpoint_with_cancellation($name, None, $cancel) {
                 $crate::either::Either::Left(result) => match result {
                     $crate::FailpointResult::Continue => Ok(()),

pageserver/src/http/routes.rs

@@ -3976,7 +3976,7 @@ pub fn make_router(
         .get("/profile/cpu", |r| request_span(r, profile_cpu_handler))
         .get("/profile/heap", |r| request_span(r, profile_heap_handler))
         .get("/v1/status", |r| api_handler(r, status_handler))
-        .put("/v1/failpoints", |r| {
+        .post("/v1/failpoints", |r| {
             testing_api_handler("manage failpoints", r, failpoints_handler)
         })
         .post("/v1/reload_auth_validation_keys", |r| {

safekeeper/src/http/routes.rs

@@ -717,7 +717,7 @@ pub fn make_router(
         .get("/profile/cpu", |r| request_span(r, profile_cpu_handler))
         .get("/profile/heap", |r| request_span(r, profile_heap_handler))
         .get("/v1/status", |r| request_span(r, status_handler))
-        .put("/v1/failpoints", |r| {
+        .post("/v1/failpoints", |r| {
             request_span(r, move |r| async {
                 check_permission(&r, None)?;
                 let cancel = CancellationToken::new();

test_runner/fixtures/pageserver/http.py

@@ -362,7 +362,7 @@ class PageserverHttpClient(requests.Session, MetricsGetter):
             else:
                 raise ValueError(f"Invalid config format: {config}")
 
-        res = self.post(f"{self.base_url}/failpoints", json=body)
+        res = self.post(f"{self.base_url}/v1/failpoints", json=body)
         if res.status_code != 200:
             raise PageserverApiException(
                 f"Failed to configure failpoints: {res.text}", res.status_code