rust/neon
1
0
Fork 0
mirror of https://github.com/neondatabase/neon.git synced 2026-01-16 18:02:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

delta_layer: remove ignore_key_with_err optimization; https://github.com/neondatabase/neon/pull/9353#discussion_r1920573294

Browse Source 
it would cause an assertion failure because we wouldn't be consuming all IOs
This commit is contained in:
Christian Schwarz
2025-01-21 19:11:25 +01:00
parent 1862fdf9e2
commit 14e4fcdb2a
1 changed files with 0 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
pageserver/src/tenant/storage_layer/delta_layer.rs
View File

@@ -1004,8 +1004,6 @@ impl DeltaLayerInner {
.into();
let buf_size = Self::get_min_read_buffer_size(&reads, max_vectored_read_bytes);
let mut ignore_key_with_err = None;
// Note that reads are processed in reverse order (from highest key+lsn).
// This is the order that `ReconstructState` requires such that it can
// track when a key is done.
@@ -1035,16 +1033,10 @@ impl DeltaLayerInner {
for meta in blobs_buf.blobs.iter().rev() {
let io = ios.remove(&(meta.meta.key, meta.meta.lsn)).unwrap();
if Some(meta.meta.key) == ignore_key_with_err {
continue;
}
let blob_read = meta.read(&view).await;
let blob_read = match blob_read {
Ok(buf) => buf,
Err(e) => {
ignore_key_with_err = Some(meta.meta.key);
io.complete(Err(e));
continue;
}