rust/neon
1
0
Fork 0
mirror of https://github.com/neondatabase/neon.git synced 2026-05-18 21:50:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

clarify / improve comments in Tenant::delete_timeline

Browse Source
This commit is contained in:
Christian Schwarz
2023-05-03 17:33:53 +02:00
parent db9d78151a
commit 16486edd8e
1 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
pageserver/src/tenant.rs
View File

@@ -1400,18 +1400,17 @@ impl Tenant {
timeline.walreceiver.stop().await;
debug!("wal receiver shutdown confirmed");
// Prevent new uploads from starting.
if let Some(remote_client) = timeline.remote_client.as_ref() {
remote_client.stop()?;
}
// NOTE: there is no guarantee that after this point no tasks related to a timeline are running.
// Tasks can spawn new tasks before they see the cancellation request.
// There is nothing preventing spawning new tasks after shutdown is requested for particular timeline or tenant.
// Stop & wait for the remaining timeline tasks, including upload tasks.
info!("waiting for timeline tasks to shutdown");
task_mgr::shutdown_tasks(None, Some(self.tenant_id), Some(timeline_id)).await;
// Make sure we marked timeline as deleted on the remote
// so we wont pick it up next time during attach or pageserver restart
// Mark timeline as deleted in S3 so we wont pick it up next time
// during attach or pageserver restart.
// See comment in persist_index_part_with_deleted_flag.
if let Some(remote_client) = timeline.remote_client.as_ref() {
remote_client.persist_index_part_with_deleted_flag().await?;