Add checksum todos

pageserver/src/basebackup.rs

@@ -112,6 +112,8 @@ where
     }
 
     pub fn send_tarball(mut self) -> anyhow::Result<()> {
+        // TODO include checksum
+
         // Create pgdata subdirs structure
         for dir in pg_constants::PGDATA_SUBDIRS.iter() {
             let header = new_tar_header_dir(*dir)?;

pageserver/src/page_service.rs

@@ -570,6 +570,12 @@ impl PageServerHandler {
         let reader = CopyInReader::new(pgb);
         import_basebackup_from_tar(&mut datadir_timeline, reader, base_lsn)?;
 
+        // TODO check checksum
+        // Meanwhile you can verify client-side by taking fullbackup
+        // and checking that it matches in size with what was imported.
+        // It wouldn't work if base came from vanilla postgres though,
+        // since we discard some log files.
+
         // Flush data to disk, then upload to s3
         info!("flushing layers");
         datadir_timeline.tline.checkpoint(CheckpointConfig::Flush)?;

test_runner/batch_others/test_import.py

@@ -179,4 +179,5 @@ def test_import_from_pageserver(test_output_dir, pg_bin, vanilla_pg, neon_env_bu
     new_tar_output_file = result_basepath + ".stdout"
 
     # Check it's the same as the first fullbackup
+    # TODO pageserver should be checking checksum
     assert os.path.getsize(tar_output_file) == os.path.getsize(new_tar_output_file)