rust/neon
1
0
Fork 0
mirror of https://github.com/neondatabase/neon.git synced 2026-07-04 04:30:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

experiment: demonstrate that std-fs performs better because it hits the page cache

Browse Source 
... by forcing each write system call to go to disk

test_bulk_insert[neon-release-pg14-tokio-epoll-uring].wal_written: 346 MB
test_bulk_insert[neon-release-pg14-tokio-epoll-uring].wal_recovery: 92.559 s

test_bulk_insert[neon-release-pg14-std-fs].wal_written: 346 MB
test_bulk_insert[neon-release-pg14-std-fs].wal_recovery: 81.998 s

=> 10%ish worse instead of 2x
This commit is contained in:
Christian Schwarz
2024-03-13 15:03:24 +00:00
parent c8c04c0db8
commit 2edbc07733
1 changed files with 10 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
pageserver/src/virtual_file/open_options.rs
View File

@@ -1,7 +1,12 @@
//! Enum-dispatch to the `OpenOptions` type of the respective [`super::IoEngineKind`];
use nix::libc::O_DSYNC;
use super::io_engine::IoEngine;
use std::{os::fd::OwnedFd, path::Path};
use std::{
os::{fd::OwnedFd, unix::fs::OpenOptionsExt},
path::Path,
};
#[derive(Debug, Clone)]
pub enum OpenOptions {
@@ -94,12 +99,14 @@ impl OpenOptions {
}
pub(in crate::virtual_file) async fn open(&self, path: &Path) -> std::io::Result<OwnedFd> {
match self {
let mut options = self.clone();
options.custom_flags(O_DSYNC); // disk latency
match options {
OpenOptions::StdFs(x) => x.open(path).map(|file| file.into()),
#[cfg(target_os = "linux")]
OpenOptions::TokioEpollUring(x) => {
let system = tokio_epoll_uring::thread_local_system().await;
system.open(path, x).await.map_err(|e| match e {
system.open(path, &x).await.map_err(|e| match e {
tokio_epoll_uring::Error::Op(e) => e,
tokio_epoll_uring::Error::System(system) => {
std::io::Error::new(std::io::ErrorKind::Other, system)