rust/neon
1
0
Fork 0
mirror of https://github.com/neondatabase/neon.git synced 2026-05-26 17:40:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fsync layer files before rename

Browse Source
This commit is contained in:
Anastasia Lubennikova
2022-05-18 18:06:33 +03:00
parent c1b365fdf7
commit 3da4b3165e
2 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
pageserver/src/layered_repository/delta_layer.rs
View File

@@ -425,7 +425,7 @@ impl DeltaLayer {
timelineid: ZTimelineId,
tenantid: ZTenantId,
key_start: Key,
lsn_range: Range<Lsn>,
lsn_range: &Range<Lsn>,
) -> PathBuf {
conf.timeline_path(&timelineid, &tenantid).join(format!(
"{}-XXX__{:016X}-{:016X}.temp",
@@ -622,8 +622,7 @@ impl DeltaLayerWriter {
//
// Note: This overwrites any existing file. There shouldn't be any.
// FIXME: throw an error instead?
let path =
DeltaLayer::temp_path_for(conf, timelineid, tenantid, key_start, lsn_range.clone());
let path = DeltaLayer::temp_path_for(conf, timelineid, tenantid, key_start, &lsn_range);
let mut file = VirtualFile::create(&path)?;
// make room for the header block
@@ -717,6 +716,8 @@ impl DeltaLayerWriter {
}),
};
// fsync the file
file.sync_all()?;
// Rename the file to its final name
//
// Note: This overwrites any existing file. There shouldn't be any.

3
pageserver/src/layered_repository/image_layer.rs
View File

@@ -525,6 +525,9 @@ impl ImageLayerWriter {
}),
};
// fsync the file
file.sync_all()?;
// Rename the file to its final name
//
// Note: This overwrites any existing file. There shouldn't be any.