rust/neon
1
0
Fork 0
mirror of https://github.com/neondatabase/neon.git synced 2026-05-28 18:40:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix updating relsize cache during WAL replay

Browse Source 
This makes some of the test_runner/regress/test_hot_standby.py tests
pass, (Others are still failing..)
This commit is contained in:
Heikki Linnakangas
2025-07-01 21:17:01 +03:00
parent f6761760a2
commit 471191e64e
2 changed files with 17 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
pgxn/neon/communicator_new.c
View File

@@ -1003,7 +1003,7 @@ communicator_new_rel_unlink(NRelFileInfo rinfo, ForkNumber forkNum)
/*
* The worker process can read / write shared buffers directly. But if smgrread() or
* smgrwrite() is called with a private temporary buffer, we need to copy it to the
* "bounce buffer", to make it available fro the worker process.
* "bounce buffer", to make it available for the worker process.
*/
static bool
bounce_needed(void *buffer)

20
pgxn/neon/pagestore_smgr.c
View File

@@ -824,7 +824,11 @@ neon_create(SMgrRelation reln, ForkNumber forkNum, bool isRedo)
if (neon_enable_new_communicator)
{
communicator_new_rel_create(InfoFromSMgrRel(reln), forkNum);
if (isRedo)
{
if (!communicator_new_rel_exists(InfoFromSMgrRel(reln), forkNum))
communicator_new_rel_create(InfoFromSMgrRel(reln), forkNum);
}
}
else
{
@@ -978,7 +982,6 @@ neon_extend(SMgrRelation reln, ForkNumber forkNum, BlockNumber blkno,
neon_wallog_page(reln, forkNum, n_blocks++, buffer, true);
neon_wallog_page(reln, forkNum, blkno, buffer, false);
set_cached_relsize(InfoFromSMgrRel(reln), forkNum, blkno + 1);
lsn = PageGetLSN((Page) buffer);
neon_log(SmgrTrace, "smgrextend called for %u/%u/%u.%u blk %u, page LSN: %X/%08X",
@@ -993,6 +996,7 @@ neon_extend(SMgrRelation reln, ForkNumber forkNum, BlockNumber blkno,
}
else
{
set_cached_relsize(InfoFromSMgrRel(reln), forkNum, blkno + 1);
lfc_write(InfoFromSMgrRel(reln), forkNum, blkno, buffer);
#ifdef DEBUG_COMPARE_LOCAL
@@ -2405,8 +2409,16 @@ neon_extend_rel_size(NRelFileInfo rinfo, ForkNumber forknum, BlockNumber blkno,
if (neon_enable_new_communicator)
{
// FIXME: broken, but this is only used in replica
elog(ERROR, "not implemented yet");
relsize = communicator_new_rel_nblocks(rinfo, forknum);
if (blkno >= relsize)
communicator_new_rel_zeroextend(rinfo, forknum, relsize, (blkno - relsize) + 1, end_recptr);
/*
* FIXME: does this need to update the last-written LSN too, like the
* old implementation?
*/
return;
}
/* Extend the relation if we know its size */