rust/neon
1
0
Fork 0
mirror of https://github.com/neondatabase/neon.git synced 2026-01-05 20:42:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

Little cleanup on save_decoded_record function

Browse Source 
Pass DecodedWALRecord by reference, seems nicer, and probably marginally
faster.
This commit is contained in:
Heikki Linnakangas
2021-05-27 20:50:45 +03:00
parent 34f4207501
commit 4b6563a55d
2 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
pageserver/src/restore_local_repo.rs
View File

@@ -221,7 +221,7 @@ pub fn import_timeline_wal(walpath: &Path, timeline: &dyn Timeline, startpoint:
}
if let Some((lsn, recdata)) = rec.unwrap() {
let decoded = decode_wal_record(recdata.clone());
save_decoded_record(timeline, decoded, recdata, lsn)?;
save_decoded_record(timeline, &decoded, recdata, lsn)?;
last_lsn = lsn;
} else {
break;
@@ -249,12 +249,12 @@ pub fn import_timeline_wal(walpath: &Path, timeline: &dyn Timeline, startpoint:
///
pub fn save_decoded_record(
timeline: &dyn Timeline,
decoded: DecodedWALRecord,
decoded: &DecodedWALRecord,
recdata: Bytes,
lsn: Lsn,
) -> Result<()> {
// Figure out which blocks the record applies to, and "put" a separate copy
// of the record for each block.
// Iterate through all the blocks that the record modifies, and
// "put" a separate copy of the record for each block.
for blk in decoded.blocks.iter() {
let tag = BufferTag {
rel: RelTag {

2
pageserver/src/walreceiver.rs
View File

@@ -185,7 +185,7 @@ fn walreceiver_main(
while let Some((lsn, recdata)) = waldecoder.poll_decode()? {
let decoded = decode_wal_record(recdata.clone());
restore_local_repo::save_decoded_record(&*timeline, decoded, recdata, lsn)?;
restore_local_repo::save_decoded_record(&*timeline, &decoded, recdata, lsn)?;
last_rec_lsn = lsn;
}