rust/neon
1
0
Fork 0
mirror of https://github.com/neondatabase/neon.git synced 2026-05-19 22:20:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix specifying destination buffer capacity for image decompression

Browse Source
This commit is contained in:
Konstantin Knizhnik
2022-05-27 19:14:08 +03:00
parent 18272f53db
commit 5217058e8e
1 changed files with 14 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
pageserver/src/layered_repository/image_layer.rs
View File

@@ -221,7 +221,7 @@ impl Layer for ImageLayer {
})?;
let uncompressed_bytes = if blob_ref.compressed() {
decompressor.decompress(&blob_content, blob_content.len())?
decompressor.decompress(&blob_content, PAGE_SZ)?
} else {
blob_content
};
@@ -539,18 +539,20 @@ impl ImageLayerWriter {
// Try to compress the blob
let compressed_bytes;
if let Some(ref mut compressor) = self.compressor {
compressed_bytes = compressor.compress(blob_content)?;
if blob_content.len() <= PAGE_SZ {
if let Some(ref mut compressor) = self.compressor {
compressed_bytes = compressor.compress(blob_content)?;
// If compressed version is not any smaller than the original,
// store it uncompressed. This not just an optimization, the
// the decompression assumes that too. That simplifies the
// decompression, because you don't need to jump through any
// hoops to determine how large a buffer you need to hold the
// decompression result.
if compressed_bytes.len() < blob_content.len() {
blob_content = &compressed_bytes;
compressed = true;
// If compressed version is not any smaller than the original,
// store it uncompressed. This not just an optimization, the
// the decompression assumes that too. That simplifies the
// decompression, because you don't need to jump through any
// hoops to determine how large a buffer you need to hold the
// decompression result.
if compressed_bytes.len() < blob_content.len() {
blob_content = &compressed_bytes;
compressed = true;
}
}
}