rust/neon
1
0
Fork 0
mirror of https://github.com/neondatabase/neon.git synced 2026-01-15 09:22:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

clippy

Browse Source
This commit is contained in:
Bojan Serafimov
2023-05-25 08:38:05 -04:00
parent 281bd9a48d
commit 52e5bc7992
1 changed files with 3 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
pageserver/src/tenant/layer_map/layer_coverage.rs
View File

@@ -74,7 +74,7 @@ impl<Value: Clone> LayerCoverage<Value> {
let mut to_update = Vec::new();
let mut to_remove = Vec::new();
let mut prev_covered = false;
for (k, node) in self.nodes.range(key.clone()) {
for (k, node) in self.nodes.range(key) {
let needs_cover = match node {
None => true,
Some((h, _)) => h < &lsn.end,
@@ -87,14 +87,8 @@ impl<Value: Clone> LayerCoverage<Value> {
}
prev_covered = needs_cover;
}
if !prev_covered {
// TODO This line is commented because there's a bug. If uncommented, the
// pageserver_chaos test fails. I suspect it has to do with improper
// handling of key collisions. Will add more tests.
// to_remove.push(key.end);
// TODO check if key.start is redundant too
}
// TODO check if the nodes inserted at key.start and key.end are safe
// to remove. It's fine to keep them but they could be redundant.
for k in &to_update {
self.nodes.insert_mut(*k, Some((lsn.end, value.clone())));
}