rust/neon
1
0
Fork 0
mirror of https://github.com/neondatabase/neon.git synced 2026-05-31 20:10:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: require ResidentLayer to keep resident

Browse Source 
it only matters when calling this, it can get "evicted" after, even
though, it's file will probably not be readable.
This commit is contained in:
Joonas Koivunen
2023-08-30 10:18:30 +03:00
parent 1cbb7fccaa
commit 544136f13f
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
pageserver/src/tenant/storage_layer/layer.rs
View File

@@ -1173,10 +1173,10 @@ impl ResidentLayer {
/// Ensure that the old version of this layer is dropped before the newer version (self) can be
/// evicted.
pub(crate) fn keep_resident_while(&self, old: &Layer) {
pub(crate) fn keep_resident_while(&self, old: &ResidentLayer) {
assert_eq!(old.layer_desc(), self.layer_desc());
assert_ne!(old, &self.owner);
let mut g = old.0.keep_resident.lock().unwrap();
assert_ne!(&old.owner, &self.owner);
let mut g = old.owner.0.keep_resident.lock().unwrap();
assert!(
g.is_none(),
"cannot have multiple duplicates of the same layer"