rust/neon
1
0
Fork 0
mirror of https://github.com/neondatabase/neon.git synced 2026-05-31 12:00:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix setting failpoints in test_remote_storage_backup_and_restore

Browse Source 
The checkpoints in the test were numbered 1 and 2, but the code only
tried to set the failpoints for checkpoint 0. So they were never set.
This commit is contained in:
Heikki Linnakangas
2022-11-22 14:52:11 +02:00
parent 3c4680b718
commit 5c8387aff1
1 changed files with 10 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
test_runner/regress/test_remote_storage.py
View File

@@ -81,6 +81,16 @@ def test_remote_storage_backup_and_restore(
checkpoint_numbers = range(1, 3)
# On the first iteration, exercise retry code path by making the uploads
# fail for the first 3 times
action = "3*return->off"
pageserver_http.configure_failpoints(
[
("before-upload-layer", action),
("before-upload-index", action),
]
)
for checkpoint_number in checkpoint_numbers:
with pg.cursor() as cur:
cur.execute(
@@ -99,14 +109,6 @@ def test_remote_storage_backup_and_restore(
log.info(f"waiting for checkpoint {checkpoint_number} upload")
# insert upload failpoints to exercise retry code path
action = "3*return->off" if checkpoint_number == 0 else "off"
pageserver_http.configure_failpoints(
[
("before-upload-layer", action),
("before-upload-index", action),
]
)
# wait until pageserver successfully uploaded a checkpoint to remote storage
wait_for_upload(client, tenant_id, timeline_id, current_lsn)
log.info(f"upload of checkpoint {checkpoint_number} is done")