rust/neon
1
0
Fork 0
mirror of https://github.com/neondatabase/neon.git synced 2026-05-14 03:30:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

pageserver: fail vectored search on first missing key

Browse Source 
This will be the behaviour of the real vectored search, so the
sequential implementation is changed to ease testing.
This commit is contained in:
Vlad Lazar
2024-02-02 14:14:45 +00:00
committed by Vlad Lazar
parent ec6fb422bd
commit 5e411a0e98
1 changed files with 13 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
pageserver/src/tenant/timeline.rs
View File

@@ -726,15 +726,19 @@ impl Timeline {
let block = self.get(key, lsn, ctx).await;
if matches!(
block,
Err(PageReconstructError::Cancelled | PageReconstructError::AncestorStopping(_))
) {
return Err(GetVectoredError::Cancelled);
use PageReconstructError::*;
match block {
Err(Cancelled | AncestorStopping(_)) => {
return Err(GetVectoredError::Cancelled)
}
Err(Other(err)) if err.to_string().contains("could not find data for key") => {
return Err(GetVectoredError::MissingKey(key))
}
_ => {
values.insert(key, block);
key = key.next();
}
}
values.insert(key, block);
key = key.next();
}
}
@@ -3476,11 +3480,7 @@ impl Timeline {
|| key.next() == range.end
{
let results = self
.get_vectored(
key_request_accum.consume_keyspace(),
lsn,
ctx,
)
.get_vectored(key_request_accum.consume_keyspace(), lsn, ctx)
.await?;
for (img_key, img) in results {