rename SharedState::notify

to continue_existing_attempt

pageserver/src/tenant.rs

@@ -710,7 +710,9 @@ impl Tenant {
         ));
 
         if let Some(attempt) = existing_detach_attempt {
-            tenant.ongoing_timeline_detach.notify(attempt);
+            tenant
+                .ongoing_timeline_detach
+                .continue_existing_attempt(attempt);
         }
 
         // The attach task will carry a GateGuard, so that shutdown() reliably waits for it to drop out if

pageserver/src/tenant/timeline/detach_ancestor.rs

@@ -136,7 +136,7 @@ impl Default for SharedState {
 impl SharedState {
     /// Notify an uninitialized shared state that an attempt to detach timeline ancestor continues
     /// from previous instance.
-    pub(crate) fn notify(&self, _attempt: &Attempt) {}
+    pub(crate) fn continue_existing_attempt(&self, attempt: &Attempt) {}
 
     /// Only GC must be paused while a detach ancestor is ongoing. Compaction can happen, to aid
     /// with any ongoing ingestion. Compaction even after restart is ok because layers will not be