rust/neon
1
0
Fork 0
mirror of https://github.com/neondatabase/neon.git synced 2026-07-07 06:00:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

address comments

Browse Source 
Signed-off-by: Alex Chi Z <chi@neon.tech>
This commit is contained in:
Alex Chi Z
2023-07-21 16:12:03 -04:00
parent 1b78f7cb4f
commit 5f8bd41725
1 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
pageserver/src/tenant/mgr.rs
View File

@@ -368,9 +368,6 @@ pub async fn create_tenant(
ctx,
)?;
// TODO: tenant object & its background loops remain, untracked in tenant map, if we fail here.
// See https://github.com/neondatabase/neon/issues/4233
// Put all code that might error into the check function.
let check = || {
@@ -388,6 +385,8 @@ pub async fn create_tenant(
};
if let Err(e) = check() {
// schedule_local_tenant_processing eventually launches the tenant's background task
// We need to shut them down before bailing out.
created_tenant.set_broken("failed to create".into()).await;
return Err(e);
}
@@ -636,8 +635,6 @@ pub async fn attach_tenant(
None,
ctx,
)?;
// TODO: tenant object & its background loops remain, untracked in tenant map, if we fail here.
// See https://github.com/neondatabase/neon/issues/4233
// Put all code that might error in the check function.
@@ -651,6 +648,8 @@ pub async fn attach_tenant(
};
if let Err(e) = check() {
// schedule_local_tenant_processing eventually launches the tenant's background task
// We need to shut them down before bailing out.
attached_tenant.set_broken("failed to create".into()).await;
return Err(e);
}