rust/neon
1
0
Fork 0
mirror of https://github.com/neondatabase/neon.git synced 2026-01-16 01:42:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

doc: review suggestions

Browse Source 
Co-authored-by: Christian Schwarz <christian@neon.tech>
This commit is contained in:
Joonas Koivunen
2023-05-11 20:00:33 +03:00
committed by GitHub
parent 7605aed5aa
commit 6d3be4cf7d
2 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
pageserver/src/tenant.rs
View File

@@ -1606,7 +1606,7 @@ impl Tenant {
Ok(())
}
// execute in the *winners* span so we will capture the request id etc.
// execute in the *winner's* span so we will capture the request id etc.
.instrument(span)
};

3
test_runner/regress/test_timeline_delete.py
View File

@@ -396,13 +396,14 @@ def test_concurrent_timeline_delete_if_first_stuck_at_index_upload(
# release the pause
ps_http.configure_failpoints((failpoint_name, "off"))
# both should had succeeded
# both should had succeeded: the second call will coalesce with the already-ongoing first call
result = delete_results.get()
assert result == "success"
result = delete_results.get()
assert result == "success"
# the second call will try to transition the timeline into Stopping state, but it's already in that state
# (the transition to Stopping state is not part of the request coalescing, because Tenant and Timeline states are a mess already)
env.pageserver.allowed_errors.append(
f".*{child_timeline_id}.*Ignoring new state, equal to the existing one: Stopping"
)