rust/neon
1
0
Fork 0
mirror of https://github.com/neondatabase/neon.git synced 2026-10-16 16:53:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

Update pageserver/src/tenant/timeline.rs

Browse Source 
Co-authored-by: Heikki Linnakangas <heikki@neon.tech>
This commit is contained in:
Konstantin Knizhnik
2023-05-16 21:18:20 +03:00
co-authored by Heikki Linnakangas
parent 2cf02b381c
commit 74ab232afb
1 changed files with 3 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pageserver/src/tenant/timeline.rs
+3 -7
View File
@@ -2923,13 +2923,9 @@ impl Timeline {
//
// gc_timeline only pays attention to image layers that are older than the GC cutoff,
// but create_image_layers creates image layers at last-record-lsn.
// So it's possible that gc_timeline decides that it wants new image layer to be created for a key range,
// and on next compaction create_image_layers creates the image layer.
// But on next GC cycle, gc_timeline still wants the new image layer to be created,
// because the newly created image layer doesn't help to remove the delta layer,
// until the newly created image layer falls off the PITR horizon.
//
// So we should check if image layer beyond cutoff LSN already exists.
// So it's possible that gc_timeline wants a new image layer to be created for a key range,
// but the range is already covered by image layers at more recent LSNs. Before we
// create a new image layer, check if the range is already covered at more recent LSNs.
if !layers.image_layer_exists(&img_range, &(Lsn::min(lsn, *cutoff_lsn)..lsn + 1))? {
debug!(
"Force generation of layer {}-{} wanted by GC, cutoff={}, lsn={})",