rust/neon
1
0
Fork 0
mirror of https://github.com/neondatabase/neon.git synced 2026-05-15 12:10:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

pageserver: fix vectored delta layer index traversal

Browse Source 
There were two issues with it.
1. The `key >= range.start && lsn >= lsn_range.start`
was too aggressive. Lsns are not monotonically increasing in the delta
layer index (keys are though), so we cannot assert on them.
2. Lsns greater or equal to `lsn_range.end` were not skipped. This
caused the query to consider records newer than the request Lsn.
This commit is contained in:
Vlad Lazar
2024-03-04 10:45:46 +00:00
parent c861d71eeb
commit 7debd6162c
1 changed files with 10 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
pageserver/src/tenant/storage_layer/delta_layer.rs
View File

@@ -892,15 +892,22 @@ impl DeltaLayerInner {
let lsn = DeltaKey::extract_lsn_from_buf(raw_key);
let blob_ref = BlobRef(value);
assert!(key >= range.start && lsn >= lsn_range.start);
// Lsns are not monotonically increasing, so we don't assert on them.
assert!(key >= range.start);
let cached_lsn = reconstruct_state.get_cached_lsn(&key);
let flag = {
if cached_lsn >= Some(lsn) {
#[allow(clippy::if_same_then_else)]
if lsn >= lsn_range.end || lsn < lsn_range.start {
// If the Lsn is not in the queried range it must be ignored
BlobFlag::Ignore
} else if reconstruct_state.get_cached_lsn(&key) >= Some(lsn) {
// If the Lsn is below the caching line it must be ignored
BlobFlag::Ignore
} else if blob_ref.will_init() {
// This blob will replace all previous blobs for this key
BlobFlag::Replaces
} else {
// Usual path: add blob to the read
BlobFlag::None
}
};