rust/neon
1
0
Fork 0
mirror of https://github.com/neondatabase/neon.git synced 2026-01-10 15:02:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(libpagestore): only update pageserver connstring when stripe size is available

Browse Source 
Signed-off-by: Alex Chi Z <chi@neon.tech>
This commit is contained in:
Alex Chi Z
2025-07-10 17:18:27 -04:00
parent 44ea17b7b2
commit 7e469d610b
1 changed files with 24 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
pgxn/neon/libpagestore.c
View File

@@ -249,6 +249,19 @@ CheckPageserverConnstring(char **newval, void **extra, GucSource source)
static void
AssignPageserverConnstring(const char *newval, void *extra)
{
UpdatePageserverShardMap(newval, stripe_size);
}
static void
AssignPageserverStripeSize(const int newval, void *extra)
{
UpdatePageserverShardMap(page_server_connstring, newval);
}
static void
UpdatePageserverShardMap(const char *connstring, int stripe_size)
{
ShardMap shard_map;
@@ -258,13 +271,20 @@ AssignPageserverConnstring(const char *newval, void *extra)
if (!PagestoreShmemIsValid() || IsUnderPostmaster)
return;
if (!ParseShardMap(newval, &shard_map))
if (!ParseShardMap(connstring, &shard_map))
{
/*
* shouldn't happen, because we already checked the value in
* CheckPageserverConnstring
*/
elog(ERROR, "could not parse shard map");
return;
}
if (shard_map.num_shards > 1 && stripe_size == 0)
{
elog(ERROR, "stripe_size not available yet, not updating the shard map");
return;
}
if (memcmp(&pagestore_shared->shard_map, &shard_map, sizeof(ShardMap)) != 0)
@@ -1407,13 +1427,13 @@ pg_init_libpagestore(void)
NULL, NULL, NULL);
DefineCustomIntVariable("neon.stripe_size",
"sharding stripe size",
"sharding stripe size, 0 or unset if not sharded",
NULL,
&stripe_size,
32768, 1, INT_MAX,
0, 0, INT_MAX,
PGC_SIGHUP,
GUC_UNIT_BLOCKS,
NULL, NULL, NULL);
NULL, AssignPageserverStripeSize, NULL);
DefineCustomIntVariable("neon.max_cluster_size",
"cluster size limit",